shop_storm_cops 0.1.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a60c5758c72a10410c0dff3a05e84e7bf8d1b01f
-  data.tar.gz: 7bd686aa967a7d9f3f429a419a6d90c9dd417462
+  metadata.gz: 97f47908decebef1dc56d36293a0d0aca539e648
+  data.tar.gz: 65ba06c3f64c394901f969eb4a82df904a14f61e
 SHA512:
-  metadata.gz: b9663e4334011a5bf947dc1bcf38dae46cd9798ad453f686b3d10d3f3f605f39e48d3f23a2e66c8f8e80ac0e028a902a9ee6bbf297db0efa439ea2c45dcd054f
-  data.tar.gz: 3f0abb4603a794ec7f989ad01f7fe478e72d4b5e303577fc3d217319507ec1bd505b7307d6bc195cabfc487a8ae1dfacebc25b76a133b05e305fc5f9f622ac1a
+  metadata.gz: 3e32ca4ef11a417772636e4bdd956472db8fe8e88029a39adc1edda49ca823e571f2c7db1e40beb764ae45a242aec5063fd350443a8fad4549b403b7c3a8cedd
+  data.tar.gz: d8f429644fb878336d74a6913abf3d3c5516c1384209722464f5ca61f61de8930b1f1ace1a61e0d3e75376ed3ee8622fdcfcc59d6bc5c761613d3deae2fadc80

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## 0.2.0
+
+* Update the rubocop version to ~> 0.47.1
+* Update max line length convention to 120 chars
+* Exclude Metrics/BlockLength cop from test files
+* Exclude Style/ClassAndModuleChildren cop from test files -- exclude inherance in RuboCop is fixed
+  in this version already.
+
 ## 0.1.2
 
 * Freeze the rubocop version to ~> 0.35.1

data/lib/shop_storm_cops/rubocop/shared_cops.yml

@@ -1,12 +1,14 @@
-# Rubocop config file with the fundamentals SkyVerge's coding conventions which
-# need to be overwriten from the standard Rubocop conventions. This config file
-# is the one to inherit from on apps using this gem.
+# Rubocop config file with the fundamentals SkyVerge's coding conventions which need to be
+# overwriten from the standard Rubocop conventions. This config file is the one to inherit from on
+# apps using this gem.
 
 AllCops:
-  RunRailsCops: true
   DisplayStyleGuide: true
   DisplayCopNames: true
 
+Rails:
+  Enabled: true
+
 # Lint Cops
 
 Lint/AmbiguousRegexpLiteral:
@@ -15,6 +17,15 @@ Lint/AmbiguousRegexpLiteral:
 Lint/HandleExceptions:
   Enabled: false
 
+# Metric Cops
+
+Metrics/BlockLength:
+  Exclude:
+    - 'test/**/*.rb'
+
+Metrics/LineLength:
+  Max: 120
+
 # Style Cops
 
 Style/AccessModifierIndentation:
@@ -23,30 +34,18 @@ Style/AccessModifierIndentation:
 Style/Documentation:
   Enabled: false
 
-# Allow compact `Module::Class` style inside tests.
-#
-# We comment this line since RuboCop seems to have a bug in the loading order
-# of the inherited config files. This file is supposed to be loaded in the less
-# precedence way, so Cops configured into .rubocop_todo.yml should overwrite it.
-# However that's not the real behaviour (bug), and it's specially problematic
-# in this Cop, the only one setting an Exclude parameter in this file.
-#
-# Style/ClassAndModuleChildren:
-#   Exclude:
-#     - 'test/**/*'
+# Allow compact `Module::Class` only inside tests.
+Style/ClassAndModuleChildren:
+  Exclude:
+    - 'test/**/*'
 
 Style/FormatString:
   EnforcedStyle: sprintf
 
-# Disabled regex literal style cop which seems to not work properly. Forcing
-# 'EnforcedStyle: slashes' keeps raising offeses advising the use of '%r'.
+# Disabled regex literal style cop which seems to not work properly. Forcing EnforcedStyle: slashes
+# keeps raising offeses advising the use of '%r'.
 Style/RegexpLiteral:
   Enabled: false
 
 Style/SignalException:
   EnforcedStyle: only_raise
-
-# Sometimes we align first args when many related methods are called together
-# like in /config/routes.rb
-Style/SingleSpaceBeforeFirstArg:
-  Enabled: false

data/lib/shop_storm_cops/version.rb

@@ -1,3 +1,3 @@
 module ShopStormCops
-  VERSION = '0.1.2'
+  VERSION = '0.2.0'.freeze
 end

data/shop_storm_cops.gemspec

@@ -6,8 +6,8 @@ require 'shop_storm_cops/version'
 Gem::Specification.new do |spec|
   spec.name     = 'shop_storm_cops'
   spec.version  = ShopStormCops::VERSION
-  spec.authors  = ['Daniel Madrid', 'Hannes Benson', 'Jory Hatton',
-                   'Justin Stern', 'Max Rice']
+  spec.authors  = ['Hannes Benson', 'Jory Hatton', 'Lucas Lessa', 'Daniel Madrid', 'Max Rice',
+                   'Justin Stern']
   spec.email    = ['help@shopstorm.com']
   spec.summary  = 'Ruby coding convention tools used in ShopStorm'
   spec.homepage = 'https://github.com/skyverge/shopstorm-cops'
@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = '>= 2.0.0'
 
-  spec.add_runtime_dependency 'rubocop', '~> 0.35.1'
+  spec.add_runtime_dependency 'rubocop', '~> 0.47.1'
 
   spec.add_development_dependency 'bundler', '~> 1.10'
   spec.add_development_dependency 'rake', '~> 10.0'

metadata

@@ -1,18 +1,19 @@
 --- !ruby/object:Gem::Specification
 name: shop_storm_cops
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
-- Daniel Madrid
 - Hannes Benson
 - Jory Hatton
-- Justin Stern
+- Lucas Lessa
+- Daniel Madrid
 - Max Rice
+- Justin Stern
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-03-14 00:00:00.000000000 Z
+date: 2017-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -20,14 +21,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.35.1
+        version: 0.47.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.35.1
+        version: 0.47.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement