shiprocket_api 0.4.3 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1e55a3ebda672952872f26c745bc366c00ddad9f431535df333a542768a685d8
-  data.tar.gz: 2f4e70f857c0388cf03eb52a3844fdac59f5c84f3e7955fbc3f4b40ec1012d12
+  metadata.gz: 9b03ee9034588c44b804bb772fcc9a69c596264a54d897c6fa0e726f349318d7
+  data.tar.gz: e73bca24913df4676e3386c661f8d9b8c416d829cf99fa768e403396d95cceb4
 SHA512:
-  metadata.gz: 8b9703cef3013af7bd5e9a76b7b59c4d8c036edaed872b32245d745a9203f97365d7010e9f43b65be48114e32f000e4c204f2987ae60ce59e482d27cf939b4f2
-  data.tar.gz: 3a8b58fd4c08838c3138b23fe98ec3c9e1df60205492004b2580ceaa463d3228c9e9719687f87671e5e3b358766c297fa19fc9b655177ae70d6a831762aa2c89
+  metadata.gz: b730d322c4da4c099f8cf27534fd26a69f2061ff4cc1b7cb3005385894607e0e6e7ab0e73cf1731bc751229e66e70948b2cf0519ca3e3118afb16eabc578efae
+  data.tar.gz: 7b368aeb68edbb2ba261ca4b9076167f096a047be692220592a6b933a876ff1281c5cad9decb4cd1a819468e80f7c1afd13d087836ada928629eea17119e34a8

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    shiprocket_api (0.4.2)
+    shiprocket_api (0.4.3)
       activeresource (~> 5.0)
       http
 

data/lib/shiprocket_api/resources/pickup.rb

@@ -4,9 +4,7 @@ module ShiprocketAPI
     self.element_name= ""
 
     DEFAULT_ATTRS = {
-      shipment_id: 0,
-      courier_id: 0,
-      is_return: 1
+      shipment_id: [0]
     }
   end
 end

data/lib/shiprocket_api/resources/return_order.rb

@@ -65,6 +65,8 @@ module ShiprocketAPI
     end
 
     def generate_awb(courier_id:)
+      return false unless attributes["shipment_id"] && shipment_id != 0
+      
       self.awb = Awb.new(
         shipment_id: shipment_id,
         courier_id: courier_id,
@@ -74,18 +76,16 @@ module ShiprocketAPI
     end
 
     def generate_label
-      return false unless respond_to?(:shipment_id) && shipment_id != 0
+      return false unless attributes["shipment_id"] && shipment_id != 0
 
       self.label = ::ShiprocketAPI::Label.new(shipment_id: [shipment_id])
       self.label.save
     end
 
-    def create_pickup(courier_id:)
-      self.pickup = ::ShiprocketAPI::Pickup.new(
-        shipment_id: shipment_id,
-        courier_id: courier_id,
-        is_return: 1
-      )
+    def create_pickup
+      return false unless attributes["shipment_id"] && shipment_id != 0
+
+      self.pickup = ::ShiprocketAPI::Pickup.new(shipment_id: [shipment_id])
       self.pickup.save
     end
   end

data/lib/shiprocket_api/version.rb

@@ -1,3 +1,3 @@
 module ShiprocketAPI
-  VERSION = "0.4.3"
+  VERSION = "0.4.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shiprocket_api
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.4.4
 platform: ruby
 authors:
 - Andy Chong
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-02-02 00:00:00.000000000 Z
+date: 2021-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeresource