shipit-engine 0.8.2 → 0.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 388efef49dd937f5f910c8d19da1161396422d27
-  data.tar.gz: 92242ac143b9156d9a165cd70083aef0eb0be55b
+  metadata.gz: c98a29b6cd4e544b1891a31328fe343868d656bb
+  data.tar.gz: c46cef3fbb2c601c45adbcd5052337ff80996034
 SHA512:
-  metadata.gz: ea8c7a0857f155ac526bd5c527f346fd847eabdfa0b7bd6a4f844b82f31172880062c5c912851000e06f17bd5f4c5dd4c597ccd2c7d1448ed8e5db82ecdcc4e4
-  data.tar.gz: 7e32b5ade1af2005d4d65460ec30408f56e2896e63ec9efff06d5add0eb0f5d07a9986355eaa497339d388b88860fc346c931e3b32a400cda114a17719fd5ce7
+  metadata.gz: 318ea3b94e42aa292f5a31dd6a0dbac0e2b5d59bfedefdb600f9d3388a4a70e4038f84803aeab542bdd06f82c133ff7793e87f9464092d0666e2869c27271215
+  data.tar.gz: 0b698f6259872d236d42466447fedeac55936d80083cd2c7b78cdb7a69d8fa1a8c2fca228f703cfa6fe5e8f2fd8ec982c2100c748d8c2760c19b8874e6e7d6bf

data/README.md

@@ -453,7 +453,11 @@ development:
 
 The value for `id` is your application's  *Client ID*, and the value for `secret` is your application's *Client Secret* — both of these should appear on your application's GitHub page.
 
-The `teams` key is optional, and required only if you want to specify some teams which have access to the stack in Shipit.
+The `teams` key is optional, and required only if you want to restrict access to a set of GitHub teams.
+
+If it's missing the Shipit installation will be public unless you setup another authentication method.
+
+After you change the list of time you have to invoke `bin/rake teams:fetch` in production so that a webhook is setup to keep the list of members up to date.
 
 For example:
 

data/lib/shipit/version.rb

@@ -1,3 +1,3 @@
 module Shipit
-  VERSION = '0.8.2'
+  VERSION = '0.8.3'
 end

data/lib/shipit.rb

@@ -111,8 +111,11 @@ module Shipit
   end
 
   def github_teams
-    teams = (Array(github_oauth_credentials['team']) + Array(github_oauth_credentials['teams'])).sort.uniq
-    @github_teams ||= teams.map { |t| Team.find_or_create_by_handle(t) }
+    @github_teams ||= github_teams_handles.map { |t| Team.find_or_create_by_handle(t) }
+  end
+
+  def github_teams_handles
+    (Array(github_oauth_credentials['team']) + Array(github_oauth_credentials['teams'])).sort.uniq
   end
 
   def github_oauth_id

data/lib/tasks/teams.rake

@@ -0,0 +1,30 @@
+namespace :teams do
+  desc "Import the members of each team configured through the github_oauth.teams config and attempt to set a webhook to keep the list updated"
+  task fetch: :environment do
+    handles = Shipit.github_teams_handles
+    if handles.empty?
+      puts "github_oauth.teams is empty"
+    else
+      handles.each do |handle|
+        puts "Fetching @#{handle} members"
+        begin
+          team = Shipit::Team.find_or_create_by_handle(handle)
+          team.refresh_members!
+        rescue Octokit::Unauthorized, Octokit::NotFound => error
+          puts "Failed to fetch @#{handle} members. Do you have enough permissions?"
+          puts "#{error.class}: #{error.message}"
+        end
+
+        if team
+          puts "Ensuring webhook presence for #{team.organization}"
+          begin
+            team.setup_hooks(async: false)
+          rescue Octokit::Unauthorized, Octokit::NotFound => error
+            puts "Failed to install webhook on #{team.organization}. Do you have enough permissions?"
+            puts "#{error.class}: #{error.message}"
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shipit-engine
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.8.3
 platform: ruby
 authors:
 - Jean Boussier
@@ -582,7 +582,7 @@ files:
 - lib/snippets/push-to-heroku
 - lib/tasks/cron.rake
 - lib/tasks/dev.rake
-- lib/tasks/team.rake
+- lib/tasks/teams.rake
 - lib/tasks/webhook.rake
 - test/controllers/api/base_controller_test.rb
 - test/controllers/api/deploys_controller_test.rb

data/lib/tasks/team.rake

@@ -1,10 +0,0 @@
-namespace :team do
-  desc "Import a team and it's members from Github and install a webhook to monitor it"
-  task fetch: :environment do
-    handle = ENV['HANDLE']
-    team = Shipit::Team.find_or_create_by_handle(handle)
-    fail "Could not find team with handle: #{handle}" unless team
-    team.setup_hooks(async: false)
-    team.refresh_members!
-  end
-end