shiner 0.0.3 → 0.0.4

data/lib/shiner/version.rb

@@ -1,3 +1,3 @@
 module Shiner
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/lib/shiner.rb

@@ -15,10 +15,11 @@ module Shiner
   
   def self.string_to_best_sentences(string, options={})
     sentences = string_to_scored_sentences(string)
-    options[:max_sentences]||=sentences.size
     batches = []
     sentences.each_index{|index|
-      batch={:sentences => sentences[index, options[:max_sentences]]}
+      batch={:sentences => sentences[index, options[:max_sentences] || sentences.size]}
+      next if options[:max_length] && batch[:sentences].collect{|sentence| sentence[:sentence]}.join(' ').length < options[:max_length] && batches.size > 0 #don't take last few sentences if they do not meet max_length
+      next if options[:max_sentences] && batch[:sentences].size < options[:max_sentences] && batches.size > 0 #don't take last few sentences if they do not meet max_sentences
       batch[:sentences].pop while options[:max_length] && batch[:sentences].collect{|sentence| sentence[:sentence]}.join(' ').length > options[:max_length]
       batch[:score] = batch[:sentences].collect{|sentence| sentence[:score]}.sum.to_f / batch[:sentences].size
       batches << batch

data/test/test_shiner.rb

@@ -43,15 +43,15 @@ Recent reports suggested that Facebook is to launch its own smartphone by next y
 EOF
     result = Shiner.shine(doc, :max_length => 388)
     pp [result, result.size]
-    assert result.size > 100
+    assert result.size > 200
     assert result.size < 388
     result = Shiner.shine(doc, :max_length => 888)
     pp [result, result.size]
-    assert result.size > 100
+    assert result.size > 400
     assert result.size < 888
     result = Shiner.shine(doc, :max_length => 1888)
     pp [result, result.size]
-    assert result.size > 100
+    assert result.size > 1000
     assert result.size < 1888
     result = Shiner.shine(doc, :max_sentences => 1)
     pp [result, result.size]

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: shiner
 version: !ruby/object:Gem::Version 
-  hash: 25
+  hash: 23
   prerelease: 
   segments: 
   - 0
   - 0
-  - 3
-  version: 0.0.3
+  - 4
+  version: 0.0.4
 platform: ruby
 authors: 
 - Jason Ling Xiaowei