shift_planning 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4f32e3accb175f8bfa729f4c1e69fb8805b7deea
-  data.tar.gz: c7788df7f61e701563b54aa09937292b5a2edc86
+  metadata.gz: 1e1a11b8e575ead55f9dde9c6bcce82f043753dc
+  data.tar.gz: f3605fe6ec37da42303aeb9c4234eaed15943d10
 SHA512:
-  metadata.gz: 24dd987600e1da7b07b37ff0e4de3d7594b495a0694574b461cd4516a0dbe13f8e4b5a4a63db1ddba71143b716488d3729f05b3be07958194375a6d2aced6455
-  data.tar.gz: 52f616fccf147237fc35672921a594fd4449a930ea2bc3931c167c2cbeb79ac20fc5b5afdb00034dd980a39ef7f730e49d5a9d331ad229f440478dfb35b069df
+  metadata.gz: 2ab7608e9bdf2fc730162419026a643fdc989b14e721be540e2ef24ff4156fb3b265d819dbea7336fa8086e3ca186ee4203e8a2ae03fdcf6cc03101203f5c3d6
+  data.tar.gz: 072699b5a6c490f27cbe7521c0ad6e670ee7b4d12c982383e82f8c69a15d9d1d1551d21a3249ea44f4b9ce381c89fd5fc2b51346b26027f143779aee85ef93be

data/lib/shift_planning/client.rb

@@ -5,11 +5,11 @@ require 'base64'
 module ShiftPlanning
   class Client
     def initialize(config = {})
-      raise ArgumentError.new('Missing username') unless config.has_key? :username
+      raise ArgumentError.new('Missing username') unless config.key? :username
       @username = config[:username]
-      raise ArgumentError.new('Missing password') unless config.has_key? :password
+      raise ArgumentError.new('Missing password') unless config.key? :password
       @password = config[:password]
-      raise ArgumentError.new('Missing api key') unless config.has_key? :key
+      raise ArgumentError.new('Missing api key') unless config.key? :key
       @key = config[:key]
       @url = 'http://www.shiftplanning.com/api/'
       @headers = {
@@ -35,7 +35,17 @@ module ShiftPlanning
       @token = JSON.parse(response)["token"]
     end
 
-    def request(api_module, request={}, method='GET')
+    def get(api_module, request={})
+      request("GET", api_module, request)
+    end
+
+    def update(api_module, request={})
+      request("UPDATE", api_module, request)
+    end
+
+    private
+
+    def request(method, api_module, request)
       authenticate unless authenticated?
 
       body = body_formatter({

data/lib/shift_planning/version.rb

@@ -1,3 +1,3 @@
 module ShiftPlanning
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/shift_planning.rb

@@ -5,34 +5,32 @@ module ShiftPlanning
   extend self
 
   def init(options={})
-    @@client = ShiftPlanning::Client.new(options)
+    @@client = Client.new(options)
   end
 
   def skills
-    @@client.request('staff.skills')
+    @@client.get('staff.skills')
   end
 
   def employees
-    @@client.request('staff.employees')
+    @@client.get('staff.employees')
   end
 
   def employee(employee_id)
-    @@client.request('staff.employee', "id" => employee_id)
+    @@client.get('staff.employee', "id" => employee_id)
   end
 
   def add_skill(employee_id, skill_id)
-    args = {
+    @@client.update('staff.employee', {
       "id" => employee_id,
       "addskill" => skill_id
-    }
-    @@client.request('staff.employee', args, "UPDATE")
+    })
   end
 
   def remove_skill(employee_id, skill_id)
-    args = {
+    @@client.update('staff.employee', {
       "id" => employee_id,
       "removeskill" => skill_id
-    }
-    @@client.request('staff.employee', args, "UPDATE")
+    })
   end
 end

data/test/unit/client_test.rb

@@ -12,6 +12,29 @@ describe 'Client' do
       .to_return(:status => 200, :body => "{\"token\":\"1714d482a0f3a5e3472fb51c481dc571fd6724e1\"}", :headers => {})
   end
 
+  describe '#initialize' do
+    it 'username is a required field' do
+      err = -> {
+        ShiftPlanning::Client.new(:password => '', :key => '')
+      }.must_raise ArgumentError
+      err.message.must_match /username/
+    end
+
+    it 'password is a required field' do
+      err = -> {
+        ShiftPlanning::Client.new(:username => '', :key => '')
+      }.must_raise ArgumentError
+      err.message.must_match /password/
+    end
+
+    it 'key is a required field' do
+      err = -> {
+        ShiftPlanning::Client.new(:username => '', :password => '')
+      }.must_raise ArgumentError
+      err.message.must_match /key/
+    end
+  end
+
   describe '#authenticate' do
     it 'requests auth token and saves it' do
       @client.authenticate
@@ -19,18 +42,27 @@ describe 'Client' do
     end
   end
 
-  describe '#request' do
+  describe '#get' do
+    it 'authenticates and makes api request' do
+      stub_request(:post, "http://www.shiftplanning.com/api/")
+        .with(:body => {"data"=>"{\"token\":\"1714d482a0f3a5e3472fb51c481dc571fd6724e1\",\"method\":\"GET\",\"module\":\"staff.employee\",\"request\":{\"id\":1}}"}, :headers => {'Content-Type'=>'application/x-www-form-urlencoded', 'Host'=>'www.shiftplanning.com', 'User-Agent'=>'RubyHTTPGem/0.5.0'})
+        .to_return(:status => 200, :body => "{\"id\":\"1\"}", :headers => {})
+      employee = @client.get('staff.employee', "id" => 1)
+      assert 1, employee[:id]
+    end
+  end
+
+  describe '#update' do
     it 'authenticates and makes api request' do
       stub_request(:post, "http://www.shiftplanning.com/api/")
         .with(:body => {"data"=>"{\"token\":\"1714d482a0f3a5e3472fb51c481dc571fd6724e1\",\"method\":\"UPDATE\",\"module\":\"staff.employee\",\"request\":{\"id\":1,\"addskill\":2}}"}, :headers => {'Content-Type'=>'application/x-www-form-urlencoded', 'Host'=>'www.shiftplanning.com', 'User-Agent'=>'RubyHTTPGem/0.5.0'})
         .to_return(:status => 200, :body => "{\"id\":\"1\"}", :headers => {})
 
-      args = {
+      employee = @client.update('staff.employee', {
         "id" => 1,
         "addskill" => 2
-      }
-      @client.request('staff.employee', args, "UPDATE")
-      assert true
+      })
+      assert 1, employee[:id]
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shift_planning
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Tyler Mercier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-19 00:00:00.000000000 Z
+date: 2014-02-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http