sharing_tags 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3fb8c1d07875574b3d1b8ffdc8fffaf3efc75eba
-  data.tar.gz: 30e8054db58fe3489b38be7ed6e37c05756132aa
+  metadata.gz: 15a3570cb3592d651f7f2381b4afe5177ee9d8b6
+  data.tar.gz: b4e3e9d2278551f4a82b82505d721bbc61a5a87b
 SHA512:
-  metadata.gz: bd42efa3c9565c6bac5dfb98fe4e0f8e85c784f1943b548d6586d8e8959c8d1975531e26b72655cadaedb16492619aa1e6587fda2d543ff44528e8592457ecbc
-  data.tar.gz: 5c5271f36b61cdb02900053639cfcabfd834d861d54b6c6bf9997634b9a0743736f949683cf02f55f8f36271bfaf2292a97ded35bc0af4b0f2feb4d3916b1f95
+  metadata.gz: 7c8b64a0c2b281dd60369be5ce4151be7bd8a8f503547b9f5d1468e2f71398294874515bbe0e8ed0d712e8431ee8f15bd6ba5396c57af3970bf75aed209d8316
+  data.tar.gz: b015f781dce51ac9718562cce9180ff8551b6d4aa6cc91739e9b7d765e362ef6da957b156a5743bb352dde4bb83b4481bd087785009e2c4ac61be3fb456ef269

data/Guardfile

@@ -4,6 +4,8 @@ guard 'rspec', cmd: "bundle exec rspec" do
   watch(%r{^spec/.+_spec\.rb$})
   watch(%r{^app/(.+)\.rb$})                           { |m| "spec/#{m[1]}_spec.rb" }
 
+  watch(%r{^lib/sharing_tags/(.+)\.rb$}) { |m| "spec/models/#{m[1]}_spec.rb" }
+
 end
 
 guard :teaspoon do
@@ -11,5 +13,5 @@ guard :teaspoon do
   watch(%r{^app/assets/javascripts/sharing_tags/(.+).coffee}) { |m| "#{m[1]}_spec" }
 
   # Specs / Helpers
-  watch(%r{^spec/javascripts/**/(.*)})
+  watch(%r{^spec/javascripts/(.+)})
 end

data/README.md

@@ -1,4 +1,4 @@
-# sharing_tags [![Gem Version](https://badge.fury.io/rb/sharing_tags.svg)](http://badge.fury.io/rb/sharing_tags) ![Build Status](https://secure.travis-ci.org/Kr00lIX/sharing_tags.svg?branch=master) ![Code Climate](https://codeclimate.com/github/Kr00lIX/sharing_tags/badges/gpa.svg) ![Security](https://hakiri.io/github/Kr00lIX/sharing_tags/master.svg)  [![Coverage Status](https://coveralls.io/repos/Kr00lIX/sharing_tags/badge.svg)](https://coveralls.io/r/Kr00lIX/sharing_tags)
+# sharing_tags [![Gem Version](https://badge.fury.io/rb/sharing_tags.svg)](http://badge.fury.io/rb/sharing_tags) ![Build Status](https://secure.travis-ci.org/Kr00lIX/sharing_tags.svg?branch=master) ![Code Climate](https://codeclimate.com/github/Kr00lIX/sharing_tags/badges/gpa.svg) [![Coverage Status](https://coveralls.io/repos/Kr00lIX/sharing_tags/badge.svg)](https://coveralls.io/r/Kr00lIX/sharing_tags)
 
 
 **sharing_tags** is a gem for adding social sharing buttons to your Rails app. 

data/Todo.md

@@ -0,0 +1,11 @@
+# TODO
+
+* Write specs
+* Run js and ruby specs by default rake task
+* Add default values to image networks
+* Correct merge values in default context and defined
+* Define network list
+* Render icons with links
+* Add to install task sample of view and require assets
+* Add recommendation about image size and length of text
+* Add version to sharing tags: append ?version=1 to links and assets

data/lib/sharing_tags.rb

@@ -12,7 +12,9 @@ module SharingTags
 
 
   module ActionView
-    autoload :Helpers, 'sharing_tags/action_view/helpers'
+    autoload :MetaHelper,   'sharing_tags/action_view/meta_helper'
+    autoload :ButtonHelper, 'sharing_tags/action_view/button_helper'
+    autoload :AssetHelper,  'sharing_tags/action_view/asset_helper'
   end
 
   module ActionController

data/lib/sharing_tags/action_view/asset_helper.rb

@@ -0,0 +1,37 @@
+require "non-stupid-digest-assets"
+
+module SharingTags::ActionView::AssetHelper
+
+  def without_digest_asset_url(path, options = {})
+    options.merge!(digested: false)
+
+    add_image_to_non_digest_list(path)
+    asset_url(path, options)
+  end
+
+  # redefine method Sprockets::Rails::Helper
+  # Computes asset path to public directory.
+  #
+  # Override this method for non digested assets
+  #
+  def compute_asset_path(path, options = {})
+    digested = options.delete(:digested)
+    digested = true if digested.nil?
+
+    if digest_path = asset_digest_path(path, options)
+      path = digest_path if digested && digest_assets
+      path += "?body=1" if options[:debug]
+      File.join(assets_prefix || "/", path)
+    else
+      super
+    end
+  end
+
+  private
+
+  def add_image_to_non_digest_list(asset_name)
+    return if ::NonStupidDigestAssets.whitelist.include?(asset_name)
+    ::NonStupidDigestAssets.whitelist += [ asset_name ]
+  end
+
+end

data/lib/sharing_tags/action_view/{helpers.rb → button_helper.rb}

@@ -1,13 +1,4 @@
-module SharingTags::ActionView::Helpers
-
-  def sharing_tags
-    SharingTags.config.within_context_params(self)
-  end
-
-  def render_sharing_tags
-    logger.debug "SharingTags: Render meta tags context=#{SharingTags.config.current_context.name}, params=#{sharing_tags.to_hash.inspect}"
-    render template: "sharing_tags/meta_tags"
-  end
+module SharingTags::ActionView::ButtonHelper
 
   def link_to_facebook_share(name = "Facebook", &block)
     share_link_to name, :facebook, [], &block
@@ -48,5 +39,4 @@ module SharingTags::ActionView::Helpers
       link_to name_or_options, params.page_url, data: data_attrs, role: "sharing_tags_share", target: "_blank", &block
     end
   end
-
 end

data/lib/sharing_tags/action_view/meta_helper.rb

@@ -0,0 +1,10 @@
+module SharingTags::ActionView::MetaHelper
+
+  def sharing_tags
+    SharingTags.config.within_context_params(self)
+  end
+
+  def render_sharing_tags
+    render template: "sharing_tags/meta_tags"
+  end
+end

data/lib/sharing_tags/configuration.rb

@@ -3,6 +3,8 @@ module SharingTags
 
     NETWORKS = %i{ google facebook twitter }
 
+    attr_accessor :running_context
+
     def initialize
       clear!
     end
@@ -44,10 +46,6 @@ module SharingTags
       params
     end
 
-    def running_context
-      @running_context
-    end
-
     def current_context
       @current_context || default_context
     end

data/lib/sharing_tags/network.rb

@@ -1,6 +1,8 @@
 module SharingTags
   class Network
 
+    # todo: add default values
+
     class Error < StandardError
     end
 
@@ -19,6 +21,10 @@ module SharingTags
     def initialize(name, context = nil)
       @name = name
       @context = context
+      clear!
+    end
+
+    def clear!
       @attributes = {}
       @share_url_params = nil
     end
@@ -39,13 +45,22 @@ module SharingTags
       attributes[:description] = store_value(value, &block)
     end
 
-    def image_url(new_image = nil, size = nil, content_type = nil, &block)
+    # def image_url(new_image = nil, size = nil, content_type = nil, options, &block)
+    def image_url(*arguments, &block)
+      options = arguments.extract_options!
+      new_image, size, content_type = arguments
+
+      if options[:digested] == false && !block_given?
+        block = lambda { without_digest_asset_url(new_image) }
+      end
+
+      # todo: add another class for storing image
       attributes[:image] = store_value(new_image, &block)
 
       # add size and content type for block value
       size, content_type = new_image, size if block_given?
 
-      attributes[:image_size] = store_value(size.split("x")) if size
+      attributes[:image_size] = store_value(size.split("x").map(&:to_i)) if size
       attributes[:image_content_type] = store_value(content_type) if content_type
     end
     alias :image :image_url
@@ -88,7 +103,8 @@ module SharingTags
 
     def get_value(value, context_params)
       if value.is_a?(Proc)
-        if running_context = @context.configuraton.running_context
+
+        if @context && running_context = @context.configuraton.running_context
           # execute proc within the view context with context_params
           running_context.instance_exec(*context_params, &value)
         else

data/lib/sharing_tags/railtie.rb

@@ -13,15 +13,17 @@ module SharingTags
 
     initializer "sharing_tags.configure_view_controller" do |app|
       ActiveSupport.on_load :action_view do
-        include SharingTags::ActionView::Helpers
+        include SharingTags::ActionView::MetaHelper
+        include SharingTags::ActionView::ButtonHelper
+
+        # @note: load AssetHelper after sprockets helper
+        include Sprockets::Rails::Helper if defined?(Sprockets::Rails::Helper) && !include?(Sprockets::Rails::Helper)
+        include SharingTags::ActionView::AssetHelper
       end
 
       ActiveSupport.on_load :action_controller do
         include SharingTags::ActionController::Helpers
         include SharingTags::ActionController::Filters
-
-        # todo add filter for clear context
-        # append_filter :clear_context!
       end
     end
 

data/lib/sharing_tags/version.rb

@@ -1,3 +1,3 @@
 module SharingTags
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/sharing_tags.gemspec

@@ -22,6 +22,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'hashie', '~> 3.4'
   spec.add_dependency 'slim',   '~> 3.0'
   spec.add_dependency 'coffee-script', '~> 2.3'
+  spec.add_dependency 'non-stupid-digest-assets', '~> 1.0'
 
   spec.add_development_dependency 'bundler', '~> 1.7'
   spec.add_development_dependency 'rake', '~> 10.0'

data/spec/helpers/asset_helper_spec.rb

@@ -0,0 +1,29 @@
+require "non-stupid-digest-assets"
+
+RSpec.describe SharingTags::ActionView::AssetHelper, :type => :helper do
+
+  describe "#without_digest_asset_url" do
+    before do
+      SharingTags.configure do
+        image        "http://img.png"
+      end
+    end
+
+    let(:image) { "image_path/image.png" }
+
+    subject { helper.without_digest_asset_url(image) }
+
+    it "expect exist method" do
+      expect(helper).to be_respond_to(:without_digest_asset_url)
+    end
+
+    it "expect return non digested url" do
+      is_expected.to be_eql("http://test.host/image_path/image.png")
+    end
+
+    it "add to non digest gem" do
+      NonStupidDigestAssets.whitelist = []
+      expect{ is_expected }.to change(::NonStupidDigestAssets, :whitelist)
+    end
+  end
+end

data/spec/helpers/meta_tags_helper_spec.rb

@@ -0,0 +1,36 @@
+
+RSpec.describe SharingTags::ActionView::MetaHelper, :type => :helper do
+
+  describe "#sharing_tags" do
+    pending
+  end
+
+  describe "#render_sharing_tags" do
+    before do
+      SharingTags.configure do
+        title        "Sharing title"
+        description  "Sharing description"
+        page_url     "http://a.b"
+        image        "http://img.png"
+      end
+    end
+
+    it "generate open graph meta tags" do
+      expect(helper.render_sharing_tags).to have_tag "meta", with: {property: "og:title", content: "Sharing title"}
+      expect(helper.render_sharing_tags).to have_tag "meta", with: {property: "og:description", content: "Sharing description"}
+      expect(helper.render_sharing_tags).to have_tag "meta", with: {property: "og:image", content: "http://img.png"}
+    end
+
+    it "generate schema meta tags" do
+      expect(helper.render_sharing_tags).to have_tag "meta", with: {itemprop: "name",        content: "Sharing title"}
+      expect(helper.render_sharing_tags).to have_tag "meta", with: {itemprop: "description", content: "Sharing description"}
+      expect(helper.render_sharing_tags).to have_tag "meta", with: {itemprop: "image",       content: "http://img.png"}
+    end
+
+    it "generate twitter card meta tags" do
+      expect(helper.render_sharing_tags).to have_tag "meta", with: {name: "twitter:title",       content: "Sharing title"}
+      expect(helper.render_sharing_tags).to have_tag "meta", with: {name: "twitter:description", content: "Sharing description"}
+    end
+  end
+
+end

data/spec/helpers/share_link_helper_spec.rb

@@ -1,49 +1,5 @@
 
-RSpec.describe SharingTags::ActionView::Helpers, :type => :helper do
-
-  before do
-    SharingTags.configure do
-      facebook do
-        title        "fb title"
-        description  "fb desc"
-        share_url    "http://c.d"
-        page_url     "#"
-        image        "http://img.png"
-      end
-    end
-  end
-
-  describe "#sharing_tags" do
-    pending
-  end
-
-  describe "#render_sharing_tags" do
-    before do
-      SharingTags.configure do
-        title        "Sharing title"
-        description  "Sharing description"
-        page_url     "http://a.b"
-        image        "http://img.png"
-      end
-    end
-
-    it "generate open graph meta tags" do
-      expect(helper.render_sharing_tags).to have_tag "meta", with: {property: "og:title", content: "Sharing title"}
-      expect(helper.render_sharing_tags).to have_tag "meta", with: {property: "og:description", content: "Sharing description"}
-      expect(helper.render_sharing_tags).to have_tag "meta", with: {property: "og:image", content: "http://img.png"}
-    end
-
-    it "generate schema meta tags" do
-      expect(helper.render_sharing_tags).to have_tag "meta", with: {itemprop: "name",        content: "Sharing title"}
-      expect(helper.render_sharing_tags).to have_tag "meta", with: {itemprop: "description", content: "Sharing description"}
-      expect(helper.render_sharing_tags).to have_tag "meta", with: {itemprop: "image",       content: "http://img.png"}
-    end
-
-    it "generate twitter card meta tags" do
-      expect(helper.render_sharing_tags).to have_tag "meta", with: {name: "twitter:title",       content: "Sharing title"}
-      expect(helper.render_sharing_tags).to have_tag "meta", with: {name: "twitter:description", content: "Sharing description"}
-    end
-  end
+RSpec.describe SharingTags::ActionView::ButtonHelper, :type => :helper do
 
   describe "#link_to_facebook_share" do
     before do

data/spec/models/network_spec.rb

@@ -1,6 +1,89 @@
-describe SharingTags::Network do
+module SharingTags
+
+  describe Network do
+    let!(:config)  { Configuration.new }
+    let!(:context) { Context.new(:test, config) }
+    let!(:network) { Network.new(:test, context) }
+
+    after do
+      network.clear!
+    end
+
+    it "expect get's list of available networks" do
+      expect(Network.lists).to include(:facebook, :twitter, :google, :vkontakte)
+    end
+
+    it "expect network name is a test" do
+      expect(network.name).to be_eql(:test)
+    end
+
+    describe "#image" do
+      let(:running_class_context) do
+        Class.new do
+          def some_helper(path)
+            "helper/#{path}/done"
+          end
+
+          def without_digest_asset_url(path)
+            "non_digested/#{path}"
+          end
+        end
+      end
+
+      before do
+        config.running_context = running_class_context.new
+      end
+
+      subject { network.attributes_for.image}
+
+      it "add network image through asset_url " do
+        network.image "sharing/image.png"
+        is_expected.to be_present
+
+        is_expected.to be == "sharing/image.png"
+      end
+
+      it "define image by proc and run it in running_class_context" do
+        network.image { some_helper("sharing/image.png") }
+        is_expected.to be == "helper/sharing/image.png/done"
+      end
+
+      describe "non digested image" do
+        it "expect non digested path for full image attributes" do
+          network.image "sharing/image.png", "100x500", "image/jpeg", digested: false
+
+          expect(network.attributes_for.image).to be == "non_digested/sharing/image.png"
+          expect(network.attributes_for.image_size).to be == [100, 500]
+          expect(network.attributes_for.image_content_type).to be == "image/jpeg"
+        end
+
+        it "expect correct image path without content type" do
+          network.image "sharing/image.png", "100x500", digested: false
+
+          expect(network.attributes_for.image).to be == "non_digested/sharing/image.png"
+          expect(network.attributes_for.image_size).to be == [100, 500]
+          expect(network.attributes_for.image_content_type).to be_nil
+        end
+
+        it "expect correct image path without content type and size" do
+          network.image "sharing/image.png", digested: false
+
+          expect(network.attributes_for.image).to be == "non_digested/sharing/image.png"
+          expect(network.attributes_for.image_size).to be_nil
+          expect(network.attributes_for.image_content_type).to be_nil
+        end
+
+        it "expect correct image path without content type and size" do
+          network.image "sharing/image.png", digested: false
+
+          expect(network.attributes_for.image).to be == "non_digested/sharing/image.png"
+          expect(network.attributes_for.image_size).to be_nil
+          expect(network.attributes_for.image_content_type).to be_nil
+        end
+      end
+
+    end
 
-  it "expect get's list of available networks" do
-    expect(SharingTags::Network.lists).to include(:facebook, :twitter, :google, :vkontakte)
   end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sharing_tags
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Anatoliy Kovalchuk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-07 00:00:00.000000000 Z
+date: 2015-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -66,6 +66,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.3'
+- !ruby/object:Gem::Dependency
+  name: non-stupid-digest-assets
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -266,6 +280,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- Todo.md
 - app/assets/javascripts/sharing_tags/links.js.coffee
 - app/assets/javascripts/sharing_tags/share.coffee
 - app/views/sharing_tags/_open_graphs.html.slim
@@ -278,7 +293,9 @@ files:
 - lib/sharing_tags.rb
 - lib/sharing_tags/action_controller/filters.rb
 - lib/sharing_tags/action_controller/helpers.rb
-- lib/sharing_tags/action_view/helpers.rb
+- lib/sharing_tags/action_view/asset_helper.rb
+- lib/sharing_tags/action_view/button_helper.rb
+- lib/sharing_tags/action_view/meta_helper.rb
 - lib/sharing_tags/config.rb
 - lib/sharing_tags/configuration.rb
 - lib/sharing_tags/context.rb
@@ -344,6 +361,8 @@ files:
 - spec/dummy/vendor/assets/javascripts/.keep
 - spec/dummy/vendor/assets/stylesheets/.keep
 - spec/generators/install_generator_spec.rb
+- spec/helpers/asset_helper_spec.rb
+- spec/helpers/meta_tags_helper_spec.rb
 - spec/helpers/share_link_helper_spec.rb
 - spec/javascripts/sharing_tags/sharing_tags_spec.coffee
 - spec/javascripts/spec_helper.coffee
@@ -437,6 +456,8 @@ test_files:
 - spec/dummy/vendor/assets/javascripts/.keep
 - spec/dummy/vendor/assets/stylesheets/.keep
 - spec/generators/install_generator_spec.rb
+- spec/helpers/asset_helper_spec.rb
+- spec/helpers/meta_tags_helper_spec.rb
 - spec/helpers/share_link_helper_spec.rb
 - spec/javascripts/sharing_tags/sharing_tags_spec.coffee
 - spec/javascripts/spec_helper.coffee