sharing_tags 0.0.13 → 0.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9a7912ad5e988091db82327d34f8e102cf8e71cf
-  data.tar.gz: 673a87ca47d5063faba0f6f02bb7568b96d2891e
+  metadata.gz: 270817d3806e9cc9aa725b7024ee800d57cdbe35
+  data.tar.gz: 5b08fbc8d4e692309e9b5e64bf268733c47112ce
 SHA512:
-  metadata.gz: b2fdff0f4a8a5522be58ba5e97da9da97dd228ee18d15d6602362209ef3ec0e02668fa33b6ea53a4db3c8d30bbccad1588b1355300948755edb6e344846e51e9
-  data.tar.gz: a2a92dc3a6addd2629742096c9277b76eef610a37a3133bbe6db5ff36245c67380a7f37f5a29b1f77654df4f634c7f6b5737ccf6b9296aa9018c0b214868ef19
+  metadata.gz: da7c3d0b92af30223626f77611b845e177bfd999b5bcdb2204f1d92d3efa271af3eec09abcc0f91fbf22239adfaebe281484e6413600d2a5c95ff6b25b89f220
+  data.tar.gz: 7d4eb00a481549809894a037f05b0ee52f20137a22093bd271816bd01b90d998e0c12b9f74098942de919bf0cd1cf1427240ee3312582c6bce8c679b202c5e53

data/README.md

@@ -151,6 +151,7 @@ Facebook sharing images 1200x630 and add mimetype and size
 
 Vkontakte sharing images 537x240
 
+Twitter Summary card images must be at least 120x120px 
 
 ## Tools for testing
 

data/app/assets/images/sharing_tags/icons/twitter.svg

@@ -1 +1 @@
-<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 -1 77 79"><path class="tw-sharing-tags-icon-fill sharing-tags-icon-fill" fill="none" d="M38.9.3C18.2.3 1.4 17.4 1.4 38.5s16.8 38.2 37.5 38.2 37.5-17.1 37.5-38.2S59.6.3 38.9.3z"/><path class="tw-sharing-tags-icon-in sharing-tags-icon-in" d="M19.5 52.9c.3 0 .7.1 1 .1h1c1 0 2-.1 2.9-.3.9-.1 1.9-.4 2.8-.8.9-.3 1.7-.7 2.5-1.2s1.6-.9 2.4-1.6c-.9 0-1.9-.1-2.7-.5-.9-.3-1.6-.8-2.4-1.2-.7-.5-1.3-1.2-1.9-1.9s-.9-1.5-1.2-2.4c.3 0 .5.1.8.1h.8c.4 0 .8 0 1.2-.1.4 0 .8-.1 1.2-.3-.9-.3-1.9-.5-2.8-1-.8-.5-1.6-1.2-2.3-1.9-.7-.8-1-1.6-1.5-2.5-.4-.9-.5-1.9-.5-2.9.5.3 1.2.5 1.9.8.7.1 1.3.3 2 .3-1.2-.8-2.1-1.7-2.8-3-.7-1.2-1-2.7-1-4.1 0-.8.1-1.5.3-2.3.3-.8.5-1.5.8-2 1 1.3 2.3 2.5 3.6 3.6 1.3 1 2.8 2 4.3 2.8 1.5.8 3 1.3 4.8 1.9 1.7.5 3.4.8 5.2.8 0-.3-.1-.7-.1-.9v-1c0-1.2.3-2.3.7-3.3.4-1 1-2 1.9-2.8s1.7-1.5 2.8-1.9c1-.4 2.1-.7 3.3-.7s2.4.3 3.4.8 2 1.2 2.8 2c.9-.1 2-.5 2.9-.8.9-.4 1.9-.8 2.7-1.3-.3.9-.8 1.9-1.5 2.7-.7.8-1.5 1.5-2.4 2 .9-.1 1.7-.3 2.5-.5.8-.3 1.6-.5 2.4-.8-.5.8-1.2 1.6-2 2.4-.7.8-1.5 1.5-2.4 2.1v1c0 2.8-.5 5.7-1.6 8.6-1 2.9-2.7 5.6-4.8 8-2.1 2.4-4.7 4.3-7.7 5.7-3 1.5-6.5 2.3-10.5 2.3-1.2 0-2.4-.1-3.6-.3-1.2-.1-2.4-.4-3.4-.8-1-.3-2.1-.8-3.2-1.2-.7-.4-1.7-1-2.6-1.7z"/></svg>
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 -1 78 79"><path class="tw-sharing-tags-icon-fill sharing-tags-icon-fill" fill="none" d="M38.9.3C18.2.3 1.4 17.4 1.4 38.5s16.8 38.2 37.5 38.2 37.5-17.1 37.5-38.2S59.6.3 38.9.3z"/><path class="tw-sharing-tags-icon-in sharing-tags-icon-in" d="M19.5 52.9c.3 0 .7.1 1 .1h1c1 0 2-.1 2.9-.3.9-.1 1.9-.4 2.8-.8.9-.3 1.7-.7 2.5-1.2s1.6-.9 2.4-1.6c-.9 0-1.9-.1-2.7-.5-.9-.3-1.6-.8-2.4-1.2-.7-.5-1.3-1.2-1.9-1.9s-.9-1.5-1.2-2.4c.3 0 .5.1.8.1h.8c.4 0 .8 0 1.2-.1.4 0 .8-.1 1.2-.3-.9-.3-1.9-.5-2.8-1-.8-.5-1.6-1.2-2.3-1.9-.7-.8-1-1.6-1.5-2.5-.4-.9-.5-1.9-.5-2.9.5.3 1.2.5 1.9.8.7.1 1.3.3 2 .3-1.2-.8-2.1-1.7-2.8-3-.7-1.2-1-2.7-1-4.1 0-.8.1-1.5.3-2.3.3-.8.5-1.5.8-2 1 1.3 2.3 2.5 3.6 3.6 1.3 1 2.8 2 4.3 2.8 1.5.8 3 1.3 4.8 1.9 1.7.5 3.4.8 5.2.8 0-.3-.1-.7-.1-.9v-1c0-1.2.3-2.3.7-3.3.4-1 1-2 1.9-2.8s1.7-1.5 2.8-1.9c1-.4 2.1-.7 3.3-.7s2.4.3 3.4.8 2 1.2 2.8 2c.9-.1 2-.5 2.9-.8.9-.4 1.9-.8 2.7-1.3-.3.9-.8 1.9-1.5 2.7-.7.8-1.5 1.5-2.4 2 .9-.1 1.7-.3 2.5-.5.8-.3 1.6-.5 2.4-.8-.5.8-1.2 1.6-2 2.4-.7.8-1.5 1.5-2.4 2.1v1c0 2.8-.5 5.7-1.6 8.6-1 2.9-2.7 5.6-4.8 8-2.1 2.4-4.7 4.3-7.7 5.7-3 1.5-6.5 2.3-10.5 2.3-1.2 0-2.4-.1-3.6-.3-1.2-.1-2.4-.4-3.4-.8-1-.3-2.1-.8-3.2-1.2-.7-.4-1.7-1-2.6-1.7z"/></svg>

data/app/assets/javascripts/sharing_tags/init.js.coffee.erb

@@ -2,8 +2,8 @@
 
 <% if fb && app_id = fb.attributes[:app_id]  %>
 try
-  @fbAsyncInit = ->
-    FB.init(
+  window.fbAsyncInit = ->
+    window.FB.init(
       appId: '<%= app_id %>',
       status : false,
       # or v2.0, v2.1, v2.0

data/app/assets/javascripts/sharing_tags/links.js.coffee

@@ -16,6 +16,6 @@ $(document).on 'click', "@sharing_tags_share", (event) ->
       app_id:      self.data 'app-id'
       provider:    self.data 'provider'
       caption:     self.data 'caption'
-
+      context:     context
       message:     self.data 'description' # @note deprecated
     )

data/app/assets/javascripts/sharing_tags/share/callback.js.coffee

@@ -1,11 +1,13 @@
 class @SharingTags.Share.Callback
   constructor: (@share)->
+    @network = @share.network
+    @context = @share.context
 
   before_sharing: (provider)=>
-    @trigger("start_share", url: @share.url, provider: provider)
+    @trigger("start_share", url: @share.url, provider: provider, network: @network, context: @context)
 
-  after_sharing: ->
-    @trigger("shared")
+  after_sharing: (response)->
+    @trigger("shared", response: response, network: @network, context: @context)
 
   before_open_popup: (open_url, popup_window)=>
     @trigger("open_popup", url: open_url, popup_window: popup_window)

data/app/assets/javascripts/sharing_tags/share/facebook.js.coffee

@@ -23,14 +23,18 @@ class @SharingTags.FacebookShare extends @SharingTags.Share
     # js.src = "//connect.facebook.net/en_US/sdk/debug.js";
     if not FB?
       sdk_url = locale + (if @debug then "/sdk/debug.js" else "/all.js")
-
-      `(function(d, s, id){
-      var js, fjs = d.getElementsByTagName(s)[0];
-      if (d.getElementById(id)) {return;}
-      js = d.createElement(s); js.id = id;
-      js.src = "http://connect.facebook.net/" + sdk_url;
-      fjs.parentNode.insertBefore(js, fjs);
-      }(document, 'script', 'facebook-jssdk'));`
+      jQuery.ajax(
+        url: "//connect.facebook.net/#{sdk_url}"
+        dataType: "script"
+        cache: true
+      )
+#      `(function(d, s, id){
+#      var js, fjs = d.getElementsByTagName(s)[0];
+#      if (d.getElementById(id)) {return;}
+#      js = d.createElement(s); js.id = id;
+#      js.src = "http://connect.facebook.net/" + sdk_url;
+#      fjs.parentNode.insertBefore(js, fjs);
+#      }(document, 'script', 'facebook-jssdk'));`
 
   share: (provider = @provider)->
     @callback.before_sharing(provider)
@@ -44,8 +48,6 @@ class @SharingTags.FacebookShare extends @SharingTags.Share
   #   https://developers.facebook.com/docs/javascript/reference/FB.ui
   _fb_ui: =>
     @_assert_vars "url", "app_id"
-    return @constructor.init().done(@_fb_ui) if not FB?
-
     FB?.ui(
       method: 'share',
       href: @url,
@@ -72,22 +74,21 @@ class @SharingTags.FacebookShare extends @SharingTags.Share
         @callback.after_sharing(response)
     )
 
-  # @note: iphone facebook browser - doesn't show page after sharing
+  # @note: iphone facebook browser - doesn't redirect to page after sharing
   # @note: android browser - Ok
   # return post_id
   # https://developers.facebook.com/docs/sharing/reference/feed-dialog/v2.3
   _fb_ui_feed: =>
-    return @constructor.init().done(@_fb_ui_feed) if not FB?
     FB.ui(
-      method:     'feed'
-      link:        @url
-      name:        @caption # The name of the link attachment.
-      title:       @title
-      caption:     @caption
-      description: @description
-      picture:     @image
-#      actions: {name: 'Jetradar Tokyo', link: 'http://www.jetradar.co.th/promo/tokyo'},
-#      redirect_uri
+      @_prepare_params(
+        method:      'feed'
+        link:         @url
+        name:         @caption   # The name of the link attachment.
+        caption:      @title
+        description:  @description
+        picture:      @image
+        redirect_uri: @return_url
+      ),
       (response)=>
         @callback.after_sharing(response)
     )

data/app/assets/javascripts/sharing_tags/share.js.coffee

@@ -21,8 +21,8 @@ class @SharingTags
         popup_params: null
       )
 
-    @facebook: ({url, app_id, return_url, provider}) ->
-      @_debug("Facebook sharing", {url, app_id, return_url, provider})
+    @facebook: ({url, app_id, caption, title, description, image, return_url, provider}) ->
+      @_debug("Facebook sharing", arguments[0])
       (new SharingTags.FacebookShare(arguments[0])).share()
 
     @twitter: ({url, title}) ->
@@ -82,16 +82,24 @@ class @SharingTags
     @_debug: (args...)->
       console?.debug(args...) if SharingTags.debug
 
-    constructor: ({@network, @url, @title, @description, @image})->
+    constructor: ({@network, @context, @url, @title, @description, @image})->
       @_assert_vars 'url'
       @callback = new SharingTags.Share.Callback(@)
 
       @constructor._debug("Init sharing #{@network}", {@url, @title, @description})
 
 
-    open_popup: (api_url, params)->
+    open_popup: (api_url, params, popup_attrs = 'width=550,height=420,toolbar=no')->
       share_url = if params then "#{api_url}?#{$.param(params)}" else api_url
-      share_window = window.open share_url, 'Sharing', 'width=740,height=440'
+
+#      popup_attrs =
+#        case @network
+#          when "twitter" then "width=550,height=420,toolbar=no"
+#          when "google"   then "menubar=no,toolbar=no,resizable=yes,scrollbars=yes,height=600,width=600"
+#          when "facebook" then "width=550,height=420,toolbar=no"
+#          when "vkontakte" then "width=550,height=420,toolbar=no"
+
+      share_window = window.open share_url, 'Sharing', popup_attrs
       @callback.before_open_popup(share_url, share_window)
 
       clearInterval(@interval)
@@ -117,3 +125,7 @@ class @SharingTags
     _user_agent: ->
       window.navigator?.userAgent
 
+    _prepare_params: (params)->
+      result = {}
+      result[key] = value for key, value of params when value? and  value != ""
+      result

data/app/assets/stylesheets/sharing_tags/themes.css.sass

@@ -0,0 +1,75 @@
+%sharing_tags-squared-theme
+  .sharing_tags-buttons__item
+    border: 1px solid
+    box-sizing: border-box
+
+  .sharing_tags-facebook_buttons__item
+    background-color: #5071AA
+    border-color: darken(#5071AA, 2)
+
+  .sharing_tags-google_buttons__item
+    background-color: #dd4b39
+    border-color: darken(#dd4b39, 2)
+
+  .sharing_tags-twitter_buttons__item
+    background-color: #68C6E1
+    border-color: darken(#68C6E1, 2)
+
+  .sharing_tags-buttons__icon
+      .sharing-tags-icon-fill
+        fill: none
+        stroke: none
+
+      .sharing-tags-icon-in
+        fill: #FFFFFF
+
+  //.sharing_tags-buttons__item:hover
+    background-color: #FFFFFF
+    border: 1px solid
+    box-sizing: border-box
+    outline: none
+
+    &.sharing_tags-facebook_buttons__item
+      border-color: #5071AA
+
+    &.sharing_tags-google_buttons__item
+      border-color: #dd4b39
+
+    &.sharing_tags-twitter_buttons__item
+      border-color: #68C6E1
+
+    .sharing_tags-buttons__icon
+      .sharing-tags-icon-in
+        stroke: none
+
+      .sharing-tags-icon-fill
+        fill: none
+        stroke: none
+
+      .gl-sharing-tags-icon-in
+        fill: #dd4b39
+
+      .fb-sharing-tags-icon-in
+        fill: #5071AA
+
+      .tw-sharing-tags-icon-in
+        fill: #68C6E1
+
+  // darker on hover
+  .sharing_tags-buttons__item:hover
+    &.sharing_tags-facebook_buttons__item
+      background-color: darken(#5071AA, 7)
+
+    &.sharing_tags-google_buttons__item
+      background-color: darken(#dd4b39, 7)
+
+    &.sharing_tags-twitter_buttons__item
+      background-color: darken(#68C6E1, 7)
+
+    .sharing_tags-buttons__icon
+      .sharing-tags-icon-fill
+        fill: none
+        stroke: none
+
+      .sharing-tags-icon-in
+        fill: darken(#FFFFFF, 7)

data/app/assets/stylesheets/sharing_tags/wave_animation.css.sass

@@ -29,6 +29,6 @@
     $center: $right - $half_step
     $left: $center - $half_step
 
-    $animation_name: '#{&}-animate__button#{$i}'
+    $animation_name: 'animate__button#{$i}'
     +create_keyframes_animation($animation_name, $left, $center, $right, $scale)
     +add_animation_on_sharing_button($animation_name, $i, $speed)

data/app/assets/stylesheets/sharing_tags.css.sass

@@ -13,7 +13,7 @@
     &:last-child
       margin-right: 0
 
-    a
+    a.sharing_tags-buttons__icon
       cursor: pointer
       display: inline-block
       vertical-align: middle
@@ -22,7 +22,9 @@
 
 .sharing_tags-buttons__icon
   display: inline-block
-  width: 50px
-  height: 50px
-
+  width: 36px
+  height: 36px
+  @media screen and (max-width: 600px) and (min-width: 360px)
+    width: 50px
+    height: 50px
 

data/app/views/sharing_tags/buttons.html.slim

@@ -1,3 +1,3 @@
 ul.sharing_tags-buttons class="sharing_tags-buttons__#{context.name} #{options[:class]}"
   - networks.each do |network|
-    li.sharing_tags-buttons__item= render "sharing_tags/button/#{network}"
+    li.sharing_tags-buttons__item class="sharing_tags-#{network}_buttons__item"= render "sharing_tags/button/#{network}"

data/app/views/sharing_tags/meta/_open_graphs.html.slim

@@ -1,5 +1,5 @@
-- if meta.title
-  meta property="og:title"         content=meta.title
+- if meta.title || meta.caption
+  meta property="og:title"         content=(meta.title || meta.caption)
 
 - if meta.description
   meta property="og:description"   content=meta.description

data/lib/sharing_tags/action_view/button_helper.rb

@@ -17,7 +17,7 @@ module SharingTags
       end
 
       def link_to_facebook_share(name_or_options = nil, &block)
-        share_to name_or_options, :facebook, [:app_id, :provider, :title, :description, :caption, :image], &block
+        share_to name_or_options, :facebook, [:app_id, :provider, :title, :description, :caption, :image, :return_url], &block
       end
 
       def link_to_vkontakte_share(name_or_options = nil, &block)
@@ -76,7 +76,7 @@ module SharingTags
           link_to "",  params.page_url, data: data_attrs, role: "sharing_tags_share", class: classes, target: "_blank", &block
         end
       end
-      # rubocop:enable Metrics/CyclomaticComplexity
+      # rubocop:enable Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/AbcSize
     end
   end      
 end

data/lib/sharing_tags/network/facebook.rb

@@ -2,7 +2,7 @@ module SharingTags
   class Network
     class Facebook < Network
       def self.available_attributes
-        super + %i( app_id provider )
+        super + %i( app_id caption provider return_url)
       end
 
       def provider(provider = 'auto', &block)
@@ -13,6 +13,10 @@ module SharingTags
         attributes[:app_id] = store_value(app_id, &block)
       end
 
+      def return_url(url = nil, &block)
+        attributes[:return_url] = store_value(url, &block)
+      end
+
       def caption(message = nil, &block)
         attributes[:caption] = store_value(message, &block)
       end

data/lib/sharing_tags/version.rb

@@ -1,3 +1,3 @@
 module SharingTags
-  VERSION = "0.0.13"
+  VERSION = "0.0.14"
 end

data/spec/helpers/button_helper_spec.rb

@@ -8,7 +8,9 @@ RSpec.describe SharingTags::ActionView::ButtonHelper, type: :helper do
           description "fb desc"
           share_url "http://c.d"
           page_url "http://a.b"
+          return_url "http://r.url"
           image "http://img.png"
+          caption "Caption"
         end
       end
     end
@@ -17,15 +19,19 @@ RSpec.describe SharingTags::ActionView::ButtonHelper, type: :helper do
 
     it "generate default text share link" do
       is_expected.to have_tag "a", with: {href: "http://a.b", role: "sharing_tags_share"}
-      is_expected.to have_tag "a", with: {"data-share-url" => "http://c.d"}
+      is_expected.to have_tag "a", with: {
+                                     "data-share-url"   =>  "http://c.d",
+                                     "data-title"       =>  "fb title",
+                                     "data-description" =>  "fb desc",
+                                     "data-image"       =>  "http://img.png",
+                                     "data-network"     =>  "facebook",
+                                     "data-caption"     =>  "Caption",
+                                     "data-return-url"  =>  "http://r.url"
+                                 }
       is_expected.to have_tag "a", with: {class: "sharing_tags-facebook__icon sharing_tags-buttons__icon"}
 
       is_expected.to have_tag("a", without: {
-                                     "data-share-url" => "http://c.d",
-                                     "data-title" => "fb title",
-                                     "data-description" => "fb desc",
-                                     "data-image" => "http://img.png",
-                                     "data-network" => "facebook"
+                                     "data-share-url"   =>  "http://c.d"
                                  })
     end
 

data/spec/javascripts/fixtures/facebook.json

@@ -25,7 +25,8 @@
   "fb_ui": {
     "url":         "http://fb_ui.url",
     "app_id":      "123",
-    "provider":    "fb_ui"
+    "provider":    "fb_ui",
+    "network":      "facebook"
   },
 
   "dialog": {
@@ -46,6 +47,7 @@
     "title":       "Title full",
     "description": "Description",
     "image":       "http://image.url",
-    "app_id":      "123"
+    "app_id":      "123",
+    "return_url":  "http://my.site/return_url"
   }
 }

data/spec/javascripts/sharing_tags/share/callback_spec.coffee

@@ -0,0 +1,21 @@
+#=require sharing_tags/share
+#=require sharing_tags/share/facebook
+#=require sharing_tags/share/callback
+
+fixture.preload("facebook.json")
+
+describe "SharingTags.Share.Callback", ->
+
+  subject = SharingTags.Share.Callback
+
+  beforeEach ->
+    @fb_fixture = fixture.load("facebook.json")[0]
+    @fb = @fb_fixture.fb_ui
+    @share =  new SharingTags.Share @fb
+    @callback = new subject(@share)
+
+
+  it "expect get network and context attr from share", ->
+    expect( @callback.network ).toBe "facebook"
+
+  # todo: check all callbacks

data/spec/javascripts/sharing_tags/share/facebook_spec.coffee

@@ -188,18 +188,6 @@ describe "SharingTags.FacebookShare", ->
         delete @share.url
         expect(=> @share._fb_ui()).toThrow(SharingTags.Error(), /Error could not initialize sharing class/)
 
-    describe "loading FB.ui", ->
-      beforeEach ->
-        spyOn(@share.constructor, "init").andCallThrough()
-        spyOn(@share, "_fb_ui").andCallThrough()
-
-      it "expect load FB.ui if FB undefined", ->
-        expect(typeof FB).toBe('undefined')
-
-        @share._fb_ui()
-        expect(@share.constructor.init).toHaveBeenCalled()
-        expect(@share._fb_ui).toHaveBeenCalled()
-
   describe "#_stream_share", ->
     beforeEach ->
       @fb = @fb_fixture.fb_ui
@@ -216,7 +204,7 @@ describe "SharingTags.FacebookShare", ->
 
   describe "#_fb_ui_feed", ->
     beforeEach ->
-      @fb = @fb_fixture.fb_ui_feed
+      @fb =  jQuery.extend({}, @fb_fixture.fb_ui_feed)
       @share = new subject(@fb)
       window.FB = jasmine.createSpyObj "FB", ['ui', 'init']
 
@@ -225,9 +213,28 @@ describe "SharingTags.FacebookShare", ->
       expect(FB.ui).toHaveBeenCalled()
       expect(FB.ui).toHaveBeenCalledWith(
         jasmine.objectContaining(
-          link: @fb.url, method: 'feed', title: @fb.title,
-          description: @fb.description, caption: @fb.caption,
-          picture: @fb.image
+          link: @fb.url, method: 'feed', caption: @fb.title,
+          description: @fb.description, name: @fb.caption,
+          picture: @fb.image, redirect_uri: @fb.return_url
+        ),
+        jasmine.any(Function)
+      )
+
+    it "expect call FB.ui method with not empty params", ->
+      @fb.return_url = ""
+      @fb.description = ""
+      @share._fb_ui_feed()
+      expect(FB.ui).toHaveBeenCalled()
+      expect(FB.ui).toHaveBeenCalledWith(
+        jasmine.objectContaining(
+          link: @fb.url, method: 'feed', caption: @fb.title,
+          name: @fb.caption, picture: @fb.image
+        ),
+        jasmine.any(Function)
+      )
+      expect(FB.ui).not.toHaveBeenCalledWith(
+        jasmine.objectContaining(
+          return_url: @fb.return_url, description: @fb.description
         ),
         jasmine.any(Function)
       )
@@ -255,7 +262,7 @@ describe "SharingTags.FacebookShare", ->
     it "expect to receive fb_ui provider for sharing with app_id params", ->
       @share = new subject(@fb_fixture.fb_ui)
       expect(@share.app_id).toBeDefined()
-      expect(@share.detect_provider()).toBe "fb_ui"
+      expect(@share.detect_provider()).toBe "fb_ui_feed"
 
     it "expect to receive dialog provider for sharing with app_id and return url params", ->
       @share = new subject(@fb_fixture.returned)
@@ -268,8 +275,4 @@ describe "SharingTags.FacebookShare", ->
       @share = new subject(@fb_fixture.partial)
       expect(@share.detect_provider()).toBe "sharer"
 
-    it "expect to receive fb_ui provider for sharing with app_id params", ->
-      delete @fb_fixture.partial.provider
-      @share = new subject(@fb_fixture.partial)
-      expect(@share.detect_provider()).toBe "sharer"
 

data/spec/models/configuration_spec.rb

@@ -166,15 +166,14 @@ describe SharingTags::Configuration do
           app_id "APP ID"
           provider "sharer"
           caption "Caption"
+          return_url "http://return.com"
         end
       end
     end
 
-    it "expect get app id" do
-      expect(subject.facebook.app_id).to be == "APP ID"
-      expect(subject.facebook.provider).to be == "sharer"
-      expect(subject.facebook.caption).to be == "Caption"
-    end
-
+    it { expect(subject.facebook.app_id).to be == "APP ID" }
+    it { expect(subject.facebook.provider).to be == "sharer" }
+    it { expect(subject.facebook.caption).to be == "Caption" }
+    it { expect(subject.facebook.return_url).to be == "http://return.com" }
   end
 end

data/spec/views/meta_tags/facebook_meta_tags_erb_spec.rb

@@ -58,4 +58,37 @@ RSpec.describe "sharing_tags/meta_tags", type: :view do
       expect(rendered).to have_tag "meta", with: {property: "og:url",          content: "http://a.b"}
     end
   end
+
+  describe "doesn't render empty params" do
+    before do
+      controller.append_view_path 'app/views'
+
+      SharingTags.configure do
+        share_url "http:://dummy.com"
+
+        facebook do
+          caption       { "Facebook caption" }
+          image_url     { "http://img.jpg" }
+        end
+      end
+    end
+
+    it "render caption instead title" do
+      render
+      expect(rendered).to have_tag "meta", with: {property: "og:title",        content: "Facebook caption"}
+    end
+
+    it "expect render image meta" do
+      render
+      expect(rendered).to have_tag "meta", with: {property: "og:image",        content: "http://img.jpg"}
+    end
+
+    it "shouldn't render empty params" do
+      render
+      expect(rendered).to_not have_tag "meta", with: {property: "og:description"}
+      expect(rendered).to_not have_tag "meta", with: {property: "og:image:type"}
+      expect(rendered).to_not have_tag "meta", with: {property: "og:image:width"}
+      expect(rendered).to_not have_tag "meta", with: {property: "og:image:height"}
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sharing_tags
 version: !ruby/object:Gem::Version
-  version: 0.0.13
+  version: 0.0.14
 platform: ruby
 authors:
 - Anatoliy Kovalchuk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-26 00:00:00.000000000 Z
+date: 2015-07-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -340,6 +340,7 @@ files:
 - app/assets/javascripts/sharing_tags/share/facebook.js.coffee
 - app/assets/stylesheets/sharing_tags.css.sass
 - app/assets/stylesheets/sharing_tags/icons.css.sass
+- app/assets/stylesheets/sharing_tags/themes.css.sass
 - app/assets/stylesheets/sharing_tags/wave_animation.css.sass
 - app/views/sharing_tags/button/_facebook.html.slim
 - app/views/sharing_tags/button/_google.html.slim
@@ -435,6 +436,7 @@ files:
 - spec/helpers/meta_tags_helper_spec.rb
 - spec/javascripts/fixtures/facebook.json
 - spec/javascripts/fixtures/vkontakte.json
+- spec/javascripts/sharing_tags/share/callback_spec.coffee
 - spec/javascripts/sharing_tags/share/facebook_spec.coffee
 - spec/javascripts/sharing_tags/share/vkontakte_spec.coffee
 - spec/javascripts/sharing_tags/share_spec.coffee
@@ -537,6 +539,7 @@ test_files:
 - spec/helpers/meta_tags_helper_spec.rb
 - spec/javascripts/fixtures/facebook.json
 - spec/javascripts/fixtures/vkontakte.json
+- spec/javascripts/sharing_tags/share/callback_spec.coffee
 - spec/javascripts/sharing_tags/share/facebook_spec.coffee
 - spec/javascripts/sharing_tags/share/vkontakte_spec.coffee
 - spec/javascripts/sharing_tags/share_spec.coffee