sharing_tags 0.0.10 → 0.0.11

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (7) hide show
  1. checksums.yaml +4 -4
  2. data/app/assets/javascripts/sharing_tags/share.js.coffee +2 -0
  3. data/app/assets/javascripts/sharing_tags/share/facebook.js.coffee +10 -7
  4. data/lib/sharing_tags/version.rb +1 -1
  5. data/sharing_tags.gemspec +1 -1
  6. data/spec/javascripts/sharing_tags/share/facebook_spec.coffee +15 -1
  7. metadata +4 -4
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: 93ed24d53b7eeb1a37d2990de382d72886f26862
4
- data.tar.gz: 70e4d24747716bd06410a4c296db7786976f82cd
3
+ metadata.gz: 3d3d74205d99ac0223a665f135dee84293f0d7b6
4
+ data.tar.gz: 49f37b2d8d0f6228668b93ee9bf91e4cc2714afb
5
5
  SHA512:
6
- metadata.gz: 3bb59b015c7798db9a6dcf6847694eaa10dda8687143289b8811cc966167352ee7359d1b13aa42f26c0c0761a0bff5dde5747b5d2a746e78ae4fedd30be3c7cd
7
- data.tar.gz: 6095a346998f5be9cef3919f6f7457cfab49352750a5666b57728d9582c595d1b34a07d4f69ae1865fe448c9e2108a9afab5119ff41e3a956e790c8e37eaad2b
6
+ metadata.gz: c30b282e88b2a3560fd28457dcb800d4ce63bd967393b15281e3be280d2ebe625cb46b8defb00c8c86b62b552d18a747ea6aded7d9a870a11ab738e12b45530d
7
+ data.tar.gz: 513274eca7a80355e48695f253125c143249a90f02dc3363b4378f8974691d4905d683a06ff4854809400922875d8ea472a7987275300a8313c5dd7af7162f64
data/app/assets/javascripts/sharing_tags/share.js.coffee CHANGED
@@ -77,6 +77,8 @@ class @SharingTags
77
77
  social_share
78
78
 
79
79
  constructor: ({@network, @url, @title, @description})->
80
+ # @url = encodeURIComponent(url)
81
+
80
82
  @_assert_vars 'url'
81
83
  @callback = new SharingTags.Share.Callback(@)
82
84
 
data/app/assets/javascripts/sharing_tags/share/facebook.js.coffee CHANGED
@@ -36,12 +36,15 @@ class @SharingTags.FacebookShare extends @SharingTags.Share
36
36
  @_assert_vars "url", "app_id"
37
37
  return @constructor.init().done(@_fb_ui) if not FB?
38
38
 
39
- FB?.ui(method: 'share', href: @url, app_id: @app_id, (response)=>
40
- @callback.after_sharing(response)
41
- # if response && !response.error_code
42
- # @_after_callback(response)
43
- # else
44
- # # another callback
39
+ FB?.ui(
40
+ method: 'share',
41
+ href: encodeURIComponent(@url),
42
+ (response)=>
43
+ @callback.after_sharing(response)
44
+ # if response && !response.error_code
45
+ # @_after_callback(response)
46
+ # else
47
+ # # another callback
45
48
  )
46
49
 
47
50
  _dialog: (display = 'page')->
@@ -54,7 +57,7 @@ class @SharingTags.FacebookShare extends @SharingTags.Share
54
57
  @_assert_vars 'url'
55
58
  FB.ui(
56
59
  method: 'stream.share',
57
- u: @url
60
+ u: encodeURIComponent(@url)
58
61
  (response) ->
59
62
  console?.log response
60
63
  )
data/lib/sharing_tags/version.rb CHANGED
@@ -1,3 +1,3 @@
1
1
  module SharingTags
2
- VERSION = "0.0.10"
2
+ VERSION = "0.0.11"
3
3
  end
data/sharing_tags.gemspec CHANGED
@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
20
20
  spec.require_paths = ['lib', 'vendor']
21
21
  spec.required_ruby_version = '>= 2.0.0'
22
22
 
23
- spec.add_dependency 'rails', '~> 4.0'
23
+ spec.add_dependency 'rails', '> 4.0'
24
24
  spec.add_dependency 'hashie', '~> 3.4'
25
25
  spec.add_dependency 'slim-rails', '~> 3.0'
26
26
  spec.add_dependency 'coffee-script', '~> 2.3'
data/spec/javascripts/sharing_tags/share/facebook_spec.coffee CHANGED
@@ -180,7 +180,7 @@ describe "SharingTags.FacebookShare", ->
180
180
  @share._fb_ui()
181
181
  expect(FB.ui).toHaveBeenCalled()
182
182
  expect(FB.ui).toHaveBeenCalledWith(
183
- jasmine.objectContaining(app_id: @fb.app_id, href: @fb.url, method: 'share'),
183
+ jasmine.objectContaining(href: encodeURIComponent(@fb.url), method: 'share'),
184
184
  jasmine.any(Function)
185
185
  )
186
186
 
@@ -200,6 +200,20 @@ describe "SharingTags.FacebookShare", ->
200
200
  expect(@share.constructor.init).toHaveBeenCalled()
201
201
  expect(@share._fb_ui).toHaveBeenCalled()
202
202
 
203
+ describe "#_stream_share", ->
204
+ beforeEach ->
205
+ @fb = @fb_fixture.fb_ui
206
+ @share = new subject(@fb)
207
+ window.FB = jasmine.createSpyObj "FB", ['ui', 'init']
208
+
209
+ it "expect call FB.ui method with params", ->
210
+ @share._stream_share()
211
+ expect(FB.ui).toHaveBeenCalled()
212
+ expect(FB.ui).toHaveBeenCalledWith(
213
+ jasmine.objectContaining(u: encodeURIComponent(@fb.url), method: 'stream.share'),
214
+ jasmine.any(Function)
215
+ )
216
+
203
217
  describe "#detect_provider", ->
204
218
 
205
219
  it "expect call detect provider for auto provider", ->
metadata CHANGED
@@ -1,27 +1,27 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: sharing_tags
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.0.10
4
+ version: 0.0.11
5
5
  platform: ruby
6
6
  authors:
7
7
  - Anatoliy Kovalchuk
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2015-05-28 00:00:00.000000000 Z
11
+ date: 2015-06-08 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: rails
15
15
  requirement: !ruby/object:Gem::Requirement
16
16
  requirements:
17
- - - "~>"
17
+ - - ">"
18
18
  - !ruby/object:Gem::Version
19
19
  version: '4.0'
20
20
  type: :runtime
21
21
  prerelease: false
22
22
  version_requirements: !ruby/object:Gem::Requirement
23
23
  requirements:
24
- - - "~>"
24
+ - - ">"
25
25
  - !ruby/object:Gem::Version
26
26
  version: '4.0'
27
27
  - !ruby/object:Gem::Dependency