shamu 0.0.11 → 0.0.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 202b665e0d910a1c418ca7a5ea4bb35d441c16c7
-  data.tar.gz: 8089bef31c11ba75389f8c6b417b2b8f1c34e9dd
+  metadata.gz: b2e88c67ffd19033c4fafc5933fb288f8538a709
+  data.tar.gz: daaf1a9d1f8dcd9746f335ef0fa6122aa7c9dfa0
 SHA512:
-  metadata.gz: ab5be942fca9ff72725316a71a84761a28a954c3cb4445073eb94126556569ada8747795c5788811349740e828d83dfabf516fd1b9851c0ac296b993e95c5075
-  data.tar.gz: cce3f9ff5242932c85e3dfc92977ff0a4469439a865213aeb264ee67cde98f3731aeea157651dbbc60fd18c12acff8d938e1eed42b9b2e35750cb00ba7e00496
+  metadata.gz: 74934132c1023791f4fff72aa458ae8815c72138044bc33b0de60a39d71802e7c976f8409b675a7bb67644d377576370ed3e88a79c21bce48a6b8fbca698c7b3
+  data.tar.gz: '00095f967a07a2517a92721450ab45b2ee991d43f526fcde7b9bb853ea8f98dd4dd014f000d8ff46247e83be0cd62cb93513491df24b79f1a73be1c1f293b3e0'

data/.gitignore

@@ -3,7 +3,6 @@
 .bundle
 .config
 .yardoc
-Gemfile.lock
 InstalledFiles
 _yardoc
 coverage
@@ -22,4 +21,4 @@ tmp
 mkmf.log
 .env
 *.sqlite
-test.db
+test.db

data/.rubocop.yml

@@ -1,5 +1,5 @@
 AllCops:
-  TargetRubyVersion: 2.2
+  TargetRubyVersion: 2.3
 
 
 Lint/AmbiguousRegexpLiteral:
@@ -51,6 +51,9 @@ Style/EmptyLinesAroundClassBody:
 Style/EmptyLinesAroundModuleBody:
   Enabled: false
 
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
 Style/DoubleNegation:
   Enabled: false
 
@@ -124,4 +127,4 @@ Style/CaseEquality:
   Enabled: false
 
 Style/WordArray:
-  Enabled: false
+  Enabled: false

data/Gemfile

@@ -3,7 +3,7 @@ source "https://rubygems.org"
 # Specify your gem"s dependencies in shamu.gemspec
 gemspec
 
-gem 'rake'
+gem "rake"
 
 group :test do
   gem "activerecord", "~> 5.0"
@@ -26,7 +26,7 @@ group :test do
   gem "fuubar"
   gem "yard"
   gem "yard-activesupport-concern"
-  gem "simplecov", github: "colszowka/simplecov"
+  gem "simplecov"
   gem "ruby_gntp", "~> 0.3.4"
   gem "awesome_print"
 

data/Gemfile.lock

@@ -0,0 +1,271 @@
+PATH
+  remote: .
+  specs:
+    shamu (0.0.13)
+      activemodel (>= 5.0)
+      activesupport (>= 5.0)
+      crc32 (~> 1)
+      listen (~> 3)
+      loofah (~> 2)
+      multi_json (~> 1.11.2)
+      rack (>= 1)
+      scorpion-ioc (~> 0.6)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    actioncable (5.0.3)
+      actionpack (= 5.0.3)
+      nio4r (>= 1.2, < 3.0)
+      websocket-driver (~> 0.6.1)
+    actionmailer (5.0.3)
+      actionpack (= 5.0.3)
+      actionview (= 5.0.3)
+      activejob (= 5.0.3)
+      mail (~> 2.5, >= 2.5.4)
+      rails-dom-testing (~> 2.0)
+    actionpack (5.0.3)
+      actionview (= 5.0.3)
+      activesupport (= 5.0.3)
+      rack (~> 2.0)
+      rack-test (~> 0.6.3)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.0.2)
+    actionview (5.0.3)
+      activesupport (= 5.0.3)
+      builder (~> 3.1)
+      erubis (~> 2.7.0)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.0.3)
+    activejob (5.0.3)
+      activesupport (= 5.0.3)
+      globalid (>= 0.3.6)
+    activemodel (5.0.3)
+      activesupport (= 5.0.3)
+    activerecord (5.0.3)
+      activemodel (= 5.0.3)
+      activesupport (= 5.0.3)
+      arel (~> 7.0)
+    activesupport (5.0.3)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (~> 0.7)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+    arel (7.1.4)
+    ast (2.3.0)
+    awesome_print (1.7.0)
+    builder (3.2.3)
+    byebug (9.0.6)
+    codeclimate-test-reporter (1.0.8)
+      simplecov (<= 0.13)
+    coderay (1.1.1)
+    combustion (0.6.0)
+      activesupport (>= 3.0.0)
+      railties (>= 3.0.0)
+      thor (>= 0.14.6)
+    concurrent-ruby (1.0.5)
+    crc32 (1.0.1)
+    diff-lcs (1.3)
+    docile (1.1.5)
+    erubis (2.7.0)
+    ffi (1.9.18)
+    formatador (0.2.5)
+    fuubar (2.2.0)
+      rspec-core (~> 3.0)
+      ruby-progressbar (~> 1.4)
+    globalid (0.4.0)
+      activesupport (>= 4.2.0)
+    guard (2.12.9)
+      formatador (>= 0.2.4)
+      listen (>= 2.7, <= 4.0)
+      lumberjack (~> 1.0)
+      nenv (~> 0.1)
+      notiffany (~> 0.0)
+      pry (>= 0.9.12)
+      shellany (~> 0.0)
+      thor (>= 0.18.1)
+    guard-compat (1.2.1)
+    guard-rspec (4.7.3)
+      guard (~> 2.1)
+      guard-compat (~> 1.1)
+      rspec (>= 2.99.0, < 4.0)
+    guard-rubocop (1.2.0)
+      guard (~> 2.0)
+      rubocop (~> 0.20)
+    i18n (0.8.1)
+    json (2.1.0)
+    kaminari (0.16.3)
+      actionpack (>= 3.0.0)
+      activesupport (>= 3.0.0)
+    listen (3.1.5)
+      rb-fsevent (~> 0.9, >= 0.9.4)
+      rb-inotify (~> 0.9, >= 0.9.7)
+      ruby_dep (~> 1.2)
+    loofah (2.0.3)
+      nokogiri (>= 1.5.9)
+    lumberjack (1.0.12)
+    mail (2.6.5)
+      mime-types (>= 1.16, < 4)
+    method_source (0.8.2)
+    mime-types (3.1)
+      mime-types-data (~> 3.2015)
+    mime-types-data (3.2016.0521)
+    mini_portile2 (2.1.0)
+    minitest (5.10.2)
+    multi_json (1.11.3)
+    nenv (0.3.0)
+    nio4r (2.0.0)
+    nokogiri (1.7.2)
+      mini_portile2 (~> 2.1.0)
+    notiffany (0.1.1)
+      nenv (~> 0.1)
+      shellany (~> 0.0)
+    parser (2.4.0.0)
+      ast (~> 2.2)
+    powerpack (0.1.1)
+    pry (0.10.4)
+      coderay (~> 1.1.0)
+      method_source (~> 0.8.1)
+      slop (~> 3.4)
+    pry-byebug (3.4.2)
+      byebug (~> 9.0)
+      pry (~> 0.10)
+    rack (2.0.3)
+    rack-test (0.6.3)
+      rack (>= 1.0)
+    rails (5.0.3)
+      actioncable (= 5.0.3)
+      actionmailer (= 5.0.3)
+      actionpack (= 5.0.3)
+      actionview (= 5.0.3)
+      activejob (= 5.0.3)
+      activemodel (= 5.0.3)
+      activerecord (= 5.0.3)
+      activesupport (= 5.0.3)
+      bundler (>= 1.3.0, < 2.0)
+      railties (= 5.0.3)
+      sprockets-rails (>= 2.0.0)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
+    rails-html-sanitizer (1.0.3)
+      loofah (~> 2.0)
+    railties (5.0.3)
+      actionpack (= 5.0.3)
+      activesupport (= 5.0.3)
+      method_source
+      rake (>= 0.8.7)
+      thor (>= 0.18.1, < 2.0)
+    rainbow (2.2.2)
+      rake
+    rake (12.0.0)
+    rb-fsevent (0.9.8)
+    rb-inotify (0.9.8)
+      ffi (>= 0.5.0)
+    responders (2.1.2)
+      railties (>= 4.2.0, < 5.1)
+    rspec (3.6.0)
+      rspec-core (~> 3.6.0)
+      rspec-expectations (~> 3.6.0)
+      rspec-mocks (~> 3.6.0)
+    rspec-core (3.6.0)
+      rspec-support (~> 3.6.0)
+    rspec-expectations (3.6.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.6.0)
+    rspec-its (1.2.0)
+      rspec-core (>= 3.0.0)
+      rspec-expectations (>= 3.0.0)
+    rspec-mocks (3.6.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.6.0)
+    rspec-rails (3.6.0)
+      actionpack (>= 3.0)
+      activesupport (>= 3.0)
+      railties (>= 3.0)
+      rspec-core (~> 3.6.0)
+      rspec-expectations (~> 3.6.0)
+      rspec-mocks (~> 3.6.0)
+      rspec-support (~> 3.6.0)
+    rspec-support (3.6.0)
+    rspec-wait (0.0.9)
+      rspec (>= 3, < 4)
+    rspec_junit_formatter (0.2.3)
+      builder (< 4)
+      rspec-core (>= 2, < 4, != 2.12.0)
+    rubocop (0.39.0)
+      parser (>= 2.3.0.7, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 1.99.1, < 3.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    ruby-progressbar (1.8.1)
+    ruby_dep (1.5.0)
+    ruby_gntp (0.3.4)
+    scorpion-ioc (0.6.0)
+      rails (>= 4.0)
+    shellany (0.0.1)
+    simplecov (0.13.0)
+      docile (~> 1.1.0)
+      json (>= 1.8, < 3)
+      simplecov-html (~> 0.10.0)
+    simplecov-html (0.10.1)
+    slop (3.6.0)
+    spring (2.0.1)
+      activesupport (>= 4.2)
+    sprockets (3.7.1)
+      concurrent-ruby (~> 1.0)
+      rack (> 1, < 3)
+    sprockets-rails (3.2.0)
+      actionpack (>= 4.0)
+      activesupport (>= 4.0)
+      sprockets (>= 3.0.0)
+    sqlite3 (1.3.13)
+    thor (0.19.4)
+    thread_safe (0.3.6)
+    tzinfo (1.2.3)
+      thread_safe (~> 0.1)
+    unicode-display_width (1.2.1)
+    websocket-driver (0.6.5)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.2)
+    yard (0.9.9)
+    yard-activesupport-concern (0.0.1)
+      yard (>= 0.8)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  actionpack (~> 5.0)
+  activerecord (~> 5.0)
+  awesome_print
+  bundler (~> 1.6)
+  byebug
+  codeclimate-test-reporter
+  combustion (~> 0.5)
+  fuubar
+  guard (~> 2.12.8)
+  guard-rspec
+  guard-rubocop
+  i18n (~> 0.7)
+  kaminari (~> 0.16.3)
+  pry-byebug
+  rake
+  responders (~> 2.1.2)
+  rspec (~> 3.00)
+  rspec-its
+  rspec-rails
+  rspec-wait
+  rspec_junit_formatter (~> 0.2.2)
+  rubocop (~> 0.39.0)
+  ruby_gntp (~> 0.3.4)
+  shamu!
+  simplecov
+  spring
+  sqlite3 (~> 1.3.11)
+  yard
+  yard-activesupport-concern
+
+BUNDLED WITH
+   1.14.6

data/bin/rake

@@ -9,7 +9,7 @@
 
 require "pathname"
 ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
+                                           Pathname.new(__FILE__).realpath)
 
 require "rubygems"
 require "bundler/setup"

data/bin/rspec

@@ -9,7 +9,7 @@
 
 require "pathname"
 ENV["BUNDLE_GEMFILE"] = File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
+                                         Pathname.new(__FILE__).realpath)
 
 require "rubygems"
 require "bundler/setup"

data/circle.yml

@@ -6,4 +6,7 @@ database:
 test:
   override:
     - RAILS_ENV=test bundle exec rspec -r rspec_junit_formatter --format RspecJunitFormatter -o $CIRCLE_TEST_REPORTS/rspec/junit.xml
-    - bundle exec rubocop
+    - bundle exec rubocop
+
+  post:
+    - bundle exec codeclimate-test-reporter

data/lib/shamu/json_api/builder_methods/identifier.rb

@@ -35,7 +35,7 @@ module Shamu
             type = type.model_name.element         if type.respond_to?( :model_name )
             type = type.name.demodulize.underscore if type.is_a?( Module )
 
-            type
+            type.to_s
           end
 
           def require_identifier!

data/lib/shamu/json_api/presenter.rb

@@ -60,7 +60,7 @@ module Shamu
         def attribute_value( value )
           case value
           when Date, DateTime then
-            value.to_date.to_time.iso8601
+            value.to_date.iso8601
           when Time, ActiveSupport::TimeWithZone then
             value.iso8601
           else value

data/lib/shamu/json_api/rails/controller.rb

@@ -73,8 +73,8 @@ module Shamu
             if result.valid?
               if result.entity
                 status ||= case request.method
-                           when 'POST'   then :created
-                           when 'DELETE' then :no_content
+                           when "POST"   then :created
+                           when "DELETE" then :no_content
                            else               :ok
                            end
 
@@ -125,8 +125,6 @@ module Shamu
             response.as_json
           end
 
-        private
-
           # @!visibility public
           #
           # Add page-based pagination links for the resources to the builder.
@@ -230,7 +228,8 @@ module Shamu
           # @return [JsonApi::Context] the builder context honoring any filter
           #     parameters sent by the client.
           def json_context( fields: :not_set, namespaces: :not_set, presenters: :not_set )
-            Shamu::JsonApi::Context.new fields: fields == :not_set ? json_context_fields : fields,
+            Shamu::JsonApi::Context.new \
+              fields: fields == :not_set ? json_context_fields : fields,
               namespaces: namespaces == :not_set ? json_context_namespaces : namespaces,
               presenters: presenters == :not_set ? json_context_presenters : presenters
           end
@@ -245,15 +244,13 @@ module Shamu
             payload = map_json_resource_payload( json_request_payload )
 
             request.params.each do |key, value|
-              if ID_PATTERN =~ key
-                payload[ key.to_sym ] ||= value
-              end
+              payload[ key.to_sym ] ||= value if ID_PATTERN =~ key
             end
 
             payload
           end
 
-          def map_json_resource_payload( resource )
+          def map_json_resource_payload( resource ) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
             payload = resource[ :attributes ] ? resource[ :attributes ].dup : {}
             payload[ :id ] = resource[ :id ] if resource.key?( :id )
 
@@ -262,7 +259,7 @@ module Shamu
                 attr_key = "#{ key.to_s.singularize }_id"
 
                 if value[ :data ].is_a?( Array )
-                  attr_key += 's' if value[ :data ].is_a?( Array )
+                  attr_key += "s" if value[ :data ].is_a?( Array )
 
                   payload[ attr_key.to_sym ] = value[ :data ].map { |d| d[ :id ] }
                   payload[ key ] = value[ :data ].map { |d| map_json_resource_payload( d ) }

data/lib/shamu/json_api/rails/responder.rb

@@ -35,12 +35,13 @@ module Shamu
                 controller.json_resource resource, **given_options
               end
 
-            super json, given_options
+            super json.to_json, given_options
           end
 
           # @visibility private
           def display_errors
-            controller.render format => controller.json_validation_errors( resource_errors ), :status => :unprocessable_entity # rubocop:disable Metrics/LineLength
+            controller.render format => controller.json_validation_errors( resource_errors ).to_json,
+                              :status => :unprocessable_entity
           end
 
         private
@@ -52,4 +53,4 @@ module Shamu
       end
     end
   end
-end
+end

data/lib/shamu/services/active_record_crud.rb

@@ -163,6 +163,8 @@ module Shamu
           end
         end
 
+        # rubocop:disable Metrics/MethodLength
+
         # Define an change `method` on the service that takes the id of the
         # resource to modify and a corresponding {Request} parameter.
         #
@@ -195,6 +197,9 @@ module Shamu
           end
         end
 
+        # rubocop:enabled Metrics/MethodLength
+
+
         # Define an `update` method on the service that takes the id of the
         # resource to update and a {Request} parameter. After applying the
         # changes the record is persisted and the updated entity result is
@@ -252,7 +257,7 @@ module Shamu
             define_method :find do |id|
               wrap_not_found do
                 record = yield( id )
-                authorize! :read, build_entities( record )
+                authorize! :read, build_entity( record )
               end
             end
           else

data/lib/shamu/services/error.rb

@@ -27,7 +27,7 @@ module Shamu
       def initialize( result )
         @result = result
 
-        super translate( :service_request_failed, errors: result.errors.full_messages.join( ', ' ) )
+        super translate( :service_request_failed, errors: result.errors.full_messages.join( ", " ) )
       end
     end
   end

data/lib/shamu/services/request_support.rb

@@ -119,7 +119,7 @@ module Shamu
           def request_class_namespace
             @request_class_namespace ||= ( name || "" ).sub( /(Service)?$/, "" )
                                                        .singularize
-                                                       .concat( 'Request' )
+                                                       .concat( "Request" )
                                                        .constantize
           rescue NameError
             self

data/lib/shamu/services/result.rb

@@ -89,7 +89,7 @@ module Shamu
       # @return [self]
       # @raise [ServiceRequestFailedError] if the result was not valid.
       def valid!
-        raise ServiceRequestFailedError.new( self ) unless valid?
+        raise ServiceRequestFailedError, self unless valid?
         self
       end
 

data/lib/shamu/version.rb

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 module Shamu
   # The primary version number
-  VERSION_NUMBER  = "0.0.11".freeze
+  VERSION_NUMBER  = "0.0.13"
 
   # Version suffix such as 'beta' or 'alpha'
-  VERSION_SUFFIX  = "".freeze
+  VERSION_SUFFIX  = ""
 
   # Published version number
-  VERSION         = "#{ VERSION_NUMBER }#{ VERSION_SUFFIX }".freeze
+  VERSION         = "#{ VERSION_NUMBER }#{ VERSION_SUFFIX }"
 end

data/spec/lib/shamu/active_record_support.rb

@@ -4,8 +4,8 @@ require "shamu/entities/active_record"
 module ActiveRecordSpec
   class Favorite < ::ActiveRecord::Base
     self.table_name = "favorites"
-    extend Shamu::Entities::ActiveRecord
-    include Shamu::Entities::ActiveRecordSoftDestroy
+    extend ::Shamu::Entities::ActiveRecord
+    include ::Shamu::Entities::ActiveRecordSoftDestroy
 
     scope :by_name, ->( name ) { where( name: name ) }
     scope :by_label, ->( label ) { where( label: label ) }
@@ -29,4 +29,4 @@ module ActiveRecordSpec
   class FavoriteScope < Shamu::Entities::ListScope
     attribute :name
   end
-end
+end

data/spec/lib/shamu/entities/active_record_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
-require "shamu/entities/active_record"
 require "active_record"
+require "shamu/entities/active_record"
 
 describe Shamu::Entities::ActiveRecord do
   use_active_record
@@ -48,8 +48,8 @@ describe Shamu::Entities::ActiveRecord do
       scope    = klass.new( since: since_date, until: until_date )
       relation = ActiveRecordSpec::Favorite.by_list_scope( scope )
 
-      expect( relation.where_values.any? { |w| w.left.name == :since } ).to be_truthy
-      expect( relation.where_values.any? { |w| w.left.name == :until } ).to be_truthy
+      expect( relation.where_clause.any? { |w| w.left.name == :since } ).to be_truthy
+      expect( relation.where_clause.any? { |w| w.left.name == :until } ).to be_truthy
     end
 
     it "sorts by attribute" do
@@ -63,4 +63,4 @@ describe Shamu::Entities::ActiveRecord do
       expect( relation.order_values.any? { |o| o.expr.name == :name } ).to be_truthy
     end
   end
-end
+end

data/spec/lib/shamu/features/toggle_spec.rb

@@ -39,4 +39,4 @@ describe Shamu::Features::Toggle do
       Shamu::Features::Toggle.new( "retire_at" => Time.now )
      end.to raise_error ArgumentError, /Type/
   end
-end
+end

data/spec/lib/shamu/json_api/rails/controller_spec.rb

@@ -103,13 +103,13 @@ describe JsonApiControllerSpec::ResourcesController, type: :controller do
   describe "#render_resource" do
     it "adds Location header" do
       get :show, params: { id: 1 }
-      expect( response.headers ).to include 'Location'
+      expect( response.headers ).to include "Location"
     end
   end
 
   describe "#render_result" do
     it "returns status created on #create" do
-      post :create, params: { name: 'example' }
+      post :create, params: { name: "example" }
       expect( response.status ).to eq 201
       expect( response.body ).to include "data"
     end
@@ -203,7 +203,7 @@ describe JsonApiControllerSpec::ResourcesController, type: :controller do
           },
           relationships: {
             book: {
-              data: { type: "book", id: "5", attributes: { title: "Bibliography" }  }
+              data: { type: "book", id: "5", attributes: { title: "Bibliography" } }
             },
             stores: {
               data: [

data/spec/lib/shamu/json_api/rails/responder_spec.rb

@@ -14,6 +14,8 @@ module JsonApiResponderSpec
   class ResourcesController < ActionController::Base
     include Shamu::JsonApi::Rails::Controller
 
+    public :json_resource, :json_collection, :json_validation_errors, :json_error
+
     respond_to :json_api, :json
     self.responder = Responder
 

data/spec/lib/shamu/json_api/response_spec.rb

@@ -69,4 +69,4 @@ describe Shamu::JsonApi::Response do
     expect( response.compile ).to include errors: include( hash_including( source: { pointer: "/data/attributes/title" } ) ) # rubocop:disable Metrics/LineLength
     expect( response.compile ).to include errors: include( hash_including( source: { pointer: "/data" } ) )
   end
-end
+end

data/spec/lib/shamu/rails/features_spec.rb

@@ -39,7 +39,7 @@ describe Shamu::Rails::Features, type: :controller do
       controller.render plain: ""
     end
 
-    get :show, params: { id: 1, Shamu::Features::EnvStore::RACK_PARAMS_KEY => override } 
+    get :show, params: { id: 1, Shamu::Features::EnvStore::RACK_PARAMS_KEY => override }
   end
 
 end

data/spec/lib/shamu/services/active_record_crud_spec.rb

@@ -298,7 +298,10 @@ describe Shamu::Services::ActiveRecordCrud do
     it "yields to block if block given" do
       find_klass = Class.new( klass )
       expect do |b|
-        find_klass.find( &b )
+        find_klass.find do |_|
+          b.to_proc.call
+          ActiveRecordSpec::Favorite.all.first
+        end
         scorpion.new( find_klass ).find( entity.id )
       end.to yield_control
     end

data/spec/lib/shamu/services/lazy_transform_spec.rb

@@ -4,12 +4,12 @@ describe Shamu::Services::LazyTransform do
   let( :source ) { [ 1, 2, 3 ] }
 
   def transformer( &block  )
-    ->( records ) {
+    ->( records ) do
       records.map do |r|
         yield
         r
       end
-    }
+    end
   end
 
   it "short-circuits count" do
@@ -69,7 +69,7 @@ describe Shamu::Services::LazyTransform do
   end
 
   it "yields transformed values" do
-    transformed = Shamu::Services::LazyTransform.new( source ) { |vs| vs.map { |v| v * v  } }
+    transformed = Shamu::Services::LazyTransform.new( source ) { |vs| vs.map { |v| v * v } }
     expect( transformed.to_a ).to eq [ 1, 4, 9 ]
   end
 

data/spec/lib/shamu/services/request_support_spec.rb

@@ -81,7 +81,7 @@ describe Shamu::Services::RequestSupport do
         end.request_class( :change )
       end.to raise_error Shamu::Services::IncompleteSetupError, /Request/
     end
-    
+
     it "singularizes service namespace" do
       service = scorpion.new RequestSupportSpec::UsersService
       expect( service.request_class( :change ) ).to be RequestSupportSpec::UserRequest::Change

data/spec/lib/shamu/services/service_spec.rb

@@ -54,11 +54,11 @@ describe Shamu::Services::Service do
   let( :service ) { scorpion.new ServiceSpec::Service }
 
   def transformer( &block )
-    ->( records ) {
+    ->( records ) do
       records.map do |r|
         yield || r
       end
-    }
+    end
   end
 
 
@@ -136,7 +136,7 @@ describe Shamu::Services::Service do
     end
 
     it "matches on a custom field" do
-      list = service.entity_lookup_list( records, [record.amount], ServiceSpec::NullEntity, match: :amount ) do |records|
+      list = service.entity_lookup_list( records, [record.amount], ServiceSpec::NullEntity, match: :amount ) do |records| # rubocop:disable Metrics/LineLength
         records.map { |r| scorpion.fetch ServiceSpec::Entity, { record: r }, {} }
       end
 
@@ -145,7 +145,7 @@ describe Shamu::Services::Service do
 
     it "matches with a custom proc" do
       matcher = ->( record ) { record.amount }
-      list = service.entity_lookup_list( records, [record.amount], ServiceSpec::NullEntity, match: matcher ) do |records|
+      list = service.entity_lookup_list( records, [record.amount], ServiceSpec::NullEntity, match: matcher ) do |records| # rubocop:disable Metrics/LineLength
         records.map { |r| scorpion.fetch ServiceSpec::Entity, { record: r }, {} }
       end
 

data/spec/spec_helper.rb

@@ -1,10 +1,6 @@
 require "simplecov"
-if ENV[ "COVERAGE" ]
-  require "codeclimate-test-reporter"
-  CodeClimate::TestReporter.start
-else
-  SimpleCov.start
-end
+SimpleCov.start
+
 require "pry"
 require "bundler/setup"
 
@@ -24,7 +20,8 @@ RSpec.configure do |config|
 
   config.order = "random"
 
-  config.filter_gems_from_backtrace "activesupport", "actionpack", "actionview", "scorpion-ioc", "rspec-wait", "rspec-core", "rspec", "rspec-support", "rspec-expectations"
+  config.filter_gems_from_backtrace "activesupport", "actionpack", "actionview", "scorpion-ioc", "rspec-wait",
+                                    "rspec-core", "rspec", "rspec-support", "rspec-expectations"
 
   config.filter_run focus: true
   config.filter_run_excluding :broken => true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: shamu
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.13
 platform: ruby
 authors:
 - Paul Alexander
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-17 00:00:00.000000000 Z
+date: 2017-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -209,6 +209,7 @@ files:
 - ".yardopts"
 - CHANGELOG.md
 - Gemfile
+- Gemfile.lock
 - Guardfile
 - LABELS.md
 - LICENSE
@@ -353,7 +354,6 @@ files:
 - lib/shamu/services/request_support.rb
 - lib/shamu/services/result.rb
 - lib/shamu/services/service.rb
-- lib/shamu/services/service_call_failed_error.rb
 - lib/shamu/sessions.rb
 - lib/shamu/sessions/README.md
 - lib/shamu/sessions/cookie_store.rb

data/lib/shamu/services/service_call_failed_error.rb

@@ -1,4 +0,0 @@
-module Shamu
-  module Services
-
-    class