shale-builder 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a0bb7fdc1a286efcf893e13eb582ce75308e644ba0b97d61416e8960179b1abb
-  data.tar.gz: 1b1c5e02a9deb9cd87ad860ec3121933a4afc17606e07541bff808fa9af4747a
+  metadata.gz: 1bc4050027c07ff6a3bf24b27df89131835ebe1cf9beb9d53bc1277809616a27
+  data.tar.gz: 109df45cbb2687a06e08fcc9baa153c2a813410cc009a730c1453672031e0387
 SHA512:
-  metadata.gz: abd61d99919161f2fef011a0db94390f8a0239f33b7e175569d773ad2b4ba519130d1ff97b3a5f83bb3ad2e705a6d64ef8dfa9ca15ca9c871b9ad26aff25274d
-  data.tar.gz: 4589178be4684e967fd37ecf4e2ad1c7a22198fa387ee787fd968fa31af61c8874a7040d15fd64c3444839575684abdfaf03e41dcc530e15b47123f3369a39d6
+  metadata.gz: 0b363fdf655cb8aec7a996f9dee375e8116aaed816a28e112acdaba2413cdbc902f32915f8670cffc92caec08042b8a0bd90c4e80c996d58ee7b9a0bcff07f95
+  data.tar.gz: 93ffb3fa8e767cab76bb9ad84492fd4fb581b1345fe2614964f4f63a5ba4b107c5928892c16edb8794288d49bcd9b8097321be904da7628d09ec9934c2709c00

data/CHANGELOG.md

@@ -5,6 +5,20 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.8.0] - 2025-10-24
+
+[Diff](https://github.com/Verseth/ruby-shale-builder/compare/v0.7.1...v0.8.0)
+
+### Changes
+- Add `Shale::Builder::NestedValidations#validatable_attribute_names`, `Shale::Builder::NestedValidations#nested_attr_name_separator`, `Shale::Builder::NestedValidations#import_errors`
+
+## [0.7.1] - 2025-10-17
+
+[Diff](https://github.com/Verseth/ruby-shale-builder/compare/v0.7.0...v0.7.1)
+
+### Changes
+- Make `Shale::Builder::NestedValidations::nested_attr_name_separator` inheritable
+
 ## [0.7.0] - 2025-10-17
 
 [Diff](https://github.com/Verseth/ruby-shale-builder/compare/v0.6.4...v0.7.0)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    shale-builder (0.7.0)
+    shale-builder (0.8.0)
       booleans (>= 0.1)
       shale (< 2.0)
       sorbet-runtime (> 0.5)

data/README.md

@@ -263,6 +263,25 @@ obj.errors.messages #=> {cvv_code: ["can't be blank"], "amount.value": ["can't b
 
 You MUST include `ActiveModel::Validations` before `Shale::Builder::NestedValidations`.
 
+The attribute name separator can be changed like so:
+
+```rb
+class TransactionType < ::Shale::Mapper
+    self.nested_attr_name_separator = ':'
+end
+
+
+obj = TransactionType.build do |t|
+    t.amount do |a|
+        a.currency = 'USD'
+    end
+end
+
+obj.valid? #=> false
+obj.errors #=> #<ActiveModel::Errors [#<ActiveModel::Error attribute=cvv_code, type=blank, options={}>, #<ActiveModel::NestedError attribute=amount:value, type=blank, options={}>]>
+obj.errors.messages #=> {cvv_code: ["can't be blank"], "amount:value": ["can't be blank"]}
+```
+
 ### Recording Assigned Attributes
 
 There is an additional module `Shale::Builder::AssignedAttributes` that provides

data/lib/shale/builder/nested_validations.rb

@@ -23,47 +23,74 @@ module Shale
 
         #: -> String
         def nested_attr_name_separator
-          @nested_attr_name_separator ||= '.'
+          return @nested_attr_name_separator if @nested_attr_name_separator
+
+          s = superclass
+          return @nested_attr_name_separator = s.nested_attr_name_separator if s < NestedValidations
+
+          @nested_attr_name_separator = '.'
         end
 
-        sig { returns(T::Hash[Symbol, Shale::Attribute]) }
+        #: -> Hash[Symbol, Shale::Attribute]
         def validatable_attributes
           @validatable_attributes ||= attributes.select do |_, val|
             val.validatable?
           end
         end
+
+        #: -> Array[Symbol]
+        def validatable_attribute_names
+          validatable_attribute_names.keys
+        end
       end
       mixes_in_class_methods ClassMethods
 
-      sig { returns(T::Boolean) }
+      #: -> Array[Symbol]
+      def validatable_attribute_names
+        self.class.validatable_attribute_names
+      end
+
+      #: -> String
+      def nested_attr_name_separator
+        self.class.nested_attr_name_separator
+      end
+
+      #: -> bool
       def valid?
         result = super
-        errlist = errors
-        klass = self.class #: as untyped
-        separator = klass.nested_attr_name_separator
 
-        attrs = T.unsafe(self).class.validatable_attributes
-        attrs.each_key do |name|
+        validatable_attribute_names.each_key do |name|
+          next unless name
+
           val = public_send(name)
           next unless val
           next if val.valid?
 
           result = false
-          val.errors.each do |err|
-            errlist.import(err, attribute: "#{name}#{separator}#{err.attribute}")
-          end
+          import_errors(val)
         end
 
         result
       end
 
+      #: (ActiveModel::Validations?) -> void
+      def import_errors(obj)
+        return unless obj
+
+        errlist = errors
+        separator = nested_attr_name_separator
+        obj.errors.each do |err|
+          errlist.import(err, attribute: "#{name}#{separator}#{err.attribute}")
+        end
+      end
+
     end
   end
 end
 
 module Shale
   class Attribute # rubocop:disable Style/Documentation
-    sig { returns(T::Boolean) }
+    #: -> bool
     def validatable?
       Boolean(type.is_a?(Class) && type < ::ActiveModel::Validations)
     end

data/lib/shale/builder/version.rb

@@ -2,6 +2,6 @@
 
 module Shale
   module Builder
-    VERSION = '0.7.0'
+    VERSION = '0.8.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shale-builder
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Mateusz Drewniak