shakapacker 9.5.0 → 9.6.0.beta.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3b214b9c8a64b8d7a39fa119818f9cd85e872abf2278ca9659685ebfe73d3324
-  data.tar.gz: 06a7f954d5909f19df8cf13188b398e0b3ce2d5b4b17c6d74eca65e8573e6a30
+  metadata.gz: 16a87e8e339c085afc34f5f70af6fee7aa534590949f02faa1863d9c5e7f9f7d
+  data.tar.gz: 19d1f859e00dc29bfe4c593ba1b4a1e5b64c6347fc1b56a2cbabcc8c8020205b
 SHA512:
-  metadata.gz: f728d9d77e03e1c8113edefdd426fd96b900eb64ce7c8e6470cd2e78f45e2f326645d58c31a95dc383809cfebef6af157cd06c145c9204d9975368212e842cb1
-  data.tar.gz: 7feac095bbf2182d7e87c21fd8f739cbf774ae1bdb8ec55dbe297e76b154f00b81cbabb3ee6f838dda9fd42b67fe718a749b4778924cf23c8f65b896e6a1b7da
+  metadata.gz: f4286284b7cbbec5324ce2ad26c6d6892cfcecae96e31c7324ff0a533f332301b4008e7083592b3b4b639be131758ab6fa5bc81ed46ac0903f2370f20a05fae0
+  data.tar.gz: e4e6bfdd5837dabfd9f5d031e5a1d905ca88b6c1d50b1f3d440fb3f3c6a23d0abbec1d8839a769536af52d67eed5657ec602786c824dd57156f1678026ec300e

data/.github/workflows/claude-code-review.yml

@@ -2,7 +2,7 @@ name: Claude Code Review
 
 on:
   pull_request:
-    types: [opened, synchronize]
+    types: [opened, synchronize, ready_for_review, reopened]
     # Optional: Only run on specific file changes
     # paths:
     #   - "src/**/*.ts"
@@ -36,18 +36,9 @@ jobs:
         uses: anthropics/claude-code-action@v1
         with:
           claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
-          prompt: |
-            Please review this pull request and provide feedback on:
-            - Code quality and best practices
-            - Potential bugs or issues
-            - Performance considerations
-            - Security concerns
-            - Test coverage
-
-            Use the repository's CLAUDE.md for guidance on style and conventions. Be constructive and helpful in your feedback.
-
-            Use `gh pr comment` with your Bash tool to leave your review as a comment on the PR.
-
+          plugin_marketplaces: 'https://github.com/anthropics/claude-code.git'
+          plugins: 'code-review@claude-code-plugins'
+          prompt: '/code-review:code-review ${{ github.repository }}/pull/${{ github.event.pull_request.number }}'
           # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
-          # or https://docs.claude.com/en/docs/claude-code/sdk#command-line for available options
-          claude_args: '--model claude-sonnet-4-5-20250929 --allowed-tools "Bash(gh issue view:*),Bash(gh search:*),Bash(gh issue list:*),Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh pr list:*)"'
+          # or https://code.claude.com/docs/en/cli-reference for available options
+

data/.github/workflows/claude.yml

@@ -45,5 +45,6 @@ jobs:
 
           # Optional: Add claude_args to customize behavior and configuration
           # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
-          # or https://docs.claude.com/en/docs/claude-code/sdk#command-line for available options
-          # claude_args: '--model claude-opus-4-1-20250805 --allowed-tools Bash(gh pr:*)'
+          # or https://code.claude.com/docs/en/cli-reference for available options
+          # claude_args: '--allowed-tools Bash(gh pr:*)'
+

data/.prettierignore

@@ -1,3 +1,7 @@
 # Template files that should maintain their original quote style
 lib/install/config/**/*.ts
 lib/install/config/**/*.js
+
+# Temporarily ignore workflow files that cannot be modified in PRs due to claude-review validation
+.github/workflows/claude.yml
+.github/workflows/claude-code-review.yml

data/.rubocop.yml

@@ -10,6 +10,7 @@ AllCops:
     - "node_modules/**/*"
     - "_actions/**/*"
     - "spec/dummy-rspack/**/*"
+    - "bin/conductor-exec" # Shell script, not Ruby
 
 # Prefer &&/|| over and/or.
 Style/AndOr:

data/CHANGELOG.md

@@ -11,7 +11,38 @@
 
 Changes since the last non-beta release.
 
-_None yet._
+### Changed
+
+- **BREAKING: sass-loader now defaults to modern Sass API**. [PR #879](https://github.com/shakacode/shakapacker/pull/879) by [justin808](https://github.com/justin808). The sass-loader configuration now uses `api: "modern"` instead of the deprecated legacy API. This improves compatibility with plugins like sass-resources-loader that require the modern API. If you experience issues after upgrading, you can revert to the legacy API by customizing your webpack config:
+
+  ```javascript
+  // config/webpack/webpack.config.js
+  const { generateWebpackConfig } = require("shakapacker")
+  const config = generateWebpackConfig()
+
+  // Find and modify sass-loader options
+  config.module.rules.forEach((rule) => {
+    if (rule.use) {
+      rule.use.forEach((loader) => {
+        if (loader.loader?.includes("sass-loader")) {
+          loader.options.api = "legacy"
+        }
+      })
+    }
+  })
+
+  module.exports = config
+  ```
+
+### Fixed
+
+- **Fixed orphaned webpack/rspack processes when foreman receives SIGTERM**. [PR #888](https://github.com/shakacode/shakapacker/pull/888) by [jordan-brough](https://github.com/jordan-brough). When running under foreman, sending SIGTERM to foreman (e.g. `kill <pid>`) would kill the Ruby shakapacker process but leave the webpack/rspack child process running as an orphan. DevServerRunner now uses `exec` to replace the Ruby process entirely, and Runner uses `spawn` with SIGTERM forwarding to ensure the child process is properly terminated.
+- **Fixed installer writing wrong shakapacker version in package.json**. [PR #899](https://github.com/shakacode/shakapacker/pull/899) by [justin808](https://github.com/justin808). The `shakapacker:install` generator now keeps the `package.json` dependency value in sync with the exact version or path that was requested, instead of relying on the post-install value which could differ.
+- **Fixed NODE_ENV=test causing DefinePlugin warnings**. [PR #870](https://github.com/shakacode/shakapacker/pull/870) by [justin808](https://github.com/justin808). When RAILS_ENV=test, Shakapacker now sets NODE_ENV=development instead of NODE_ENV=test. This prevents webpack/rspack DefinePlugin conflicts since these bundlers only recognize "development" and "production" as valid NODE_ENV values.
+
+### Documentation
+
+- **Added CDN limitation warnings for Early Hints feature**. [PR #878](https://github.com/shakacode/shakapacker/pull/878) by [justin808](https://github.com/justin808). The early hints documentation now prominently notes that most CDNs (Cloudflare, AWS CloudFront, AWS ALB) strip HTTP 103 responses before they reach end users. Debug mode also includes CDN warnings in HTML comments.
 
 ## [v9.5.0] - January 7, 2026
 
@@ -256,7 +287,6 @@ See the [v9 Upgrade Guide](https://github.com/shakacode/shakapacker/blob/main/do
 ### ⚠️ Breaking Changes
 
 1. **SWC is now the default JavaScript transpiler instead of Babel** ([PR 603](https://github.com/shakacode/shakapacker/pull/603) by [justin808](https://github.com/justin808))
-
    - Babel dependencies are no longer included as peer dependencies
    - Improves compilation speed by 20x
    - **Migration for existing projects:**
@@ -273,7 +303,6 @@ See the [v9 Upgrade Guide](https://github.com/shakacode/shakapacker/blob/main/do
        ```
 
 2. **CSS Modules now use named exports by default** ([PR 599](https://github.com/shakacode/shakapacker/pull/599))
-
    - **JavaScript:** Use named imports: `import { className } from './styles.module.css'`
    - **TypeScript:** Use namespace imports: `import * as styles from './styles.module.css'`
    - To keep the old behavior with default imports, see [CSS Modules Export Mode documentation](./docs/css-modules-export-mode.md) for configuration instructions
@@ -539,7 +568,6 @@ See the [v8 Upgrade Guide](https://github.com/shakacode/shakapacker/blob/main/do
 
 - Set `source_entry_path` to `packs` and `nested_entries` to `true` in`shakapacker.yml` [PR 284](https://github.com/shakacode/shakapacker/pull/284) by [ahangarha](https://github.com/ahangarha).
 - Dev server configuration is modified to follow [webpack recommended configurations](https://webpack.js.org/configuration/dev-server/) for dev server. [PR276](https://github.com/shakacode/shakapacker/pull/276) by [ahangarha](https://github.com/ahangarha):
-
   - Deprecated `https` entry is removed from the default configuration file, allowing to set `server` or `https` as per the project requirements. For more detail, check webpack documentation. The `https` entry can be effective only if there is no `server` entry in the config file.
   - `allowed_hosts` is now set to `auto` instead of `all` by default.
 

data/CLAUDE.md

@@ -45,3 +45,11 @@
 - This gem supports both webpack and rspack configurations
 - Test changes with both bundlers when modifying core functionality
 - Be aware of the dual package.json/Gemfile dependency management
+
+## Conductor Environment
+
+- **Version manager support**: The setup script detects mise, asdf, or direct PATH tools (rbenv/nvm/nodenv)
+- **bin/conductor-exec**: Use this wrapper for commands when tool versions aren't detected correctly in Conductor's non-interactive shell
+  - Example: `bin/conductor-exec bundle exec rubocop`
+  - The wrapper uses `mise exec` if mise is available, otherwise falls back to direct execution
+- **conductor.json scripts** already use this wrapper, so you typically don't need to use it manually

data/bin/conductor-exec

@@ -0,0 +1,24 @@
+#!/bin/zsh
+# Wrapper script to run commands in Conductor with proper tool versions
+# Usage: bin/conductor-exec <command> [args...]
+#
+# This is needed because Conductor (and other non-interactive shells) don't
+# source .zshrc, so version manager PATH configuration isn't active by default.
+#
+# - If mise is available: uses `mise exec` for correct tool versions
+# - Otherwise: falls back to direct execution (for asdf/rbenv/nvm users)
+#
+# Examples:
+#   bin/conductor-exec ruby --version       # Uses correct Ruby version
+#   bin/conductor-exec bundle exec rubocop  # Correct Ruby for linting
+#   bin/conductor-exec git commit -m "msg"  # Pre-commit hooks work correctly
+#   bin/conductor-exec yarn install         # Uses correct Node version
+#
+# See: https://github.com/shakacode/react_on_rails-demos/issues/105
+
+if command -v mise &> /dev/null; then
+  exec mise exec -- "$@"
+else
+  # Fall back to direct execution for non-mise users
+  exec "$@"
+fi

data/conductor-setup.sh

@@ -1,43 +1,124 @@
-#!/usr/bin/env bash
+#!/bin/zsh
 set -euo pipefail
 
 echo "🔧 Setting up Shakapacker workspace..."
 
-# Set up Ruby version if asdf is available
-if command -v asdf &> /dev/null; then
-    echo "📝 Using asdf Ruby version management..."
-    # Ensure we have the right Ruby version file
-    echo "ruby 3.3.4" > .tool-versions
-    # Use asdf exec to run commands with the right Ruby version
-    BUNDLE_CMD="asdf exec bundle"
+# Detect and initialize version manager
+# Supports: mise, asdf, or direct PATH (rbenv/nvm/nodenv already in PATH)
+VERSION_MANAGER="none"
+
+echo "📋 Detecting version manager..."
+
+if command -v mise &> /dev/null; then
+    VERSION_MANAGER="mise"
+    echo "✅ Found mise"
+    # Trust mise config for current directory only
+    mise trust 2>/dev/null || true
+elif [[ -f ~/.asdf/asdf.sh ]]; then
+    VERSION_MANAGER="asdf"
+    source ~/.asdf/asdf.sh
+    echo "✅ Found asdf (from ~/.asdf/asdf.sh)"
+elif command -v asdf &> /dev/null; then
+    VERSION_MANAGER="asdf"
+    # For homebrew-installed asdf
+    if [[ -f /opt/homebrew/opt/asdf/libexec/asdf.sh ]]; then
+        source /opt/homebrew/opt/asdf/libexec/asdf.sh
+    fi
+    echo "✅ Found asdf"
 else
-    BUNDLE_CMD="bundle"
+    echo "ℹ️  No version manager detected, using system PATH"
+    echo "   (Assuming rbenv/nvm/nodenv or system tools are already configured)"
+fi
+
+# Ensure version config exists for asdf/mise users
+if [[ "$VERSION_MANAGER" != "none" ]] && [[ ! -f .tool-versions ]] && [[ ! -f .mise.toml ]]; then
+    echo "📝 Creating .tool-versions from project version files..."
+
+    # Read Ruby version from .ruby-version or use default
+    if [[ -f .ruby-version ]]; then
+        RUBY_VER=$(cat .ruby-version | tr -d '[:space:]')
+    else
+        RUBY_VER="3.3.4"  # Default: recent stable Ruby
+    fi
+
+    # Read Node version from .node-version or use default
+    if [[ -f .node-version ]]; then
+        NODE_VER=$(cat .node-version | tr -d '[:space:]')
+    else
+        NODE_VER="20.18.0"  # Default: LTS Node
+    fi
+
+    cat > .tool-versions << EOF
+ruby $RUBY_VER
+nodejs $NODE_VER
+EOF
+    echo "   Using Ruby $RUBY_VER, Node $NODE_VER"
 fi
 
-# Check for required tools
-if ! $BUNDLE_CMD --version &> /dev/null; then
-    echo "❌ Error: Ruby bundler is not installed"
-    echo "Please install bundler first: gem install bundler"
+# Install tools via mise (after .tool-versions exists)
+if [[ "$VERSION_MANAGER" == "mise" ]]; then
+    echo "📦 Installing tools via mise..."
+    mise install
+fi
+
+# Helper function to run commands with the detected version manager
+run_cmd() {
+    if [[ "$VERSION_MANAGER" == "mise" ]] && [[ -x "bin/conductor-exec" ]]; then
+        bin/conductor-exec "$@"
+    else
+        "$@"
+    fi
+}
+
+# Check required tools
+echo "📋 Checking required tools..."
+run_cmd ruby --version >/dev/null 2>&1 || { echo "❌ Error: Ruby is not installed or not in PATH."; exit 1; }
+run_cmd node --version >/dev/null 2>&1 || { echo "❌ Error: Node.js is not installed or not in PATH."; exit 1; }
+
+# Check Ruby version
+RUBY_VERSION=$(run_cmd ruby -v | awk '{print $2}')
+MIN_RUBY_VERSION="2.7.0"
+if [[ $(echo -e "$MIN_RUBY_VERSION\n$RUBY_VERSION" | sort -V | head -n1) != "$MIN_RUBY_VERSION" ]]; then
+    echo "❌ Error: Ruby version $RUBY_VERSION is too old. Shakapacker requires Ruby >= 2.7.0"
+    echo "   Please upgrade Ruby using your version manager or system package manager."
     exit 1
 fi
+echo "✅ Ruby version: $RUBY_VERSION"
 
-if ! command -v yarn &> /dev/null; then
-    echo "❌ Error: Yarn is not installed"
-    echo "Please install yarn first"
+# Check Node version
+NODE_VERSION=$(run_cmd node -v | cut -d'v' -f2)
+MIN_NODE_VERSION="14.0.0"
+if [[ $(echo -e "$MIN_NODE_VERSION\n$NODE_VERSION" | sort -V | head -n1) != "$MIN_NODE_VERSION" ]]; then
+    echo "❌ Error: Node.js version v$NODE_VERSION is too old. Shakapacker requires Node.js >= 14.0.0"
+    echo "   Please upgrade Node.js using your version manager or system package manager."
     exit 1
 fi
+echo "✅ Node.js version: v$NODE_VERSION"
+
+# Copy any environment files from root if they exist
+if [ -n "${CONDUCTOR_ROOT_PATH:-}" ]; then
+    if [ -f "$CONDUCTOR_ROOT_PATH/.env" ]; then
+        echo "📝 Copying .env file..."
+        cp "$CONDUCTOR_ROOT_PATH/.env" .env
+    fi
+
+    if [ -f "$CONDUCTOR_ROOT_PATH/.env.local" ]; then
+        echo "📝 Copying .env.local file..."
+        cp "$CONDUCTOR_ROOT_PATH/.env.local" .env.local
+    fi
+fi
 
 # Install Ruby dependencies
-echo "📦 Installing Ruby dependencies..."
-$BUNDLE_CMD install
+echo "💎 Installing Ruby dependencies..."
+run_cmd bundle install
 
 # Install JavaScript dependencies
 echo "📦 Installing JavaScript dependencies..."
-yarn install --frozen-lockfile
+run_cmd yarn install --frozen-lockfile
 
 # Set up Husky git hooks
 echo "🪝 Setting up Husky git hooks..."
-npx husky
+run_cmd npx husky
 if [ ! -f .husky/pre-commit ]; then
     echo "Creating pre-commit hook..."
     cat > .husky/pre-commit << 'EOF'
@@ -47,24 +128,20 @@ EOF
     chmod +x .husky/pre-commit
 fi
 
-# Copy environment files if they exist in root
-if [ -n "${CONDUCTOR_ROOT_PATH:-}" ]; then
-    if [ -f "$CONDUCTOR_ROOT_PATH/.env" ]; then
-        echo "📋 Copying .env file from root..."
-        cp "$CONDUCTOR_ROOT_PATH/.env" .env
-    fi
-    
-    if [ -f "$CONDUCTOR_ROOT_PATH/.env.local" ]; then
-        echo "📋 Copying .env.local file from root..."
-        cp "$CONDUCTOR_ROOT_PATH/.env.local" .env.local
-    fi
-fi
+# Verify linting tools are available
+echo "✅ Verifying linting tools..."
+run_cmd bundle exec rubocop --version
 
-echo "✅ Workspace setup complete!"
+echo "✨ Workspace setup complete!"
 echo ""
-echo "Available commands:"
-echo "  - Run tests: bundle exec rspec"
-echo "  - Run specific test suites: bundle exec rake run_spec:gem"
-echo "  - Run JavaScript tests: yarn test"
-echo "  - Lint JavaScript: yarn lint"
-echo "  - Lint Ruby: bundle exec rubocop"
+echo "📚 Key commands:"
+echo "  • bundle exec rspec - Run Ruby tests"
+echo "  • bundle exec rake run_spec:gem - Run gem-specific tests"
+echo "  • yarn test - Run JavaScript tests"
+echo "  • yarn lint - Run JavaScript linting"
+echo "  • bundle exec rubocop - Run Ruby linting (required before commits)"
+echo ""
+if [[ "$VERSION_MANAGER" == "mise" ]]; then
+    echo "💡 Tip: Use 'bin/conductor-exec <command>' if tool versions aren't detected correctly."
+fi
+echo "⚠️ Remember: Always run 'bundle exec rubocop' before committing!"

data/conductor.json

@@ -1,7 +1,9 @@
 {
   "scripts": {
     "setup": "./conductor-setup.sh",
-    "run": "bundle exec rspec",
+    "run": "bin/conductor-exec bundle exec rspec",
+    "test": "bin/conductor-exec bundle exec rspec",
+    "lint": "bin/conductor-exec bundle exec rubocop && bin/conductor-exec yarn lint",
     "archive": ""
   }
 }

data/docs/early_hints.md

@@ -4,6 +4,8 @@ This guide shows you how to use HTTP 103 Early Hints with Shakapacker to optimiz
 
 > **📚 Related Documentation:** For advanced manual control using `send_pack_early_hints` in controllers before expensive work, see [early_hints_manual_api.md](early_hints_manual_api.md).
 
+> ⚠️ **CDN Limitation**: Most CDNs (Cloudflare, AWS CloudFront, AWS ALB, etc.) strip HTTP 103 Early Hints before they reach end users. While Shakapacker sends early hints correctly, and your application server (Puma/Thruster) forwards them properly, **CDNs typically strip the 103 response**. End users will only receive the 200 response with Link headers (which arrive too late to provide early hints benefits). This is an industry-wide limitation—even major sites like GitHub, Google, and Shopify don't serve 103 in production through CDNs. For full early hints delivery, you need either direct connections without a CDN, or specific CDN configuration (e.g., Cloudflare's Early Hints feature on paid plans, which works differently by caching Link headers). See [Reverse proxy stripping 103 responses](#reverse-proxy-stripping-103-responses) for configuration details.
+
 ## What are Early Hints?
 
 HTTP 103 Early Hints is emitted **after** Rails has finished rendering but **before** the final response is sent, allowing browsers to begin fetching resources (JS, CSS) prior to receiving the full HTML response. This may significantly improve page load performance or cause an equally significant regression, depending on the page's content.
@@ -336,8 +338,12 @@ See the [Manual API Guide](early_hints_manual_api.md) for detailed examples and
 - **Modern browsers:**
   - Chrome/Edge/Firefox 103+ ✅
   - Safari 16.4+ ✅
+- **Infrastructure that preserves 103 responses:**
+  - Direct connections (no CDN) ✅
+  - Cloudflare with Early Hints enabled (paid plans, works via Link header caching) ✅
+  - Most CDNs/load balancers ❌ (strip 103 responses - see [CDN Limitation](#troubleshooting) above)
 
-If requirements not met, feature gracefully degrades with no errors.
+If requirements not met, feature gracefully degrades with no errors. The Link headers will still be present in the 200 response, which may provide some browser prefetching benefits even when 103 is stripped.
 
 ## Quick Reference
 
@@ -377,8 +383,9 @@ Debug mode adds HTML comments to your page showing:
 - What pack names were processed
 - What Link headers were sent
 - HTTP/2 support status
+- CDN warning reminder (since most CDNs strip 103 responses)
 
-View page source and look for `<!-- Shakapacker Early Hints Debug -->` comments.
+View page source and look for `<!-- Shakapacker Early Hints -->` comments.
 
 **Early hints not appearing:**
 

data/docs/precompile_hook.md

@@ -23,6 +23,52 @@ The precompile hook is especially useful when you need to run commands like:
 - **Development**: Runs before `bin/shakapacker --watch` or dev server starts
 - **Production**: Runs before `bundle exec rake assets:precompile`
 
+## Choosing an Approach
+
+Use `precompile_hook` when your setup should always run preparatory commands right
+before Shakapacker compiles. For React on Rails projects, this is often the
+simplest default.
+
+For projects with more custom startup needs (for example, additional build steps
+or strict process ordering in `bin/dev`), you can run those commands explicitly
+before launching long-running processes instead of using `precompile_hook`.
+
+### Comparison
+
+| Aspect | `precompile_hook` | Explicit setup in `bin/dev` |
+|--------|-------------------|-------------------------------|
+| Best for | Default/consistent pre-build tasks | Custom multi-step dev boot flows |
+| Runs when | Immediately before compilation starts | Wherever you place it in startup script |
+| Production integration | Automatic via `assets:precompile` | Requires explicit production wiring |
+| Process manager complexity | Lower | Higher (you own orchestration) |
+| Debugging | Centralized hook command | Fully explicit command-by-command flow |
+
+### `shakapacker_precompile` Interaction
+
+`shakapacker_precompile` controls whether Shakapacker compilation is included in
+`assets:precompile`, while `precompile_hook` controls whether a preparatory command
+runs before compilation.
+
+```yaml
+# Option A: Default behavior
+shakapacker_precompile: true
+precompile_hook: "bin/shakapacker-precompile-hook"
+
+# Option B: You manage compilation elsewhere
+shakapacker_precompile: false
+precompile_hook: "bin/shakapacker-precompile-hook"
+
+# Option C: Fully explicit startup flow (no hook)
+shakapacker_precompile: false
+# precompile_hook: not set
+```
+
+To temporarily skip only the hook, set:
+
+```bash
+SHAKAPACKER_SKIP_PRECOMPILE_HOOK=true
+```
+
 ## Configuration
 
 Add the `precompile_hook` option to your `config/shakapacker.yml`:

data/lib/install/template.rb

@@ -141,6 +141,9 @@ if (setup_path = Rails.root.join("bin/setup")).exist?
 end
 
 Dir.chdir(Rails.root) do
+  npm_version = Shakapacker::Utils::VersionSyntaxConverter.new.rubygem_to_npm(Shakapacker::VERSION)
+  shakapacker_dependency_value = nil
+
   # In CI, use the pre-packed tarball if available
   if ENV["SHAKAPACKER_NPM_PACKAGE"]
     package_path = ENV["SHAKAPACKER_NPM_PACKAGE"]
@@ -167,6 +170,7 @@ Dir.chdir(Rails.root) do
         say "📦 Installing shakapacker from local package: #{absolute_path}", :cyan
         begin
           @package_json.manager.add!([absolute_path], type: :production)
+          shakapacker_dependency_value = absolute_path
         rescue PackageJson::Error
           say "Shakapacker installation failed 😭 See above for details.", :red
           exit 1
@@ -174,9 +178,9 @@ Dir.chdir(Rails.root) do
       else
         say "⚠️  SHAKAPACKER_NPM_PACKAGE set but file not found: #{absolute_path}", :yellow
         say "Falling back to npm registry...", :yellow
-        npm_version = Shakapacker::Utils::VersionSyntaxConverter.new.rubygem_to_npm(Shakapacker::VERSION)
         begin
           @package_json.manager.add!(["shakapacker@#{npm_version}"], type: :production)
+          shakapacker_dependency_value = npm_version
         rescue PackageJson::Error
           say "Shakapacker installation failed 😭 See above for details.", :red
           exit 1
@@ -187,10 +191,10 @@ Dir.chdir(Rails.root) do
       exit 1
     end
   else
-    npm_version = Shakapacker::Utils::VersionSyntaxConverter.new.rubygem_to_npm(Shakapacker::VERSION)
     say "Installing shakapacker@#{npm_version}"
     begin
       @package_json.manager.add!(["shakapacker@#{npm_version}"], type: :production)
+      shakapacker_dependency_value = npm_version
     rescue PackageJson::Error
       say "Shakapacker installation failed 😭 See above for details.", :red
       exit 1
@@ -201,8 +205,8 @@ Dir.chdir(Rails.root) do
     if pj["dependencies"] && pj["dependencies"]["shakapacker"]
       {
         "dependencies" => pj["dependencies"].merge({
-          # TODO: workaround for test suite - long-run need to actually account for diff pkg manager behaviour
-          "shakapacker" => pj["dependencies"]["shakapacker"].delete_prefix("^")
+          # Keep package.json aligned with the exact source/version this installer requested.
+          "shakapacker" => shakapacker_dependency_value || pj["dependencies"]["shakapacker"].delete_prefix("^")
         })
       }
     else

data/lib/shakapacker/configuration.rb

@@ -189,7 +189,7 @@ class Shakapacker::Configuration
   # @return [Pathname, nil] the absolute private output path or nil
   def private_output_path
     private_path = fetch(:private_output_path)
-    return nil unless private_path
+    return nil if private_path.blank?
     validate_output_paths!
     root_path.join(private_path)
   end

data/lib/shakapacker/dev_server_runner.rb

@@ -310,10 +310,8 @@ module Shakapacker
         cmd += @argv
 
         Dir.chdir(@app_path) do
-          system(env, *cmd)
+          exec(env, *cmd)
         end
-
-        exit($?.exitstatus || 1) unless $?.success?
       end
 
       def build_cmd

data/lib/shakapacker/helper.rb

@@ -657,6 +657,8 @@ module Shakapacker::Helper
         end
         store[:debug_buffer] << "<!--   Note: Browsers only process the FIRST 103 response -->"
         store[:debug_buffer] << "<!--   Note: Puma only supports HTTP/1.1 Early Hints (not HTTP/2) -->"
+        store[:debug_buffer] << "<!--   CDN Warning: Most CDNs (Cloudflare, AWS CloudFront, AWS ALB) strip 103 responses. -->"
+        store[:debug_buffer] << "<!--   Link headers in the 200 response may still provide some browser hints. -->"
       end
     end
 

data/lib/shakapacker/runner.rb

@@ -279,7 +279,18 @@ module Shakapacker
       start_time = Time.now unless watch_mode
 
       Dir.chdir(@app_path) do
-        system(env, *cmd)
+        child_pid = nil
+        trap("TERM") do
+          if child_pid
+            Process.kill("TERM", child_pid)
+          else
+            raise SignalException, "TERM" # if there is no child_pid we never spawned the process and can quit as normal
+          end
+        rescue Errno::ESRCH
+          nil
+        end
+        child_pid = spawn(env, *cmd)
+        Process.wait(child_pid)
       end
 
       if !watch_mode && start_time

data/lib/shakapacker/version.rb

@@ -1,4 +1,4 @@
 module Shakapacker
   # Change the version in package.json too, please!
-  VERSION = "9.5.0".freeze
+  VERSION = "9.6.0.beta.0".freeze
 end

data/lib/shakapacker.rb

@@ -42,9 +42,12 @@ module Shakapacker
 
   # Default environment when RAILS_ENV is not set
   DEFAULT_ENV = "development".freeze
-  # Environments that use their RAILS_ENV value for NODE_ENV
+  # Environments that use "development" for NODE_ENV
   # All other environments (production, staging, etc.) use "production" for webpack optimizations
-  DEV_TEST_ENVS = %w[development test].freeze
+  # Note: Both development and test RAILS_ENV use NODE_ENV=development because
+  # webpack/rspack only recognize "development" and "production" values for NODE_ENV.
+  # Using "test" causes DefinePlugin conflicts with optimization.nodeEnv.
+  DEV_ENVS = %w[development test].freeze
 
   # Sets the shared Shakapacker instance
   #
@@ -94,15 +97,19 @@ module Shakapacker
   # Sets NODE_ENV based on RAILS_ENV if not already set
   #
   # Environment mapping:
-  # - +development+ and +test+ environments use their RAILS_ENV value for NODE_ENV
+  # - +development+ and +test+ environments use "development" for NODE_ENV
   # - All other environments (+production+, +staging+, etc.) use "production" for webpack optimizations
   #
+  # Note: We always use "development" (not "test") for test environments because
+  # webpack/rspack only recognize "development" and "production" as valid NODE_ENV values.
+  # Using "test" causes DefinePlugin conflicts with optimization.nodeEnv.
+  #
   # This method is typically called automatically during Rails initialization.
   #
   # @return [String] the NODE_ENV value that was set
   # @api private
   def ensure_node_env!
-    ENV["NODE_ENV"] ||= DEV_TEST_ENVS.include?(ENV["RAILS_ENV"]) ? ENV["RAILS_ENV"] : "production"
+    ENV["NODE_ENV"] ||= DEV_ENVS.include?(ENV["RAILS_ENV"]) ? "development" : "production"
   end
 
   # Temporarily redirects Shakapacker logging to STDOUT

data/package/config.ts

@@ -111,6 +111,10 @@ if (existsSync(configPath)) {
 
 config.outputPath = resolve(config.public_root_path, config.public_output_path)
 
+if (config.private_output_path) {
+  config.privateOutputPath = resolve(config.private_output_path)
+}
+
 // Ensure that the publicPath includes our asset host so dynamic imports
 // (code-splitting chunks and static assets) load from the CDN instead of a relative path.
 const getPublicPath = (): string => {

data/package/rules/file.ts

@@ -8,7 +8,7 @@ const {
 export = {
   test: /\.(bmp|gif|jpe?g|png|tiff|ico|avif|webp|eot|otf|ttf|woff|woff2|svg)$/,
   exclude: /\.(js|mjs|jsx|ts|tsx)$/,
-  type: "asset/resource",
+  type: "asset",
   generator: {
     filename: (pathData: { filename?: string }) => {
       // Guard against null/undefined pathData or filename

data/package/rules/sass.ts

@@ -9,6 +9,7 @@ export = canProcess("sass-loader", (resolvedPath: string) => {
     {
       loader: resolvedPath,
       options: {
+        api: "modern",
         sourceMap: true,
         sassOptions: {
           [optionKey]: extraPaths,

data/package/types.ts

@@ -30,6 +30,7 @@ export interface Config {
   useContentHash: boolean
   compile: boolean
   outputPath: string
+  privateOutputPath?: string
   publicPath: string
   publicPathWithoutCDN: string
   manifestPath: string

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "shakapacker",
-  "version": "9.5.0",
+  "version": "9.6.0-beta.0",
   "description": "Use webpack to manage app-like JavaScript modules in Rails",
   "homepage": "https://github.com/shakacode/shakapacker",
   "bugs": {

data/test/package/config.test.js

@@ -55,6 +55,17 @@ describe("Config", () => {
     )
   })
 
+  test("should return privateOutputPath as absolute path", () => {
+    const config = require("../../package/config")
+    expect(config.privateOutputPath).toStrictEqual(resolve("ssr-generated"))
+  })
+
+  test("should not set privateOutputPath when not configured", () => {
+    process.env.SHAKAPACKER_CONFIG = "config/shakapacker_manifest_path.yml"
+    const config = require("../../package/config")
+    expect(config.privateOutputPath).toBeUndefined()
+  })
+
   test("should have integrity disabled by default", () => {
     const config = require("../../package/config")
     expect(config.integrity.enabled).toBe(false)

data/test/package/rules/file.test.js

@@ -35,6 +35,10 @@ describe("file", () => {
     types.forEach((type) => expect(file.exclude.test(type)).toBe(true))
   })
 
+  test("uses webpack asset module type by default", () => {
+    expect(file.type).toBe("asset")
+  })
+
   test("correct generated output path is returned for top level files", () => {
     const pathData = {
       filename: "app/javascript/image.svg"

data/test/package/rules/sass1.test.js

@@ -19,4 +19,8 @@ describe("sass rule", () => {
     )
     expect(typeof sass.use[2].options.sassOptions.loadPaths).toBe("object")
   })
+
+  test("uses modern API for better compatibility with sass plugins", () => {
+    expect(sass.use[2].options.api).toBe("modern")
+  })
 })

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shakapacker
 version: !ruby/object:Gem::Version
-  version: 9.5.0
+  version: 9.6.0.beta.0
 platform: ruby
 authors:
 - David Heinemeier Hansson
@@ -181,6 +181,7 @@ files:
 - TODO_v9.md
 - __mocks__/nonexistent/package.json
 - __mocks__/sass-loader/package.json
+- bin/conductor-exec
 - bin/shakapacker-config
 - conductor-setup.sh
 - conductor.json
@@ -415,7 +416,7 @@ homepage: https://github.com/shakacode/shakapacker
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/shakacode/shakapacker/tree/v9.5.0
+  source_code_uri: https://github.com/shakacode/shakapacker/tree/v9.6.0.beta.0
 rdoc_options: []
 require_paths:
 - lib