shakapacker 10.3.0 → 10.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9066233e8c71edd7018db4b397e132013a8dcde79a111acbd6f3a79617fa9367
-  data.tar.gz: 1e7d899486f7bf0c43cebb923ba4a013bd5bdb7e4348193662872a5b77278208
+  metadata.gz: 66455bdf084a5e63422cf5741b2ce549b2dc77dcd36553e8e5fa7dcc6ce34286
+  data.tar.gz: a7030178f8ec26e3c1243fbdeb806c2746d6b14484bc99142a35f3fa3f57e9dd
 SHA512:
-  metadata.gz: 6becce7cfd7598aeb8b6cb734882e0dbd6668125e61c711608d81e242724c8b27d613efdf5cecff77e737ca46d8f8c5c727938c5bbb13551f3394f7149d495a0
-  data.tar.gz: f56d65242942ce8ce7b372af52b28a7a62dd6ce47c7fce5b4268bd638d22691276166796620179682b0b61ad2cc4028d951219d208652f84a99cb60bf0d8757a
+  metadata.gz: ec0476cbbaaa7044f9f06a3fe207caad61350c309164deffa47d5990e583b025c03e235b4e0e110adac394461fce264b887a71de6159a43ce5664e7a8a133992
+  data.tar.gz: 3d625e63b6f838c9febaaad2dda13d43cd7486748d7e39d6ff09e5675d06ab8b85414b9d323c41a3b09fca5adb19ec193b6d90d5651dce92f8573cd18e23937f

data/CHANGELOG.md

@@ -10,6 +10,20 @@
 
 ## [Unreleased]
 
+## [v10.3.1] - August 3, 2026
+
+### Fixed
+
+- **Fixed 502 responses for proxied dev server assets under `rack-proxy` v1.** [PR #1222](https://github.com/shakacode/shakapacker/pull/1222) by [jcbpl](https://github.com/jcbpl). Fixes [#1220](https://github.com/shakacode/shakapacker/issues/1220).
+- **Fixed dev-server liveness checks treating refused macOS 27 connections as running.** The Ruby probe now verifies the connected socket's `SO_ERROR` result before proxying asset requests, avoiding false-positive dev-server detection and resulting 502 responses. [PR #1225](https://github.com/shakacode/shakapacker/pull/1225) by [justin808](https://github.com/justin808). Fixes [#1224](https://github.com/shakacode/shakapacker/issues/1224).
+- **Fixed webpack Babel, SWC, and esbuild rules skipping explicitly included `.cjs` files.** [PR #1219](https://github.com/shakacode/shakapacker/pull/1219) by [oiahoon](https://github.com/oiahoon). Fixes [#1218](https://github.com/shakacode/shakapacker/issues/1218).
+- **Added a `shakapacker:doctor` warning for Rspack React Refresh v2 configs that still use the v1 default-export constructor pattern.** [PR #1207](https://github.com/shakacode/shakapacker/pull/1207) by [justin808](https://github.com/justin808). Existing configs with `const ReactRefreshPlugin = require("@rspack/plugin-react-refresh")` followed by `new ReactRefreshPlugin()` can fail after upgrading to `@rspack/plugin-react-refresh` v2 with `ReactRefreshPlugin is not a constructor`; Doctor now points to the affected JS/TS config file and suggests the named-export/default/module compatibility form. Fixes [#1204](https://github.com/shakacode/shakapacker/issues/1204).
+- **Fixed the missing-`@babel/core` failure to report an actionable install message.** [PR #1212](https://github.com/shakacode/shakapacker/pull/1212) by [justin808](https://github.com/justin808). Babel-transpiled builds whose app lacks `@babel/core` previously surfaced a raw module-resolution error from the Babel 8 compatibility check; the rule now explains which package to install and how to switch `javascript_transpiler` instead. Refs [#1163](https://github.com/shakacode/shakapacker/issues/1163).
+
+### Documentation
+
+- **Documented the required `css-loader@^7.1.4` in the v10 Rspack upgrade instructions.** [PR #1211](https://github.com/shakacode/shakapacker/pull/1211) by [justin808](https://github.com/justin808). The v10 upgrade guide's copy-paste Rspack v2 commands omitted `css-loader`, so apps following them could upgrade into an unsatisfied peer dependency.
+
 ## [v10.3.0] - July 5, 2026
 
 ### Added
@@ -986,7 +1000,8 @@ Note: [Rubygem is 6.3.0.pre.rc.1](https://rubygems.org/gems/shakapacker/versions
 
 See [CHANGELOG.md in rails/webpacker (up to v5.4.3)](https://github.com/rails/webpacker/blob/master/CHANGELOG.md)
 
-[Unreleased]: https://github.com/shakacode/shakapacker/compare/v10.3.0...main
+[Unreleased]: https://github.com/shakacode/shakapacker/compare/v10.3.1...main
+[v10.3.1]: https://github.com/shakacode/shakapacker/compare/v10.3.0...v10.3.1
 [v10.3.0]: https://github.com/shakacode/shakapacker/compare/v10.2.0...v10.3.0
 [v10.2.0]: https://github.com/shakacode/shakapacker/compare/v10.1.0...v10.2.0
 [v10.1.0]: https://github.com/shakacode/shakapacker/compare/v10.0.0...v10.1.0

data/lib/shakapacker/dev_server.rb

@@ -47,8 +47,13 @@ class Shakapacker::DevServer
   # @return [Boolean] true if the dev server is running
   def running?
     if config.dev_server.present?
-      Socket.tcp(host, port, connect_timeout: connect_timeout).close
-      true
+      socket = Socket.tcp(host, port, connect_timeout: connect_timeout)
+
+      begin
+        socket.getsockopt(Socket::SOL_SOCKET, Socket::SO_ERROR).int.zero?
+      ensure
+        socket.close
+      end
     else
       false
     end

data/lib/shakapacker/dev_server_proxy.rb

@@ -11,6 +11,10 @@ class Shakapacker::DevServerProxy < Rack::Proxy
 
   def perform_request(env)
     if env["PATH_INFO"].start_with?("/#{public_output_uri_path}") && dev_server.running?
+      # rack-proxy v1 refuses to derive the backend from the Host header.
+      env["rack.backend"] = URI::Generic.build(
+        scheme: dev_server.protocol, host: dev_server.host, port: dev_server.port
+      )
       env["HTTP_HOST"] = env["HTTP_X_FORWARDED_HOST"] = dev_server.host
       env["HTTP_X_FORWARDED_SERVER"] = dev_server.host_with_port
       env["HTTP_PORT"] = env["HTTP_X_FORWARDED_PORT"] = dev_server.port.to_s

data/lib/shakapacker/doctor.rb

@@ -59,6 +59,9 @@ module Shakapacker
       "@rspack/plugin-react-refresh" => "^2.0.0"
     }.freeze
 
+    RSPACK_REACT_REFRESH_PACKAGE = "@rspack/plugin-react-refresh".freeze
+    VERSION_UPPER_BOUND_OPERATORS = %w[< <=].freeze
+
     CUSTOM_HYBRID_LOADER_DEPS = %w[
       babel-loader
       esbuild-loader
@@ -170,6 +173,7 @@ module Shakapacker
         check_css_modules_configuration
         check_bundler_dependencies if config_exists?
         check_rspack_cache_configuration if config_exists?
+        check_rspack_react_refresh_plugin_constructor if config_exists?
         check_file_type_dependencies if config_exists?
         check_sri_dependencies if config_exists?
         check_peer_dependencies
@@ -878,14 +882,89 @@ module Shakapacker
                      "See https://rspack.rs/config/cache for options.")
       end
 
+      def check_rspack_react_refresh_plugin_constructor
+        return unless rspack_react_refresh_check_applicable?
+        return unless rspack_react_refresh_plugin_v2_or_newer?
+
+        rspack_react_refresh_config_paths.each do |path|
+          content = File.read(path)
+          next unless legacy_rspack_react_refresh_constructor?(content)
+
+          relative = config_path_for_warning(path)
+          add_action_required("Rspack React Refresh config #{relative} uses the " \
+                              "#{RSPACK_REACT_REFRESH_PACKAGE} v1 default-export constructor pattern. " \
+                              "With #{RSPACK_REACT_REFRESH_PACKAGE} v2, rspack may fail with " \
+                              "'ReactRefreshPlugin is not a constructor'.")
+          add_fix_hint("Use a compat constructor: const ReactRefresh = require(\"#{RSPACK_REACT_REFRESH_PACKAGE}\"); " \
+                       "const ReactRefreshRspackPlugin = ReactRefresh.ReactRefreshRspackPlugin || " \
+                       "ReactRefresh.default || ReactRefresh; then call new ReactRefreshRspackPlugin().")
+        rescue SystemCallError => e
+          add_info_warning("Unable to validate Rspack React Refresh config #{config_path_for_warning(path)}: #{e.message}")
+        end
+      end
+
+      def rspack_react_refresh_check_applicable?
+        assets_bundler == "rspack" || unconfigured_hybrid_loader_graph?
+      end
+
+      def rspack_react_refresh_plugin_v2_or_newer?
+        version = installed_package_version(RSPACK_REACT_REFRESH_PACKAGE)
+        return version >= Gem::Version.new("2.0.0") if version
+
+        package_specifier_allows_version_or_newer?(
+          package_json_dependency_version(RSPACK_REACT_REFRESH_PACKAGE),
+          Gem::Version.new("2.0.0")
+        )
+      end
+
+      def rspack_react_refresh_config_paths
+        config_dir = rspack_react_refresh_config_dir
+        config_dir_path = Pathname.new(File.join(root_path.to_s, config_dir))
+        return [] unless config_dir_path.directory?
+
+        path = active_bundler_config_path_in(config_dir)
+        path ? [path] : []
+      end
+
+      def rspack_react_refresh_config_dir
+        config_dir = config.assets_bundler_config_path.to_s
+
+        if assets_bundler == "rspack" || same_directory_hybrid_config_present?(config_dir)
+          config_dir
+        else
+          "config/rspack"
+        end
+      end
+
+      def legacy_rspack_react_refresh_constructor?(content)
+        stripped = strip_rspack_config_comments_and_literals(content, preserve_literals: [RSPACK_REACT_REFRESH_PACKAGE])
+        constructor_names = []
+
+        constructor_names.concat(stripped.scan(
+          /\b(?:const|let|var)\s+([A-Za-z_$][\w$]*)\s*=\s*require\(\s*["']#{Regexp.escape(RSPACK_REACT_REFRESH_PACKAGE)}["']\s*\)(?=\s*(?:[;,\)]|$))/
+        ).flatten)
+        constructor_names.concat(stripped.scan(
+          /\bimport\s+([A-Za-z_$][\w$]*)\s*(?:,\s*\{[^}]*\}\s*)?\s+from\s*["']#{Regexp.escape(RSPACK_REACT_REFRESH_PACKAGE)}["']/
+        ).flatten)
+        constructor_names.concat(stripped.scan(
+          /\bimport\s+\*\s+as\s+([A-Za-z_$][\w$]*)\s+from\s*["']#{Regexp.escape(RSPACK_REACT_REFRESH_PACKAGE)}["']/
+        ).flatten)
+
+        constructor_names.uniq.any? do |constructor_name|
+          stripped.match?(/\bnew\s+#{Regexp.escape(constructor_name)}\s*\(/)
+        end
+      end
+
       # Returns the single active config path the runner would load, or nil. Mirrors the
       # resolution order in Shakapacker::Runner#find_rspack_config_with_fallback so the
       # doctor inspects the same file the build will actually use (and so unused sibling
       # configs in the same directory don't trigger spurious warnings).
       # NOTE: keep this candidate list in sync with Runner#find_rspack_config_with_fallback.
       def active_assets_bundler_config_path
-        config_dir = config.assets_bundler_config_path.to_s
+        active_bundler_config_path_in(config.assets_bundler_config_path.to_s)
+      end
 
+      def active_bundler_config_path_in(config_dir)
         candidates = %w[ts js].map { |ext| Pathname.new(File.join(root_path.to_s, config_dir, "rspack.config.#{ext}")) }
         candidates += %w[ts js].map { |ext| Pathname.new(File.join(root_path.to_s, config_dir, "webpack.config.#{ext}")) }
         if default_rspack_config_dir?(config_dir)
@@ -944,7 +1023,7 @@ module Shakapacker
         stripped.gsub(%r{/(?:\\.|\[[^\]\n]*\]|[^/\n\\\[])+?/[gimsuy]*}, "")
       end
 
-      def strip_rspack_config_comments_and_literals(content)
+      def strip_rspack_config_comments_and_literals(content, preserve_literals: [])
         stripped = +""
         index = 0
 
@@ -987,8 +1066,12 @@ module Shakapacker
             end
 
             literal = content[index...literal_end]
-            stripped << '""'
-            stripped << literal.gsub(/[^\n]/, "")
+            if preserved_js_string_literal?(literal, char, preserve_literals)
+              stripped << literal
+            else
+              stripped << '""'
+              stripped << literal.gsub(/[^\n]/, "")
+            end
             index = literal_end
           elsif char == "`"
             literal_end = index + 1
@@ -1029,6 +1112,12 @@ module Shakapacker
         stripped
       end
 
+      def preserved_js_string_literal?(literal, quote, preserve_literals)
+        return false unless literal.end_with?(quote)
+
+        preserve_literals.include?(literal[1...-1])
+      end
+
       def direct_export_cache_disabled?(stripped)
         # Match `cache: false` only near an exported config object at brace depth
         # 1. This avoids warning on local base config objects while still
@@ -1183,8 +1272,9 @@ module Shakapacker
           return versions.min
         end
 
+        return package_version_from_range_specifier(cleaned) if cleaned.match?(/[<>=]/)
         return nil unless cleaned.match?(/\A[\^~]?\d/)
-        return nil if cleaned.match?(/(\s|\|\||[<>=:]|\A(?:git|file|link|workspace|npm):)/)
+        return nil if cleaned.match?(/(\s|\|\||:|\A(?:git|file|link|workspace|npm):)/)
 
         match = cleaned.sub(/\A[\^~]/, "").match(/\A(\d+(?:\.\d+){0,2})(?:-[0-9A-Za-z.-]+)?\z/)
         match && Gem::Version.new(match[1])
@@ -1192,6 +1282,48 @@ module Shakapacker
         nil
       end
 
+      def package_version_from_range_specifier(specifier)
+        lower_bounds = specifier.scan(/(?:\A|\s)(?:>=|>)\s*(\d+(?:\.\d+){0,2})(?:-[0-9A-Za-z.-]+)?/)
+        versions = lower_bounds.flatten.map { |version| Gem::Version.new(version) }
+
+        versions.max
+      rescue ArgumentError
+        nil
+      end
+
+      def package_specifier_allows_version_or_newer?(specifier, minimum)
+        return false unless specifier
+
+        cleaned = specifier.strip
+        if cleaned.include?("||")
+          return cleaned.split("||").any? { |part| package_specifier_allows_version_or_newer?(part, minimum) }
+        end
+        return false if cleaned.match?(/(:|\A(?:git|file|link|workspace|npm):)/)
+
+        if cleaned.match?(/[<>=]/)
+          return package_range_specifier_allows_version_or_newer?(cleaned, minimum)
+        end
+
+        version = package_version_from_specifier(cleaned)
+        version && version >= minimum
+      end
+
+      def package_range_specifier_allows_version_or_newer?(specifier, minimum)
+        comparators = specifier.scan(/(?:\A|\s)(<=|<|>=|>|=)\s*(\d+(?:\.\d+){0,2})(?:-[0-9A-Za-z.-]+)?/)
+        return false if comparators.empty?
+
+        equalities = comparators.select { |operator, _version| operator == "=" }
+        return equalities.any? { |_operator, version| Gem::Version.new(version) >= minimum } if equalities.any?
+
+        upper_bounds = comparators.select { |operator, _version| VERSION_UPPER_BOUND_OPERATORS.include?(operator) }
+        upper_bounds.all? do |operator, version|
+          parsed = Gem::Version.new(version)
+          operator == "<" ? parsed > minimum : parsed >= minimum
+        end
+      rescue ArgumentError
+        false
+      end
+
       def declared_package_dependencies
         @declared_package_dependencies ||= begin
           package_json_paths.reverse_each.each_with_object({}) do |path, dependencies|

data/lib/shakapacker/version.rb

@@ -1,4 +1,4 @@
 module Shakapacker
   # Change the version in package.json too, please!
-  VERSION = "10.3.0".freeze
+  VERSION = "10.3.1".freeze
 end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "shakapacker",
-  "version": "10.3.0",
+  "version": "10.3.1",
   "description": "Use webpack to manage app-like JavaScript modules in Rails",
   "homepage": "https://github.com/shakacode/shakapacker",
   "bugs": {

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: shakapacker
 version: !ruby/object:Gem::Version
-  version: 10.3.0
+  version: 10.3.1
 platform: ruby
 authors:
 - David Heinemeier Hansson
@@ -225,7 +225,7 @@ homepage: https://github.com/shakacode/shakapacker
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/shakacode/shakapacker/tree/v10.3.0
+  source_code_uri: https://github.com/shakacode/shakapacker/tree/v10.3.1
 rdoc_options: []
 require_paths:
 - lib