sfax 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5fdaa7dc60428262e6a5e7329b1472404011e5ac
-  data.tar.gz: 15ff36354f2180a0a85179f22ec134a30f093378
+  metadata.gz: eec66efe4f81cba14622f07b75517a1749ddc56b
+  data.tar.gz: e30e25d9bb3c84e7664f559bac45b43bf5c9d9c8
 SHA512:
-  metadata.gz: 2fa0aad3bfb66aed503049d66802e23133fbd21231fe18b64069d414254061caa223eca4be737a806b5c9d81c3225782e931ae26f86062c423e434d253cd3692
-  data.tar.gz: d0d558856c8f2a9dcb4b6fd4973fcacf9b8c280f760c6115ec787df6e5f8cd3c8f85e5b1645f55f14519fd3cb6aefeae301eae9bdf9767040ed2189c17d1bad7
+  metadata.gz: 6a5a9b9a5bee104c31ac823225c2044ea1f1da22eda4c68e2d89a08aa50c13f1d7d6dd9e5227f38aab941d92f68f974d94b833e93e12041f5e2ea4a5b0cff830
+  data.tar.gz: 79c2b10cf033095caed2908e6838880bf8082b6c7328b0fb40e50685910e32ce5a2bc24e4cde2047c8270a696ed3098eb5ae4d763ab63a391f5b9eb70f51c312

data/lib/sfax.rb

@@ -1,3 +1,4 @@
+require 'sfax/errors'
 require 'sfax/client'
 require 'sfax/encryptor'
 require 'sfax/version'

data/lib/sfax/client.rb

@@ -7,6 +7,7 @@ require 'json'
 module SFax
   class Client
     include Constants
+    include Errors
 
     def initialize(username:, api_key:, encryption_key:)
       @username = username
@@ -44,8 +45,8 @@ module SFax
       end
 
       response_object.tap do |o|
-        raise SendFaxError, o.message unless o.success?
-        raise SendFaxError, o.message if o.fax_id.to_s == SEND_FAX_QUEUE_ID_ERROR_VALUE
+        raise SendFaxError.new(message: o.message, response: o) unless o.success?
+        raise SendFaxError.new(message: o.message, response: o) if o.fax_id.to_s == SEND_FAX_QUEUE_ID_ERROR_VALUE
       end
     end
 
@@ -74,8 +75,5 @@ module SFax
         raise InvalidFaxNumberError, "Expected an 11 digit fax number. Got: #{number}"
       end
     end
-
-    InvalidFaxNumberError = Class.new(StandardError)
-    SendFaxError = Class.new(StandardError)
   end
 end

data/lib/sfax/errors.rb

@@ -0,0 +1,16 @@
+
+module SFax
+  module Errors
+    class SendFaxError < StandardError
+      attr_reader :response
+      DEFAULT_MESSAGE = 'An error occurred while submitting the fax for sending.'.freeze
+
+      def initialize(message: DEFAULT_MESSAGE, response: nil)
+        @response = response
+        super(message)
+      end
+    end
+
+    InvalidFaxNumberError = Class.new(StandardError)
+  end
+end

data/lib/sfax/version.rb

@@ -1,3 +1,3 @@
 module SFax
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

data/spec/sfax/errors_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+RSpec.describe SFax::Errors do
+  let(:message) { SecureRandom.hex }
+  let(:response) do
+    {
+      'isSuccess' => false,
+    }
+  end
+
+  describe 'SendFaxError' do
+    specify do
+      error = described_class::SendFaxError.new
+
+      expect(error.message).to eq('An error occurred while submitting the fax for sending.')
+      expect(error.response).to eq(nil)
+    end
+
+    specify do
+      error = described_class::SendFaxError.new(message: message)
+
+      expect(error.message).to eq(message)
+      expect(error.response).to eq(nil)
+    end
+
+    specify do
+      error = described_class::SendFaxError.new(message: message, response: response)
+
+      expect(error.message).to eq(message)
+      expect(error.response).to eq(response)
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sfax
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Derek Schneider
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-19 00:00:00.000000000 Z
+date: 2017-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -97,8 +97,10 @@ files:
 - lib/sfax/client.rb
 - lib/sfax/constants.rb
 - lib/sfax/encryptor.rb
+- lib/sfax/errors.rb
 - lib/sfax/version.rb
 - sfax.gemspec
+- spec/sfax/errors_spec.rb
 - spec/sfax_client_spec.rb
 - spec/sfax_encryptor_spec.rb
 - spec/sfax_spec.rb
@@ -128,6 +130,7 @@ signing_key:
 specification_version: 4
 summary: Ruby client for SFax API
 test_files:
+- spec/sfax/errors_spec.rb
 - spec/sfax_client_spec.rb
 - spec/sfax_encryptor_spec.rb
 - spec/sfax_spec.rb