sewing_kit 0.95.3 → 0.95.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5326345174261f199f09dd225bff39a8bff36211605f02e50023cb42599cbbf0
-  data.tar.gz: 4ce1b74f45294fbe3b3a78756e032ed5663ee8de7349a1ab3664fd7a0d7fd01c
+  metadata.gz: 8847792f430ca9ff0b5d9e2da35b701392636af48ac0435f9e82f816e4d9b385
+  data.tar.gz: cb61d56de21e9ae5e4c937313d2acfc213e10790cb8139c5b3e432ec76759f25
 SHA512:
-  metadata.gz: 46b6f646a80548019b2504bcded4bfa5a2c9341dc712c2a34d2f5d574fbd52c1520c7868c72aabf1e6e148381b40e6fce96d1df43154073f5b996cb453a28568
-  data.tar.gz: b84efa8493dc8d172087001a3058bef87be22fa2a74f0be1a60327495f7a54fd18cffe8f388ba044c67a138d68e410071faba1aa7e0cb129f61330ed9e0a2474
+  metadata.gz: f956eb534703a3b6f1bc57013be323209fec34ff1d34377757067cf42b6364ed399b88e37fa8db81401cc63909c80efebf68077e08cfdfdd7c1c93745d648f3a
+  data.tar.gz: 7dd03739b8f4677e9e5e55834af4481027a4b23a85413bfbdb9d46f7122455956e04a95290ba71378aa056e253c5ee29f19b8f1ed11c178b9c2c0c49e33db6b4

data/lib/sewing_kit/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module SewingKit
-  VERSION = "0.95.3"
+  VERSION = "0.95.4"
 end

data/lib/sewing_kit/webpack/manifest/production.rb

@@ -43,14 +43,28 @@ module SewingKit
         def find_matching_metadata(consolidated_metadata, user_agent)
           return metadata unless metadata.is_a?(Array)
 
-          found = consolidated_metadata.find do |metadata|
-            return nil if metadata["resolvedBrowsers"].nil?
-            matcher = BrowserslistUseragent::Match.new(metadata["resolvedBrowsers"], user_agent)
-
-            matcher.browser? && matcher.version?(allow_higher: true)
+          found = consolidated_metadata.find do |metadata_item|
+            metadata_matches?(metadata_item, user_agent)
           end
 
-          found || consolidated_metadata.last
+          found || baseline(consolidated_metadata)
+        end
+
+        def metadata_matches?(metadata_item, user_agent)
+          return false if metadata_item["resolvedBrowsers"].nil?
+
+          matcher = BrowserslistUseragent::Match.new(metadata_item["resolvedBrowsers"], user_agent)
+          matcher.browser? && matcher.version?(allow_higher: true)
+        rescue ArgumentError
+          # Some user_agent strings have bad semver versions.
+          # In these cases the Semver gem ends up throwing an ArgumentError when we parse the user_agent.
+          # Since we cannot know what kind of browser the user has when parsing fails,
+          # the safest option is to just return false here and let the defaulting logic send the baseline manifest.
+          false
+        end
+
+        def baseline(consolidated_metadata)
+          consolidated_metadata.last
         end
 
         def load_metadata

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sewing_kit
 version: !ruby/object:Gem::Version
-  version: 0.95.3
+  version: 0.95.4
 platform: ruby
 authors:
 - Chris Sauve
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-07 00:00:00.000000000 Z
+date: 2019-10-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties