sewing_kit 0.95.2 → 0.95.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 759d3abb34bbf6410d9c9169709715d7945d49381402482bdeeb509261051ad5
-  data.tar.gz: 056e13651007ff24eaf011c94b4c957fe614830342a3640f7f53df21e6598d17
+  metadata.gz: 5326345174261f199f09dd225bff39a8bff36211605f02e50023cb42599cbbf0
+  data.tar.gz: 4ce1b74f45294fbe3b3a78756e032ed5663ee8de7349a1ab3664fd7a0d7fd01c
 SHA512:
-  metadata.gz: c0010f8cf7cca5ebd41b6df31168c26f646919b861669e48c288ea649d2f442ca4408da3d76791e558cf81d556f516ecf0f949d04f22b1acf49e8422d83ab49d
-  data.tar.gz: 97caa8ba30633c96ee91b1931c412623a0187dc92f94821dd8cef9f52b33213963d5d222e6dda07bb51ab30953696f7079a3ad47426f19c997cd76ef071c9a84
+  metadata.gz: 46b6f646a80548019b2504bcded4bfa5a2c9341dc712c2a34d2f5d574fbd52c1520c7868c72aabf1e6e148381b40e6fce96d1df43154073f5b996cb453a28568
+  data.tar.gz: b84efa8493dc8d172087001a3058bef87be22fa2a74f0be1a60327495f7a54fd18cffe8f388ba044c67a138d68e410071faba1aa7e0cb129f61330ed9e0a2474

data/README.md

@@ -4,6 +4,12 @@ Zero configuration, high performance front end development at organization scale
 
 `sewing_kit` facilitates legacy Rails integration using ERB tags. For a more complete modern stack with performance-as-a-feature, consider [quilt_rails](https://github.com/Shopify/quilt/tree/master/gems/quilt_rails). For details of the `sewing-kit` node package's configuration and usage, see the [sewing-kit README](/README.md).
 
+## Use `quilt_rails` for React Server-Side-Rendering
+
+For React applications with a Rails backend, the best-practice for user-experience is server-side-rendering (SSR). **For building out React applications using SSR and Sewing-Kit, see [`quilt_rails`](https://github.com/Shopify/quilt/tree/master/gems/quilt_rails)**.
+
+If you are building a conventional Rails application using `.erb` files and just want modern JavaScript / TypeScript compilation, continue reading this document.
+
 ## Quick Start
 
 Create a Rails project using `dev init` then:
@@ -15,9 +21,6 @@ Create a Rails project using `dev init` then:
 bundle add sewing_kit
 yarn add @shopify/sewing-kit
 
-# Optional - add Polaris
-yarn add @shopify/polaris react react-dom
-
 yarn
 dev up
 ```
@@ -51,133 +54,17 @@ The `main` bundle is imported into `erb` files using Rails helpers:
            └─- application.html.erb (must link to JS / CSS using sewing_kit_script_tag / sewing_kit_link_tag
 ```
 
-## Rails, Polaris, and React Layout
-
-A typical Polaris app will use React to render views and components. The following layout shows best practice locations for:
-
-- Global SCSS settings
-- App sections (roughly analogous to Rails routes)
-- Components
-- Co-located CSS modules
-- Co-located unit tests
-
-```
-└── app
-    └── ui
-        ├─- index.js (renders React into the DOM)
-        ├── styles (optional)
-        │   └── settings.scss (global vars and @polaris overrides)
-        │
-        └── tests (optional)
-        │   └── each-test.ts
-        │   └── setup.ts
-        └── components (optional)
-            ├── App
-            │   ├── index.js
-            │   ├── App.js
-            │   └── tests
-            │       └── App.test.js
-            │
-            ├-─ MyComponent
-            │   ├-─ index.js
-            │   ├-─ MyComponent.js
-            │   ├── MyComponent.scss (optional; component-scoped CSS styles, mixins, etc)
-            │   └── tests
-            │       └── MyComponent.test.js
-            │
-            └── sections (optional; container views that compose presentation components into UI blocks)
-                └── Home
-                    ├-─ index.js
-                    └── Home.js
-```
-
-## React Boilerplate
-
-- Create a React app in `app/ui/App.js` ([example](https://github.com/Shopify/sewing-kit-gem-example/blob/master/app/ui/App.jsx))
-- In an `erb` view, add a placeholder for React content ([example](https://github.com/Shopify/sewing-kit-gem-example/blob/master/app/views/home/index.html.erb#L4))
-- In `index.js`, render a React component into the placeholder element ([example](https://github.com/Shopify/sewing-kit-gem-example/blob/master/app/ui/index.js))
-- Use `sewing_kit_script_tag`/`sewing_kit_link_tag` helpers to link erb/js ([example](https://github.com/Shopify/sewing-kit-gem-example/blob/master/app/views/layouts/application.html.erb#L8))
-
 ## Testing the front end
 
 For fast tests with consistent results, test front-end components using Jest instead of Rails integration tests.
 
 Use [`sewing-kit test`](https://github.com/Shopify/sewing-kit/blob/master/docs/commands/test.md#L3) to run all `.test.tsx` files in the `app/ui` directory. [Jest](https://jestjs.io) is used as a test runner, with customization available via [its sewing-kit plugin](https://github.com/Shopify/sewing-kit/blob/master/docs/plugins/jest.md).
 
-### Testing React
-
-For testing React applications we provide and support [`@shopify/react-testing`](https://github.com/Shopify/quilt/tree/master/packages/react-testing).
-
-#### Example
-
-Given a component `MyComponent.tsx`
+### Customizing the test environment
 
-```tsx
-// app/components/MyComponent/MyComponent.tsx
-export function MyComponent({name}: {name: string}) {
-  return <div>Hello, {name}!</div>;
-}
-```
-
-A test would be written using Jest and `@shopify/react-testing`'s `mount` feature.
-
-```tsx
-// app/components/MyComponent/tests/MyComponent.test.tsx
-import {MyComponent} from '../MyComponent';
+Often you will want to hook up custom polyfills, global mocks, or other logic that needs to run either before the initialization of the test environment, or once for each test suite.
 
-describe('MyComponent', () => {
-  it('greets the given named person', () => {
-    const wrapper = mount(<MyComponent name="Kokusho" />);
-
-    // toContainReactText is a custom matcher provided by @shopify/react-testing/matchers
-    expect(wrapper).toContainReactText('Hello, Kokusho');
-  });
-});
-```
-
-### Test setup files
-
-By default, the jest plugin will look for test setup files under `/app/ui/tests`.
-
-`setup` can be used to add any custom polyfills needed for the testing environment.
-
-```tsx
-// app/ui/tests/setup.ts
-
-import 'isomorphic-fetch';
-import 'raf/polyfill';
-import {URL, URLSearchParams} from 'url';
-
-(global as any).URL = URL;
-(global as any).URLSearchParams = URLSearchParams;
-```
-
-`each-test` can be used for any logic that needs to run for each individual test suite. Any setup logic that needs to happen with `jest` globals in scope, such as importing custom matchers, should also be done here.
-
-```tsx
-// app/ui/tests/each-test.ts
-
-// we cannot import these in `setup` because `expect` will not be defined
-import '@shopify/react-testing/matchers';
-
-beforeAll(() => {
-  console.log('I will run before every test suite');
-});
-
-beforeEach(() => {
-  console.log('I will run before every test case');
-});
-
-afterEach(() => {
-  console.log('I will run after every test case');
-});
-
-afterAll(() => {
-  console.log('I will run after every test suite');
-});
-```
-
-For more complete documentation of the jest plugin see [it's documentation](/docs/plugins/jest.md).
+By default, sewing-kit will look for such test setup files under `/app/ui/tests`. Check out the [documentation](https://github.com/Shopify/sewing-kit/blob/master/docs/plugins/jest.md#smart-defaults) for more details.
 
 ### Rails tests
 
@@ -254,11 +141,3 @@ SewingKit.configure do |config|
  config.log_level = :warn # may be `:inherit`, `:debug`, `:info`, `:warn`, or `:error`
 end
 ```
-
-### How can I set breakpoints for server rendered apps?
-
-Start your Rails server with `SK_DEBUG` set as an environment variable, and configure your Node debugger to listen on port `5858`.
-
-```bash
-SK_DEBUG=1 bundle exec rails start
-```

data/lib/sewing_kit/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module SewingKit
-  VERSION = "0.95.2"
+  VERSION = "0.95.3"
 end

data/lib/sewing_kit/webpack/manifest/test_with_no_assets.rb

@@ -10,7 +10,7 @@ module SewingKit
         end
 
         def asset_dependencies(_entrypoint_name, _user_agent)
-          []
+          {}
         end
 
         def manifest

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sewing_kit
 version: !ruby/object:Gem::Version
-  version: 0.95.2
+  version: 0.95.3
 platform: ruby
 authors:
 - Chris Sauve
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-17 00:00:00.000000000 Z
+date: 2019-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties