sewing_kit 0.94.0 → 0.95.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e3b2b21c04f2ce3043bc5ff0c27dc61b301ab3585e4f84347d1edfeef0f92121
-  data.tar.gz: d378424249b09da4747a81281d2ba3f703790f23ac8fa2732e0a39ef655224a7
+  metadata.gz: 6b602141d9384dbe196746242130707db37ed8cc877f50b36364b3c8e15a018f
+  data.tar.gz: b9669c5e2666ae28ae2f3ad6228cff9b6e969e73da05855224ba8acc837cf437
 SHA512:
-  metadata.gz: f5beb6976e7812ebef7adc31040a1c5c08178af88118d3952d7aaaea5c740172a6e381b89cf1a388c1ed7e4e6d026e21effdc321e196587613fc0a56233b7be3
-  data.tar.gz: 2b2a62b6e61004d24571e4b5b14319100e5bfc3a60c392a2fcec30912e1e71c4ca3e2142de49d25d14d64d438384e2d3c51385ad7b413d0a5f60a898b195d852
+  metadata.gz: e05bd301abc39d37c44b660cc56d35874de2a4d527012e872a6bf76f46b88079d8e683a8dd983ea3eadd267a3a7f054f4ad65685f823dac5784d2f655e39672c
+  data.tar.gz: 53129c412805f4a5cc602566d0add516693a1e5f723045def7826498884dbaa314f8338b9ae887ae095b6b3182586c117a68af68d3c1f8d4214e3cc573399e9a

data/README.md

@@ -235,6 +235,24 @@ NODE_ENV=production SK_SIMULATE_PRODUCTION=1 dev run
 
 Note that code changes will not be automatically recompiled in this state. After verifying production behaviour, run `bundle exec rake assets:clobber` to get back to development mode.
 
-### My project is using `sprockets-commenoner`, can I use sewing_kit too?
+### My project is using `sprockets-commoner`, can I use sewing_kit too?
 
 No. sprockets-commoner uses an outdated Babel version, and is no longer compatible with sewing-kit.
+
+## sewing-kit's logs are too noisy. How can I see less of them?
+
+sewing-kit defaults to using the same `log_level` as Rails' built in logger. It can be customized this using a configuration block:
+
+```ruby
+SewingKit.configure do |config|
+ config.log_level = :warn # may be `:inherit`, `:debug`, `:info`, `:warn`, or `:error`
+end
+```
+
+### How can I set breakpoints for server rendered apps?
+
+Start your Rails server with `SK_DEBUG` set as an environment variable, and configure your Node debugger to listen on port `5858`.
+
+```bash
+SK_DEBUG=1 bundle exec rails start
+```

data/lib/sewing_kit/configuration.rb

@@ -3,7 +3,7 @@ module SewingKit
   class Configuration
     attr_accessor :build_options, :dev_server_sewing_kit_bin, :manifest_name,
       :manifest_path
-    attr_reader :test_manifest_mode
+    attr_reader :test_manifest_mode, :log_level
 
     def test_manifest_mode=(mode)
       valid_modes = [:return_no_assets, :use_precompiled_assets]
@@ -12,11 +12,22 @@ module SewingKit
       @test_manifest_mode = mode
     end
 
+    def log_level=(level)
+      valid_log_levels = [:inherit, :info, :debug, :warn, :error]
+
+      if valid_log_levels.include?(level)
+        @log_level = level
+      else
+        raise "Unknown log_level '#{level}' (valid log_levels are: #{valid_log_levels})"
+      end
+    end
+
     def initialize
       @build_options = nil
       @manifest_name = 'sewing-kit-manifest.json'
       @manifest_path = nil
       @dev_server_sewing_kit_bin = 'node_modules/.bin/sewing-kit'
+      @log_level = :inherit
       self.test_manifest_mode = :return_no_assets
     end
   end

data/lib/sewing_kit/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module SewingKit
-  VERSION = "0.94.0"
+  VERSION = "0.95.0"
 end

data/lib/sewing_kit/webpack/dev.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-
 require 'English'
 
 module SewingKit
@@ -25,17 +24,13 @@ module SewingKit
       private
 
       def spawn
-        sewing_kit_bin = SewingKit.configuration.dev_server_sewing_kit_bin
-        raise NodeSewingKitNotInstalled unless File.exist?(sewing_kit_bin)
-
         Kernel.spawn(
           {
             'NODE_ENV' => 'development',
             'BLUEBIRD_DEBUG' => '0',
             'BLUEBIRD_LONG_STACK_TRACES' => '0',
           },
-          sewing_kit_bin,
-          'dev',
+          command,
           chdir: Rails.root.to_s,
           out: $stdout,
           err: $stderr,
@@ -52,6 +47,52 @@ module SewingKit
       def detach
         Process.detach pid
       end
+
+      def command
+        command_list = [
+          sewing_kit_bin,
+          'dev',
+          '--logLevel',
+          log_level,
+        ]
+
+        if debug_mode?
+          command_list.push(['--debug'])
+        end
+
+        command_list.join(' ')
+      end
+
+      def sewing_kit_bin
+        bin = SewingKit.configuration.dev_server_sewing_kit_bin
+        raise NodeSewingKitNotInstalled unless File.exist?(bin)
+        bin
+      end
+
+      def log_level
+        if SewingKit.configuration.log_level == :inherit
+          log_level_from_rails
+        else
+          SewingKit.configuration.log_level.to_s
+        end
+      end
+
+      def log_level_from_rails
+        case Rails.logger.level
+        when 0
+          :debug
+        when 1
+          :info
+        when 2
+          :warn
+        else
+          :error
+        end
+      end
+
+      def debug_mode?
+        !ENV['SK_DEBUG'].nil?
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sewing_kit
 version: !ruby/object:Gem::Version
-  version: 0.94.0
+  version: 0.95.0
 platform: ruby
 authors:
 - Chris Sauve