sewing_kit 0.28.0 → 0.29.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0bea84b065d0c7713ba5973213988b614db786e3
-  data.tar.gz: 2bd89efe8f95ca2c9868f211c3051854d934ac23
+  metadata.gz: d23f8144c067f32539e07da4cb8e106f70f8eeb4
+  data.tar.gz: 55e53bf2912ae6059099c9a0ebcbc7bcd94353cc
 SHA512:
-  metadata.gz: 7869086387d0f21dc8e22d49ad1863c4aefd8b57a01902bbb336c1f52910862388a60d759e27026f7d4d2b69b434d9b1dde90e07fb8abd5bd7e769bfa6f7cc23
-  data.tar.gz: d5d3805841c1a0d33a50cbb822d178bb2ec9f5c68239cd6feb649b3fb69af6829095c27051207f4547d27d414e41e22148c645900c896e4a9a271570b65ac17e
+  metadata.gz: d45d0879e97f5c38f9d76a7c3f32bb1d7703a5792cb73c78cef0351255e8acbd7a1bb7c5c104b34c26401adcfcf0fbfd4851ed4ea9d16c76ca7f394877764c33
+  data.tar.gz: bd33f6fa33df9f136ffacb4ca02a6fb103ee40388e0bb9e88de999109ba02d5b56de1078ddbe5732a9e8f89e28ce6c542dbd28301e8b94eafa578faed1dae91b

data/README.md

@@ -1,4 +1,4 @@
-# sewing_kit
+# sewing_kit [![Build status](https://badge.buildkite.com/e7cdc87e61b9fe80e91e8686b6bfba53ca26a36366eb811a50.svg)](https://buildkite.com/shopify/sewing-kit-1)
 
 Zero configuration, high performance front end development at organization scale.
 
@@ -95,3 +95,7 @@ Minimally, it is required that the project does not have its own `babel-*` libra
 * In an `erb` view, add a placeholder for React content ([example](https://github.com/Shopify/rails_sewing_kit_example/blob/master/app/views/home/index.html.erb#L4))
 * In `index.js`, render a React component into the placeholder element ([example](https://github.com/Shopify/rails_sewing_kit_example/blob/master/app/ui/index.js))
 * Use `sewing_kit_script_tag`/`sewing_kit_link_tag` helpers to link erb/js ([example](https://github.com/Shopify/rails_sewing_kit_example/blob/master/app/views/layouts/application.html.erb#L8))
+
+## FAQ
+### How can I fix production builds that are failing due to missing devDependencies?
+By moving everything into `package.json#dependencies`.  This is necessary because Rails 5.2 prunes `devDependencies` during asset compilation.

data/lib/sewing_kit/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module SewingKit
-  VERSION = "0.28.0"
+  VERSION = "0.29.1"
 end

data/lib/sewing_kit/webpack/compiler.rb

@@ -4,7 +4,21 @@ require 'sewing_kit/webpack/webpack'
 module SewingKit
   module Webpack
     class Compiler
+      class NodeNotInstalled < StandardError
+        def initialize
+          super(
+            "nodejs is not installed.  " \
+            "Try creating a `.buildpack` file in the root of the project with following content:
+
+            https://github.com/heroku/heroku-buildpack-nodejs.git
+            https://github.com/heroku/heroku-buildpack-ruby.git
+            "
+          )
+        end
+      end
+
       def compile
+        raise NodeNotInstalled unless node_installed?
         raise NodeSewingKitNotRunnable, node_env unless File.exist?('node_modules/.bin/sewing-kit')
 
         result = Kernel.system(
@@ -29,13 +43,17 @@ module SewingKit
           'node_modules/.bin/sewing-kit',
           'build',
           '--mode',
-          node_env
+          node_env,
         ].reject(&:empty?)
       end
 
       def node_env
         ENV['NODE_ENV'] || Rails.env.to_s
       end
+
+      def node_installed?
+        Kernel.system('node --version')
+      end
     end
   end
 end

data/lib/sewing_kit/webpack/dev.rb

@@ -1,4 +1,7 @@
 # frozen_string_literal: true
+
+require 'English'
+
 module SewingKit
   module Webpack
     class Dev
@@ -15,6 +18,7 @@ module SewingKit
 
       def start
         @pid = spawn
+        at_exit { handle_exit }
         detach
       end
 
@@ -38,6 +42,13 @@ module SewingKit
         ) || exit(1)
       end
 
+      def handle_exit
+        return if $ERROR_INFO.nil?
+        Process.kill 'SIGTERM', pid
+      rescue Errno::ESRCH
+        nil
+      end
+
       def detach
         Process.detach pid
       end

data/lib/sewing_kit/webpack/manifest/base.rb

@@ -11,7 +11,12 @@ module SewingKit
 
         # :nodoc:
         def asset_dependencies(entrypoint_name)
-          metadata['entrypoints'][entrypoint_name]
+          current_metadata = metadata
+          if current_metadata.key?('development')
+            current_metadata['development']['hangTight']
+          else
+            current_metadata['entrypoints'][entrypoint_name]
+          end
         end
 
         def clear_cache!

data/lib/sewing_kit/webpack/manifest/development.rb

@@ -28,7 +28,7 @@ module SewingKit
           end
 
           result = load_metadata_from_node
-          raise LegacyManifestError, result unless result['entrypoints']
+          raise LegacyManifestError, result unless result['entrypoints'] || result['development']
 
           @metadata_path = result && result['path']
           result

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sewing_kit
 version: !ruby/object:Gem::Version
-  version: 0.28.0
+  version: 0.29.1
 platform: ruby
 authors:
 - Chris Sauve
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-21 00:00:00.000000000 Z
+date: 2018-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.0
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
@@ -44,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.51'
+        version: '0.56'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.51'
+        version: '0.56'
 - !ruby/object:Gem::Dependency
   name: rubocop-git
   requirement: !ruby/object:Gem::Requirement