sewing_kit 0.27.3 → 0.28.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 54caa1fe8a4c60c1040e465c857f5d255c111964
-  data.tar.gz: 80662d8a0a5c5995ab9a4294ff2ee3b002aa759a
+  metadata.gz: 0bea84b065d0c7713ba5973213988b614db786e3
+  data.tar.gz: 2bd89efe8f95ca2c9868f211c3051854d934ac23
 SHA512:
-  metadata.gz: 69db1d5bb726b8dd4189175b1556f5b053688f5a7252a26f990d10e09a58c3e3843afab12e83704e8118c7db12a5fd18ba18fd361c53ccda241cd6602bda2708
-  data.tar.gz: 57cce427b05e3de2b2b795ad0ef0cf7bc137b927f4a9121a5c64915cc6d8bbf77bdefbe04a2c616006f3eeb4151ae95ce85364a97eed1e0edb68d2ce86937289
+  metadata.gz: 7869086387d0f21dc8e22d49ad1863c4aefd8b57a01902bbb336c1f52910862388a60d759e27026f7d4d2b69b434d9b1dde90e07fb8abd5bd7e769bfa6f7cc23
+  data.tar.gz: d5d3805841c1a0d33a50cbb822d178bb2ec9f5c68239cd6feb649b3fb69af6829095c27051207f4547d27d414e41e22148c645900c896e4a9a271570b65ac17e

data/README.md

@@ -11,8 +11,7 @@ Create a Rails project using `dev init` then:
 ```sh
 # Add Ruby/Node dependencies
 bundle add sewing_kit
-yarn add --dev @shopify/sewing-kit
-yarn add --dev react-hot-loader@3.0.0-beta.7
+yarn add @shopify/sewing-kit
 
 # Optional - add Polaris
 yarn add @shopify/polaris react react-dom
@@ -91,13 +90,6 @@ If sewing-kit makes a breaking change, this gem's minor version will be bumped t
 It is currently not recommended to use `sprockets-commoner` and `sewing_kit` in the same project.
 Minimally, it is required that the project does not have its own `babel-*` libraries that `sewing-kit` currently has as [dependencies](https://github.com/Shopify/sewing-kit/blob/master/package.json#L97~L102).
 
-## Build Pipeline Gotchas
-While sewing-kit is a dev dependency, it is needed for production builds. This means that the production build will break if the environment variable `YARN_INSTALL` is set to true, because it will prevent `devDependencies` from being installed.
-
-To work around this in Buildkite, set `YARN_PRODUCTION=false` in the Environment Variables section of Pipeline Settings:
-
-![image](https://user-images.githubusercontent.com/2354121/36445473-64f6c4a2-164c-11e8-90fd-4e1b7835d7a2.png)
-
 ## React Boilerplate
 * Create a React app in `app/ui/App.js` ([example](https://github.com/Shopify/rails_sewing_kit_example/blob/master/app/ui/App.jsx))
 * In an `erb` view, add a placeholder for React content ([example](https://github.com/Shopify/rails_sewing_kit_example/blob/master/app/views/home/index.html.erb#L4))

data/lib/sewing_kit/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module SewingKit
-  VERSION = "0.27.3"
+  VERSION = "0.28.0"
 end

data/lib/sewing_kit/webpack/dev.rb

@@ -6,7 +6,7 @@ module SewingKit
         def initialize
           super(
             "sewing-kit is not installed.  " \
-            "Try `yarn add --dev @shopify/sewing-kit`"
+            "Try `yarn add @shopify/sewing-kit`"
           )
         end
       end

data/lib/sewing_kit/webpack/helper.rb

@@ -8,15 +8,18 @@ module SewingKit
     module Helper
       include ActionView::Helpers
 
-      class UnknownJavaScriptAssetError < StandardError
+      class UnknownAssetError < StandardError
       end
 
       Asset = Struct.new(:path, :integrity)
 
+      # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
       def sewing_kit_assets(entrypoint_name, extension: 'js')
         return '' unless entrypoint_name.present?
 
         assets = SewingKit::Webpack::Manifest.asset_dependencies(entrypoint_name)
+
+        raise UnknownAssetError, "#{entrypoint_name} was not found in manifest." if raise_unknown_error? assets
         return [] unless assets && assets[extension]
 
         dependencies = assets[extension]
@@ -25,6 +28,7 @@ module SewingKit
           Asset.new(raw_asset['path'], raw_asset['integrity'])
         end
       end
+      # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
 
       def sewing_kit_link_tag(*assets)
         options = assets.extract_options!
@@ -74,6 +78,10 @@ module SewingKit
         Rails.env.development?
       end
 
+      def raise_unknown_error?(assets)
+        assets.nil? && serve_development_assets?
+      end
+
       def dll_asset
         Asset.new('/webpack/assets/dll/vendor.js')
       end

data/lib/sewing_kit/webpack/webpack.rb

@@ -10,7 +10,7 @@ module SewingKit
     class NodeSewingKitNotRunnable < StandardError
       def initialize(mode, cause = nil)
         env_message = if 'development' == mode
-          "Try `yarn add --dev @shopify/sewing-kit`"
+          "Try `yarn add @shopify/sewing-kit`"
         else
           "\nIf this is a container build, try:\n" \
           "  - Adding #{highlight('https://github.com/heroku/heroku-buildpack-nodejs')} to your " \

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sewing_kit
 version: !ruby/object:Gem::Version
-  version: 0.27.3
+  version: 0.28.0
 platform: ruby
 authors:
 - Chris Sauve
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-08 00:00:00.000000000 Z
+date: 2018-06-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties