sevencop 0.42.1 → 0.43.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d6458ef2aecd8e03654e70a76fc22ff59d2dd509f1eb377f65977b363dd3d43c
-  data.tar.gz: 8566e27a40c3eb6bd51ae2afa1f592758641a18019492d599cf7c95e811465b1
+  metadata.gz: 27ef12a9d73af780d2df174d7f5e76a7c882a364310a90de25a5b74a7f805c89
+  data.tar.gz: 41b9ec3b0ba6639bd6b12b60da6d70cd7c7ded19f35bb1d97527ec98ecdaeca3
 SHA512:
-  metadata.gz: ca075075040e44c561fed97593c321375f831a5d034deb7a4c7e1510efbe70d2623196d901546123c453abce3a8c3aa3bc198041cd85d9ff8d671c1ff03dceea
-  data.tar.gz: b38e408140a08a3a173c8700ecc6006950666a9f0d77fd9858e8110fc7676bfa9878c07d6bbfdba40fba039b35d9cf5d001704af77a646e16d91e79ae44dc9a2
+  metadata.gz: f96546be70eefad0cc889efdf726aabd3417db9e3e29af83e2961f8066bff6cfa1974b6f058c2c96a9366a6e7309441c34139cc50f716fd05ee92fc6673ffdde
+  data.tar.gz: 278fbde7bc95f4a592f5e249aafb16f22874b75961e85336d814dd4726f446165058682ac3acfb9318add398841c1a81e6bdbb47a3024ee76bc53721ab3420a9

data/.rubocop.yml

@@ -42,6 +42,7 @@ RSpec/FilePath:
     RSpecMatcherConsistentParentheses: rspec_matcher_consistent_parentheses
     RSpecMemoizedHelperBlockDelimiter: rspec_memoized_helper_block_delimiter
     RSpecRailsHaveHttpStatus: rspec_rails_have_http_status
+    RSpecRailsStatusCodeCheckBySubject: rspec_rails_status_code_check_by_subject
 
 RSpec/MultipleExpectations:
   Enabled: false
@@ -54,6 +55,7 @@ RSpec/SpecFilePathFormat:
     RSpecMatcherConsistentParentheses: rspec_matcher_consistent_parentheses
     RSpecMemoizedHelperBlockDelimiter: rspec_memoized_helper_block_delimiter
     RSpecRailsHaveHttpStatus: rspec_rails_have_http_status
+    RSpecRailsStatusCodeCheckBySubject: rspec_rails_status_code_check_by_subject
 
 Sevencop/AutoloadOrdered:
   Enabled: true

data/Gemfile.lock

@@ -1,14 +1,14 @@
 PATH
   remote: .
   specs:
-    sevencop (0.42.1)
+    sevencop (0.43.0)
       activesupport
       rubocop
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.1.3.2)
+    activesupport (7.1.3.3)
       base64
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
@@ -29,7 +29,7 @@ GEM
       concurrent-ruby (~> 1.0)
     json (2.7.1)
     language_server-protocol (3.17.0.3)
-    minitest (5.22.3)
+    minitest (5.23.1)
     mutex_m (0.2.0)
     parallel (1.24.0)
     parser (3.3.0.5)

data/README.md

@@ -50,6 +50,7 @@ Note that all cops are `Enabled: false` by default.
 - [Sevencop/RSpecMatcherConsistentParentheses](lib/rubocop/cop/sevencop/rspec_matcher_consistent_parentheses.rb)
 - [Sevencop/RSpecMemoizedHelperBlockDelimiter](lib/rubocop/cop/sevencop/rspec_memoized_helper_block_delimiter.rb)
 - [Sevencop/RSpecRailsHaveHttpStatus](lib/rubocop/cop/sevencop/rspec_rails_have_http_status.rb)
+- [Sevencop/RSpecRailsStatusCodeCheckBySubject](lib/rubocop/cop/sevencop/rspec_rails_status_code_check_by_subject.rb)
 
 ## Notes
 

data/config/default.yml

@@ -149,3 +149,11 @@ Sevencop/RSpecRailsHaveHttpStatus:
   Include:
     - "**/spec/controllers/**/*.rb"
     - "**/spec/requests/**/*.rb"
+
+Sevencop/RSpecRailsStatusCodeCheckBySubject:
+  Description: |
+    Use `expect(response).to have_http_status(code)` instead of `is_expected.to eq(code)`.
+  Enabled: false
+  Include:
+    - "**/spec/controllers/**/*.rb"
+    - "**/spec/requests/**/*.rb"

data/lib/rubocop/cop/sevencop/rspec_rails_status_code_check_by_subject.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sevencop
+      # Use `expect(response).to have_http_status(code)` instead of `is_expected.to eq(code)`.
+      #
+      # @example
+      #   # bad
+      #   is_expected.to eq(200)
+      #
+      #   # good
+      #   expect(response).to have_http_status(200)
+      #
+      #   # bad
+      #   is_expected.to eq(:ok)
+      #
+      #   # good
+      #   expect(response).to have_http_status(:ok)
+      class RSpecRailsStatusCodeCheckBySubject < Base
+        extend AutoCorrector
+
+        MSG = 'Use `expect(response).to have_http_status(code)` instead of `is_expected.to eq(code)`.'
+
+        RESTRICT_ON_SEND = %i[
+          to
+        ].freeze
+
+        # @param [RuboCop::AST::SendNode] node
+        # @return [void]
+        def on_send(node)
+          return unless is_expected_to_eq_code?(node)
+
+          add_offense(node) do |corrector|
+            corrector.insert_before(node, "subject\n")
+            corrector.replace(node.receiver, 'expect(response)')
+            corrector.replace(node.first_argument.location.selector, 'have_http_status')
+          end
+        end
+
+        private
+
+        # @!method is_expected_to_eq_code?(node)
+        #   @param [RuboCop::AST::SendNode] node
+        #   @return [Boolean]
+        def_node_matcher :is_expected_to_eq_code?, <<~PATTERN
+          (send (send nil? :is_expected) :to (send nil? :eq {int sym}))
+        PATTERN
+      end
+    end
+  end
+end

data/lib/sevencop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Sevencop
-  VERSION = '0.42.1'
+  VERSION = '0.43.0'
 end

data/lib/sevencop.rb

@@ -26,3 +26,4 @@ require_relative 'rubocop/cop/sevencop/rspec_examples_in_same_group'
 require_relative 'rubocop/cop/sevencop/rspec_matcher_consistent_parentheses'
 require_relative 'rubocop/cop/sevencop/rspec_memoized_helper_block_delimiter'
 require_relative 'rubocop/cop/sevencop/rspec_rails_have_http_status'
+require_relative 'rubocop/cop/sevencop/rspec_rails_status_code_check_by_subject'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sevencop
 version: !ruby/object:Gem::Version
-  version: 0.42.1
+  version: 0.43.0
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-05-13 00:00:00.000000000 Z
+date: 2024-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -78,6 +78,7 @@ files:
 - lib/rubocop/cop/sevencop/rspec_matcher_consistent_parentheses.rb
 - lib/rubocop/cop/sevencop/rspec_memoized_helper_block_delimiter.rb
 - lib/rubocop/cop/sevencop/rspec_rails_have_http_status.rb
+- lib/rubocop/cop/sevencop/rspec_rails_status_code_check_by_subject.rb
 - lib/sevencop.rb
 - lib/sevencop/config_loader.rb
 - lib/sevencop/cop_concerns.rb