sevencop 0.28.0 → 0.29.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 79bb602015c9eea9c89de44bfbd22274ef1197412a420f274280cc3cac7fe8c5
-  data.tar.gz: 8fe918f1ad6031ec0b4886a778e5333d9574ecf23c5658f133e32423349d2a28
+  metadata.gz: d415f24d882b17eb832c22fa9a17d40ebf1ea91fda15e5a25e8e5ceea6824633
+  data.tar.gz: b770d04a2620d1ef6e5f7a0e0b0cd1e6f440b44a5173bd8c26890f0707a4e9b5
 SHA512:
-  metadata.gz: 0bdc4d1d137ea5c3a3b2048e8c1aa37bfff81672aef0b10d75cc361f4ff10938d9327ec1193f7936b6180b8fc2e2f6e51909723a9b036279c2852d76e810990b
-  data.tar.gz: 4235669bbd83b5f460663877b3e47272bffa0aadec21e1f413a7e957c6f0bdafe851443d0bbff5985553978b495e4b8c0d418b7736b9ebc9f2ee941859885f85
+  metadata.gz: ddd45cdafff3edc2512a962f32d817cd5836f5435547d987c76f96a0d3a873f8398506dc567caea00ed165f7bd206378bcdbea71eec0516fe05ce7249a2b88e9
+  data.tar.gz: 737bd07f00679aa77fce2209f9692b5babff560362a03c412f228584f74d4cd213bbfc5a1223ed999e3ba66abb3f6f7cd7cfcd1d702ee4fed7f8f80d4940e0a3

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    sevencop (0.28.0)
+    sevencop (0.29.0)
       activesupport
       rubocop
 

data/README.md

@@ -36,11 +36,11 @@ Note that all cops are `Enabled: false` by default.
 - [Sevencop/MethodDefinitionInIncluded](lib/rubocop/cop/sevencop/method_definition_in_included.rb)
 - [Sevencop/MethodDefinitionKeywordArgumentOrdered](lib/rubocop/cop/sevencop/method_definition_keyword_argument_ordered.rb)
 - [Sevencop/MethodDefinitionOrdered](lib/rubocop/cop/sevencop/method_definition_ordered.rb)
-- [Sevencop/RailsActionName](lib/rubocop/cop/sevencop/rails_action_name.rb)
 - [Sevencop/RailsBelongsToOptional](lib/rubocop/cop/sevencop/rails_belongs_to_optional.rb)
 - [Sevencop/RailsDateAndTimeCalculation](lib/rubocop/cop/sevencop/rails_date_and_time_calculation.rb)
 - [Sevencop/RailsInferredSpecType](lib/rubocop/cop/sevencop/rails_inferred_spec_type.rb)
 - [Sevencop/RailsOrderField](lib/rubocop/cop/sevencop/rails_order_field.rb)
+- [Sevencop/RailsSpecificActionName](lib/rubocop/cop/sevencop/rails_specific_action_name.rb)
 - [Sevencop/RailsUniquenessValidatorExplicitCaseSensitivity](lib/rubocop/cop/sevencop/rails_uniqueness_validator_explicit_case_sensitivity.rb)
 - [Sevencop/RailsWhereNot](lib/rubocop/cop/sevencop/rails_where_not.rb)
 - [Sevencop/RequireOrdered](lib/rubocop/cop/sevencop/require_ordered.rb)

data/config/default.yml

@@ -68,22 +68,6 @@ Sevencop/MethodDefinitionKeywordArgumentOrdered:
   Safe: false
   VersionAdded: '0.13'
 
-Sevencop/RailsActionName:
-  Description: |
-    Use only specific action names.
-  Enabled: false
-  VersionAdded: '0.24'
-  ActionNames:
-    - create
-    - destroy
-    - edit
-    - index
-    - new
-    - show
-    - update
-  Include:
-    - app/controllers/**/*.rb
-
 Sevencop/RailsBelongsToOptional:
   Description: |
     Force `belongs_to` with `optional: true` option.
@@ -112,6 +96,23 @@ Sevencop/RailsOrderField:
   Safe: false
   VersionAdded: '0.4'
 
+Sevencop/RailsSpecificActionName:
+  Description: |
+    Use only specific action names.
+  Enabled: false
+  VersionAdded: '0.24'
+  VersionChanged: '0.29'
+  ActionNames:
+    - create
+    - destroy
+    - edit
+    - index
+    - new
+    - show
+    - update
+  Include:
+    - app/controllers/**/*.rb
+
 Sevencop/RailsUniquenessValidatorExplicitCaseSensitivity:
   Description: |
     Specify :case_sensitivity option on use of UniquenessValidator.

data/lib/rubocop/cop/sevencop/{rails_action_name.rb → rails_specific_action_name.rb}

@@ -5,6 +5,9 @@ module RuboCop
     module Sevencop
       # Use only specific action names.
       #
+      # It is good practice to separate controller classes rather than adding more actions as needed.
+      # By default, the 7 CRUD action names are specified that are generated by the Rails scaffold.
+      #
       # @example
       #   # bad
       #   class UsersController < ApplicationController
@@ -17,7 +20,7 @@ module RuboCop
       #     def index
       #     end
       #   end
-      class RailsActionName < Base
+      class RailsSpecificActionName < Base
         include VisibilityHelp
 
         MSG = 'Use only specific action names.'
@@ -27,7 +30,13 @@ module RuboCop
         def on_def(node)
           return unless bad?(node)
 
-          add_offense(node.location.name)
+          add_offense(
+            node.location.name,
+            message: format(
+              'Use only specific action names (%<action_names>s).',
+              action_names: configured_action_names.join(', ')
+            )
+          )
         end
 
         private

data/lib/sevencop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Sevencop
-  VERSION = '0.28.0'
+  VERSION = '0.29.0'
 end

data/lib/sevencop.rb

@@ -12,11 +12,11 @@ require_relative 'rubocop/cop/sevencop/method_definition_arguments_multiline'
 require_relative 'rubocop/cop/sevencop/method_definition_in_included'
 require_relative 'rubocop/cop/sevencop/method_definition_keyword_argument_ordered'
 require_relative 'rubocop/cop/sevencop/method_definition_ordered'
-require_relative 'rubocop/cop/sevencop/rails_action_name'
 require_relative 'rubocop/cop/sevencop/rails_belongs_to_optional'
 require_relative 'rubocop/cop/sevencop/rails_date_and_time_calculation'
 require_relative 'rubocop/cop/sevencop/rails_inferred_spec_type'
 require_relative 'rubocop/cop/sevencop/rails_order_field'
+require_relative 'rubocop/cop/sevencop/rails_specific_action_name'
 require_relative 'rubocop/cop/sevencop/rails_uniqueness_validator_explicit_case_sensitivity'
 require_relative 'rubocop/cop/sevencop/rails_where_not'
 require_relative 'rubocop/cop/sevencop/require_ordered'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sevencop
 version: !ruby/object:Gem::Version
-  version: 0.28.0
+  version: 0.29.0
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-11-05 00:00:00.000000000 Z
+date: 2022-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -64,11 +64,11 @@ files:
 - lib/rubocop/cop/sevencop/method_definition_in_included.rb
 - lib/rubocop/cop/sevencop/method_definition_keyword_argument_ordered.rb
 - lib/rubocop/cop/sevencop/method_definition_ordered.rb
-- lib/rubocop/cop/sevencop/rails_action_name.rb
 - lib/rubocop/cop/sevencop/rails_belongs_to_optional.rb
 - lib/rubocop/cop/sevencop/rails_date_and_time_calculation.rb
 - lib/rubocop/cop/sevencop/rails_inferred_spec_type.rb
 - lib/rubocop/cop/sevencop/rails_order_field.rb
+- lib/rubocop/cop/sevencop/rails_specific_action_name.rb
 - lib/rubocop/cop/sevencop/rails_uniqueness_validator_explicit_case_sensitivity.rb
 - lib/rubocop/cop/sevencop/rails_where_not.rb
 - lib/rubocop/cop/sevencop/require_ordered.rb