sevencop 0.16.0 → 0.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c55fa975db18f38f073127cff1b736321d599328040959966ca3c7ee68e576f4
-  data.tar.gz: a976b6455cf9083a81dca72c0ecd2b7df79e963ca1fd49124d6c756799975ee3
+  metadata.gz: 3e346d243517396c6f0813c7369dab4817564a13f019700543e6bf10a8469a7e
+  data.tar.gz: 66c31821ed67e2c39946ee62cea8192104924847de0d0e3fb0c029eb0e9c7d47
 SHA512:
-  metadata.gz: 8f9f873aead1ae719deb96b16f46850fb8daa55a81dbb7709f548352b624bffdb34f639176f5580bbc25bd279c8acd679b175b0a9755c89260c23ef303975a18
-  data.tar.gz: 43e716bfb540bfa7a607aeefae2bef61334518b636d277fcff4155af7145734d17f6eec10494a72b09e40b3d6736175f28b84db18091f89dad4c179bd5479320
+  metadata.gz: 9f19c719aa7a9c7fe2c5c48b9a0bb15840ec743759722ccb4ae497472fde33269158105e7128fe43bcfeb1795a8be385738c8d325de9b7d9dc106a9aede56736
+  data.tar.gz: b6ea5b4210c1aed498d72eaf6c1b088e8d7aae22904b5b7afd10f1ce84a584e5a5d01b7b0f265d885c2ea86d179fcdd74d2bc50f7e4c5d77157bedaae0406b36

data/.rubocop.yml

@@ -10,6 +10,9 @@ AllCops:
   SuggestExtensions: false
   TargetRubyVersion: 2.6
 
+Gemspec/RequireMFA:
+  Enabled: false
+
 Metrics:
   Enabled: false
 
@@ -23,6 +26,10 @@ RSpec:
 RSpec/ExampleLength:
   Enabled: false
 
+RSpec/FilePath:
+  CustomTransform:
+    RSpecExamplesInSameGroup: rspec_examples_in_same_group
+
 RSpec/MultipleExpectations:
   Enabled: false
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    sevencop (0.16.0)
+    sevencop (0.17.0)
       rubocop
 
 GEM

data/README.md

@@ -39,5 +39,6 @@ Choose the cops you want to use and enable them on your .rubocop.yml.
 - [Sevencop/RailsUniquenessValidatorExplicitCaseSensitivity](lib/rubocop/cop/sevencop/rails_uniqueness_validator_explicit_case_sensitivity.rb)
 - [Sevencop/RailsWhereNot](lib/rubocop/cop/sevencop/rails_where_not.rb)
 - [Sevencop/RequireOrdered](lib/rubocop/cop/sevencop/require_ordered.rb)
+- [Sevencop/RSpecExamplesInSameGroup](lib/rubocop/cop/sevencop/rspec_examples_in_same_group.rb)
 
 Note that all cops are `Enabled: false` by default.

data/config/default.yml

@@ -67,3 +67,12 @@ Sevencop/RequireOrdered:
     Sort `require` and `require_relative` in alphabetical order.
   Enabled: false
   VersionAdded: '0.16'
+
+Sevencop/RSpecExamplesInSameGroup:
+  Description: |
+    Combine examples in the same groups in the time-consuming kinds of specs.
+  Enabled: false
+  VersionAdded: '0.17'
+  Include:
+    - spec/controllers/**/*
+    - spec/requests/**/*

data/lib/rubocop/cop/sevencop/rspec_examples_in_same_group.rb

@@ -0,0 +1,77 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sevencop
+      # Combine examples in same group in the time-consuming kinds of specs.
+      #
+      # @example
+      #
+      #   # bad
+      #   context 'when user is logged in' do
+      #     it 'returns 200' do
+      #       subject
+      #       expect(response).to have_http_status(200)
+      #     end
+      #
+      #     it 'creates Foo' do
+      #       expect { subject }.to change(Foo, :count).by(1)
+      #     end
+      #   end
+      #
+      #   # good
+      #   context 'when user is logged in' do
+      #     it 'creates Foo and returns 200' do
+      #       expect { subject }.to change(Foo, :count).by(1)
+      #       expect(response).to have_http_status(200)
+      #     end
+      #   end
+      #
+      class RSpecExamplesInSameGroup < Base
+        extend AutoCorrector
+
+        EXAMPLE_METHOD_NAMES_REGULAR = ::Set[
+          :it,
+          :its,
+          :specify,
+          :example,
+          :scenario,
+        ].freeze
+
+        MSG = 'Combine examples in the same group in the time-consuming kinds of specs.'
+
+        # @param node [RuboCop::AST::BlockNode]
+        # @return [void]
+        def on_block(node)
+          return unless example?(node)
+
+          previous_sibling_example = previous_sibling_example_of(node)
+          return unless previous_sibling_example
+
+          add_offense(node)
+        end
+        alias on_numblock on_block
+
+        private
+
+        # @!method example?(node)
+        #   @param node [RuboCop::AST::Node]
+        #   @return [Boolean]
+        def_node_matcher :example?, <<~PATTERN
+          (block
+            (send nil? EXAMPLE_METHOD_NAMES_REGULAR ...)
+            ...
+          )
+        PATTERN
+
+        # @param node [RuboCop::AST::BlockNode]
+        # @return [RuboCop::AST::BlockNode, nil]
+        def previous_sibling_example_of(node)
+          node.left_siblings.find do |sibling|
+            sibling.is_a?(::RuboCop::AST::Node) && example?(sibling)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/sevencop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Sevencop
-  VERSION = '0.16.0'
+  VERSION = '0.17.0'
 end

data/lib/sevencop.rb

@@ -15,3 +15,4 @@ require_relative 'rubocop/cop/sevencop/rails_order_field'
 require_relative 'rubocop/cop/sevencop/rails_uniqueness_validator_explicit_case_sensitivity'
 require_relative 'rubocop/cop/sevencop/rails_where_not'
 require_relative 'rubocop/cop/sevencop/require_ordered'
+require_relative 'rubocop/cop/sevencop/rspec_examples_in_same_group'

data/sevencop.gemspec

@@ -16,7 +16,6 @@ Gem::Specification.new do |spec|
   spec.metadata['homepage_uri'] = spec.homepage
   spec.metadata['source_code_uri'] = spec.homepage
   spec.metadata['changelog_uri'] = "#{spec.homepage}/releases"
-  spec.metadata['rubygems_mfa_required'] = 'true'
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sevencop
 version: !ruby/object:Gem::Version
-  version: 0.16.0
+  version: 0.17.0
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-09-30 00:00:00.000000000 Z
+date: 2022-10-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -52,6 +52,7 @@ files:
 - lib/rubocop/cop/sevencop/rails_uniqueness_validator_explicit_case_sensitivity.rb
 - lib/rubocop/cop/sevencop/rails_where_not.rb
 - lib/rubocop/cop/sevencop/require_ordered.rb
+- lib/rubocop/cop/sevencop/rspec_examples_in_same_group.rb
 - lib/sevencop.rb
 - lib/sevencop/config_loader.rb
 - lib/sevencop/cop_concerns.rb
@@ -66,7 +67,6 @@ metadata:
   homepage_uri: https://github.com/r7kamura/sevencop
   source_code_uri: https://github.com/r7kamura/sevencop
   changelog_uri: https://github.com/r7kamura/sevencop/releases
-  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths: