seven_bank_fx_rate 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 27785e430ec8ad56d4f8a8e15eb1b549a5a0158596e50ad44f31feff6cf9b7d1
-  data.tar.gz: c68def2502e4a0d4155d4e6c787acafc4d871b12cc1ea6f07678d6a151e5dfa3
+  metadata.gz: 77c756f13108334c7a5afd0e9e686231de1a2207e7b60ba1be0329bed55901f1
+  data.tar.gz: 76b1401a985dbae61ef7672f36c6b92d6a0efad978ba409a09a6fff2f47550d9
 SHA512:
-  metadata.gz: d9470dda92c3bcd91e129b6d6f826eb92395296360551207ef939eff9bcb95526734e7fc55b10aa173ef4e415f6f924aab0913885029d21aa9900c7a275b7a46
-  data.tar.gz: 074d973f412d82ac61eb5b1d103ba827824bfb66ddcd744a048487af74afb3430b78e4594b56537b3d4cc1e773216257ad856be792d43dcbd2f904a89ab21151
+  metadata.gz: 8cf490eb059fa8b5138fd685cb516c0e95653c40336f134758fe2c66921ac4e1486a56ad6cd6ebd509933025d1009a35bf9f0cb8261054397dd52b4c89957dbe
+  data.tar.gz: 55783b2ff0e8b397c0b358222d69bff04308589197f8657eb87cb611e0b358626d346b489d92f3370205086e66265a27bc81edc102cba819e1dc079cf9204bc9

data/CHANGELOG.md

@@ -1,2 +1,7 @@
 ### v1.0.0
 - Initial release
+
+### v1.1.0
+- Switched unnecessary instance variables in `SevenBankFxRate::Parser` to local ones
+- Fixed `SevenBankFxRate::respond_to_missing` to strictly check missing method pattern
+- Added mutex to avoid extra http requests due to race condition with multiple threads

data/README.md

@@ -1,4 +1,4 @@
-# SevenBankFxRate
+# SevenBankFxRate [![Gem Version](https://badge.fury.io/rb/seven_bank_fx_rate.svg)](https://badge.fury.io/rb/seven_bank_fx_rate) [![Build Status](https://travis-ci.org/yuan-jiang/seven_bank_fx_rate.svg?branch=master)](https://travis-ci.org/yuan-jiang/seven_bank_fx_rate)
 
 Easier access to the foreign exchange rate data of Seven Bank international
 money transfer service in Japan, with JPY1.00 as the base currency and unit.

data/lib/seven_bank_fx_rate/parser.rb

@@ -8,27 +8,27 @@ module SevenBankFxRate
     # @param response the body of Net::HTTPResponse
     def initialize(response)
       @root = REXML::Document.new(response).root
-      @meta = Elements::Meta.new
-      @countries = []
     end
 
     # Parses the <header> section in original xml response
     # @return instance of SevenBankFxRate::Elements::Meta
     def meta
-      return @meta unless @root
+      meta = Elements::Meta.new
+      return meta unless @root
 
       %w[create_date apply_date apply_time data_count].each do |attr|
         @root.elements.each("header/#{attr.split('_').join}") do |e|
-          @meta.send("#{attr}=".to_sym, e.text.strip)
+          meta.send("#{attr}=".to_sym, e.text.strip)
         end
       end
-      @meta
+      meta
     end
 
     # Parses the <countries> section in original xml response
     # @return an array of SevenBankFxRate::Elements::Country
     def countries
-      return @countries unless @root
+      countries = []
+      return countries unless @root
 
       @root.elements.each('countries/country') do |country_tag|
         country = Elements::Country.new
@@ -38,9 +38,9 @@ module SevenBankFxRate
           end
         end
         country.currencies = currencies country_tag
-        @countries << country
+        countries << country
       end
-      @countries
+      countries
     end
 
     private

data/lib/seven_bank_fx_rate/seven_bank_fx_rate.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 module SevenBankFxRate
+  @mutex = Mutex.new
   class << self
     # Methods to access meta attributes of the latest exchange rate data
     %i[create_date apply_date apply_time data_count].each do |attr|
@@ -47,11 +48,15 @@ module SevenBankFxRate
     private
 
     def data
-      @data ||= Data.new
+      @mutex.synchronize do
+        @data ||= Data.new
+      end
     end
 
+    GHOST_METHOD_PATTERN = /\Acountry_[A-Za-z]{2}_currency_[A-Za-z]{3}\z/.freeze
+
     def method_missing(method_name, *arguments, &block)
-      if /\Acountry_[A-Za-z]{2}_currency_[A-Za-z]{3}\z/ =~ method_name.to_s
+      if GHOST_METHOD_PATTERN =~ method_name.to_s
         _, country_code, _, currency_code = method_name.to_s.split('_')
         send :for, country_code, currency_code
       else
@@ -60,7 +65,7 @@ module SevenBankFxRate
     end
 
     def respond_to_missing?(method_name, include_private = false)
-      method_name.to_s.start_with?('country_') || super
+      !!(GHOST_METHOD_PATTERN =~ method_name.to_s) || super
     end
   end
 

data/lib/seven_bank_fx_rate/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SevenBankFxRate
-  VERSION = '1.0.0'
+  VERSION = '1.1.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: seven_bank_fx_rate
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Andy Jiang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-04 00:00:00.000000000 Z
+date: 2020-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake