setting_accessors 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7e10e1f1db74ffd1a88c6cda07070ee743347be2
-  data.tar.gz: bb11685605adb3eb565543d9282b76c133609529
+  metadata.gz: 6ba51cce908ff75943938e86e01d1aed48b0ccf6
+  data.tar.gz: 7d164c7545cb6adfa0741b8dabf3b4a7bfae5a74
 SHA512:
-  metadata.gz: 4cf233138c9ea194ce51cf154a136030ef7d835fa089f968d2ba6ffdd47b33b191357496e6627a3f56b3d4d9713e678b922d34e6843249f92f859d5c12c9b1c2
-  data.tar.gz: df955321287251309b6a5f2ef6dd24e0701b3218423eb365dbf5e5156e4cea031526fa6ce3b5478b9b69dda030f9067807331d34888dcce2363cacf34a8c0c90
+  metadata.gz: ee4917d83045b732589124c938999204b8458859707119faa78d7c2aa3626d4f0949d1cf34afc4d994dda2f4740ceefe4679ff2aec004e7f0382bc2a1c6f1cf7
+  data.tar.gz: 3feb815f194119f2817314c3b6b01880083132eae3972dff75b9ae38c821ae1ee9a4bf105d5105294af7b84ad6c901508a0804f132e5562b0e7a46779bd0ac1f

data/.gitignore

@@ -21,8 +21,8 @@ tmp
 *.a
 mkmf.log
 
-#Rubymine
-.idea
+# RVM
+.ruby-version
 
 #Dummy Application
 test/dummy/log

data/.travis.yml

@@ -5,6 +5,9 @@ rvm:
   - 2.2
   - 2.3.1
 
+env:
+  - DISABLE_DATABASE_ENVIRONMENT_CHECK=1
+
 before_install: 'gem install bundler'
 script: 'bundle exec rake'
 

data/CHANGELOG.md

@@ -0,0 +1,5 @@
+# Changelog
+
+## 0.3.0
+
+* Fixed a bug that caused setting accessors not being initialized when being called as part of a rake task chain (#6)

data/lib/setting_accessors/integration.rb

@@ -36,20 +36,11 @@ module SettingAccessors::Integration
     #   setting and return +nil+ if none was specified previously.
     #
     def setting_accessor(setting_name, options = {})
-      #If the database table does not yet exist,
-      return unless self.table_exists?
-
       fallback = options.delete(:fallback)
 
       SettingAccessors::Internal.set_class_setting(self, setting_name, options)
 
-      setting_type = SettingAccessors::Internal.setting_value_type(setting_name, self.new).to_sym
-
-      #Create a virtual column in the models column hash.
-      #This is currently not absolutely necessary, but will become important once
-      #Time etc. are supported. Otherwise, Rails won't be able to e.g. automatically
-      #create multi-param fields in forms.
-      self.columns_hash[setting_name.to_s] = OpenStruct.new(type: setting_type)
+      setting_type = SettingAccessors::Internal.setting_value_type(setting_name, self).to_sym
 
       #Add the setting's name to the list of setting_accessors for this class
       SettingAccessors::Internal.add_setting_accessor_name(self, setting_name)

data/lib/setting_accessors/internal.rb

@@ -76,8 +76,12 @@ module SettingAccessors
     #   - If it's a setting defined in a setting_accessor call, the information is taken from this call
     #   - Otherwise, an empty hash is returned
     #
-    def self.setting_data(setting_name, assignable = nil)
-      (assignable && self.get_class_setting(assignable.class, setting_name)) ||
+    def self.setting_data(setting_name, assignable_class = nil)
+      # As a convenience function (and to keep the existing code working),
+      # it is possible to provide a class or an instance of said class
+      assignable_class &&= assignable_class.class unless assignable_class.is_a?(Class)
+
+      (assignable_class && self.get_class_setting(assignable_class, setting_name)) ||
           self.global_config[setting_name.to_s] ||
           {}
     end

data/lib/setting_accessors/version.rb

@@ -1,3 +1,3 @@
 module SettingAccessors
-  VERSION = '0.2.0'.freeze
+  VERSION = '0.3.0'.freeze
 end

data/test/test_helper.rb

@@ -18,6 +18,14 @@ if ActiveSupport::TestCase.method_defined?(:fixture_path=)
   ActiveSupport::TestCase.fixture_path = File.expand_path("../fixtures", __FILE__)
 end
 
+# configure shoulda matchers
+Shoulda::Matchers.configure do |config|
+  config.integrate do |with|
+    with.test_framework :minitest
+    with.library :rails
+  end
+end
+
 # For generators
 require "rails/generators/test_case"
 require "generators/setting_accessors/install_generator"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: setting_accessors
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Stefan Exner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-13 00:00:00.000000000 Z
+date: 2018-07-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -126,6 +126,7 @@ files:
 - ".codeclimate.yml"
 - ".gitignore"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -224,7 +225,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.9
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: A global key-value-store and virtual model columns