setler 0.0.13 → 0.0.14

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    MDlmODVjNzM5ZWZiMzY3Njk4YjJkMWM4YTZiMTQyMDEyYTRkYzU3MA==
-  data.tar.gz: !binary |-
-    MWM0MTJjNWE2YmYyZmE4MWM1NGUyYWZkNzllNTM3YzgxMTQ4NzdiNg==
+SHA256:
+  metadata.gz: cbe29674970fc77e130e8ab2927c5afb9697f2f60d0c6b1edd0f7e95c9fa4710
+  data.tar.gz: 896867601cf7eee4ae4eeb4cca788952a334f450e9980c123ba38f54568778af
 SHA512:
-  metadata.gz: !binary |-
-    NDVjNDRlNjU0MDZjZWJiODdkNzNiY2YyNGQ2MDBhMTBmZjE3NzJiYTcxMjc0
-    NmFkNzRhZTZhOTllZTU2MTk5MDZkZDBmOTBiZjNhMTdiNDQ0NjQ5MGQ0ZDg4
-    NTcwOWY2ZWFiMGM5YjU4MGM0MDg1MzhjMGVhZjQ3YWVhZTcxMGM=
-  data.tar.gz: !binary |-
-    MzdlNDgwMGZlNzYxMGQ3ODQ5Y2Q2Y2JkMDNiNWIwNmYyY2FhMjYzMmE4MWYw
-    OTY0MDE3MDVhNjVmYWM3Mjc1OWEwOGUzNDVjYmJmZWViOTY3NjYzYjczMmEw
-    M2NkNDZhNDQ4ZmViOGNiMzJjZTc2MmE3MjIwOTY1ZDM1NmM2Mzk=
+  metadata.gz: e9f90bc4f78b627a5d512cdf18bdedc7947a80f20fe7ef46acedbdad4f3321e02f76c7d8ab86278c41aee252a9607a2688d31086ee1621123c9ed8e4deec5aef
+  data.tar.gz: e01e2a723f9b0db1b77625f5f50912f670edfe71b519f07a975ae07412a360f9d3f7a727fd1b58cc1eb8a9bcc2d04aebf3d44c7c20a12513f046f1d7b6523e20

data/.ruby-version

@@ -1 +1 @@
-ruby-1.9.3-p547
+2.6.5

data/.travis.yml

@@ -1,8 +1,22 @@
+language: ruby
 rvm:
-  - 1.9.3
-  - 2.1.2
+  - 2.3.8
+  - 2.4.7
+  - 2.5.7
+  - 2.6.5
+before_install: "gem install bundler:1.17.2"
 cache: bundler
-script:
-  - bundle exec rake test
+script: "bundle exec rake test"
 notifications:
   email: false
+gemfile:
+  - gemfiles/rails_4.gemfile
+  - gemfiles/rails_5.gemfile
+  - gemfiles/rails_6_edge.gemfile
+matrix:
+  fast_finish: true
+  exclude:
+    - rvm: 2.3.8
+      gemfile: gemfiles/rails_6_edge.gemfile
+    - rvm: 2.4.7
+      gemfile: gemfiles/rails_6_edge.gemfile

data/Appraisals

@@ -0,0 +1,14 @@
+appraise "rails-4" do
+  gem "rails", "4.2.11.1"
+  gem 'sqlite3', '1.3.13' # 5/13/2019: LOCKED DOWN AGAIN.
+end
+
+appraise "rails-5" do
+  gem "rails", "5.2.3"
+  gem 'sqlite3'
+end
+
+appraise "rails-6-edge" do
+  gem 'rails', git: 'https://github.com/rails/rails'
+  gem 'sqlite3'
+end

data/Gemfile

@@ -1,4 +1,4 @@
-source "http://rubygems.org"
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in setler.gemspec
 gemspec

data/README.rdoc

@@ -3,6 +3,9 @@
 Setler is a Gem that lets one easily implement the "Feature Flags" pattern, or add settings to individual models. This is a cleanroom implementation of what the 'rails-settings' gem does. It's been forked all over the place, and my favorite version of it doesn't have any tests and doesn't work with settings associated with models.
 
 {<img src="https://travis-ci.org/ckdake/setler.svg?branch=master" alt="Build Status" />}[https://travis-ci.org/ckdake/setler]
+{<img src="https://badge.fury.io/rb/setler.svg" alt="Gem Version" />}[http://badge.fury.io/rb/setler]
+
+While Setler enables you to create both app-level and model-level settings, they are two separate things and don't mix. For example, if you create defaults for the app, they won't appear as defaults for individual models.
 
 == Setup
 
@@ -74,7 +77,8 @@ Getting started is pretty straightforward:
 
   1. Check out the code:  `git clone git://github.com/ckdake/setler.git`
   2. Bundle install:  `bundle install`
-  3. Run the tests and make sure they all pass and code coverage is still 100%:  `rake test`
+  3. Run:  `appraisal install`  to generate the appraisal's gemfiles.
+  4. Run the tests for all supported releases in Appraisals file and make sure they all pass and code coverage is still the same:  `appraisal rake test`
 
 If you'd like to contribute code, make your changes and submit a pull request that includes appropriate tests
 

data/Rakefile

@@ -1,6 +1,12 @@
+# encoding: utf-8
+
+require 'rubygems'
+require 'bundler/setup'
+require 'bundler/gem_tasks'
+
 require 'rake'
 require 'rake/testtask'
-require 'bundler/gem_tasks'
+require 'appraisal'
 
 Rake::TestTask.new(:test) do |test|
   test.libs << 'lib' << 'test'
@@ -8,4 +14,20 @@ Rake::TestTask.new(:test) do |test|
   test.verbose = true
 end
 
-task default: [:test]
+require 'bundler/gem_tasks'
+
+require 'rake'
+require 'appraisal'
+
+desc 'Default'
+task :default do
+  if ENV['BUNDLE_GEMFILE'] =~ /gemfiles/
+    task default: [:test]
+  else
+    Rake::Task['appraise'].invoke
+  end
+end
+
+task :appraise do
+  exec 'appraisal install && appraisal rake test'
+end

data/contributors.txt

@@ -7,3 +7,5 @@ Steven Harman github.com/stevenharman
 Chris Stefano github.com/virtualstaticvoid
 Brian Stanwyck github.com/brianstanwyck
 Jay Hayes github.com/iamvery
+Al Snow github.com/jasnow
+Gal Tsubery github.com/tsubery

data/gemfiles/rails_4.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "4.2.11.1"
+gem "sqlite3", "1.3.13"
+
+gemspec path: "../"

data/gemfiles/rails_4.gemfile.lock

@@ -0,0 +1,128 @@
+PATH
+  remote: ..
+  specs:
+    setler (0.0.13)
+      activerecord (>= 3.0.0)
+      rails (>= 3.0.0)
+      sprockets (= 3.7.2)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    actionmailer (4.2.11.1)
+      actionpack (= 4.2.11.1)
+      actionview (= 4.2.11.1)
+      activejob (= 4.2.11.1)
+      mail (~> 2.5, >= 2.5.4)
+      rails-dom-testing (~> 1.0, >= 1.0.5)
+    actionpack (4.2.11.1)
+      actionview (= 4.2.11.1)
+      activesupport (= 4.2.11.1)
+      rack (~> 1.6)
+      rack-test (~> 0.6.2)
+      rails-dom-testing (~> 1.0, >= 1.0.5)
+      rails-html-sanitizer (~> 1.0, >= 1.0.2)
+    actionview (4.2.11.1)
+      activesupport (= 4.2.11.1)
+      builder (~> 3.1)
+      erubis (~> 2.7.0)
+      rails-dom-testing (~> 1.0, >= 1.0.5)
+      rails-html-sanitizer (~> 1.0, >= 1.0.3)
+    activejob (4.2.11.1)
+      activesupport (= 4.2.11.1)
+      globalid (>= 0.3.0)
+    activemodel (4.2.11.1)
+      activesupport (= 4.2.11.1)
+      builder (~> 3.1)
+    activerecord (4.2.11.1)
+      activemodel (= 4.2.11.1)
+      activesupport (= 4.2.11.1)
+      arel (~> 6.0)
+    activesupport (4.2.11.1)
+      i18n (~> 0.7)
+      minitest (~> 5.1)
+      thread_safe (~> 0.3, >= 0.3.4)
+      tzinfo (~> 1.1)
+    appraisal (2.2.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    arel (6.0.4)
+    builder (3.2.4)
+    concurrent-ruby (1.1.5)
+    crass (1.0.6)
+    docile (1.3.2)
+    erubis (2.7.0)
+    globalid (0.4.2)
+      activesupport (>= 4.2.0)
+    i18n (0.9.5)
+      concurrent-ruby (~> 1.0)
+    loofah (2.4.0)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.5.9)
+    mail (2.7.1)
+      mini_mime (>= 0.1.1)
+    mini_mime (1.0.2)
+    mini_portile2 (2.4.0)
+    minitest (5.14.0)
+    nokogiri (1.10.7)
+      mini_portile2 (~> 2.4.0)
+    rack (1.6.13)
+    rack-test (0.6.3)
+      rack (>= 1.0)
+    rails (4.2.11.1)
+      actionmailer (= 4.2.11.1)
+      actionpack (= 4.2.11.1)
+      actionview (= 4.2.11.1)
+      activejob (= 4.2.11.1)
+      activemodel (= 4.2.11.1)
+      activerecord (= 4.2.11.1)
+      activesupport (= 4.2.11.1)
+      bundler (>= 1.3.0, < 2.0)
+      railties (= 4.2.11.1)
+      sprockets-rails
+    rails-deprecated_sanitizer (1.0.3)
+      activesupport (>= 4.2.0.alpha)
+    rails-dom-testing (1.0.9)
+      activesupport (>= 4.2.0, < 5.0)
+      nokogiri (~> 1.6)
+      rails-deprecated_sanitizer (>= 1.0.1)
+    rails-html-sanitizer (1.3.0)
+      loofah (~> 2.3)
+    railties (4.2.11.1)
+      actionpack (= 4.2.11.1)
+      activesupport (= 4.2.11.1)
+      rake (>= 0.8.7)
+      thor (>= 0.18.1, < 2.0)
+    rake (13.0.1)
+    simplecov (0.18.1)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11.0)
+    simplecov-html (0.11.0)
+    sprockets (3.7.2)
+      concurrent-ruby (~> 1.0)
+      rack (> 1, < 3)
+    sprockets-rails (3.2.1)
+      actionpack (>= 4.0)
+      activesupport (>= 4.0)
+      sprockets (>= 3.0.0)
+    sqlite3 (1.3.13)
+    thor (1.0.1)
+    thread_safe (0.3.6)
+    tzinfo (1.2.6)
+      thread_safe (~> 0.1)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  appraisal
+  minitest
+  rails (= 4.2.11.1)
+  rake
+  setler!
+  simplecov
+  sqlite3 (= 1.3.13)
+
+BUNDLED WITH
+   1.17.3

data/gemfiles/rails_5.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "5.2.3"
+gem "sqlite3"
+
+gemspec path: "../"

data/gemfiles/rails_5.gemfile.lock

@@ -0,0 +1,143 @@
+PATH
+  remote: ..
+  specs:
+    setler (0.0.13)
+      activerecord (>= 3.0.0)
+      rails (>= 3.0.0)
+      sprockets (= 3.7.2)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    actioncable (5.2.3)
+      actionpack (= 5.2.3)
+      nio4r (~> 2.0)
+      websocket-driver (>= 0.6.1)
+    actionmailer (5.2.3)
+      actionpack (= 5.2.3)
+      actionview (= 5.2.3)
+      activejob (= 5.2.3)
+      mail (~> 2.5, >= 2.5.4)
+      rails-dom-testing (~> 2.0)
+    actionpack (5.2.3)
+      actionview (= 5.2.3)
+      activesupport (= 5.2.3)
+      rack (~> 2.0)
+      rack-test (>= 0.6.3)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.0.2)
+    actionview (5.2.3)
+      activesupport (= 5.2.3)
+      builder (~> 3.1)
+      erubi (~> 1.4)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.0.3)
+    activejob (5.2.3)
+      activesupport (= 5.2.3)
+      globalid (>= 0.3.6)
+    activemodel (5.2.3)
+      activesupport (= 5.2.3)
+    activerecord (5.2.3)
+      activemodel (= 5.2.3)
+      activesupport (= 5.2.3)
+      arel (>= 9.0)
+    activestorage (5.2.3)
+      actionpack (= 5.2.3)
+      activerecord (= 5.2.3)
+      marcel (~> 0.3.1)
+    activesupport (5.2.3)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 0.7, < 2)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+    appraisal (2.2.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    arel (9.0.0)
+    builder (3.2.4)
+    concurrent-ruby (1.1.5)
+    crass (1.0.6)
+    docile (1.3.2)
+    erubi (1.9.0)
+    globalid (0.4.2)
+      activesupport (>= 4.2.0)
+    i18n (1.8.2)
+      concurrent-ruby (~> 1.0)
+    loofah (2.4.0)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.5.9)
+    mail (2.7.1)
+      mini_mime (>= 0.1.1)
+    marcel (0.3.3)
+      mimemagic (~> 0.3.2)
+    method_source (0.9.2)
+    mimemagic (0.3.4)
+    mini_mime (1.0.2)
+    mini_portile2 (2.4.0)
+    minitest (5.14.0)
+    nio4r (2.5.2)
+    nokogiri (1.10.7)
+      mini_portile2 (~> 2.4.0)
+    rack (2.2.1)
+    rack-test (1.1.0)
+      rack (>= 1.0, < 3)
+    rails (5.2.3)
+      actioncable (= 5.2.3)
+      actionmailer (= 5.2.3)
+      actionpack (= 5.2.3)
+      actionview (= 5.2.3)
+      activejob (= 5.2.3)
+      activemodel (= 5.2.3)
+      activerecord (= 5.2.3)
+      activestorage (= 5.2.3)
+      activesupport (= 5.2.3)
+      bundler (>= 1.3.0)
+      railties (= 5.2.3)
+      sprockets-rails (>= 2.0.0)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
+    rails-html-sanitizer (1.3.0)
+      loofah (~> 2.3)
+    railties (5.2.3)
+      actionpack (= 5.2.3)
+      activesupport (= 5.2.3)
+      method_source
+      rake (>= 0.8.7)
+      thor (>= 0.19.0, < 2.0)
+    rake (13.0.1)
+    simplecov (0.18.1)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11.0)
+    simplecov-html (0.11.0)
+    sprockets (3.7.2)
+      concurrent-ruby (~> 1.0)
+      rack (> 1, < 3)
+    sprockets-rails (3.2.1)
+      actionpack (>= 4.0)
+      activesupport (>= 4.0)
+      sprockets (>= 3.0.0)
+    sqlite3 (1.4.2)
+    thor (1.0.1)
+    thread_safe (0.3.6)
+    tzinfo (1.2.6)
+      thread_safe (~> 0.1)
+    websocket-driver (0.7.1)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.4)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  appraisal
+  minitest
+  rails (= 5.2.3)
+  rake
+  setler!
+  simplecov
+  sqlite3
+
+BUNDLED WITH
+   1.17.3

data/gemfiles/rails_6_edge.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", git: "https://github.com/rails/rails"
+gem "sqlite3"
+
+gemspec path: "../"

data/gemfiles/rails_6_edge.gemfile.lock

@@ -0,0 +1,167 @@
+GIT
+  remote: https://github.com/rails/rails
+  revision: c77a949299fcddd0f6f35d9bc21888b862ff665c
+  specs:
+    actioncable (6.1.0.alpha)
+      actionpack (= 6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+      nio4r (~> 2.0)
+      websocket-driver (>= 0.6.1)
+    actionmailbox (6.1.0.alpha)
+      actionpack (= 6.1.0.alpha)
+      activejob (= 6.1.0.alpha)
+      activerecord (= 6.1.0.alpha)
+      activestorage (= 6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+      mail (>= 2.7.1)
+    actionmailer (6.1.0.alpha)
+      actionpack (= 6.1.0.alpha)
+      actionview (= 6.1.0.alpha)
+      activejob (= 6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+      mail (~> 2.5, >= 2.5.4)
+      rails-dom-testing (~> 2.0)
+    actionpack (6.1.0.alpha)
+      actionview (= 6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+      rack (~> 2.0, >= 2.0.8)
+      rack-test (>= 0.6.3)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.2.0)
+    actiontext (6.1.0.alpha)
+      actionpack (= 6.1.0.alpha)
+      activerecord (= 6.1.0.alpha)
+      activestorage (= 6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+      nokogiri (>= 1.8.5)
+    actionview (6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+      builder (~> 3.1)
+      erubi (~> 1.4)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.1, >= 1.2.0)
+    activejob (6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+      globalid (>= 0.3.6)
+    activemodel (6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+    activerecord (6.1.0.alpha)
+      activemodel (= 6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+    activestorage (6.1.0.alpha)
+      actionpack (= 6.1.0.alpha)
+      activejob (= 6.1.0.alpha)
+      activerecord (= 6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+      marcel (~> 0.3.1)
+    activesupport (6.1.0.alpha)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 1.6, < 2)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+      zeitwerk (~> 2.2, >= 2.2.2)
+    rails (6.1.0.alpha)
+      actioncable (= 6.1.0.alpha)
+      actionmailbox (= 6.1.0.alpha)
+      actionmailer (= 6.1.0.alpha)
+      actionpack (= 6.1.0.alpha)
+      actiontext (= 6.1.0.alpha)
+      actionview (= 6.1.0.alpha)
+      activejob (= 6.1.0.alpha)
+      activemodel (= 6.1.0.alpha)
+      activerecord (= 6.1.0.alpha)
+      activestorage (= 6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+      bundler (>= 1.3.0)
+      railties (= 6.1.0.alpha)
+      sprockets-rails (>= 2.0.0)
+    railties (6.1.0.alpha)
+      actionpack (= 6.1.0.alpha)
+      activesupport (= 6.1.0.alpha)
+      method_source
+      rake (>= 0.8.7)
+      thor (~> 1.0)
+
+PATH
+  remote: ..
+  specs:
+    setler (0.0.13)
+      activerecord (>= 3.0.0)
+      rails (>= 3.0.0)
+      sprockets (= 3.7.2)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    appraisal (2.2.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    builder (3.2.4)
+    concurrent-ruby (1.1.5)
+    crass (1.0.6)
+    docile (1.3.2)
+    erubi (1.9.0)
+    globalid (0.4.2)
+      activesupport (>= 4.2.0)
+    i18n (1.8.2)
+      concurrent-ruby (~> 1.0)
+    loofah (2.4.0)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.5.9)
+    mail (2.7.1)
+      mini_mime (>= 0.1.1)
+    marcel (0.3.3)
+      mimemagic (~> 0.3.2)
+    method_source (0.9.2)
+    mimemagic (0.3.4)
+    mini_mime (1.0.2)
+    mini_portile2 (2.4.0)
+    minitest (5.14.0)
+    nio4r (2.5.2)
+    nokogiri (1.10.7)
+      mini_portile2 (~> 2.4.0)
+    rack (2.2.1)
+    rack-test (1.1.0)
+      rack (>= 1.0, < 3)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
+    rails-html-sanitizer (1.3.0)
+      loofah (~> 2.3)
+    rake (13.0.1)
+    simplecov (0.18.1)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11.0)
+    simplecov-html (0.11.0)
+    sprockets (3.7.2)
+      concurrent-ruby (~> 1.0)
+      rack (> 1, < 3)
+    sprockets-rails (3.2.1)
+      actionpack (>= 4.0)
+      activesupport (>= 4.0)
+      sprockets (>= 3.0.0)
+    sqlite3 (1.4.2)
+    thor (1.0.1)
+    thread_safe (0.3.6)
+    tzinfo (1.2.6)
+      thread_safe (~> 0.1)
+    websocket-driver (0.7.1)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.4)
+    zeitwerk (2.2.2)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  appraisal
+  minitest
+  rails!
+  rake
+  setler!
+  simplecov
+  sqlite3
+
+BUNDLED WITH
+   1.17.3

data/lib/generators/setler/templates/migration.rb

@@ -9,6 +9,7 @@ class SetlerCreate<%= table_name.camelize %> < ActiveRecord::Migration
     end
 
     add_index :<%= table_name %>, [ :thing_type, :thing_id, :var ], unique: true
+    add_index :<%= table_name %>, :var, unique: true, where: "thing_id IS NULL AND thing_type is NULL"
   end
 
   def self.down

data/lib/setler/settings.rb

@@ -48,11 +48,19 @@ module Setler
       # thing_scoped.find_or_create_by_var(method_name[0..-2]) should work but doesnt for some reason
       # When @object is present, thing_scoped sets the where scope for the polymorphic association
       # but the find_or_create_by wasn't using the thing_type and thing_id
-      thing_scoped.find_or_create_by(
-        var: var.to_s,
-        thing_type: @object.try(:class).try(:base_class).try(:to_s),
-        thing_id: @object.try(:id)
-      ).update_attributes({ :value => value })
+      if Rails::VERSION::MAJOR == 3
+        thing_scoped.find_or_create_by_var_and_thing_type_and_thing_id(
+          var.to_s,
+          @object.try(:class).try(:base_class).try(:to_s),
+          @object.try(:id)
+        ).update({ :value => value })
+      else
+        thing_scoped.find_or_create_by(
+          var: var.to_s,
+          thing_type: @object.try(:class).try(:base_class).try(:to_s),
+          thing_id: @object.try(:id)
+        ).update({ :value => value })
+      end
     end
 
     def self.destroy(var_name)

data/lib/setler/version.rb

@@ -1,3 +1,3 @@
 module Setler
-  VERSION = "0.0.13"
+  VERSION = "0.0.14"
 end

data/setler.gemspec

@@ -7,12 +7,11 @@ Gem::Specification.new do |s|
   s.version     = Setler::VERSION
   s.authors     = ["Chris Kelly"]
   s.email       = ["ckdake@ckdake.com"]
+  s.license     = 'MIT'
   s.homepage    = "https://github.com/ckdake/setler"
   s.summary     = %q{Settler lets you use the 'Feature Flags' pettern or add settings to models.}
   s.description = %q{Setler is a Gem that lets one easily implement the "Feature Flags" pattern, or add settings to individual models. This is a cleanroom implementation of what the 'rails-settings' gem does. It's been forked all over the place, and my favorite version of it doesn't have any tests and doesn't work with settings associated with models.}
 
-  s.rubyforge_project = "setler"
-
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
@@ -20,8 +19,10 @@ Gem::Specification.new do |s|
 
   s.add_dependency('activerecord', '>=3.0.0')
   s.add_dependency('rails',        '>=3.0.0')
+  s.add_dependency('sprockets',    '3.7.2') # 10/16/2019: LOCKED DOWN
 
-  s.add_development_dependency('sqlite3')
   s.add_development_dependency('rake')
   s.add_development_dependency('minitest')
+  s.add_development_dependency('simplecov')
+  s.add_development_dependency('appraisal')
 end

data/test/settings_test.rb

@@ -60,7 +60,7 @@ class ::SettingsTest < Minitest::Test
   def test_update_with_nil_and_default_not_nil
     ::Settings.defaults[:foo] = :test
     ::Settings.foo = nil
-    assert_equal nil, ::Settings.foo
+    assert_nil ::Settings.foo
   end
 
   def test_update_with_array_syntax
@@ -76,8 +76,20 @@ class ::SettingsTest < Minitest::Test
     assert_equal '123', ::Settings.onetwothree
   end
 
+  def test_multithreaded_create
+    s1 = Settings.new var: :conflict, value: 1
+    s2 = Settings.new var: :conflict, value: 2
+    s1.save!
+    exc = assert_raises ActiveRecord::RecordNotUnique, ActiveRecord::StatementInvalid do
+        s2.save!
+    end
+    unless exc.is_a?(ActiveRecord::RecordNotUnique)
+      assert exc.message.match(/UNIQUE/)
+    end
+  end
+
   def test_complex_serialization
-    complex = [1, '2', {:three => true}]
+    complex = [1, '2', {"three" => true}]
     ::Settings.complex = complex
     assert_equal complex, ::Settings.complex
   end

data/test/test_helper.rb

@@ -1,5 +1,8 @@
 require 'rubygems'
 
+require 'simplecov'
+SimpleCov.start 'rails'
+
 require 'bundler'
 begin
   Bundler.setup(:default, :development)
@@ -34,18 +37,20 @@ def setup_db
       t.text   :value, :null => true
       t.integer :thing_id, :null => true
       t.string :thing_type, :limit => 30, :null => true
-      t.timestamps
+      t.timestamps null: false
     end
     add_index :settings, [ :thing_type, :thing_id, :var ], :unique => true
+    add_index :settings, :var, unique: true, where: "thing_id IS NULL AND thing_type is NULL"
 
     create_table :preferences do |t|
       t.string :var, :null => false
       t.text   :value, :null => true
       t.integer :thing_id, :null => true
       t.string :thing_type, :limit => 30, :null => true
-      t.timestamps
+      t.timestamps null: false
     end
     add_index :preferences, [ :thing_type, :thing_id, :var ], :unique => true
+    add_index :preferences, :var, unique: true, where: "thing_id IS NULL AND thing_type is NULL"
 
     create_table :users do |t|
       t.string :name

metadata

@@ -1,83 +1,111 @@
 --- !ruby/object:Gem::Specification
 name: setler
 version: !ruby/object:Gem::Version
-  version: 0.0.13
+  version: 0.0.14
 platform: ruby
 authors:
 - Chris Kelly
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2014-06-26 00:00:00.000000000 Z
+date: 2021-11-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: sprockets
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.7.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.7.2
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: appraisal
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Setler is a Gem that lets one easily implement the "Feature Flags" pattern,
@@ -91,15 +119,22 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .ruby-gemset
-- .ruby-version
-- .travis.yml
+- ".gitignore"
+- ".ruby-gemset"
+- ".ruby-version"
+- ".travis.yml"
+- Appraisals
 - Gemfile
 - MIT-LICENSE
 - README.rdoc
 - Rakefile
 - contributors.txt
+- gemfiles/rails_4.gemfile
+- gemfiles/rails_4.gemfile.lock
+- gemfiles/rails_5.gemfile
+- gemfiles/rails_5.gemfile.lock
+- gemfiles/rails_6_edge.gemfile
+- gemfiles/rails_6_edge.gemfile.lock
 - lib/generators/setler/setler_generator.rb
 - lib/generators/setler/templates/migration.rb
 - lib/generators/setler/templates/model.rb
@@ -113,26 +148,26 @@ files:
 - test/settings_test.rb
 - test/test_helper.rb
 homepage: https://github.com/ckdake/setler
-licenses: []
+licenses:
+- MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: setler
-rubygems_version: 2.2.2
-signing_key: 
+rubygems_version: 3.2.22
+signing_key:
 specification_version: 4
 summary: Settler lets you use the 'Feature Flags' pettern or add settings to models.
 test_files: