session_tracker 0.0.2 → 0.0.3

data/README.md

@@ -32,6 +32,8 @@ Then to view the current state:
 
 If redis is accessible through $redis, you don't have to give it as an argument to SessionTracker.new.
 
+Read the spec and/or code to see how it works.
+
 ## Contributing
 
 1. Fork it

data/lib/session_tracker/version.rb

@@ -1,3 +1,3 @@
 class SessionTracker
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/session_tracker.rb

@@ -18,14 +18,14 @@ class SessionTracker
     # so we don't want to raise errors just because redis is down for a few seconds.
   end
 
-  def active_users(time = Time.now)
-    @redis.sunion(*keys_for_last_3_minutes(time)).size
+  def active_users(timespan_in_minutes = 5, time = Time.now)
+    @redis.sunion(*keys_within(timespan_in_minutes, time)).size
   end
 
   private
   
-  def keys_for_last_3_minutes(time)
-    times = 0.upto(2).map { |n| time - (n * 60) }
+  def keys_within(minutes, time)
+    times = 0.upto(minutes - 1).map { |n| time - (n * 60) }
     times.map { |t| key_for(t) }
   end
 

data/spec/session_tracker_spec.rb

@@ -44,14 +44,21 @@ describe SessionTracker, "active_users" do
 
   let(:redis) { mock.as_null_object }
 
-  it "should do a union on the last 3 minutes to get a active user count" do
+  it "should do a union on the last 5 minutes to get a active user count" do
     time = Time.parse("13:09")
     redis.should_receive(:sunion).with("active_customer_sessions_minute_09",
                                        "active_customer_sessions_minute_08",
                                        "active_customer_sessions_minute_07").
                                        and_return([ mock, mock ])
 
-    SessionTracker.new("customer", redis).active_users(time).should == 2
+    SessionTracker.new("customer", redis).active_users(3, time).should == 2
+  end
+
+  it "should use a default time span of 5 minutes" do
+    redis.should_receive(:sunion).with(anything, anything, anything,
+                                       anything, anything).and_return([ mock, mock ])
+
+    SessionTracker.new("customer", redis).active_users.should == 2
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: session_tracker
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-02-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2160370920 !ruby/object:Gem::Requirement
+  requirement: &2156132780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2160370920
+  version_requirements: *2156132780
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2160370440 !ruby/object:Gem::Requirement
+  requirement: &2156132280 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2160370440
+  version_requirements: *2156132280
 - !ruby/object:Gem::Dependency
   name: guard
-  requirement: &2160370020 !ruby/object:Gem::Requirement
+  requirement: &2156131740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2160370020
+  version_requirements: *2156131740
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  requirement: &2160369580 !ruby/object:Gem::Requirement
+  requirement: &2156131260 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +54,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2160369580
+  version_requirements: *2156131260
 description: Track active user sessions in redis
 email:
 - joakim.kolsjo@gmail.com