servizio 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 813806f66607dba01c96b178f0ccde49ff28e845
-  data.tar.gz: 30fba7afa7b7d808ceb021b84e490215b698ad4a
+  metadata.gz: e88521b5ae99b6b45c50f81766f39dfeb2223bd7
+  data.tar.gz: a0e981be9e716218e3e1598a8288dcb8829670ea
 SHA512:
-  metadata.gz: 3cf60f0f2d1fa2fb171ba95c40a1776e8eb4413d760e50895cfc9edf254009682c519950f43a43c799b981a2232af9aa555dc15cbe1859a77c660327605f177a
-  data.tar.gz: e77581b8dc72c5d940b21221972192e799c84bae43c996b4cbf44bf712b453e04ca997b8d5d39c97aef50f432b5d90dcbfba403293f7ca91c10b5d157f75fdb9
+  metadata.gz: b880b1b89e6dc594ffa754c123819e7d46f3e328907986e9ef147f3e72ee2cf5ff2c1bca9b9cd1b1316ce8a8574249a12e3e9a8eaacb083e388af4d2bee02f48
+  data.tar.gz: d3e740be6edff8b103fcd9a1427549a11152b0915f82359b213ee5d5f064fd3d2c4672df8bd5cda4c68c688b82421909ddc5fd3dbe4b4863c23427a0b7a01c9b

data/Gemfile

@@ -3,9 +3,16 @@ source "https://rubygems.org"
 # Specify your gem's dependencies in servizio.gemspec
 gemspec
 
-gem "codeclimate-test-reporter", group: :test, require: nil
+if !ENV["CI"]
+  group :development do
+    gem "pry",                "~> 0.9.12.6"
+    gem "pry-byebug",         "<= 1.3.2"
+    gem "pry-rescue",         "~> 1.4.1"
+    gem "pry-stack_explorer", "~> 0.4.9.1"
+    gem "pry-syntax-hacks",   "~> 0.0.6"
+  end
+end
 
-gem "pry",                "~> 0.9.12.6"
-gem 'pry-byebug',         "<= 1.3.2"
-gem "pry-stack_explorer", "~> 0.4.9.1"
-gem "pry-syntax-hacks",   "~> 0.0.6"
+group :test do
+  gem "codeclimate-test-reporter", require: nil
+end

data/README.md

@@ -3,6 +3,7 @@
 [![Build Status](https://travis-ci.org/msievers/servizio.svg?branch=master)](https://travis-ci.org/msievers/servizio)
 [![Test Coverage](https://codeclimate.com/github/msievers/servizio/badges/coverage.svg)](https://codeclimate.com/github/msievers/servizio)
 [![Code Climate](https://codeclimate.com/github/msievers/servizio/badges/gpa.svg)](https://codeclimate.com/github/msievers/servizio)
+[![Dependency Status](https://gemnasium.com/msievers/servizio.svg)](https://gemnasium.com/msievers/servizio)
 
 Servizio is a gem to support you creating service objects. It was created after I read a blog post about [service objects](http://brewhouse.io/blog/2014/04/30/gourmet-service-objects.html) from [Philippe Creux](https://twitter.com/pcreux). Realy great post, check it out.
 
@@ -27,7 +28,7 @@ end
 operation = MyService.new(operands: [1,2,3])
 
 # call the operation and get it's result
-operation.call.result # => 6
+operation.call!.result # => 6
 ```
 
 ## Additional readings

data/lib/servizio/service.rb

@@ -6,6 +6,8 @@ class Servizio::Service
 
   attr_accessor :result
 
+  OperationFailedError = Class.new(StandardError)
+  OperationInvalidError = Class.new(StandardError)
   OperationNotCalledError = Class.new(StandardError)
 
   # http://stackoverflow.com/questions/14431723/activemodelvalidations-on-anonymous-class
@@ -13,6 +15,21 @@ class Servizio::Service
     super ? super : "__anonymous_servizio_service_class__"
   end
 
+  # shortcut to call operations, which returns the result and/or throws errors
+  def self.call(*args)
+    operation = self.new(*args)
+
+    if operation.valid?
+      if operation.call!.succeeded?
+        operation.result
+      else
+        raise Servizio::Service::OperationFailedError
+      end
+    else
+      raise Servizio::Service::OperationInvalidError
+    end
+  end
+
   def result
     called? ? @result : (raise OperationNotCalledError)
   end

data/lib/servizio/version.rb

@@ -1,3 +1,3 @@
 module Servizio
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/spec/servizio/service_spec.rb

@@ -1,26 +1,44 @@
 describe Servizio::Service do
-  context "if derived" do
-    let(:service) do
-      Class.new(described_class) do
-        attr_accessor :should_fail
-        attr_accessor :summands
+  let(:service) do
+    Class.new(described_class) do
+      attr_accessor :should_fail
+      attr_accessor :summands
 
-        validates_presence_of :summands
+      validates_presence_of :summands
 
-        def should_fail?
-          @should_fail == true
-        end
+      def should_fail?
+        @should_fail == true
+      end
 
-        def call
-          if should_fail?
-            errors.add(:call, "failed")
-          else
-            summands.reduce(:+)
-          end
+      def call
+        if should_fail?
+          errors.add(:call, "failed")
+        else
+          summands.reduce(:+)
         end
       end
     end
+  end
+
+  describe ".call" do
+    it "creates an instance of the service, calls it with the given arguments and returns the result" do
+      expect(service.call(summands: [1,2])).to eq(3)
+    end
+
+    context "if the operation is invalid" do
+      it "raises an error" do
+        expect { service.call }.to raise_error(Servizio::Service::OperationInvalidError)
+      end
+    end
 
+    context "if the operation did not succeeded" do
+      it "raises an error" do
+        expect { service.call(summands: [1,2], should_fail: true) }.to raise_error(Servizio::Service::OperationFailedError)
+      end
+    end
+  end
+
+  context "if derived" do
     let(:summands)             { [1,2,3] }
     let(:succeeding_operation) { service.new summands: summands }
     let(:failing_operation)    { service.new summands: summands, should_fail: true }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: servizio
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Michael Sievers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-04 00:00:00.000000000 Z
+date: 2015-02-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel