servicenow 1.1.2 → 1.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 50811eaebda4b3293c39dbca68a12552c79c1413
-  data.tar.gz: 7266d98a79d7c30d907b4fea252dd2b512ea2a3b
+  metadata.gz: 18c4645dd46a4043144d7f0f95a6283be65ad32f
+  data.tar.gz: cecb08079b14e3c1679d5cdf59c2ccbc944fd12c
 SHA512:
-  metadata.gz: b0da2932d8df63756bcf537956c036be0990d20eaef69a220421111d80282be0065ea72f1ad5ad3014f55f937221fc548bbb78d16a74a1d2e974f59e632c68e6
-  data.tar.gz: 66c93a9908078e34bf9e79a89f7c4a2a193250dc98769adf349c4b13b0e605bfb0b6e7597ad6b35551b7d10eb28af970a6404277c26c1923dd7d68f7e433a35d
+  metadata.gz: 6ad4abf79e426b25f34aad75c3fa39be3148ba1a8d98951c292690013d497a419820685af52eeca1fab190475d5b8a559d371d0cbecc2bb1728de6c84895401f
+  data.tar.gz: 57bd61e2b229770c7f354c38c767d362f9d5ec4cf807c08bc5cf4491a408e4c8f168d7ae19ec1836693130dc31e8d7e86021f9b14dba136b3ec5f6130ea7ff40

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 1.1.3
+
+* @maxy removed unused variable assignments
+* fixed readme and code climate integration
+* fixed additional rubocop offenses
+
 ## 1.1.2
 
 * fixed Rake test invocation, thanks @maxy

data/README.md

@@ -1,4 +1,4 @@
-# servicenow [![Build Status](https://travis-ci.org/rubyisbeautiful/servicenow.png)](https://travis-ci.org/rubyisbeautiful/servicenow)[![Code Climate](ht    tps://codeclimate.com/github/rubyisbeautiful/servicenow.png)](https://codeclimate.com/github/rubyisbeautiful/servicenow)
+# servicenow [![Build Status](https://travis-ci.org/rubyisbeautiful/servicenow.png)](https://travis-ci.org/rubyisbeautiful/servicenow)[![Code Climate](https://codeclimate.com/github/rubyisbeautiful/servicenow.png)](https://codeclimate.com/github/rubyisbeautiful/servicenow)
 This is a very simple, WIP REST API Client for ServiceNow.
 
 

data/Rakefile

@@ -7,4 +7,4 @@ Rake::TestTask.new(:test) do |t|
   t.test_files = FileList['test/**/test_*.rb']
 end
 
-task :default => :test
+task default: :test

data/lib/servicenow.rb

@@ -2,6 +2,9 @@ require 'servicenow/version'
 require 'servicenow/client'
 require 'servicenow/change'
 
+# This module is the base for the ServiceNow gem.  It's primary
+# interface consists of the 'configure', 'configuration'
+# and 'logger' methods
 module Servicenow
 
   @logger = nil
@@ -20,18 +23,14 @@ module Servicenow
   #
   # @yieldparam config [Servicenow::Configuration]
   def self.configure(&block)
-    if @configuration.nil?
-      @configuration = OpenStruct.new({})
-    end
+    @configuration = OpenStruct.new({}) if @configuration.nil?
     yield @configuration
   end
 
 
   # @return [Servicenow::Configuration]
   def self.configuration
-    if @configuration.nil?
-      @configuration = OpenStruct.new({})
-    end
+    @configuration = OpenStruct.new({}) if @configuration.nil?
     @configuration
   end
 
@@ -48,9 +47,7 @@ module Servicenow
   #
   # @return [Logger] the module logger
   def self.logger
-    if @logger.nil?
-      @logger = Logger.new(STDOUT)
-    end
+    @logger = Logger.new(STDOUT) if @logger.nil?
     @logger
   end
 

data/lib/servicenow/change.rb

@@ -2,6 +2,9 @@ require 'ostruct'
 
 module Servicenow
 
+  # This class represents a ServiceNow Change.  A Change is a local
+  # representation of the state of the remote.  For writing operations, the
+  # local is updated, and then a request to update the remote is sent
   class Change < OpenStruct
 
     @_client = nil
@@ -16,7 +19,7 @@ module Servicenow
         work_notes: notes
       }
 
-      response = client.send_request(url, query, :patch)
+      client.send_request(url, query, :patch)
       change
     end
 
@@ -33,7 +36,7 @@ module Servicenow
         work_start: Time.now.utc
       }.merge(extra)
 
-      response = client.send_request(url, query, :patch)
+      client.send_request(url, query, :patch)
       change
     end
 
@@ -50,7 +53,7 @@ module Servicenow
         work_end: Time.now.utc
       }.merge(extra)
 
-      response = client.send_request(url, query, :patch)
+      client.send_request(url, query, :patch)
       change
     end
 
@@ -70,9 +73,7 @@ module Servicenow
 
 
     def client
-      if @_client.nil?
-        @_client = Servicenow::Client.new
-      end
+      @_client = Servicenow::Client.new if @_client.nil?
       @_client
     end
 
@@ -83,7 +84,7 @@ module Servicenow
         'work in progress' => 2,
         'work complete' => 11,
         'work incomplete' => 4,
-        'waiting on user' => -5,
+        'waiting on user' => -5
       }
     end
 

data/lib/servicenow/client.rb

@@ -4,6 +4,7 @@ require 'json'
 
 module Servicenow
 
+  # Client is the client to interact with the ServiceNow REST API
   class Client
 
     attr_reader :snow_api_base_url, :snow_table_url
@@ -42,8 +43,8 @@ module Servicenow
     def get_changes_by_user(user_id)
       url = format('%s/change_request', @snow_table_url)
       query = {
-          sysparm_limit: 10,
-          sysparm_query: "active=true^GOTOu_cr_requester.u_name_idLIKE#{user_id}"
+        sysparm_limit: 10,
+        sysparm_query: "active=true^GOTOu_cr_requester.u_name_idLIKE#{user_id}"
       }
 
       response = send_request(url, query)
@@ -61,9 +62,9 @@ module Servicenow
     def get_changes_by_query(encodedquery, limit=10, page=1)
       url = format('%s/change_request', @snow_table_url)
       query = {
-          sysparm_limit: limit,
-          sysparm_page: page,
-          sysparm_query: encodedquery
+        sysparm_limit: limit,
+        sysparm_page: page,
+        sysparm_query: encodedquery
       }
 
       response = send_request(url, query)
@@ -80,8 +81,8 @@ module Servicenow
     def get_change(number)
       url = format('%s/change_request', @snow_table_url)
       query = {
-          sysparm_limit: 1,
-          number: number
+        sysparm_limit: 1,
+        number: number
       } 
 
       response = send_request(url, query)

data/lib/servicenow/version.rb

@@ -1,3 +1,3 @@
 module Servicenow
-  VERSION = '1.1.2'
+  VERSION = '1.1.3'.freeze
 end

data/servicenow.gemspec

@@ -1,5 +1,4 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 require 'base64'
@@ -11,8 +10,8 @@ Gem::Specification.new do |spec|
   spec.authors       = ['rubyisbeautiful']
   spec.email         = ['YmNwdGF5bG9yQGdtYWlsLmNvbQ==\n'].collect{ |foo| Base64.decode64(foo) }
 
-  spec.summary       = %q{Simple WIP REST API client for ServiceNow}
-  spec.description   = %q{This REST API client for ServiceNow is a work in progress}
+  spec.summary       = 'Simple WIP REST API client for ServiceNow'
+  spec.description   = 'This REST API client for ServiceNow is a work in progress'
   spec.homepage      = 'https://github.com/rubyisbeautiful/servicenow'
   spec.license       = 'MIT'
 
@@ -25,7 +24,7 @@ Gem::Specification.new do |spec|
       'public gem pushes.'
   end
 
-  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+  spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
   spec.bindir        = 'exe'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: servicenow
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 1.1.3
 platform: ruby
 authors:
 - rubyisbeautiful