service_it 1.2.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f3f5602ec47b3704b58581e2367192e409ff098a3232f25d925cf1256f82d434
-  data.tar.gz: a9c85fe22387bcca449b0242905f204e2b30473c6259246cf345341c549712f5
+  metadata.gz: 242be73eac2e2beb31caa752a64e14b3df89a8d5d1e86171ed0ebd17108363eb
+  data.tar.gz: f9bf6a0a347ea667a1b1d057edc866db2a7c720699bd2227ff251f71a1e212c7
 SHA512:
-  metadata.gz: df4426ddc277a66097a73e40228e722fffcb69c9e114041143936f1c377fa98d440651bacf4f20d8a06e62fff1a2a769bcd66395657aa959ad7b5a47c64aa9ff
-  data.tar.gz: 2d356875f6f388617705b4b8f6799a616a8046553385f3c0da94b087f4b077d1dbf7bba7e43792fe495aa1e89040c067a8351f0dae19ee74190d3cb3beb4151c
+  metadata.gz: 63383bbf3934b6a25a3ed4bef403c0e21ad2c35abb5ba81914cd6fa010fa602d948e9868927a981ed0e0870df0767c5bf304bf8297f419d7c8bfb496950445e4
+  data.tar.gz: d44619f576bfb329151a241f40f589ff0c54248faf0bc9dce9b229bf0095a79cd6cc432feaf6ac95f3d11f9ce40483b49b84b982e3f4b57714493a8ccfe7a7ca

data/README.md

@@ -1,5 +1,5 @@
 # ServiceIt
-[![Gem Version](https://badge.fury.io/rb/service_it.svg)](https://badge.fury.io/rb/service_it) [![Build Status](https://travis-ci.org/iago-silva/service_it.svg?branch=master)](https://travis-ci.org/iago-silva/service_it) [![Code Climate](https://codeclimate.com/github/iago-silva/service_it.png)](https://codeclimate.com/github/iago-silva/service_it) [![Test Coverage](https://api.codeclimate.com/v1/badges/fcc8375ebe8fa5412381/test_coverage)](https://codeclimate.com/github/iago-silva/service_it/test_coverage)
+[![Gem Version](https://badge.fury.io/rb/service_it.svg)](https://badge.fury.io/rb/service_it) [![Build Status](https://travis-ci.org/iago-silva/service_it.svg?branch=master)](https://travis-ci.org/iago-silva/service_it) [![Code Climate](https://codeclimate.com/github/iago-silva/service_it.png)](https://codeclimate.com/github/iago-silva/service_it) 
 
 Its benefit is to facilitate the creation of Service Objects, providing you the basic and enough to have a complete one and letting you free to use on your own way.
 
@@ -49,7 +49,7 @@ class Foo < ServiceIt::Base
 end
 ```
 
-Call your service from anywhere
+Call your service from anywhere (controllers, models, migrations, ...)
 
 ```ruby
 Foo.call(foo: foo, bar: bar)
@@ -59,48 +59,8 @@ Foo.call(foo: foo, bar: bar)
 
 Simple example to release a _POST_
 
-* Before
-
-```ruby
-# app/controllers/post_releases_controller.rb
-class PostReleasesController < ApplicationController
-
-  # [...]
-
-  def update
-    @post.prepare_to_release                      # <--
-    if @post.update(released_at: Date.current)    # <--
-      # [...]
-    else
-      # [...]
-    end
-  end
-
-  # [...]
-
-end
-
-```
-
-* After
-
 ```ruby
-# app/controllers/post_releases_controller.rb
-class PostReleasesController < ApplicationController
-
-  # [...]
-
-  def update
-    if ReleasePost.call(post: @post)    # <--
-      # [...]
-    else
-      # [...]
-    end
-  end
-
-  # [...]
-
-end
+ReleasePost.call(post: @post)
 ```
 
 ```ruby

data/lib/service_it/base.rb

@@ -6,6 +6,8 @@ module ServiceIt
   # Documentation:
   #   https://github.com/iago-silva/service_it
   class Base
+    private_class_method :new
+
     # Call your service
     #
     # Example:
@@ -21,7 +23,10 @@ module ServiceIt
     end
 
     def initialize(args)
-      args.each { |key, value| set_private_ivar(key, value) }
+      args.each do |key, value|
+        define_ivar(key, value)
+        define_private_reader(key)
+      end
     end
 
     # Implement this method to run your service
@@ -32,9 +37,11 @@ module ServiceIt
 
     private
 
-    def set_private_ivar(key, value)
+    def define_ivar(key, value)
       instance_variable_set("@#{key}", value)
+    end
 
+    def define_private_reader(key)
       self.class.class_eval do
         private
 

data/lib/service_it/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ServiceIt
-  VERSION = '1.2.0'.freeze
+  VERSION = '2.0.0'
 end

data/spec/service_it/base_spec.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+describe ServiceIt::Base do
+  context 'when calls new method' do
+    subject { described_class.new }
+
+    it 'raises NoMethodError exception' do
+      expect { subject }.to raise_error(NoMethodError)
+    end
+  end
+
+  describe SayMyName do
+    context 'when I ask what is my name' do
+      subject { described_class.call(name: name) }
+
+      let(:name) { 'Heisenberg' }
+
+      it 'says Heisenberg' do
+        expect(subject).to eq(name)
+      end
+    end
+  end
+
+  describe MissedPerformService do
+    context 'when perform method is not defined' do
+      subject { described_class.call }
+
+      it 'raises NotImplementedError exception' do
+        expect { subject }.to raise_error(NotImplementedError)
+      end
+    end
+  end
+end

data/spec/service_it_spec.rb

@@ -1,22 +1,7 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-
 describe ServiceIt do
-  describe SayMyName do
-    let(:name) { 'Heisenberg' }
-
-    it 'says Heisenberg' do
-      result = SayMyName.call(name: name)
-      expect(result).to eq(name)
-    end
-  end
-
-  context 'when perform method is not defined' do
-    it 'raises an NotImplementedError exception' do
-      expect do
-        MissedPerformService.call
-      end.to raise_error(NotImplementedError)
-    end
+  it 'has a version number' do
+    expect(ServiceIt::VERSION).not_to be nil
   end
 end

data/spec/spec_helper.rb

@@ -3,11 +3,5 @@
 $LOAD_PATH.unshift File.expand_path('../lib', __dir__)
 
 require 'service_it'
-require 'simplecov'
 
-Dir['./spec/support/**/*.rb'].each { |f| require f }
-
-SimpleCov.minimum_coverage 100
-SimpleCov.start do
-  add_filter '/spec/'
-end
+Dir['./spec/support/**/*.rb'].sort.each { |f| require f }

data/spec/support/test_classes.rb

@@ -6,5 +6,4 @@ class SayMyName < ServiceIt::Base
   end
 end
 
-class MissedPerformService < ServiceIt::Base
-end
+class MissedPerformService < ServiceIt::Base; end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: service_it
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Iago Silva
@@ -10,52 +10,67 @@ bindir: bin
 cert_chain: []
 date: 2018-07-27 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.13.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.13.1
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.10.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.10.0
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.5.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.5.1
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.0.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.0.1
 description: |-
   Service objects are a holy grail to keep your controllers and
                     models slim and readable
-email: iago.silva@interage.in
+email:
+- iago.cith@hotmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -67,13 +82,16 @@ files:
 - lib/service_it.rb
 - lib/service_it/base.rb
 - lib/service_it/version.rb
+- spec/service_it/base_spec.rb
 - spec/service_it_spec.rb
 - spec/spec_helper.rb
 - spec/support/test_classes.rb
 homepage: https://github.com/iago-silva/service_it
 licenses:
 - MIT
-metadata: {}
+metadata:
+  homepage_uri: https://github.com/iago-silva/service_it
+  source_code_uri: https://github.com/iago-silva/service_it
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -82,19 +100,19 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.9
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Simple gem to keep your controllers and models slim and readable
 test_files:
-- spec/spec_helper.rb
 - spec/service_it_spec.rb
 - spec/support/test_classes.rb
+- spec/service_it/base_spec.rb
+- spec/spec_helper.rb