serum-rails 0.1.1 → 0.2.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    YzI5ZTAwNWNjNjViNGM2ZmIwNzY2MTBjNTVmMzBhMjczNzk5ZDk2ZA==
-  data.tar.gz: !binary |-
-    ZTM4NGM0MGI4N2YyM2YxN2VkNTliN2I1MGMxNWJjM2YyOWVjYjgyZg==
-!binary "U0hBNTEy":
-  metadata.gz: !binary |-
-    MTY0MGU0NzM2ZTI5YjhmMjA2YzQ3N2RiZTBhMzEzMmQ3OTJkYmQxZGI2NWNm
-    MWUzMGRkNGJlYWE1NzliMjNkZDc3NDE0OTM2MzYzZGMwNmI2ZjgyZjdjYzVh
-    NjNiZGI1YzJlM2FkZjgyYTRjYmZlM2I5ZmViNWQwMzZjM2NjYjc=
-  data.tar.gz: !binary |-
-    NmJmMzM3ZTFiNDI4ODM3NzY2NjE0MWYyZDE0N2Q4Y2Y2YTVkODkxMDlmYzgz
-    Njg2ODUzZGM2NmVkMTJlMmMwYzM2M2JlNTE3OTJmYTZiMDEyNjhjNDZkOTNl
-    YzFkNjU4YjgxMmU3Yjg3ZGJmYzIzMDhhMzgxNzdjOGYzNWY2MmE=
+SHA1:
+  metadata.gz: 8618c5eef15c29da8d226c626b0ccdac8ddc952a
+  data.tar.gz: f575327bf6556db01f79fc950cbe98c16211ae12
+SHA512:
+  metadata.gz: a2f95adfded11edc85309746f3c851fe0425fbdc913f2c701164fcce6f28ebf9b61972b05a4acabe958049b7dced8227de7562b4b2b74f084efc372aefab8da6
+  data.tar.gz: a050d3fb43e62e375a6a1196e789149656f9840a25106d1be8cb6641ecc1e0fa4344479f0fddd2a69130c1e4c134576c1a69186b72d7f98e260ab885f230a9bd

data/.ruby-version

@@ -0,0 +1,2 @@
+2.1.2
+

data/Gemfile.lock

@@ -1,22 +1,22 @@
 PATH
   remote: .
   specs:
-    serum-rails (0.1.1)
+    serum-rails (0.2.0)
       activesupport (>= 3.2)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (4.0.5)
+    activesupport (4.1.4)
       i18n (~> 0.6, >= 0.6.9)
-      minitest (~> 4.2)
-      multi_json (~> 1.3)
+      json (~> 1.7, >= 1.7.7)
+      minitest (~> 5.1)
       thread_safe (~> 0.1)
-      tzinfo (~> 0.3.37)
+      tzinfo (~> 1.1)
     diff-lcs (1.2.5)
-    i18n (0.6.9)
-    minitest (4.7.5)
-    multi_json (1.10.0)
+    i18n (0.6.11)
+    json (1.8.1)
+    minitest (5.4.1)
     rake (10.3.1)
     rspec (3.0.0)
       rspec-core (~> 3.0.0)
@@ -30,8 +30,9 @@ GEM
     rspec-mocks (3.0.4)
       rspec-support (~> 3.0.0)
     rspec-support (3.0.4)
-    thread_safe (0.3.3)
-    tzinfo (0.3.39)
+    thread_safe (0.3.4)
+    tzinfo (1.2.2)
+      thread_safe (~> 0.1)
 
 PLATFORMS
   ruby

data/lib/serum/rails/app.rb

@@ -21,8 +21,28 @@ module Serum
 
       delegate :count_lines, :to => :code_scanner
 
+      def count_routes
+        Dir.chdir(@root) do
+          run_command('bundle exec rake routes').split(/\n/).size - 1
+        end
+      end
+
+      def count_gems
+        Dir.chdir(@root) do
+          run_command('bundle list').split(/\n/).size - 1
+        end
+      end
+
       private
 
+      def run_command(cmd)
+        Bundler.with_clean_env do
+          result = `#{cmd}`
+          $?.success? or raise "Error while running command: #{cmd}"
+          result
+        end
+      end
+
       def ensure_root_exists
         File.directory?(@root) or raise "Not a directory: #{@root}"
       end

data/lib/serum/rails/metrics.rb

@@ -2,8 +2,6 @@ module Serum
   module Rails
     class Metrics
 
-      FRACTION_PRIVATE_CONTROLLER_METHODS = 0.2
-
       class << self
 
         attr_reader :metrics
@@ -29,14 +27,12 @@ module Serum
         )
       end
 
-      metric :controller_actions do
-        count = @app.count_lines(
+      metric :controller_methods do
+        @app.count_lines(
           :pattern => /\bdef\b/,
           :types => [:ruby],
           :folders => 'app/controllers'
         )
-        count *= (1 - FRACTION_PRIVATE_CONTROLLER_METHODS)
-        count.round
       end
 
       #metric :gem_count do
@@ -104,6 +100,14 @@ module Serum
         @app.lines_of_code
       end
 
+      metric :routes do
+        @app.count_routes
+      end
+
+      metric :gems do
+        @app.count_gems
+      end
+
       def to_hash
         hash = {}
         self.class.metrics.sort_by(&:to_s).each do |metric|

data/lib/serum/rails/version.rb

@@ -1,7 +1,7 @@
 module Serum
   module Rails
 
-    VERSION = '0.1.1'
+    VERSION = '0.2.0'
 
   end
-end
+end

data/spec/serum/rails/metrics_spec.rb

@@ -2,86 +2,97 @@
 # through the example application in spec/test_app
 describe Serum::Rails::Metrics do
 
-  let(:root) { 'spec/test_app' }
+  let(:rails_2_3_metrics) { Serum::Rails::Metrics.new('spec/test_apps/rails-2-3') }
+  let(:rails_4_1_metrics) { Serum::Rails::Metrics.new('spec/test_apps/rails-4-1') }
 
-  subject { Serum::Rails::Metrics.new(root) }
+  describe '#routes' do
+    it 'should count the occurrences' do
+      expect(rails_4_1_metrics.routes).to eq(11)
+    end
+  end
+
+  describe '#gems' do
+    it 'should count the occurrences' do
+      expect(rails_4_1_metrics.gems).to eq(47)
+    end
+  end
 
   describe '#unescaped_strings' do
     it 'should count the occurrences' do
-      expect(subject.unescaped_strings).to eq(17)
+      expect(rails_2_3_metrics.unescaped_strings).to eq(17)
     end
   end
 
-  describe '#controller_actions' do
+  describe '#controller_methods' do
     it 'should count the occurrences' do
-      expect(subject.controller_actions).to eq((94 * 0.8).round) # we ignore some fraction for private methods
+      expect(rails_2_3_metrics.controller_methods).to eq(94)
     end
   end
 
   describe '#uploaders' do
     it 'should count the occurrences' do
-      expect(subject.uploaders).to eq(2)
+      expect(rails_2_3_metrics.uploaders).to eq(2)
     end
   end
 
   describe '#crypto_terms' do
     it 'should count the occurrences' do
-      expect(subject.crypto_terms).to eq(17)
+      expect(rails_2_3_metrics.crypto_terms).to eq(17)
     end
   end
 
   describe '#cookie_accesses' do
     it 'should count the occurrences' do
-      expect(subject.cookie_accesses).to eq(5)
+      expect(rails_2_3_metrics.cookie_accesses).to eq(5)
     end
   end
 
   describe '#file_accesses' do
     it 'should count the occurrences' do
-      expect(subject.file_accesses).to eq(33)
+      expect(rails_2_3_metrics.file_accesses).to eq(33)
     end
   end
 
   describe '#mailer_invocations' do
     it 'should count the occurrences' do
-      expect(subject.mailer_invocations).to eq(4)
+      expect(rails_2_3_metrics.mailer_invocations).to eq(4)
     end
   end
 
   describe '#redirects' do
     it 'should count the occurrences' do
-      expect(subject.redirects).to eq(15)
+      expect(rails_2_3_metrics.redirects).to eq(15)
     end
   end
 
   describe '#json_outputs' do
     it 'should count the occurrences' do
-      expect(subject.json_outputs).to eq(2)
+      expect(rails_2_3_metrics.json_outputs).to eq(2)
     end
   end
 
   describe '#yaml_inputs' do
     it 'should count the occurrences' do
-      expect(subject.yaml_inputs).to eq(3)
+      expect(rails_2_3_metrics.yaml_inputs).to eq(3)
     end
   end
 
   describe '#lines_of_code' do
     it 'should count the occurrences' do
-      expect(subject.lines_of_code).to eq(12627)
+      expect(rails_2_3_metrics.lines_of_code).to eq(12627)
     end
   end
 
   #describe '#lines_of_ruby_code' do
-  #  expect(subject.lines_of_ruby_code).to eq(123)
+  #  expect(rails_2_3_metrics.lines_of_ruby_code).to eq(123)
   #end
   #
   #describe '#lines_of_view_code' do
-  #  expect(subject.lines_of_view_code).to eq(123)
+  #  expect(rails_2_3_metrics.lines_of_view_code).to eq(123)
   #end
   #
   #describe '#lines_of_javascript_code' do
-  #  expect(subject.lines_of_javascript_code).to eq(123)
+  #  expect(rails_2_3_metrics.lines_of_javascript_code).to eq(123)
   #end
 
 end