serialize_attributes 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9264e3f62465ae9a4a27bf3afa14fa9cd516d14eab7b93e316c56d6cfb88ab4b
-  data.tar.gz: 69bf1f4d1ccf209aabee4bb0ee5f128cc6ff93c3bb59dbbe295b39517c2cd5d7
+  metadata.gz: fcfd75fcff7e883cb0063752bb35de287b4683c59e0029bf654d77b0e67b7ec0
+  data.tar.gz: adc7cc26ba5b6dca8b543a2a33960419c66cd37149a5e759bdfc820f131fbe60
 SHA512:
-  metadata.gz: 045a9d1d63e862b7eadb8372d68c002ae2c1c6cf32b00157c5c97d9970012f3c82c5d944a4cc55a632a693c7241875e9355953586d23d262f9355f61f1afc3bc
-  data.tar.gz: d9992e49647e63d28b44d5c29e2c74936e7ee1fc305243c92bed744d579142c05c0475c26ce976cbce079f4ba29a67a48cd2cbd43729872daac337ecc45aefd7
+  metadata.gz: f160a8efe020f2d47d385f3c2ea76149adcf2d6eff06dd6d9b49e08e0684e7fa1cbcd4abb7e6c8f8ea3d25cebed1c888a2aa7bbb42d4a7fff5f0c5ec30d08d67
+  data.tar.gz: a58b02f33d14bd4afa8202a7d69553377ecf2fc2b9b4c011fbc5fdf2ff8460628dc8675d8ad883bfedb98e810779597a3afbe4f01347a9014baa5189d0223afb

data/lib/serialize_attributes/store.rb

@@ -150,6 +150,18 @@ module SerializeAttributes
       def deserialize(value)
         Array.wrap(value).map { __getobj__.deserialize(_1) }
       end
+
+      # For arrays of strings (the most common array type), the underlying Type::String in
+      # Rails won't do this check if the raw value isn't a String (and returns `nil`):
+      #
+      #   def changed_in_place?(a, b)
+      #     if a.is_a?(String)
+      #       ...
+      #
+      # This means we have to override this check ourselves here.
+      def changed_in_place?(raw_old_value, new_value)
+        raw_old_value != new_value
+      end
     end
 
     class AttributeSet < ::ActiveModel::AttributeSet # :nodoc:
@@ -176,7 +188,7 @@ module SerializeAttributes
       end
 
       def changed_in_place?(raw_original_value, new_value)
-        AttributeSet.new(raw_original_value) != new_value
+        (deserialize(raw_original_value) != new_value) || new_value.each_value.any?(&:changed_in_place?)
       end
 
       def serialize(value)

data/lib/serialize_attributes/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SerializeAttributes
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: serialize_attributes
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Zaikio
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-10-17 00:00:00.000000000 Z
+date: 2022-10-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel