serialist 0.5.2 → 1.0.0

data/VERSION

@@ -1 +1 @@
-0.5.2
+1.0.0

data/lib/serialist/serialist_module.rb

@@ -18,6 +18,8 @@ module Serialist
         include Serialist::InstanceMethods
       else
         @serialist_options.each do |field|
+          cols = self.columns.map{|c|c.name.to_s}
+          raise Exception.new("Column #{field} already exist for #{self.name}") if cols.include?(field.to_s)
           define_method field.to_s do 
             return nil unless (slug = self.send(serialist_field))
             slug[field.to_sym]
@@ -46,17 +48,19 @@ module Serialist
   end
   
   module InstanceMethods
-    
     def attributes=(new_attributes, guard_protected_attributes = true)
-      return if new_attributes.nil?
+      return if new_attributes.nil? 
       attributes = new_attributes.dup
       attributes.stringify_keys!
       attributes.each do |k, v|
-        unless k.include?("(") || respond_to?(:"#{k}=")
+        unless k.include?("(") || respond_to?(:"#{k}")
           self.class.send(:define_method, :"#{k}=") do |param|
             self.send(self.class.serialist_field.to_s + "=", Hash.new) unless self.send(self.class.serialist_field)
             self.send(self.class.serialist_field)[k.to_sym] = param
           end
+          self.class.send(:define_method, :"#{k}") do 
+            self.send(self.class.serialist_field)[k.to_sym]
+          end
         end
       end
       super

data/serialist.gemspec

@@ -1,15 +1,15 @@
 # Generated by jeweler
-# DO NOT EDIT THIS FILE
-# Instead, edit Jeweler::Tasks in Rakefile, and run `rake gemspec`
+# DO NOT EDIT THIS FILE DIRECTLY
+# Instead, edit Jeweler::Tasks in Rakefile, and run the gemspec command
 # -*- encoding: utf-8 -*-
 
 Gem::Specification.new do |s|
   s.name = %q{serialist}
-  s.version = "0.5.2"
+  s.version = "1.0.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Benoit B\303\251n\303\251zech"]
-  s.date = %q{2009-09-17}
+  s.date = %q{2009-10-27}
   s.description = %q{Serialize any data, set and fetch it like any column attributes}
   s.email = %q{benoit.benezech@gmail.com}
   s.extra_rdoc_files = [
@@ -32,18 +32,15 @@ Gem::Specification.new do |s|
      "rails/init.rb",
      "serialist.gemspec",
      "tasks/acts_as_serializable_tasks.rake",
-     "test/acts_as_serializable_test.rb",
-     "test/test_helper.rb",
      "uninstall.rb"
   ]
   s.homepage = %q{http://github.com/bbenezech/serialist}
   s.rdoc_options = ["--charset=UTF-8"]
   s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.3.4}
+  s.rubygems_version = %q{1.3.5}
   s.summary = %q{Serialize any data, set and fetch it like any column attributes}
   s.test_files = [
-    "test/acts_as_serializable_test.rb",
-     "test/test_helper.rb"
+    "test/serialist_test.rb"
   ]
 
   if s.respond_to? :specification_version then
@@ -56,3 +53,4 @@ Gem::Specification.new do |s|
   else
   end
 end
+

data/test/serialist_test.rb

@@ -0,0 +1,178 @@
+require 'test/unit'
+ 
+require 'rubygems'
+gem 'activerecord'
+require 'active_record'
+RAILS_ROOT = File.dirname(__FILE__)
+$: << File.join(File.dirname(__FILE__), '../lib') 
+require File.join(File.dirname(__FILE__), '../init')
+ 
+ActiveRecord::Base.establish_connection(:adapter => "sqlite3", :database => "acts_as_url.sqlite3")
+ 
+ActiveRecord::Migration.verbose = false
+ActiveRecord::Schema.define(:version => 1) do
+  create_table :serialisted_table, :force => true do |t|
+    t.string :title
+    t.string :type
+    t.text :slug
+    t.text :slug2
+  end
+end
+ActiveRecord::Migration.verbose = true
+ 
+class SerialistedLazy < ActiveRecord::Base
+  def self.table_name 
+    :serialisted_table
+  end
+  serialist :slug
+  validates_presence_of :foo
+end
+
+class SerialistedDeclarative < ActiveRecord::Base
+  def self.table_name 
+    :serialisted_table
+  end
+  serialist :slug, [:foo, :bar]
+  validates_presence_of :foo
+end
+
+class SubSerialistedLazy1 < SerialistedLazy
+end
+class SubSerialistedLazy2 < SerialistedLazy
+  serialist :slug, [:foo, :bar]
+end
+
+class SubSerialistedDeclarative1 < SerialistedDeclarative
+end
+class SubSerialistedDeclarative2 < SerialistedDeclarative
+  serialist :slug, [:foo, :baz]
+end
+
+
+class LazyRegressionTestClass < ActiveRecord::Base
+  def self.table_name 
+    :serialisted_table
+  end
+  validates_presence_of :title
+  serialist :slug
+  
+  def title_fun
+    title.reverse
+  end
+  
+end
+
+class DeclarativeRegressionTestClass < ActiveRecord::Base
+  def self.table_name 
+    :serialisted_table
+  end
+  validates_presence_of :title
+  serialist :slug, [:foo, :bar]
+  
+  def title_fun
+    title.reverse
+  end
+end
+
+
+class SerialistTest < Test::Unit::TestCase
+  # lazy
+  def test_should_serialize_lazily
+    @serialisted = SerialistedLazy.create!({:foo => "foo", :bar => "bar"})
+    assert_equal @serialisted.slug[:foo], "foo"
+    assert_equal @serialisted.foo, "foo"
+    assert_equal @serialisted.foo?, true
+    @serialisted.foo = "foo2"
+    @serialisted.save
+    @serialisted.reload
+    assert_equal @serialisted.foo, "foo2"
+    @serialisted.bar = nil
+    @serialisted.save
+    @serialisted.reload
+    assert_equal @serialisted.bar?, false
+  end
+  
+  # declarative
+  def test_should_be_serialisted_declaratively
+    @serialisted = SerialistedDeclarative.create!({:foo => "foo", :bar => "bar"})
+    assert_equal @serialisted.slug[:foo], "foo"
+    assert_equal @serialisted.foo, "foo"
+    assert_equal @serialisted.foo?, true
+    @serialisted.foo = "foo2"
+    @serialisted.save
+    @serialisted.reload
+    assert_equal @serialisted.foo, "foo2"
+    @serialisted.bar = nil
+    @serialisted.save
+    @serialisted.reload
+    assert_equal @serialisted.bar?, false
+  end
+  
+  def test_should_not_serialize_unknown_attributes_when_serialisted_declaratively
+    assert_raise ActiveRecord::UnknownAttributeError do
+       SerialistedDeclarative.create({:foo => "legit", :baz => "not legit"})
+    end
+    @serialisted = SerialistedDeclarative.create!({:foo => "legit"})
+    assert_raise NoMethodError do
+      @serialisted.baz = "not legit"
+    end
+  end
+  
+  # STI tests.
+  
+  # test {:foo, :bar} + {} => {:foo, :bar}
+  def test_STI_classes_should_inherit_serialist_declarative_declaration
+    @serialisted = SubSerialistedDeclarative1.create!({:foo => "foo", :bar => "bar"})
+    assert_equal @serialisted.foo, "foo"
+  end
+  
+  # test {:foo, :bar} + {:foo, :baz} => {:foo, :bar, :baz}
+  def test_declarative_serialisted_STI_classes_should_inherit_serialist_declarative_declaration
+    @serialisted = SubSerialistedDeclarative2.create!({:foo => "foo", :bar => "bar", :baz => "baz"})
+    assert_equal @serialisted.foo, "foo"
+    assert_equal @serialisted.bar, "bar"
+    assert_equal @serialisted.baz, "baz"
+    # but anyway :
+    assert_raise ActiveRecord::UnknownAttributeError do
+      SubSerialistedDeclarative2.create!({:catz => "dogz"})
+    end
+    assert_raise NoMethodError do
+      @serialisted.catz
+    end
+  end
+  
+  # test {:all} + {} => {:all}
+  def test_STI_classes_should_inherit_serialist_lazy_declaration
+    @serialisted = SubSerialistedLazy1.create!({:foo => "foo", :bar => "bar"})
+    assert_equal @serialisted.foo, "foo"
+  end
+
+  # test {:all} + {:foo, :bar} => {:all}
+  def test_declarative_serialisted_STI_classes_should_not_override_serialist_lazy_declaration    
+    @serialisted = SubSerialistedLazy2.create!({:foo => "foo", :bar => "bar", :baz => "baz"})
+    assert_equal @serialisted.baz, "baz"
+  end
+  
+  # non-regression test
+  def test_mass_assignement_to_lazily_serialisted_should_not_create_record_if_record_is_invalid
+    @serialisted = LazyRegressionTestClass.create({:foo => "foo", :bar => "bar"})
+    assert_equal @serialisted.new_record?, true
+    assert_nil @serialisted.id
+  end
+  
+  def test_mass_assignement_to_declarative_serialisted_should_not_create_record_if_record_is_invalid
+    @serialisted = DeclarativeRegressionTestClass.create({:foo => "foo", :bar => "bar"})
+    assert_equal @serialisted.new_record?, true
+    assert_nil @serialisted.id
+  end
+  
+  def test_lazily_serialist_should_not_try_to_override_existing_methods_and_columns
+    assert_raise ActiveRecord::UnknownAttributeError do
+      LazyRegressionTestClass.create!({:foo => "foo", :bar => "bar", :title => "hoho", :title_fun => "haha"})
+    end
+    @serialisted = LazyRegressionTestClass.create!({:foo => "foo", :bar => "bar", :title => "hoho"})
+    assert_nil @serialisted.slug[:title]
+    assert_equal @serialisted.title, "hoho"
+    assert_equal @serialisted.title_fun, "ohoh"
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: serialist
 version: !ruby/object:Gem::Version 
-  version: 0.5.2
+  version: 1.0.0
 platform: ruby
 authors: 
 - "Benoit B\xC3\xA9n\xC3\xA9zech"
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-09-17 00:00:00 +02:00
+date: 2009-10-27 00:00:00 +01:00
 default_executable: 
 dependencies: []
 
@@ -38,8 +38,6 @@ files:
 - rails/init.rb
 - serialist.gemspec
 - tasks/acts_as_serializable_tasks.rake
-- test/acts_as_serializable_test.rb
-- test/test_helper.rb
 - uninstall.rb
 has_rdoc: true
 homepage: http://github.com/bbenezech/serialist
@@ -65,10 +63,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.4
+rubygems_version: 1.3.5
 signing_key: 
 specification_version: 3
 summary: Serialize any data, set and fetch it like any column attributes
 test_files: 
-- test/acts_as_serializable_test.rb
-- test/test_helper.rb
+- test/serialist_test.rb

data/test/acts_as_serializable_test.rb

@@ -1,8 +0,0 @@
-require 'test_helper'
-
-class ActsAsSerializableTest < ActiveSupport::TestCase
-  # Replace this with your real tests.
-  test "the truth" do
-    assert true
-  end
-end

data/test/test_helper.rb

@@ -1,3 +0,0 @@
-require 'rubygems'
-require 'active_support'
-require 'active_support/test_case'