serial_preference 1.1.1 → 1.1.2

data/lib/serial_preference/has_preference_map.rb

@@ -34,17 +34,17 @@ module SerialPreference
 
           key = preference.name
           define_method("#{key}=") do |value|
-            write_preference_attribute(_preferences_attribute,key,self.class.preference_definition(key).value(value))
+            write_preference_attribute(self.class._preferences_attribute,key,self.class.preference_definition(key).value(value))
           end
 
           define_method(key) do
-            value = read_preference_attribute(_preferences_attribute,key)
+            value = read_preference_attribute(self.class._preferences_attribute,key)
             self.class.preference_definition(key).value(value)
           end
 
           if preference.boolean?
             define_method("#{key}?") do
-              read_preference_attribute(_preferences_attribute,key).present?
+              read_preference_attribute(self.class._preferences_attribute,key).present?
             end
           end
 
@@ -56,14 +56,14 @@ module SerialPreference
 
     def read_preference_attribute(store_attribute, key)
       attribute = send(store_attribute)
-      attribute[key]
+      attribute[key.to_sym]
     end
 
     def write_preference_attribute(store_attribute, key, value)
       attribute = send(store_attribute)
       if value != attribute[key]
         send :"#{store_attribute}_will_change!"
-        attribute[key] = value
+        attribute[key.to_sym] = value
       end
     end
 

data/lib/serial_preference/version.rb

@@ -1,3 +1,3 @@
 module SerialPreference
-  VERSION = "1.1.1"
+  VERSION = "1.1.2"
 end

data/spec/has_preference_map_spec.rb

@@ -43,6 +43,12 @@ describe SerialPreference::HasSerialPreferences do
       d.respond_to?(:write_preference_attribute).should be_true
     end
 
+    it "should ensure that the readers returns the correct data" do
+      d = DummyClass.new
+      d.preferences = {:vat_no => "abc"}
+      d.vat_no.should eq("abc")
+    end
+
     it "should have writers available" do
       d = DummyClass.new
       d.respond_to?(:taxable=).should be_true
@@ -51,12 +57,27 @@ describe SerialPreference::HasSerialPreferences do
       d.respond_to?(:income_ledger_id=).should be_true
     end
 
+    it "should ensure that the writer write the correct data" do
+      d = DummyClass.new
+      d.vat_no = "abc"
+      d.vat_no.should eq("abc")
+    end
+
+    it "should ensure that the querier the correct data" do
+      d = DummyClass.new
+      d.taxable = true
+      d.should be_taxable
+      d.taxable = false
+      d.should_not be_taxable
+    end
+
     it "should have query methods available for booleans" do
       DummyClass.new.respond_to?(:taxable?)
     end
-
   end
 
+
+
 =begin
   context "should define validations" do
     it "should define presence validation on required preferences" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: serial_preference
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -130,7 +130,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -808331589467144063
+      hash: 4541839474087512825
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -139,7 +139,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -808331589467144063
+      hash: 4541839474087512825
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24