seri 1.0.2 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5adc32c82dea64e690e2a39b2b2dd1cbfc5bcd8816a8d34d271cd14d71edfd95
-  data.tar.gz: 5415cb4b3ac84b365ad4dd34bb81dc3d3edc9d12697556b31078d74bc4a574c8
+  metadata.gz: '090b3dd7fc4be4bb07693768f57ae5b050a6227c893237d58ab278418ae5fd6b'
+  data.tar.gz: 8f163f78cd03f5587d8a4817e79b08082c6ba14f2e8fc900dcf3fb6f49d310f2
 SHA512:
-  metadata.gz: 567a40baa057f07add6ad38aedaf6f04303e93a67d41e056a30f25adbd2ccb3580af5270f5ae15c6daf7db805f383aef191b1bd2754150f43965206073e688cc
-  data.tar.gz: aa5d0a9a533845d21dd9fc9a9e7538eed5bc88bbb06b361cb0ce6454f9ce32f14a990e2b9e8425061068a0970d049529d5dcddea3118a2759f66ac1d5afe17fd
+  metadata.gz: a31af8088e22f3dc4e6b26f77c59d8eee27c1e0f43084d4cb0c261dc6f61fe825a704636c751cc11aec63b6a4e7393148ff237c8ad3219d20976049e3a2a6489
+  data.tar.gz: df133caeaf514a0ff001c426a5e5078ec99bfc5177b57690ade401e06b2ff473ffe34b2f0aeea38e73a69ba5fe89625022ffc5d5a2185c13c2b85a4dd737463c

data/lib/serializer/value.rb

@@ -0,0 +1,58 @@
+class Value
+  def initialize(attribute, scope = nil)
+    @attribute = attribute
+    @scope = scope
+  end
+
+  def extraction_key
+    @attribute.from || @attribute.key
+  end
+
+  def precondition?
+    raise NotImplementedError, 'needs a method called precondition?'
+  end
+
+  def value
+    raise NotImplementedError, 'needs a method called value'
+  end
+end
+
+class StaticValue < Value
+  def precondition?
+    @attribute.options.key?(:static_value)
+  end
+
+  def value
+    @attribute.options.fetch(:static_value)
+  end
+end
+
+class SerializedValue < Value
+  def precondition?
+    @scope.respond_to?(extraction_key)
+  end
+
+  def value
+    @scope.public_send(extraction_key)
+  end
+end
+
+class HashValue < Value
+  def precondition?
+    @scope.is_a?(Hash) && @scope.key?(extraction_key)
+  end
+
+  def value
+    @scope.fetch(extraction_key)
+  end
+end
+
+class ObjectValue < Value
+  def precondition?
+    @scope.respond_to?(extraction_key)
+  end
+
+  def value
+    @scope.public_send(extraction_key)
+  end
+end

data/lib/serializer/value_fetcher.rb

@@ -0,0 +1,59 @@
+class ValueFetcher
+  class SerializerError < StandardError; end
+
+  ARRAYS = %w[
+    Array
+    ActiveRecord_AssociationRelation
+    ActiveRecord_Associations_CollectionProxy
+  ].freeze
+
+  def self.fetch(attribute, object, serializer)
+    new(attribute, object, serializer).fetch
+  end
+
+  private_class_method :new
+
+  def initialize(attribute, object, serializer)
+    @attribute = attribute
+    @values = [
+      StaticValue.new(attribute),
+      SerializedValue.new(attribute, serializer),
+      HashValue.new(attribute, object),
+      ObjectValue.new(attribute, object)
+    ]
+  end
+
+  def fetch
+    serializer = @attribute.serializer
+
+    return value unless serializer
+
+    if is_array?
+      value.map { |item| serializer.new(item).to_h }
+    else
+      serializer.new(value).to_h
+    end
+  end
+
+  # Fetches a value from an attribute by checking if there's a ..
+  # .. static value set, or a ..
+  # .. method defined in the serializer, or a ..
+  # .. method/attribute defined in the object or ..
+  # .. it raises an error
+  def value
+    @value ||= begin
+      extracted_value = @values.detect(&:precondition?)
+
+      if extracted_value.nil?
+        raise SerializerError,
+              "unknown attribute '#{@values[0].extraction_key}'"
+      end
+
+      extracted_value.value
+    end
+  end
+
+  def is_array?
+    ARRAYS.any? { |match| value.class.to_s.end_with?(match) }
+  end
+end

data/lib/serializer/version.rb

@@ -1,3 +1,3 @@
 class Serializer
-  VERSION = '1.0.2'.freeze
+  VERSION = '1.1.2'.freeze
 end

data/lib/serializer.rb

@@ -1,15 +1,9 @@
 require 'serializer/version'
+require 'serializer/value'
+require 'serializer/value_fetcher'
 require 'serializer/group_serializer'
 
 class Serializer
-  class SerializerError < StandardError; end
-
-  ARRAYS = %w[
-    Array
-    ActiveRecord_AssociationRelation
-    ActiveRecord_Associations_CollectionProxy
-  ].freeze
-
   Attribute = Struct.new(:key, :condition, :from, :serializer, :options)
 
   def self.attributes
@@ -32,7 +26,7 @@ class Serializer
     self.class.attributes.each_with_object({}) do |attribute, obj|
       next if attribute.condition && !public_send(attribute.condition)
 
-      obj[attribute.key] = serialize_value(attribute)
+      obj[attribute.key] = ValueFetcher.fetch(attribute, object, self)
     end
   end
 
@@ -41,38 +35,4 @@ class Serializer
       Oj.dump(to_h, mode: :json)
     end
   end
-
-  private
-
-  def serialize_value(attribute)
-    value = extract_value(attribute)
-    serializer = attribute.serializer
-
-    return value unless serializer
-
-    if ARRAYS.any? { |match| value.class.to_s.end_with?(match) }
-      value.map { |v| serializer.new(v).to_h }
-    else
-      serializer.new(value).to_h
-    end
-  end
-
-  # Fetches a value from an attribute by checking if there's a ..
-  # .. static value set, or a ..
-  # .. method defined in the serializer, or a ..
-  # .. method/attribute defined in the object or ..
-  # .. it raises an error
-  def extract_value(attribute)
-    extraction_key = attribute.from || attribute.key
-
-    if attribute.options.key?(:static_value)
-      attribute.options.fetch(:static_value)
-    elsif respond_to?(extraction_key)
-      public_send(extraction_key)
-    elsif object.respond_to?(extraction_key)
-      object.public_send(extraction_key)
-    else
-      raise SerializerError, "unknown attribute '#{extraction_key}'"
-    end
-  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: seri
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.2
 platform: ruby
 authors:
 - grdw
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-04-12 00:00:00.000000000 Z
+date: 2019-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: appsignal
@@ -116,6 +116,8 @@ files:
 - bin/setup
 - lib/serializer.rb
 - lib/serializer/group_serializer.rb
+- lib/serializer/value.rb
+- lib/serializer/value_fetcher.rb
 - lib/serializer/version.rb
 - seri.gemspec
 homepage: https://github.com/grdw/seri