sequra-style 1.9.0 → 1.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d4fbdb8adc90c530fbc5f62fb0619e920bda0e85fd44176eca0f9e9162dd0bc9
-  data.tar.gz: ff36093e496d8d23d922f0c612cff9fd5b6c488aba54f36fdd1e7be7c2b670cc
+  metadata.gz: ac36e918663e99576328aa7740655149cb2a44bdf26909a53d43eb1ff2a8d3aa
+  data.tar.gz: 2e490af77771f9bdcba719b988182c527d121dcc1a91037432f1dded77741836
 SHA512:
-  metadata.gz: 68ff7381c13b8d95b8ddbe2d22d1f8cb17e86fdb48041f67b6f985be42ad571ce9a3cfcb5f346a56734420086916dedb60b89cf790ae515fed5314dd6480906e
-  data.tar.gz: bf4881096eecf81ec3d4f3929b3d2f11168bbdc9767db1ab214deb5722b4b197b11485b9f9497d0e02c026a9f05b57dbedf6766e0d13cceeb5d952be1b4b9915
+  metadata.gz: 00117fdcaf8ba15aa5b69f6cc078705982dec612445f1bbee9ad314fc52bc5802c67623b5b4aae8b398f842c6787758f0c25d4556602823afc1cc1d5759e69af
+  data.tar.gz: 33983c2d39255eb9fc88d1f0de7558be7fcb7f7f204db7ffd5ac19b626bccf99000386808e2ec5695cf52a9de727a962dc7e2d3dcfaec8dc7d873265ac2064f0

data/.gitignore

@@ -6,3 +6,4 @@
 /pkg/
 /spec/reports/
 /tmp/
+.claude

data/.rubocop.yml

@@ -1,2 +1,5 @@
+require:
+  - ./lib/sequra_style
+
 inherit_from:
   - default.yml

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [1.10.0](https://github.com/sequra/sequra-style/compare/v1.9.0...v1.10.0) (2026-02-05)
+
+
+### Features
+
+* [COR-689] Add Sequra/AsyncJobPattern cop ([#57](https://github.com/sequra/sequra-style/issues/57)) ([fe8007f](https://github.com/sequra/sequra-style/commit/fe8007f2932670de3203ff1d486d4c2fc90b123c))
+
 ## [1.9.0](https://github.com/sequra/sequra-style/compare/v1.8.1...v1.9.0) (2026-01-29)
 
 

data/Gemfile.lock

@@ -1,52 +1,67 @@
 PATH
   remote: .
   specs:
-    sequra-style (1.9.0)
-      rubocop (~> 1)
-      rubocop-performance (~> 1)
-      rubocop-rails (~> 2)
-      rubocop-rspec (~> 2)
+    sequra-style (1.10.0)
+      rubocop (~> 1.75)
+      rubocop-performance (~> 1.25)
+      rubocop-rails (~> 2.31)
+      rubocop-rspec (~> 3.5)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (8.0.1)
+    activesupport (8.1.2)
       base64
-      benchmark (>= 0.3)
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.3.1)
       connection_pool (>= 2.2.5)
       drb
       i18n (>= 1.6, < 2)
+      json
       logger (>= 1.4.2)
       minitest (>= 5.1)
       securerandom (>= 0.3)
       tzinfo (~> 2.0, >= 2.0.5)
       uri (>= 0.13.1)
-    ast (2.4.2)
-    base64 (0.2.0)
-    benchmark (0.4.0)
-    bigdecimal (3.1.9)
-    concurrent-ruby (1.3.5)
-    connection_pool (2.5.0)
-    drb (2.2.1)
-    i18n (1.14.7)
+    ast (2.4.3)
+    base64 (0.3.0)
+    bigdecimal (4.0.1)
+    concurrent-ruby (1.3.6)
+    connection_pool (3.0.2)
+    diff-lcs (1.6.2)
+    drb (2.2.3)
+    i18n (1.14.8)
       concurrent-ruby (~> 1.0)
-    json (2.10.1)
-    language_server-protocol (3.17.0.4)
+    json (2.18.1)
+    language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
-    logger (1.6.6)
-    minitest (5.25.4)
-    parallel (1.26.3)
-    parser (3.3.7.1)
+    logger (1.7.0)
+    minitest (6.0.1)
+      prism (~> 1.5)
+    parallel (1.27.0)
+    parser (3.3.10.1)
       ast (~> 2.4.1)
       racc
+    prism (1.9.0)
     racc (1.8.1)
-    rack (3.0.0)
+    rack (3.2.4)
     rainbow (3.1.1)
     rake (13.0.6)
-    regexp_parser (2.10.0)
-    rubocop (1.73.0)
+    regexp_parser (2.11.3)
+    rspec (3.13.2)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.6)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.5)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.7)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.7)
+    rubocop (1.84.1)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
@@ -54,28 +69,33 @@ GEM
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.38.0, < 2.0)
+      rubocop-ast (>= 1.49.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.38.1)
-      parser (>= 3.3.1.0)
-    rubocop-performance (1.15.1)
-      rubocop (>= 1.7.0, < 2.0)
-      rubocop-ast (>= 0.4.0)
-    rubocop-rails (2.17.2)
+    rubocop-ast (1.49.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.7)
+    rubocop-performance (1.26.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.47.1, < 2.0)
+    rubocop-rails (2.34.3)
       activesupport (>= 4.2.0)
+      lint_roller (~> 1.1)
       rack (>= 1.1)
-      rubocop (>= 1.33.0, < 2.0)
-    rubocop-rspec (2.15.0)
-      rubocop (~> 1.33)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.44.0, < 2.0)
+    rubocop-rspec (3.9.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.81)
     ruby-progressbar (1.13.0)
     securerandom (0.4.1)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (3.1.4)
-      unicode-emoji (~> 4.0, >= 4.0.4)
-    unicode-emoji (4.0.4)
-    uri (1.0.3)
+    unicode-display_width (3.2.0)
+      unicode-emoji (~> 4.1)
+    unicode-emoji (4.2.0)
+    uri (1.1.1)
 
 PLATFORMS
   ruby
@@ -83,6 +103,7 @@ PLATFORMS
 DEPENDENCIES
   bundler (~> 2.1.4)
   rake (~> 13.0.1)
+  rspec (~> 3.13)
   sequra-style!
 
 BUNDLED WITH

data/default.yml

@@ -810,3 +810,17 @@ Style/TrivialAccessors:
 Style/WordArray:
   EnforcedStyle: brackets
   Enabled: true
+
+# Custom Sequra cops
+
+# Enforce async job pattern: each job should delegate to exactly one Operation
+# and stay within the maximum class length (10 lines).
+Sequra/AsyncJobPattern:
+  Enabled: true
+  Include:
+    - "app/jobs/**/*.rb"
+    - "app/workers/**/*.rb"
+    - "packs/*/app/jobs/**/*.rb"
+    - "packs/*/app/workers/**/*.rb"
+  Exclude:
+    - "**/application_job.rb"

data/lib/rubocop/cop/sequra/async_job_pattern.rb

@@ -0,0 +1,166 @@
+module RuboCop
+  module Cop
+    module Sequra
+      # Detects Sidekiq jobs that haven't adopted the ApplicationOperation pattern.
+      #
+      # A job is considered migrated when it meets ALL conditions:
+      # 1. Has exactly ONE `*Operation.call` invocation (delegates to single operation)
+      # 2. Class length ≤ 10 "smart lines" (using CountAsOne semantics)
+      #
+      # A job is considered unmigrated (offense) when:
+      # - Zero `Operation.call` → business logic lives in the job itself
+      # - Multiple `Operation.call` → job orchestrates multiple operations
+      # - Exceeds class length → job has too much logic beyond delegation
+      #
+      # @example
+      #   # bad - no operation delegation
+      #   class MyJob < ApplicationJob
+      #     def perform(id)
+      #       user = User.find(id)
+      #       user.update!(status: :active)
+      #       UserMailer.welcome(user).deliver_later
+      #     end
+      #   end
+      #
+      #   # bad - multiple operations
+      #   class MyJob < ApplicationJob
+      #     def perform(id, type)
+      #       if type == :a
+      #         OperationA.call(id: id)
+      #       else
+      #         OperationB.call(id: id)
+      #       end
+      #     end
+      #   end
+      #
+      #   # good - single operation delegation
+      #   class MyJob < ApplicationJob
+      #     def perform(id)
+      #       MyOperation.call(id:)
+      #     end
+      #   end
+      #
+      class AsyncJobPattern < Base
+        MSG = "Sidekiq job should delegate to exactly one Operation".freeze
+        MSG_CLASS_LENGTH = "Job has too much logic to be a simple Operation delegate. " \
+                           "Consider moving logic into the Operation".freeze
+
+        MAX_CLASS_LENGTH = 10
+        COUNT_AS_ONE = ["array", "hash", "heredoc", "method_call"].freeze
+        OPERATION_CLASS_PATTERN = /Operation$/
+
+        def_node_matcher :application_job_subclass?, <<~PATTERN
+          (class _ (const nil? :ApplicationJob) ...)
+        PATTERN
+
+        def_node_matcher :includes_sidekiq_worker?, <<~PATTERN
+          (send nil? :include (const (const nil? :Sidekiq) {:Worker :Job}))
+        PATTERN
+
+        def_node_matcher :operation_call?, <<~PATTERN
+          (send (const _ OPERATION_CLASS_PATTERN) :call ...)
+        PATTERN
+
+        def on_class(node)
+          return unless sidekiq_job?(node)
+
+          check_operation_delegation(node)
+          check_class_length(node)
+        end
+
+        private
+
+        def sidekiq_job?(node)
+          return true if application_job_subclass?(node)
+
+          node.body&.each_descendant(:send)&.any? { |send_node| includes_sidekiq_worker?(send_node) }
+        end
+
+        def check_operation_delegation(node)
+          operation_calls = find_operation_calls(node)
+
+          return if operation_calls.size == 1
+
+          add_offense(node.loc.name, message: MSG)
+        end
+
+        def find_operation_calls(node)
+          return [] unless node.body
+
+          node.body.each_descendant(:send).select { |send_node| operation_call?(send_node) }
+        end
+
+        def check_class_length(node)
+          return unless node.body
+
+          length = class_length(node)
+          return if length <= MAX_CLASS_LENGTH
+
+          add_offense(node.loc.keyword, message: MSG_CLASS_LENGTH)
+        end
+
+        def class_length(node)
+          return 0 unless node.body
+
+          body_lines = line_range(node.body)
+          count_lines(body_lines, node)
+        end
+
+        def line_range(node)
+          node.loc.first_line..node.loc.last_line
+        end
+
+        def count_lines(range, node)
+          source_lines = processed_source.lines[(range.begin - 1)..(range.end - 1)]
+          return 0 if source_lines.nil?
+
+          effective_lines = source_lines.reject { |line| irrelevant_line?(line) }
+
+          # Subtract lines that should count as one
+          count_as_one_adjustment = count_as_one_lines(node)
+
+          [effective_lines.size - count_as_one_adjustment, 0].max
+        end
+
+        def irrelevant_line?(line)
+          line.strip.empty? || line.strip.start_with?("#")
+        end
+
+        def count_as_one_lines(node)
+          adjustment = 0
+          return adjustment unless node.body
+
+          node.body.each_descendant do |descendant|
+            next unless count_as_one_node?(descendant)
+
+            lines = descendant.loc.last_line - descendant.loc.first_line
+            adjustment += lines if lines.positive?
+          end
+
+          adjustment
+        end
+
+        def count_as_one_node?(node)
+          COUNT_AS_ONE.any? { |type| node_matches_type?(node, type) }
+        end
+
+        def node_matches_type?(node, type)
+          case type
+          when "array" then node.array_type?
+          when "hash" then node.hash_type?
+          when "heredoc" then node.str_type? && node.heredoc?
+          when "method_call" then multiline_method_call?(node)
+          else false
+          end
+        end
+
+        def multiline_method_call?(node)
+          node.send_type? &&
+            node.loc.respond_to?(:selector) &&
+            node.loc.selector &&
+            node.loc.first_line != node.loc.last_line
+        end
+      end
+    end
+  end
+end

data/lib/sequra/style/version.rb

@@ -1,5 +1,5 @@
 module Sequra
   module Style
-    VERSION = "1.9.0"
+    VERSION = "1.10.0"
   end
 end

data/lib/sequra_style.rb

@@ -0,0 +1 @@
+require_relative "rubocop/cop/sequra/async_job_pattern"

data/sequra-style.gemspec

@@ -28,4 +28,5 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 2.1.4"
   spec.add_development_dependency "rake", "~> 13.0.1"
+  spec.add_development_dependency "rspec", "~> 3.13"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sequra-style
 version: !ruby/object:Gem::Version
-  version: 1.9.0
+  version: 1.10.0
 platform: ruby
 authors:
 - Sequra engineering
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-01-29 00:00:00.000000000 Z
+date: 2026-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -94,6 +94,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 13.0.1
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.13'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.13'
 description:
 email:
 - rubygems@sequra.es
@@ -120,8 +134,10 @@ files:
 - docs/decisions/README.md
 - docs/decisions/index.md
 - docs/decisions/template.md
+- lib/rubocop/cop/sequra/async_job_pattern.rb
 - lib/sequra/style.rb
 - lib/sequra/style/version.rb
+- lib/sequra_style.rb
 - sequra-style.gemspec
 homepage: https://github.com/sequra/sequra-style
 licenses: