sequitur 0.0.13 → 0.0.14

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    N2UxOWM5ZGY4OGM2YzY1NzRiOWU5OTRlNjVhOTJhNGJmM2FiZTE0Nw==
+    ZTMxYzgwZmZkMzg1YTYzMjEzZTA4Yzg0NWY2YTdkZjk2ODI2ZDVhYg==
   data.tar.gz: !binary |-
-    ZGYzMTZhNjIwMTRhMWNmYTNiMWUyOTdkMTFkMjU0NTU2YmE0OWU4Mg==
+    NTgxM2M1MjY2MzNkYmE0NjhhNzBkOTIwNDdmOGM0OWYwMjNkOGMwZA==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    MTdkNDI3MDMyMmRlOTNlOTViOGQ4ODY3YzdkMjY4MDJlNWJjNGQxZTllMTgx
-    MmIzZjA3MGVlNzRiNDU2NmJlYjFlNTZiYTlmOGE0YjFmYzY3NDYxOTk1Mzcy
-    YWYwMjljMjdkMmE0MGIzNjMyZThiYzJhMjA4NTA5ZDEwY2RkNDI=
+    NmI0YzAyNTRhYmRmODc5MTgwZmYyYWNmMzExMmRhM2FjNWI0OGQyOTYxZmRk
+    N2FkOTc2ZDU1Mzg3NjllN2M1ZmQyMDM2YWJjNGIzY2IwN2JjYzhiZjg2MGQ1
+    ZjcxYmQxYzAwYmFlOTc2MTRmMmU4YzJmMDk5ZDU5OTZkZWFlYjE=
   data.tar.gz: !binary |-
-    NTNmN2M5NTUyMjg2MTEyNDNhMjk2NWVmNDFiYmU0ZmVmM2E5NGIwZjM3MDRk
-    NjYwZTlhMWYyZjYzMjNiNzdlZWQyNmUwMzY2YTMxZTE0YjAwNDU1YmExNGU0
-    ODAzNjgzNzMyYzA5YzVmMmY2MjAxMTZiNWJkNTg1MzdiNzU4MjA=
+    NDU3NDUxZjA1NDg0Njg5MzYzMmM0MDRiMDIzOGY2ZTlmMDIwYWNlMjJjYTNm
+    ZjA0YTdhMjc0MTg3MTFkNjBmMWVlZTQzY2FlMDVmNjg5ODFmODMwNDMxY2U5
+    OGI3ZGI4ZDFjZDFhMzFjMTFjZTg5MWYzMzc3Y2QwZWIyNmFiZDU=

data/CHANGELOG.md

@@ -1,16 +1,20 @@
-### 0.0.13 / 2014-08-24
+### 0.0.14 / 2014-09-10
+* [CHANGE] Removal of invariant checking methods in `SequiturGrammar` class. These caused polynomial slowdown.
+
+
+### 0.0.13 / 2014-09-07
 * [CHANGE] Test coverage for all classes but SequiturGrammar is 100%
 
-### 0.0.12 / 2014-08-24
+### 0.0.12 / 2014-09-06
 * [CHANGE] Significant internal refactoring.
 * [CHANGE] Method `ObjectSpace::id2ref` is no more used => one obstacle to JRuby porting is removed.
 * [NEW] Added new class `ProductionReference`
 
-### 0.0.11 / 2014-08-24
+### 0.0.11 / 2014-08-26
 * [FIX] `SequiturGrammar#check_unicity`: an exception was raised when it shouldn't. Added example in spec file.
 * [CHANGE] `sequitur.rb` : Added the convenience Sequitur::build_from method.
 
-### 0.0.10 / 2014-08-24
+### 0.0.10 / 2014-08-25
 * [CHANGE] `README.md`: Added hyperlinks about Sequitur algorithm.
 
 ### 0.0.09 / 2014-08-24

data/lib/sequitur/constants.rb

@@ -3,7 +3,7 @@
 
 module Sequitur # Module used as a namespace
   # The version number of the gem.
-  Version = '0.0.13'
+  Version = '0.0.14'
 
   # Brief description of the gem.
   Description = 'Ruby implementation of the Sequitur algorithm'

data/lib/sequitur/sequitur_grammar.rb

@@ -28,28 +28,6 @@ class SequiturGrammar < DynamicGrammar
     super
   end
 
-  # Check the invariant:
-  # Every digram appearing in a rhs must occur at most once in the grammar.
-  def check_unicity()
-    all_digrams = {}
-    productions.each do |a_prod|
-      prod_digrams = a_prod.digrams
-      prod_digrams.each_with_index do |a_digram, index|
-        next if index && a_digram == a_prod.digrams[index - 1]
-        if all_digrams.include? a_digram.key
-          msg = "Digram #{a_digram.symbols} occurs twice!"
-          colliding = all_digrams[a_digram.key]
-          msg << "\nOnce in production #{colliding.production.object_id}"
-          msg << "\nSecond in production #{a_prod.object_id}"
-          msg << "\n#{to_string}"
-          fail StandardError, msg unless colliding == a_prod
-        else
-          all_digrams[a_digram.key] = a_digram
-        end
-      end
-    end
-  end
-
 
   private
 
@@ -77,7 +55,6 @@ class SequiturGrammar < DynamicGrammar
   end
 
   def append_symbol_to(aProduction, aSymbol)
-    check_digrams # TODO: remove this
     super
 
     prod_digrams = aProduction.digrams
@@ -131,8 +108,6 @@ class SequiturGrammar < DynamicGrammar
       aProduction.replace_digram(new_prod)
       add_production(new_prod)
       update_digrams_from(aProduction)
-      check_digrams # TODO: remove
-      check_unicity
     else
       # Duplicate digram used in distinct production
       # Two cases: other production is a single digram one or a multi-digram
@@ -151,7 +126,6 @@ class SequiturGrammar < DynamicGrammar
           preserve_unicity(aProduction)
         end
 
-        check_references # TODO: remove this
       else
         # aProduction, other_prod use both the same digram
         # Then create a new production with the digram as its rhs
@@ -168,11 +142,7 @@ class SequiturGrammar < DynamicGrammar
         # TODO: Check when aProduction and other_prod have same preceding symbol
         update_digrams_from(other_prod)
       end
-      check_unicity
     end
-
-    check_unicity
-    check_registered
   end
 
   # Rule utility: except for the root production, every production must occur
@@ -188,7 +158,6 @@ class SequiturGrammar < DynamicGrammar
   # Update digrams
   def enforce_rule_utility()
     return if productions.size < 2
-    check_references
 
     loop do
       all_refcount_ok = true
@@ -203,7 +172,6 @@ class SequiturGrammar < DynamicGrammar
         dependent.replace_production(productions[index])
         delete_production(index)
         update_digrams_from(dependent)
-        check_references
       end
 
       break if all_refcount_ok
@@ -232,88 +200,6 @@ class SequiturGrammar < DynamicGrammar
     end
   end
 
-  # Check the invariant:
-  # Every reference in a rhs that is bound must point
-  # to a production of the grammar.
-  def check_references()
-    productions.each do |a_prod|
-      rhs_prods = a_prod.references
-      rhs_prods.each do |a_reference|
-        next if a_reference.unbound?
-        referenced_prod = a_reference.production
-        next if productions.include? referenced_prod
-
-        msg = "Production #{a_prod.object_id} #{a_prod.to_string}"
-        msg << " references the unknown production #{referenced_prod.object_id}"
-        msg << "\nOrphan production: #{referenced_prod.to_string}"
-        msg << "\n#{to_string}"
-        fail StandardError, msg
-      end
-    end
-  end
-
-  # Check the invariant:
-  # Every registered digram must reference a production from the grammar
-  def check_registered()
-    digrams.each do |_key, digr|
-      found = productions.find { |a_prod| digr.production == a_prod }
-      next if found
-
-      msg = "Digram #{digr.symbols} references the unknown "
-      msg << "production (#{digr.production.object_id})."
-      msg << "\n#{to_string}"
-      fail StandardError, msg
-    end
-  end
-
-  # Compare the contents of digrams Hash with
-  # All digrams from all productions
-  def check_digrams()
-    # Control that every registered digram refers
-    # to a production that really has that digram
-    digrams.each do |key, digr|
-      its_prod = digr.production
-      prod_digrams = its_prod.digrams
-      prod_keys = prod_digrams.map(&:key)
-      next if prod_keys.include? key
-
-      msg = "Production #{digr.production_id} doesn't have "
-      msg << "the digram #{digr.symbols}"
-      msg << "\n#{prod_digrams.map(&:symbols)}"
-      msg << "\n#{to_string}"
-      fail StandardError, msg
-    end
-
-    all_digrams = {}
-    productions.each do |a_prod|
-      its_digrams = a_prod.digrams
-      its_digrams.each do |digr|
-        check_unicity if all_digrams[digr.key]
-        all_digrams[digr.key] = digr
-      end
-    end
-
-    all_digrams.each do |key, digr|
-      registered = digrams[key]
-      if registered
-        if registered != digr
-          msg = "Production #{digr.production.object_id} has "
-          msg << "the digram #{digr.symbols} that collides"
-          msg << "\n with same digram from #{registered.production.object_id}"
-          msg << "\n#{to_string}"
-          fail StandardError, msg
-        end
-      else
-        its_prod = digr.production
-        msg = "Production #{its_prod.object_id} (#{its_prod.rhs}) "
-        msg << "has the digram #{digr.symbols} that isn't registered."
-        msg << "\n#{to_string}"
-        fail StandardError, msg
-      end
-    end
-  end
-
-
 end # class
 
 end # module

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sequitur
 version: !ruby/object:Gem::Version
-  version: 0.0.13
+  version: 0.0.14
 platform: ruby
 authors:
 - Dimitri Geshef
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-07 00:00:00.000000000 Z
+date: 2014-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake