sequenced 1.6.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 75bc9373c8fb1dcbebb9cbfb7742d7d162546a24
-  data.tar.gz: 892d83d72c3219cc05124b9ff417de1f40bdfcc4
+  metadata.gz: 2c19db66c935260344abf853e2e1725a7dc9ef4d
+  data.tar.gz: 27bc38c11839f113839eaf23b8f213f677fa9024
 SHA512:
-  metadata.gz: 15d113af75d91959ee8335119bad539915421145638d9ece2d92c4860ab7256b282aa3c44ccf2121db45ae09351cc5e475cf7d1e8dab7dfb16ba46898a22da33
-  data.tar.gz: a2c3d6132035d47ff11d8ccdd67385df43d1e1e32e41fac37b45d2faf99ab5227f733e99a3a66cd4e9098279fee1a940c5dadb94e6f2a9ecd5be512d4b3966e3
+  metadata.gz: 1f47927ecd09469be6fc26fb30b9a752a8f94bee42cba8c54c5cb44d4e0fafa328e6c3dad9a69529a20b4461add62e1d6cd14a730230b284db904d8bb97da4be
+  data.tar.gz: 9e9707f1c891f16bd0f30a7f0dc001a6f212b9006ef3294549c5c037da817029d850f52b219872e0ac6d7ad8551a140492b28ca2a3d79cdf52117df465791366

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+2.0.0 (October 24, 2014)
+------------------------
+
+* Revert "Move generation callback from `before_save` to `before_validation` to
+  allow validations to utilize the sequential id". This change introduced a
+  critical bug where generating multiple records in one transaction would lead
+  to duplicate ids (see #10)
+
 1.6.0 (April 10, 2014)
 ----------------------
 
@@ -47,4 +55,4 @@
 0.1.0 (February 19, 2012)
 -------------------------
 
-* Initial release
+* Initial release

data/Rakefile

@@ -20,9 +20,6 @@ RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
-
-
-
 Bundler::GemHelper.install_tasks
 
 require 'rake/testtask'

data/lib/sequenced/acts_as_sequenced.rb

@@ -34,7 +34,7 @@ module Sequenced
         cattr_accessor :sequenced_options
         self.sequenced_options = options
 
-        before_validation :set_sequential_id
+        before_save :set_sequential_id
         include Sequenced::ActsAsSequenced::InstanceMethods
       end
     end

data/lib/sequenced/version.rb

@@ -1,3 +1,3 @@
 module Sequenced
-  VERSION = "1.6.0"
+  VERSION = "2.0.0"
 end

data/test/acts_as_sequenced_test.rb

@@ -129,10 +129,4 @@ class ActsAsSequencedTest < ActiveSupport::TestCase
     assert_equal 1, zombie.sequential_id
     assert_equal 2, werewolf.sequential_id
   end
-
-  test "validation passing" do
-    obj = Policeman.create
-    assert_empty obj.errors[:sequential_id]
-    assert obj.valid?
-  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sequenced
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Derrick Reimer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-10 00:00:00.000000000 Z
+date: 2014-10-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -129,6 +129,7 @@ files:
 - test/dummy/config/initializers/wrap_parameters.rb
 - test/dummy/config/locales/en.yml
 - test/dummy/config/routes.rb
+- test/dummy/db/development.sqlite3
 - test/dummy/db/migrate/20120219165346_create_questions.rb
 - test/dummy/db/migrate/20120219165548_create_answers.rb
 - test/dummy/db/migrate/20120219171957_create_accounts.rb
@@ -144,18 +145,17 @@ files:
 - test/dummy/db/migrate/20131226000000_create_monsters.rb
 - test/dummy/db/migrate/20140404195334_create_policemen.rb
 - test/dummy/db/schema.rb
+- test/dummy/db/test.sqlite3
 - test/dummy/lib/assets/.gitkeep
 - test/dummy/log/.gitkeep
+- test/dummy/log/development.log
+- test/dummy/log/test.log
 - test/dummy/public/404.html
 - test/dummy/public/422.html
 - test/dummy/public/500.html
 - test/dummy/public/favicon.ico
 - test/dummy/script/rails
 - test/test_helper.rb
-- test/dummy/db/development.sqlite3
-- test/dummy/db/test.sqlite3
-- test/dummy/log/development.log
-- test/dummy/log/test.log
 homepage: https://github.com/djreimer/sequenced
 licenses:
 - MIT
@@ -176,7 +176,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.3.0
 signing_key: 
 specification_version: 4
 summary: Generate scoped sequential IDs for ActiveRecord models