sequel_postgresql_triggers 1.0.2 → 1.0.3

data/{LICENSE → MIT-LICENSE}

@@ -1,4 +1,4 @@
-Copyright (c) 2008-2009 Jeremy Evans
+Copyright (c) 2008-2011 Jeremy Evans
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to

data/README

@@ -11,8 +11,8 @@ It handles these internally to the database via triggers, so even if
 other applications access the database (without using Sequel), things
 will still work (unless the database superuser disables triggers).
 
-To use any of these methods, you have to add the plpgsql procedural
-language to PostgreSQL, which you can do with:
+To use any of these methods before PostgreSQL 9.0, you have to add
+the plpgsql procedural language to PostgreSQL, which you can do with:
 
   DB.create_language(:plpgsql)
 
@@ -53,7 +53,8 @@ the value of any of the columns.
 
 == License
 
-This library is released under the MIT License.  See the LICENSE file for details.
+This library is released under the MIT License.  See the MIT-LICENSE
+file for details.
 
 == Author
 

data/lib/sequel_postgresql_triggers.rb

@@ -2,8 +2,9 @@ module Sequel
   module Postgres
     # Add the pgt_* methods so that any Sequel database connecting to PostgreSQL
     # can use them.  All of these methods require the plpgsql procedural language
-    # added to the PostgreSQL database before they can be used.  You can do so
-    # with:
+    # be added to the PostgreSQL database before they can be used. On PostgreSQL
+    # 9.0 and later versions, it is installed by default.  For older versions,
+    # you can install it with:
     #
     #   DB.create_language(:plpgsql)
     #
@@ -73,7 +74,7 @@ module Sequel
           old = "OLD.#{quote_identifier(c)}"
           new = "NEW.#{quote_identifier(c)}"
           <<-END
-            IF #{new} != #{old} THEN
+            IF #{new} IS DISTINCT FROM #{old} THEN
                 RAISE EXCEPTION 'Attempted event_id update: Old: %, New: %', #{old}, #{new};
             END IF;
           END

data/spec/sequel_postgresql_triggers_spec.rb

@@ -2,14 +2,21 @@
 require 'rubygems'
 require 'sequel'
 
-DB = Sequel.connect(ENV['PGT_SPEC_DB']||'postgres:///spgt_test?user=_postgresql')
+DB = Sequel.connect(ENV['PGT_SPEC_DB']||'postgres:///spgt_test?user=postgres')
 
 $:.unshift(File.join(File.dirname(File.dirname(File.expand_path(__FILE__))), 'lib'))
 require 'sequel_postgresql_triggers'
 
+context "PostgreSQL Triggers" do
+before do
+  DB.create_language(:plpgsql) if DB.server_version < 90000
+end
+after do
+  DB.drop_language(:plpgsql, :cascade=>true) if DB.server_version < 90000
+end
+
 context "PostgreSQL Counter Cache Trigger" do
   before do
-    DB.create_language(:plpgsql)
     DB.create_table(:accounts){integer :id; integer :num_entries, :default=>0}
     DB.create_table(:entries){integer :id; integer :account_id}
     DB.pgt_counter_cache(:accounts, :id, :num_entries, :entries, :account_id)
@@ -19,7 +26,6 @@ context "PostgreSQL Counter Cache Trigger" do
 
   after do
     DB.drop_table(:entries, :accounts)
-    DB.drop_language(:plpgsql, :cascade=>true)
   end
 
   specify "Should modify counter cache when adding or removing records" do
@@ -45,14 +51,12 @@ end
 
 context "PostgreSQL Created At Trigger" do
   before do
-    DB.create_language(:plpgsql)
     DB.create_table(:accounts){integer :id; timestamp :added_on}
     DB.pgt_created_at(:accounts, :added_on)
   end
 
   after do
     DB.drop_table(:accounts)
-    DB.drop_language(:plpgsql, :cascade=>true)
   end
 
   specify "Should set the column upon insertion and ignore modifications afterward" do
@@ -71,7 +75,6 @@ end
 
 context "PostgreSQL Immutable Trigger" do
   before do
-    DB.create_language(:plpgsql)
     DB.create_table(:accounts){integer :id; integer :balance, :default=>0}
     DB.pgt_immutable(:accounts, :balance)
     DB[:accounts] << {:id=>1}
@@ -79,20 +82,32 @@ context "PostgreSQL Immutable Trigger" do
 
   after do
     DB.drop_table(:accounts)
-    DB.drop_language(:plpgsql, :cascade=>true)
   end
 
-  specify "Should allow updating a record only if the immutable column does not change" do
-    DB[:accounts].update(:id=>1)
-    DB[:accounts].update(:balance=>0)
-    DB[:accounts].update(:balance=>:balance * :balance)
+  specify "Should allow modifying columns not marked as immutable" do
+    proc{DB[:accounts].update(:id=>2)}.should_not raise_error
+  end
+
+  specify "Should allow updating a column to its existing value" do
+    proc{DB[:accounts].update(:balance=>0)}.should_not raise_error
+    proc{DB[:accounts].update(:balance=>:balance * :balance)}.should_not raise_error
+  end
+
+  specify "Should not allow modifying a column's value" do
     proc{DB[:accounts].update(:balance=>1)}.should raise_error(Sequel::DatabaseError)
   end
+
+  specify "Should handle NULL values correctly" do
+    proc{DB[:accounts].update(:balance=>nil)}.should raise_error(Sequel::DatabaseError)
+    DB[:accounts].delete
+    DB[:accounts] << {:id=>1, :balance=>nil}
+    proc{DB[:accounts].update(:balance=>nil)}.should_not raise_error
+    proc{DB[:accounts].update(:balance=>0)}.should raise_error(Sequel::DatabaseError)
+  end
 end
 
 context "PostgreSQL Sum Cache Trigger" do
   before do
-    DB.create_language(:plpgsql)
     DB.create_table(:accounts){integer :id; integer :balance, :default=>0}
     DB.create_table(:entries){integer :id; integer :account_id; integer :amount}
     DB.pgt_sum_cache(:accounts, :id, :balance, :entries, :account_id, :amount)
@@ -102,7 +117,6 @@ context "PostgreSQL Sum Cache Trigger" do
 
   after do
     DB.drop_table(:entries, :accounts)
-    DB.drop_language(:plpgsql, :cascade=>true)
   end
 
   specify "Should modify sum cache when adding, updating, or removing records" do
@@ -131,14 +145,12 @@ end
 
 context "PostgreSQL Updated At Trigger" do
   before do
-    DB.create_language(:plpgsql)
     DB.create_table(:accounts){integer :id; timestamp :changed_on}
     DB.pgt_updated_at(:accounts, :changed_on)
   end
 
   after do
     DB.drop_table(:accounts)
-    DB.drop_language(:plpgsql, :cascade=>true)
   end
 
   specify "Should set the column always to the current timestamp" do
@@ -152,3 +164,4 @@ context "PostgreSQL Updated At Trigger" do
     DB[:accounts].select((Sequel::SQL::NumericExpression.new(:NOOP, ds.filter(:id=>3)) > ds.filter(:id=>2)).as(:x)).first[:x].should == true
   end
 end
+end

metadata

@@ -1,7 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: sequel_postgresql_triggers
 version: !ruby/object:Gem::Version 
-  version: 1.0.2
+  hash: 17
+  prerelease: false
+  segments: 
+  - 1
+  - 0
+  - 3
+  version: 1.0.3
 platform: ruby
 authors: 
 - Jeremy Evans
@@ -9,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-06-02 00:00:00 -07:00
+date: 2011-03-23 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -23,11 +29,13 @@ extra_rdoc_files: []
 
 files: 
 - README
-- LICENSE
+- MIT-LICENSE
 - lib/sequel_postgresql_triggers.rb
 - spec/sequel_postgresql_triggers_spec.rb
 has_rdoc: true
 homepage: 
+licenses: []
+
 post_install_message: 
 rdoc_options: 
 - --inline-source
@@ -35,28 +43,34 @@ rdoc_options:
 - --title
 - "Sequel PostgreSQL Triggers: Database enforced timestamps, immutable columns, and counter/sum caches"
 - README
-- LICENSE
+- MIT-LICENSE
 - lib
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
       version: "0"
-  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
       version: "0"
-  version: 
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.1
+rubygems_version: 1.3.7
 signing_key: 
-specification_version: 2
+specification_version: 3
 summary: Database enforced timestamps, immutable columns, and counter/sum caches
 test_files: []