sequel_pg 1.16.0 → 1.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e7bcc241985851b36df5d4e199e1edc08626fa8dcd23065aefd13b4cafd135a9
-  data.tar.gz: 8816059db9824f1396cb9d734c1b12f1c4ccb38c13ebc4a9c953a78cfff90fdd
+  metadata.gz: b418a08f23a346ec6f261855e3f20ad8c9ec97f9879a7120c43f1d48867bdd43
+  data.tar.gz: 3b15798070ba32128256dd3ec84f16b2c63a110849655be5964a08d5a481de8d
 SHA512:
-  metadata.gz: 2220c53c58d8bd549f66849529584dcf836495f0f55dc5819bd01841131e213f24cdcda089ae63a9703ae08c6c5ae5514160b1ce1f181e1277d099765d2f683b
-  data.tar.gz: 6ac01c39dddb568d29100e9bcd3a326d8bcc1b0cd4a54a4c507793fd0817d0709bfabbe6252873c7b422e8ed68f8a6b6d8f77f13b69d1012965b314611734a9c
+  metadata.gz: 273c435b2e9ffbe8ab104c32ad702215d1ef3671acf855c8be2f482d13f38fb971041e0310db492079d2187b11562e7578d6b22b6db4de82d2d7dcccb3457ae4
+  data.tar.gz: 49245e46280716939482f9865b6bede5a4a4615fb5326982103b7e9fc4d0778fb8421771aa1a858dd5a3aa4ff90e89f222cd913319c61714995f9507ba277c40

data/CHANGELOG

@@ -1,6 +1,12 @@
+=== 1.17.0 (2022-10-05)
+
+* Do not use pgresult_stream_any when using pg <1.4.4, to avoid double free in certain cases (larskanis) (#50)
+
+* Support new pgresult_stream_any API in pg 1.4.4 (larskanis) (#50)
+
 === 1.16.0 (2022-08-16)
 
-* Fix memory leak when using streaming with 1.3.4+ (jeremyevans) (#48)
+* Fix memory leak when using streaming with pg 1.3.4+ (jeremyevans) (#48)
 
 * Modify LDFLAGS when building on MacOS arm64 to allow undefined functions (maxsz) (#46)
 

data/ext/sequel_pg/sequel_pg.c

@@ -1,4 +1,4 @@
-#define SEQUEL_PG_VERSION_INTEGER 11600
+#define SEQUEL_PG_VERSION_INTEGER 11700
 
 #include <string.h>
 #include <stdio.h>
@@ -70,7 +70,7 @@
 PGconn* pg_get_pgconn(VALUE);
 PGresult* pgresult_get(VALUE);
 int pg_get_result_enc_idx(VALUE);
-VALUE pgresult_stream_any(VALUE self, void (*yielder)(VALUE, int, int, void*), void* data);
+VALUE pgresult_stream_any(VALUE self, int (*yielder)(VALUE, int, int, void*), void* data);
 
 static int spg_use_ipaddr_alloc;
 static int spg_use_pg_get_result_enc_idx;
@@ -1672,7 +1672,7 @@ struct spg__yield_each_row_stream_data {
   char type;
 };
 
-static void spg__yield_each_row_stream(VALUE rres, int ntuples, int nfields, void *rdata) {
+static int spg__yield_each_row_stream(VALUE rres, int ntuples, int nfields, void *rdata) {
   struct spg__yield_each_row_stream_data* data = (struct spg__yield_each_row_stream_data *)rdata;
   VALUE h = rb_hash_new();
   VALUE self = data->self;
@@ -1693,7 +1693,7 @@ static void spg__yield_each_row_stream(VALUE rres, int ntuples, int nfields, voi
   } else {
     rb_yield(h);
   }
-  PQclear(res);
+  return 1; /* clear the result */
 }
 
 static VALUE spg__yield_each_row_internal(VALUE self, VALUE rconn, VALUE rres, PGresult *res, int enc_index, VALUE *colsyms, VALUE *colconvert) {
@@ -1868,7 +1868,7 @@ void Init_sequel_pg(void) {
       if (FIX2INT(RARRAY_AREF(c, 1)) >= 2) {
         spg_use_pg_get_result_enc_idx = 1;
       }
-      if (FIX2INT(RARRAY_AREF(c, 1)) > 3 || (FIX2INT(RARRAY_AREF(c, 1)) == 3 && FIX2INT(RARRAY_AREF(c, 2)) >= 4)) {
+      if (FIX2INT(RARRAY_AREF(c, 1)) > 4 || (FIX2INT(RARRAY_AREF(c, 1)) == 4 && FIX2INT(RARRAY_AREF(c, 2)) >= 4)) {
         spg_use_pg_stream_any = 1;
       }
     }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sequel_pg
 version: !ruby/object:Gem::Version
-  version: 1.16.0
+  version: 1.17.0
 platform: ruby
 authors:
 - Jeremy Evans
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-08-16 00:00:00.000000000 Z
+date: 2022-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pg
@@ -77,9 +77,9 @@ metadata:
   bug_tracker_uri: https://github.com/jeremyevans/sequel_pg/issues
   changelog_uri: https://github.com/jeremyevans/sequel_pg/blob/master/CHANGELOG
   documentation_uri: https://github.com/jeremyevans/sequel_pg/blob/master/README.rdoc
-  mailing_list_uri: https://groups.google.com/forum/#!forum/sequel-talk
+  mailing_list_uri: https://github.com/jeremyevans/sequel_pg/discussions
   source_code_uri: https://github.com/jeremyevans/sequel_pg
-post_install_message: 
+post_install_message:
 rdoc_options:
 - "--quiet"
 - "--line-numbers"
@@ -102,7 +102,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.3.7
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Faster SELECTs when using Sequel with pg
 test_files: []