sequel_migration_builder 0.4.2 → 0.4.3

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NzM5ODM5Y2Q4Y2RkZjFhZjM0ZTE0YjdhZTAxZmRjOWQ5NGYzN2I5OA==
+    Njg3ZTNiMGUxODIzYTVhZjUxM2I1MTA1NmY1MzY1NzY4MWMyZjY3NQ==
   data.tar.gz: !binary |-
-    MjNhMWJmZTE4OGQwMDg4ZDc2ZjgyZTZiOWE3ZmVkYTYxNzM3MWFjOA==
+    Y2QxNmE3M2Y4OTk5MmFmNTkxN2UyNWM3NjA4Y2I1MWVmMTM5MmI0Yg==
 SHA512:
   metadata.gz: !binary |-
-    NGFlZDc2NzQyMzY0MDljMmM0ZWY5YTAxMzkyOTgwMTFmYzE3NmZiMDM3YzJm
-    NjZkNDJhMWFiNGUxODFiMzM2NmJhZTNmOWFkYTlkY2JmYTQ4MjZiYmIyNDFm
-    OWIyNGJjZGM2NzMwM2YxM2EwZmYzZDQxN2FkMzkyODQxZTU2Yjk=
+    NDYwODNkZDlmOGQ4OTYwM2YyNmU3OGE5ODdhMDM0ZDVjYTA5ZTY5NzQ4ZjI5
+    ZDY3NmU0YTA1MThhNDlhNTVhYmVjYzI3ZWVhNzU5NDhhYWExNzA3ZGM5OGIy
+    NDhhODQyYzJiMWYzMWQ3NzFmOTBhN2Q3MDJmMDZmMjBhMDA2Zjk=
   data.tar.gz: !binary |-
-    MmEwMDM2ZWZjYTZlZTYzNTk2NjQ3MDAxNDcwOGZhNDg4MWE5YTAxOTI4Mjkz
-    MzBjYWQzYjllZjdjOGRjZGY4ZGFjZTNmYzYzODFmODUwZWEzNDUxZmUyYTgz
-    ZDUzYzYyMjg0NDU0NDIwYzZkYTRjNjE2MDMxMjM5OTYzMzU2MDY=
+    YjFmZDgxZDZmNDJiNGJkYjJkN2Y3MjMyZjFkYWRkM2M4MDZhMWE5NGRlZDc2
+    Mzc0MjdlYjZmOTYyYjY3ZWRlMDZhY2JmODgzOGFlNDM0MDFjNTBiODFkYzdj
+    M2IyMDYxMTU2ZDkxNTJhNDdlM2M1NzIzODVkYWE1NDc0NTNkNmM=

data/VERSION

@@ -1 +1 @@
-0.4.2
+0.4.3

data/lib/sequel/schema/alter_table_operations.rb

@@ -52,16 +52,29 @@ module Sequel
         diffs = db_column.diff(new_column)
 
         if @immutable_columns && !diffs.empty?
-          result << :drop_statement
-          result << :add_statement
+          result << new_column.drop_statement
+          
+          statement = new_column.add_statement
+          result << (statement.include?(":default") ? statement : statement + ", :default => #{assumed_default(new_column)}")
+          result
         else
           result << :change_type_statement    if [:elements, :column_type, :size, :unsigned].any? {|sym| diffs.include?(sym) }
           # only need to explicitly set the default if we're not changing the column type.
           result << :change_default_statement if diffs.include?(:default) && result.empty?
           result << :change_null_statement    if diffs.include?(:null)
+
+          result.map {|statement| new_column.__send__(statement) }
+        end
+      end
+
+      def assumed_default(column)
+        if column.numeric?
+          0
+        elsif column.column_type == :varchar || column.column_type == :char
+          ''
+        elsif column.column_type == :boolean
+          false
         end
-        
-        result.map {|statement| new_column.__send__(statement) }
       end
     end
   end

data/sequel_migration_builder.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: sequel_migration_builder 0.4.2 ruby lib
+# stub: sequel_migration_builder 0.4.3 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "sequel_migration_builder"
-  s.version = "0.4.2"
+  s.version = "0.4.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Roland Swingler"]
-  s.date = "2014-09-03"
+  s.date = "2014-09-08"
   s.description = "Build Sequel Migrations based on the differences between two schemas"
   s.email = "roland.swingler@gmail.com"
   s.extra_rdoc_files = [
@@ -20,6 +20,7 @@ Gem::Specification.new do |s|
   ]
   s.files = [
     ".document",
+    ".rspec",
     "CHANGELOG",
     "LICENSE",
     "README.rdoc",
@@ -36,7 +37,6 @@ Gem::Specification.new do |s|
     "spec/db_index_spec.rb",
     "spec/db_schema_parser_spec.rb",
     "spec/migration_builder_spec.rb",
-    "spec/spec.opts",
     "spec/spec_helper.rb"
   ]
   s.homepage = "http://github.com/knaveofdiamonds/sequel_migration_builder"

data/spec/alter_table_operations_spec.rb

@@ -80,6 +80,7 @@ describe "Sequel::Schema::AlterTableOperations#build_column_operations" do
 
     expect(ops.first).to eql("set_column_type :foo, :enum, :default => nil, :elements => [\"A\", \"B\"]")
   end
+
 end
 
 describe "Sequel::Schema::AlterTableOperations.build" do
@@ -145,4 +146,41 @@ describe "Sequel::Schema::AlterTableOperations.build" do
     ops = Sequel::Schema::AlterTableOperations.build(table_a,table_b)
     expect(ops).to eql([])
   end
+
+  context "with immutable_columns set" do
+    subject {
+      Sequel::Schema::AlterTableOperations.new(:immutable_columns => true)
+    }
+
+    it "doesn't change columns that are not different" do
+      table_a = {:name => :example_table,
+        :columns => [build_column(:name => :foo, :column_type => :integer)]}
+      table_b = {:name => :example_table,
+        :columns => [build_column(:name => :foo, :column_type => :integer)]}
+      ops = subject.build(table_a,table_b)
+      
+      expect(ops).to be_empty
+    end
+
+    it "drops and adds a column with immutable columns set" do
+      table_a = {:name => :example_table,
+        :columns => [build_column(:name => :foo, :column_type => :integer, :allow_null => true)]}
+      table_b = {:name => :example_table,
+        :columns => [build_column(:name => :foo, :column_type => :smallint, :allow_null => true)]}
+      ops = subject.build(table_a,table_b)
+      
+      expect(ops.size).to eql(2)
+      expect(ops.first).to match(/drop_column :foo/)
+      expect(ops.last).to match(/add_column :foo/)
+    end
+
+    it "adds an assumed default to NOT NULL columns when changed" do
+      table_a = {:name => :example_table,
+        :columns => [build_column(:name => :foo, :column_type => :integer, :allow_null => false)]}
+      table_b = {:name => :example_table,
+        :columns => [build_column(:name => :foo, :column_type => :boolean, :allow_null => false)]}
+      ops = subject.build(table_a,table_b)
+      expect(ops.last).to match(/:default => false/)
+    end
+  end
 end

data/spec/migration_builder_spec.rb

@@ -201,7 +201,7 @@ change do
   end
 
   alter_table :example_table do
-    add_column :foo, :integer, :null => false
+    add_column :foo, :integer, :null => false, :default => 0
   end
 end
 END

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sequel_migration_builder
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors:
 - Roland Swingler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-03 00:00:00.000000000 Z
+date: 2014-09-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sequel
@@ -47,6 +47,7 @@ extra_rdoc_files:
 - README.rdoc
 files:
 - .document
+- .rspec
 - CHANGELOG
 - LICENSE
 - README.rdoc
@@ -63,7 +64,6 @@ files:
 - spec/db_index_spec.rb
 - spec/db_schema_parser_spec.rb
 - spec/migration_builder_spec.rb
-- spec/spec.opts
 - spec/spec_helper.rb
 homepage: http://github.com/knaveofdiamonds/sequel_migration_builder
 licenses: []