sequel 5.7.0 → 5.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dbe8916efd4df610e4bce09a3d0188dd9e104b612ef13c24b618ace444999d8e
-  data.tar.gz: 893b95c06f67028e030f31daf94eda2e9f90665093e4ed2fff10c6c41ff717b4
+  metadata.gz: a08d35934b3f831634bb0f33f7cab46262242c453f42e1991926d35d7420c17f
+  data.tar.gz: 530c498255c985753b5a2b2411d77d9087606f6f43f91a0e915299b1579c2e67
 SHA512:
-  metadata.gz: 16624a2a306df9f03d825283b4c86a5ba10145349bbdbfa0d3b1942fbba0f15a8e1dba65824b1e4105eb394295e9a31a66c2918f0714498a968b60df99f1145f
-  data.tar.gz: b60cd05380cbbcfba289170709032621399d599bbdc024070eabfae9f184bf6e2a7e56055a9fe1604af5e81e565ea8bf3be6563194c0893c1fe60898d20057a1
+  metadata.gz: d285a38669b61c579e5388fcd215637ca2f523cdfcf3e4d8290165883e3d567d91bacb3a3212d494aabecb022afa90be2bd0767393429cdc0035566fc9f702de
+  data.tar.gz: 8a81806f41fee72c293aa70b68023e3f3ec79413906649e3deea13198a8c588825166fe70b0bd37f9c77c39aadc77678415a3fea2f00ad7f912036e4861b6982

data/CHANGELOG

@@ -1,3 +1,7 @@
+=== 5.7.1 (2018-04-04)
+
+* Don't use identity columns if :serial=>true or :type=>:serial|:bigserial column options are used (#1490) (jeremyevans)
+
 === 5.7.0 (2018-04-01)
 
 * Add Sequel.start_timer and .elapsed_seconds_since for more accurate elapsed time calculations on ruby 2.1+ (jeremyevans)

data/lib/sequel/adapters/shared/postgres.rb

@@ -776,7 +776,7 @@ module Sequel
       # default value is given.
       def column_definition_default_sql(sql, column)
         super
-        if !column[:default] && (identity = column[:identity])
+        if !column[:serial] && !['serial', 'bigserial'].include?(column[:type].to_s) && !column[:default] && (identity = column[:identity])
           sql << " GENERATED "
           sql << (identity == :always ? "ALWAYS" : "BY DEFAULT")
           sql << " AS IDENTITY"

data/lib/sequel/version.rb

@@ -8,7 +8,7 @@ module Sequel
   MINOR = 7
   # The tiny version of Sequel.  Usually 0, only bumped for bugfix
   # releases that fix regressions from previous versions.
-  TINY  = 0
+  TINY  = 1
   
   # The version of Sequel you are using, as a string (e.g. "2.11.0")
   VERSION = [MAJOR, MINOR, TINY].join('.').freeze

data/spec/adapters/postgres_spec.rb

@@ -107,6 +107,20 @@ describe "PostgreSQL", '#create_table' do
     end
   end if DB.server_version >= 90000
 
+  it "should support primary_key with :type=>:serial or :type=>:bigserial" do
+    [:serial, :bigserial, 'serial', 'bigserial'].each do |type|
+      @db.create_table!(:tmp_dolls){primary_key :id, :type=>type}
+      @db[:tmp_dolls].insert
+      @db[:tmp_dolls].get(:id).must_equal 1
+    end
+  end if DB.server_version >= 100002
+
+  it "should support primary_key with :serial=>true" do
+    @db.create_table!(:tmp_dolls){primary_key :id, :serial=>true}
+    @db[:tmp_dolls].insert
+    @db[:tmp_dolls].get(:id).must_equal 1
+  end if DB.server_version >= 100002
+
   it "should support creating identity columns on non-primary key tables" do
     @db.create_table(:tmp_dolls){Integer :a, :identity=>true}
     2.times do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sequel
 version: !ruby/object:Gem::Version
-  version: 5.7.0
+  version: 5.7.1
 platform: ruby
 authors:
 - Jeremy Evans
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-02 00:00:00.000000000 Z
+date: 2018-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest