sequel 5.59.0 → 5.60.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 47d7144911d61be13cc600fc3153c8e30eb384476ea7fb94ce61bd0f2f627c36
-  data.tar.gz: fa763e2f24d5b6b26feecb405b5a43d8bbf30d2b727590e8fd98031640dfef2a
+  metadata.gz: 1bd9076a491b881827f095bbb1177974861448054cd73376ee76a42ed0f72ee5
+  data.tar.gz: e2e23f283d2d9f5b29df1510f5f39c8335cc47c37d0f92c848763cd437d4e668
 SHA512:
-  metadata.gz: 3855f6fbb47f26bfd0e9570ed8b7e908815bc7de3752751b92708c3e88948719f62dafe26cc1ea83b598c73e1ee84e4dbf12f01437dd1b087eed68ca4281b33d
-  data.tar.gz: 932fa5c97bc8dcf077a50961b2da7ecd59ae0c077409c2b0c3111d875fe468d5fbb4030f155faf17d3ba3ed0392e264d8e5ebaa11ad04db3ab98c209e2199440
+  metadata.gz: 309b37a25a51bc38c30c20276b7df1df4d21b6b14502b129fc363a0ac9bfc4897be03c21ec1d5b4b333eb6c1944491e4383406bb3f2cb96ba8dd1e98b513de42
+  data.tar.gz: 58adf4e309a3bd1d921f95d168a79830cce4526767b8ee9379ce69463327b10f0db4ded44a4a8e474cd0dd31036546b120f3e38a07c3057a5290933cffd3b77a

data/CHANGELOG

@@ -1,3 +1,13 @@
+=== 5.60.0 (2022-09-01)
+
+* Support arbitrary expressions for date_arithmetic interval values on PostgreSQL 9.4+ (jeremyevans)
+
+* Support native IS DISTINCT FROM on SQLite 3.39+ instead of emulating support in the is_distinct_from extension (jeremyevans)
+
+* Support HAVING without GROUP BY on SQLite 3.39+ (jeremyevans)
+
+* Convert most respond_to? calls to equivalent defined? for better performance (jeremyevans)
+
 === 5.59.0 (2022-08-01)
 
 * Set :allow_eager association option to false for instance specific associations without eager loaders (jeremyevans)

data/README.rdoc

@@ -416,7 +416,7 @@ As with +delete+, +update+ affects all rows in the dataset, so +where+ first,
 
 === Merging records
 
-Merging records using the SQL MERGE statment is done using <tt>merge*</tt> methods.
+Merging records using the SQL MERGE statement is done using <tt>merge*</tt> methods.
 You use +merge_using+ to specify the merge source and join conditions.
 You can use +merge_insert+, +merge_delete+, and/or +merge_update+ to set the
 INSERT, DELETE, and UPDATE clauses for the merge. +merge_insert+ takes the same

data/bin/sequel

@@ -194,7 +194,11 @@ begin
     TO_DB = connect_proc[db2]
     same_db = DB.database_type==TO_DB.database_type
     index_opts = {:same_db=>same_db}
+
+    # :nocov:
     index_opts[:index_names] = :namespace if !DB.global_index_namespace? && TO_DB.global_index_namespace?
+    # :nocov:
+
     if DB.database_type == :sqlite && !same_db
       # SQLite integer types allows 64-bit integers
       TO_DB.extension :integer64
@@ -212,18 +216,20 @@ begin
     puts "Begin copying data"
     DB.transaction do
       TO_DB.transaction do
+        all_status_lines = ENV['SEQUEL_BIN_STATUS_ALL_LINES']
+
         DB.tables.each do |table|
           puts "Begin copying records for table: #{table}"
           time = Time.now
           to_ds = TO_DB.from(table)
           j = 0
           DB.from(table).each do |record|
-            if Time.now - time > 5
+            to_ds.insert(record)
+            j += 1
+            if Time.now - time > 5 || all_status_lines
               puts "Status: #{j} records copied" 
               time = Time.now
             end
-            to_ds.insert(record)
-            j += 1
           end
           puts "Finished copying #{j} records for table: #{table}"
         end
@@ -260,8 +266,10 @@ if !ARGV.empty?
   ARGV.each{|v| load(v)}
 elsif !$stdin.isatty
   eval($stdin.read)
+# :nocov:
 else
   require 'irb'
   puts "Your database is stored in DB..."
   IRB.start
 end
+# :nocov:

data/doc/release_notes/5.60.0.txt

@@ -0,0 +1,22 @@
+= New Features
+
+* The date_arithmetic extension now supports arbitrary expressions
+  as interval values on PostgreSQL 9.4+.  Previously, only integers
+  were supported for the interval values.
+
+= Other Improvements
+
+* Most Kernel#respond_to? calls have been converted to equivalent
+  defined? calls for better performance.  defined? is a keyword
+  and is about 50% faster for the same behavior.
+
+* The is_distinct_from extension now supports the IS DISTINCT FROM
+  syntax natively on SQLite 3.39+, instead of emulating it.
+
+* HAVING without GROUP BY is now supported on SQLite 3.39+.
+
+* Coverage testing has been significantly expanded.  Previously,
+  the core, model, plugin, and extension code had 100% line/branch
+  coverage.  100% line/branch coverage has been added for the
+  core extensions, bin/sequel, and the postgres adapter with the
+  pg driver.

data/lib/sequel/adapters/jdbc/sqlite.rb

@@ -125,7 +125,7 @@ module Sequel
 
         # The result code for the exception, if the jdbc driver supports result codes for exceptions.
         def sqlite_error_code(exception)
-          exception.resultCode.code if exception.respond_to?(:resultCode)
+          exception.resultCode.code if defined?(exception.resultCode)
         end
       end
     end

data/lib/sequel/adapters/jdbc.rb

@@ -38,7 +38,7 @@ module Sequel
     else
       if defined?(::Jdbc) && ( ::Jdbc.const_defined?(name) rescue nil )
         jdbc_module = ::Jdbc.const_get(name) # e.g. Jdbc::SQLite3
-        jdbc_module.load_driver if jdbc_module.respond_to?(:load_driver)
+        jdbc_module.load_driver if defined?(jdbc_module.load_driver)
       end
     end
 
@@ -396,9 +396,9 @@ module Sequel
 
       def database_exception_sqlstate(exception, opts)
         if database_exception_use_sqlstates?
-          while exception.respond_to?(:cause)
+          while defined?(exception.cause)
             exception = exception.cause
-            return exception.getSQLState if exception.respond_to?(:getSQLState)
+            return exception.getSQLState if defined?(exception.getSQLState)
           end
         end
         nil
@@ -415,8 +415,8 @@ module Sequel
 
       # Raise a disconnect error if the SQL state of the cause of the exception indicates so.
       def disconnect_error?(exception, opts)
-        cause = exception.respond_to?(:cause) ? exception.cause : exception
-        super || (cause.respond_to?(:getSQLState) && cause.getSQLState =~ /^08/)
+        cause = defined?(exception.cause) ? exception.cause : exception
+        super || (defined?(cause.getSQLState) && cause.getSQLState =~ /^08/)
       end
 
       # Execute the prepared statement.  If the provided name is a

data/lib/sequel/adapters/mock.rb

@@ -257,7 +257,7 @@ module Sequel
             @shared_adapter = true
             extend(mod::DatabaseMethods)
             extend_datasets(mod::DatasetMethods)
-            if mod.respond_to?(:mock_adapter_setup)
+            if defined?(mod.mock_adapter_setup)
               mod.mock_adapter_setup(self)
             end
           end

data/lib/sequel/adapters/mysql.rb

@@ -72,7 +72,7 @@ module Sequel
       def connect(server)
         opts = server_opts(server)
 
-        if Mysql.respond_to?(:init)
+        if defined?(Mysql.init)
           conn = Mysql.init
           conn.options(Mysql::READ_DEFAULT_GROUP, opts[:config_default_group] || "client")
           conn.options(Mysql::OPT_LOCAL_INFILE, opts[:config_local_infile]) if opts.has_key?(:config_local_infile)
@@ -186,7 +186,7 @@ module Sequel
         elsif defined?(yield)
           yield conn
         end
-        if conn.respond_to?(:more_results?)
+        if defined?(conn.more_results?)
           while conn.more_results? do
             if r
               r.free
@@ -207,7 +207,7 @@ module Sequel
       ensure
         r.free if r
         # Use up all results to avoid a commands out of sync message.
-        if conn.respond_to?(:more_results?)
+        if defined?(conn.more_results?)
           while conn.more_results? do
             begin
               conn.next_result

data/lib/sequel/adapters/oracle.rb

@@ -149,7 +149,7 @@ module Sequel
       end
 
       def database_specific_error_class(exception, opts)
-        return super unless exception.respond_to?(:code)
+        return super unless defined?(exception.code)
         case exception.code
         when 1400, 1407
           NotNullConstraintViolation

data/lib/sequel/adapters/postgres.rb

@@ -5,6 +5,7 @@ require_relative 'shared/postgres'
 begin 
   require 'pg' 
 
+  # :nocov:
   Sequel::Postgres::PGError = PG::Error if defined?(PG::Error)
   Sequel::Postgres::PGconn = PG::Connection if defined?(PG::Connection)
   Sequel::Postgres::PGresult = PG::Result if defined?(PG::Result)
@@ -14,14 +15,17 @@ begin
     raise LoadError unless defined?(PGconn::CONNECTION_OK)
   end
 
-  Sequel::Postgres::USES_PG = true
   if defined?(PG::TypeMapByClass)
+  # :nocov:
     type_map = Sequel::Postgres::PG_QUERY_TYPE_MAP = PG::TypeMapByClass.new
     type_map[Integer] = PG::TextEncoder::Integer.new
     type_map[FalseClass] = type_map[TrueClass] = PG::TextEncoder::Boolean.new
     type_map[Float] = PG::TextEncoder::Float.new
   end
+
+  Sequel::Postgres::USES_PG = true
 rescue LoadError => e 
+  # :nocov:
   begin
     require 'sequel/postgres-pr'
   rescue LoadError 
@@ -32,16 +36,19 @@ rescue LoadError => e
     end 
   end 
   Sequel::Postgres::USES_PG = false
+  # :nocov:
 end
 
 module Sequel
   module Postgres
+    # :nocov:
     if USES_PG
       # Whether the given sequel_pg version integer is supported.
       def self.sequel_pg_version_supported?(version)
         version >= 10617
       end
     end
+    # :nocov:
 
     # PGconn subclass for connection specific methods used with the
     # pg or postgres-pr driver.
@@ -49,7 +56,9 @@ module Sequel
       # The underlying exception classes to reraise as disconnect errors
       # instead of regular database errors.
       DISCONNECT_ERROR_CLASSES = [IOError, Errno::EPIPE, Errno::ECONNRESET]
+      # :nocov:
       if defined?(::PG::ConnectionBad)
+      # :nocov:
         DISCONNECT_ERROR_CLASSES << ::PG::ConnectionBad
       end
       DISCONNECT_ERROR_CLASSES.freeze
@@ -75,6 +84,7 @@ module Sequel
         # are SQL strings.
         attr_reader :prepared_statements
 
+      # :nocov:
         unless public_method_defined?(:async_exec_params)
           alias async_exec_params async_exec
         end
@@ -117,6 +127,7 @@ module Sequel
           alias cmd_tuples cmdtuples
         end 
       end
+      # :nocov:
       
       # Raise a Sequel::DatabaseDisconnectError if a one of the disconnect
       # error classes is raised, or a PGError is raised and the connection
@@ -149,7 +160,7 @@ module Sequel
         begin
           defined?(yield) ? yield(q) : q.cmd_tuples
         ensure
-          q.clear if q && q.respond_to?(:clear)
+          q.clear if q && defined?(q.clear)
         end
       end
 
@@ -210,7 +221,9 @@ module Sequel
             :sslmode => opts[:sslmode],
             :sslrootcert => opts[:sslrootcert]
           }.delete_if { |key, value| blank_object?(value) }
+          # :nocov:
           connection_params.merge!(opts[:driver_options]) if opts[:driver_options]
+          # :nocov:
           conn = Adapter.connect(opts[:conn_str] || connection_params)
 
           conn.instance_variable_set(:@prepared_statements, {})
@@ -218,6 +231,13 @@ module Sequel
           if receiver = opts[:notice_receiver]
             conn.set_notice_receiver(&receiver)
           end
+
+          # :nocov:
+          if conn.respond_to?(:type_map_for_queries=) && defined?(PG_QUERY_TYPE_MAP)
+          # :nocov:
+            conn.type_map_for_queries = PG_QUERY_TYPE_MAP
+          end
+        # :nocov:
         else
           unless typecast_value_boolean(@opts.fetch(:force_standard_strings, true))
             raise Error, "Cannot create connection using postgres-pr unless force_standard_strings is set"
@@ -232,19 +252,19 @@ module Sequel
             opts[:password]
           )
         end
+        # :nocov:
 
         conn.instance_variable_set(:@db, self)
-        if USES_PG && conn.respond_to?(:type_map_for_queries=) && defined?(PG_QUERY_TYPE_MAP)
-          conn.type_map_for_queries = PG_QUERY_TYPE_MAP
-        end
 
+        # :nocov:
         if encoding = opts[:encoding] || opts[:charset]
-          if conn.respond_to?(:set_client_encoding)
+          if defined?(conn.set_client_encoding)
             conn.set_client_encoding(encoding)
           else
             conn.async_exec("set client_encoding to '#{encoding}'")
           end
         end
+        # :nocov:
 
         connection_configuration_sqls(opts).each{|sql| conn.execute(sql)}
         conn
@@ -271,7 +291,9 @@ module Sequel
         nil
       end
 
+      # :nocov:
       if USES_PG && Object.const_defined?(:PG) && ::PG.const_defined?(:Constants) && ::PG::Constants.const_defined?(:PG_DIAG_SCHEMA_NAME)
+      # :nocov:
         # Return a hash of information about the related PGError (or Sequel::DatabaseError that
         # wraps a PGError), with the following entries (any of which may be +nil+):
         #
@@ -322,7 +344,9 @@ module Sequel
         synchronize(opts[:server]){|conn| check_database_errors{_execute(conn, sql, opts, &block)}}
       end
 
+      # :nocov:
       if USES_PG
+      # :nocov:
         # +copy_table+ uses PostgreSQL's +COPY TO STDOUT+ SQL statement to return formatted
         # results directly to the caller.  This method is only supported if pg is the
         # underlying ruby driver.  This method should only be called if you want
@@ -468,12 +492,12 @@ module Sequel
                 opts[:after_listen].call(conn) if opts[:after_listen]
                 timeout = opts[:timeout]
                 if timeout
-                  timeout_block = timeout.respond_to?(:call) ? timeout : proc{timeout}
+                  timeout_block = defined?(timeout.call) ? timeout : proc{timeout}
                 end
 
                 if l = opts[:loop]
                   raise Error, 'calling #listen with :loop requires a block' unless block
-                  loop_call = l.respond_to?(:call)
+                  loop_call = defined?(l.call)
                   catch(:stop) do
                     while true
                       t = timeout_block ? [timeout_block.call] : []
@@ -515,8 +539,10 @@ module Sequel
       def adapter_initialize
         @use_iso_date_format = typecast_value_boolean(@opts.fetch(:use_iso_date_format, true))
         initialize_postgres_adapter
+        # :nocov:
         add_conversion_proc(17, method(:unescape_bytea)) if USES_PG
         add_conversion_proc(1082, TYPE_TRANSLATOR_DATE) if @use_iso_date_format
+        # :nocov:
         self.convert_infinite_timestamps = @opts[:convert_infinite_timestamps]
       end
 
@@ -526,19 +552,22 @@ module Sequel
       rescue => e
         raise_error(e, :classes=>database_error_classes)
       end
-
       # Set the DateStyle to ISO if configured, for faster date parsing.
       def connection_configuration_sqls(opts=@opts)
         sqls = super
+        # :nocov:
         sqls << "SET DateStyle = 'ISO'" if @use_iso_date_format
+        # :nocov:
         sqls
       end
 
+      # :nocov:
       if USES_PG
         def unescape_bytea(s)
           ::Sequel::SQL::Blob.new(Adapter.unescape_bytea(s))
         end
       end
+      # :nocov:
 
       DATABASE_ERROR_CLASSES = [PGError].freeze
       def database_error_classes
@@ -552,7 +581,9 @@ module Sequel
       end
 
       def database_exception_sqlstate(exception, opts)
-        if exception.respond_to?(:result) && (result = exception.result)
+        # :nocov:
+        if defined?(exception.result) && (result = exception.result)
+        # :nocov:
           result.error_field(PGresult::PG_DIAG_SQLSTATE)
         end
       end
@@ -594,7 +625,7 @@ module Sequel
         begin
           defined?(yield) ? yield(q) : q.cmd_tuples
         ensure
-          q.clear if q && q.respond_to?(:clear)
+          q.clear if q && defined?(q.clear)
         end
       end
 
@@ -662,7 +693,9 @@ module Sequel
         clone(:where=>Sequel.lit(['CURRENT OF '], Sequel.identifier(cursor_name)))
       end
 
+      # :nocov:
       if USES_PG
+      # :nocov:
         PREPARED_ARG_PLACEHOLDER = LiteralString.new('$').freeze
         
         # PostgreSQL specific argument mapper used for mapping the named
@@ -809,6 +842,7 @@ module Sequel
   end
 end
 
+# :nocov:
 if Sequel::Postgres::USES_PG && !ENV['NO_SEQUEL_PG']
   begin
     require 'sequel_pg'
@@ -820,3 +854,4 @@ if Sequel::Postgres::USES_PG && !ENV['NO_SEQUEL_PG']
   rescue LoadError
   end
 end
+# :nocov:

data/lib/sequel/adapters/shared/mssql.rb

@@ -205,7 +205,7 @@ module Sequel
           return @server_version = Integer(@opts[:server_version])
         end
         @server_version = synchronize(server) do |conn|
-          (conn.server_version rescue nil) if conn.respond_to?(:server_version)
+          (conn.server_version rescue nil) if defined?(conn.server_version)
         end
         unless @server_version
           m = /^(\d+)\.(\d+)\.(\d+)/.match(fetch("SELECT CAST(SERVERPROPERTY('ProductVersion') AS varchar)").single_value.to_s)

data/lib/sequel/adapters/shared/oracle.rb

@@ -121,7 +121,7 @@ module Sequel
       def server_version(server=nil)
         return @server_version if @server_version
         @server_version = synchronize(server) do |conn|
-          (conn.server_version rescue nil) if conn.respond_to?(:server_version)
+          (conn.server_version rescue nil) if defined?(conn.server_version)
         end
         unless @server_version
           @server_version = if m = /(\d+)\.(\d+)\.?(\d+)?\.?(\d+)?/.match(fetch("select version from PRODUCT_COMPONENT_VERSION where lower(product) like 'oracle%'").single_value)

data/lib/sequel/adapters/shared/postgres.rb

@@ -230,7 +230,6 @@ module Sequel
     module DatabaseMethods
       include UnmodifiedIdentifiers::DatabaseMethods
 
-      PREPARED_ARG_PLACEHOLDER = LiteralString.new('$').freeze
       FOREIGN_KEY_LIST_ON_DELETE_MAP = {'a'=>:no_action, 'r'=>:restrict, 'c'=>:cascade, 'n'=>:set_null, 'd'=>:set_default}.freeze
       ON_COMMIT = {:drop => 'DROP', :delete_rows => 'DELETE ROWS', :preserve_rows => 'PRESERVE ROWS'}.freeze
       ON_COMMIT.each_value(&:freeze)
@@ -365,9 +364,10 @@ module Sequel
 
         table_oid = regclass_oid(table)
         im = input_identifier_meth
-        unless column = im.call(opts[:column] || ((sch = schema(table).find{|_, sc| sc[:primary_key] && sc[:auto_increment]}) && sch[0]))
+        unless column = (opts[:column] || ((sch = schema(table).find{|_, sc| sc[:primary_key] && sc[:auto_increment]}) && sch[0]))
           raise Error, "could not determine column to convert from serial to identity automatically"
         end
+        column = im.call(column)
 
         column_num = ds.from(:pg_attribute).
           where(:attrelid=>table_oid, :attname=>column).
@@ -569,10 +569,12 @@ module Sequel
         if server_version >= 90500
           cpos = Sequel.expr{array_position(co[:conkey], ctable[:attnum])}
           rpos = Sequel.expr{array_position(co[:confkey], rtable[:attnum])}
+        # :nocov:
         else
           range = 0...32
           cpos = Sequel.expr{SQL::CaseExpression.new(range.map{|x| [SQL::Subscript.new(co[:conkey], [x]), x]}, 32, ctable[:attnum])}
           rpos = Sequel.expr{SQL::CaseExpression.new(range.map{|x| [SQL::Subscript.new(co[:confkey], [x]), x]}, 32, rtable[:attnum])}
+        # :nocov:
         end
 
         ds = metadata_dataset.
@@ -653,9 +655,11 @@ module Sequel
 
         if server_version >= 90500
           order = [Sequel[:indc][:relname], Sequel.function(:array_position, Sequel[:ind][:indkey], Sequel[:att][:attnum])]
+        # :nocov:
         else
           range = 0...32
           order = [Sequel[:indc][:relname], SQL::CaseExpression.new(range.map{|x| [SQL::Subscript.new(Sequel[:ind][:indkey], [x]), x]}, 32, Sequel[:att][:attnum])]
+        # :nocov:
         end
 
         attnums = SQL::Function.new(:ANY, Sequel[:ind][:indkey])
@@ -676,8 +680,10 @@ module Sequel
           select{[indc[:relname].as(:name), ind[:indisunique].as(:unique), att[:attname].as(:column), con[:condeferrable].as(:deferrable)]}
 
         ds = ds.where(:indpred=>nil) unless opts[:include_partial]
+        # :nocov:
         ds = ds.where(:indisready=>true) if server_version >= 80300
         ds = ds.where(:indislive=>true) if server_version >= 90300
+        # :nocov:
 
         indexes = {}
         ds.each do |r|
@@ -758,10 +764,12 @@ module Sequel
           seq_ds = metadata_dataset.from(:pg_sequence).where(:seqrelid=>regclass_oid(LiteralString.new(seq)))
           increment_by = :seqincrement
           min_value = :seqmin
+        # :nocov:
         else
           seq_ds = metadata_dataset.from(LiteralString.new(seq))
           increment_by = :increment_by
           min_value = :min_value
+        # :nocov:
         end
 
         get{setval(seq, db[table].select(coalesce(max(pk)+seq_ds.select(increment_by), seq_ds.select(min_value))), false)}
@@ -774,7 +782,9 @@ module Sequel
       # PostgreSQL uses SERIAL psuedo-type instead of AUTOINCREMENT for
       # managing incrementing primary keys.
       def serial_primary_key_options
+        # :nocov:
         auto_increment_key = server_version >= 100002 ? :identity : :serial
+        # :nocov:
         {:primary_key => true, auto_increment_key => true, :type=>Integer}
       end
 
@@ -1152,7 +1162,7 @@ module Sequel
         when :hash
           mod, remainder = generator.hash_values
           sql << " FOR VALUES WITH (MODULUS #{literal(mod)}, REMAINDER #{literal(remainder)})"
-        when :default
+        else # when :default
           sql << " DEFAULT"
         end
 
@@ -1356,11 +1366,6 @@ module Sequel
         end
       end
 
-      # Use a dollar sign instead of question mark for the argument placeholder.
-      def prepared_arg_placeholder
-        PREPARED_ARG_PLACEHOLDER
-      end
-
       # Return an expression the oid for the table expr.  Used by the metadata parsing
       # code to disambiguate unqualified tables.
       def regclass_oid(expr, opts=OPTS)
@@ -1434,10 +1439,14 @@ module Sequel
           where{{pg_class[:oid]=>oid}}.
           order{pg_attribute[:attnum]}
 
+        # :nocov:
         if server_version > 100000
+        # :nocov:
           ds = ds.select_append{pg_attribute[:attidentity]}
 
+          # :nocov:
           if server_version > 120000
+          # :nocov:
             ds = ds.select_append{Sequel.~(pg_attribute[:attgenerated]=>'').as(:generated)}
           end
         end
@@ -1525,7 +1534,9 @@ module Sequel
 
       # PostgreSQL 9.4+ supports views with check option.
       def view_with_check_option_support
+        # :nocov:
         :local if server_version >= 90400
+        # :nocov:
       end
     end
 
@@ -1921,6 +1932,8 @@ module Sequel
           server_version >= 90000
         when :groups, :exclude
           server_version >= 110000
+        else
+          false
         end
       end
     
@@ -2067,12 +2080,11 @@ module Sequel
 
       # Return the primary key to use for RETURNING in an INSERT statement
       def insert_pk
-        if (f = opts[:from]) && !f.empty?
-          case t = f.first
-          when Symbol, String, SQL::Identifier, SQL::QualifiedIdentifier
-            if pk = db.primary_key(t)
-              Sequel::SQL::Identifier.new(pk)
-            end
+        (f = opts[:from]) && !f.empty? && (t = f.first)
+        case t
+        when Symbol, String, SQL::Identifier, SQL::QualifiedIdentifier
+          if pk = db.primary_key(t)
+            Sequel::SQL::Identifier.new(pk)
           end
         end
       end

data/lib/sequel/adapters/shared/sqlite.rb

@@ -663,7 +663,7 @@ module Sequel
       
       # HAVING requires GROUP BY on SQLite
       def having(*cond)
-        raise(InvalidOperation, "Can only specify a HAVING clause on a grouped dataset") unless @opts[:group]
+        raise(InvalidOperation, "Can only specify a HAVING clause on a grouped dataset") if !@opts[:group] && db.sqlite_version < 33900
         super
       end
       

data/lib/sequel/adapters/sqlite.rb

@@ -305,7 +305,7 @@ module Sequel
       if USE_EXTENDED_RESULT_CODES
         # Support SQLite exception codes if ruby-sqlite3 supports them.
         def sqlite_error_code(exception)
-          exception.code if exception.respond_to?(:code)
+          exception.code if defined?(exception.code)
         end
       end
     end

data/lib/sequel/ast_transformer.rb

@@ -81,7 +81,7 @@ module Sequel
       when SQL::Wrapper
         SQL::Wrapper.new(v(o.value))
       when SQL::Expression
-        if o.respond_to?(:sequel_ast_transform)
+        if defined?(o.sequel_ast_transform)
           o.sequel_ast_transform(method(:v))
         else
           o

data/lib/sequel/database/misc.rb

@@ -350,7 +350,7 @@ module Sequel
     # strings with all whitespace, and ones that respond
     # true to empty?
     def blank_object?(obj)
-      return obj.blank? if obj.respond_to?(:blank?)
+      return obj.blank? if defined?(obj.blank?)
       case obj
       when NilClass, FalseClass
         true
@@ -359,7 +359,7 @@ module Sequel
       when String
         obj.strip.empty?
       else
-        obj.respond_to?(:empty?) ? obj.empty? : false
+        defined?(obj.empty?) ? obj.empty? : false
       end
     end
 

data/lib/sequel/dataset/sql.rb

@@ -1398,9 +1398,9 @@ module Sequel
       # don't cache SQL for a dataset that uses this.
       disable_sql_caching!
 
-      if v.respond_to?(:sql_literal_append)
+      if defined?(v.sql_literal_append)
         v.sql_literal_append(self, sql)
-      elsif v.respond_to?(:sql_literal)
+      elsif defined?(v.sql_literal)
         sql << v.sql_literal(self)
       else
         raise Error, "can't express #{v.inspect} as a SQL literal"