sequel-data-migrate 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 28e5819bb49e852cd25b5ebf696d596b64f153fd2db0bee30dda364feabf3c55
-  data.tar.gz: 99cd1ec8286e2a55f11239780ea4e2f9318919dd9bdb211cd7a25a8f40903272
+  metadata.gz: 7a03e567fda7ed849e9a70868d7395a1d9d4a8584b3027c4e9f21ad0ad73ef2f
+  data.tar.gz: 852e56344cc564be33d1028b504b735c42195d09a12e982bd148ce7435dd80c7
 SHA512:
-  metadata.gz: 3570a2f93a7ef13f99c9880147133f9cb7d44055898c93ed9da26c2216761dc0b814ec42a6278ac69aa0c6e7dbfa689f622f2257819d89449e40bcd8e0cc0fb1
-  data.tar.gz: 6ddc755e0ba9a21315195a2c5957ac897864b07bfd0e203049bd3b0f82d1f98868a9856ae71c0f9e9eb990b236b16fc17b752684cfcf643f2ca36a817a2d9129
+  metadata.gz: 6a7231580196995771534f090b14e2c92a941465a60779716e125606719c682fb3cf1a8bb23a65c6f84e1842a372a5816db3be9c1e61caea77f166b75f691ac0
+  data.tar.gz: bc2017007f8fa13551e49674d1be6f6f2120c8380baec8f1d961ef6e2d57b464566f76a8ed9a4f027c664ae54c3780becd433b13e8cee4ea2bfd46dab5cd0ac8

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## [0.1.2] - 2024-01-08
+
+- Avoid leaking DB connections
+
 ## [0.1.1] - 2023-09-01
 
 - Update gemspec to avoid `git ls-files`

data/README.md

@@ -38,8 +38,8 @@ task 'data:migrate' => :environment
 task 'data:rollback' => :environment
 ```
 
-Now you can migrate using `rake db:migrate` and rollback using `rake
-db:rollback`.
+Now you can migrate using `rake data:migrate` and rollback using `rake
+data:rollback`.
 
 To create new migration file, you can use `data:create_migration` rake task:
 

data/lib/sequel_data/migrate/migrator.rb

@@ -15,39 +15,41 @@ module SequelData
       end
 
       def migrate
-        db = connect_database
-        dataset = ensure_table_exists(db)
-
-        already_migrated = dataset.select_map(column).to_set
-        migration_files = fetch_migration_files.reject { |file| already_migrated.include?(File.basename(file)) }.sort
-        migrations = fetch_migrations(migration_files)
-
-        migrations.zip(migration_files).each do |migration, file|
-          db.log_info("Begin applying migration file #{file}")
-          migration.new.up
-          set_migration_version(db, file)
-          db.log_info("Finished applying migration version #{file}")
+        connect_database do |db|
+          dataset = ensure_table_exists(db)
+
+          already_migrated = dataset.select_map(column).to_set
+          migration_files = fetch_migration_files.reject { |file| already_migrated.include?(File.basename(file)) }.sort
+          migrations = fetch_migrations(migration_files)
+
+          migrations.zip(migration_files).each do |migration, file|
+            db.log_info("Begin applying migration file #{file}")
+            migration.new.up
+            set_migration_version(db, file)
+            db.log_info("Finished applying migration version #{file}")
+          end
         end
       end
 
       def rollback(step = 1)
-        db = connect_database
-        dataset = ensure_table_exists(db)
-
-        already_migrated = dataset.select_map(column).to_set
-        migration_files = fetch_migration_files.select do |file|
-          already_migrated.include?(File.basename(file))
-        end.sort.reverse!
-        migrations = fetch_migrations(migration_files)
-
-        migrations.zip(migration_files).each do |migration, file|
-          step -= 1
-          break if step.negative?
-
-          db.log_info("Begin rolling back migration file #{file}")
-          migration.new.down
-          remove_migration_version(db, file)
-          db.log_info("Finished rolling back migration version #{file}")
+        connect_database do |db|
+          dataset = ensure_table_exists(db)
+
+          already_migrated = dataset.select_map(column).to_set
+          migration_files = fetch_migration_files.select do |file|
+            already_migrated.include?(File.basename(file))
+          end.sort.reverse!
+          migrations = fetch_migrations(migration_files)
+
+          migrations.zip(migration_files).each do |migration, file|
+            step -= 1
+            break if step.negative?
+
+            db.log_info("Begin rolling back migration file #{file}")
+            migration.new.down
+            remove_migration_version(db, file)
+            db.log_info("Finished rolling back migration version #{file}")
+          end
         end
       end
 
@@ -63,10 +65,10 @@ module SequelData
         :data_migrations
       end
 
-      def connect_database
+      def connect_database(&block)
         raise ConfigurationError, "db_configuration is not set" if config.db_configuration.host.nil?
 
-        Sequel.connect(config.db_configuration.host)
+        Sequel.connect(config.db_configuration.host, &block)
       end
 
       def ensure_table_exists(db)

data/lib/sequel_data/migrate/version.rb

@@ -2,6 +2,6 @@
 
 module SequelData
   module Migrate
-    VERSION = "0.1.1"
+    VERSION = "0.1.2"
   end
 end

data/sig/sequel_data/migrate.rbs

@@ -54,7 +54,7 @@ module SequelData
       attr_reader config: untyped
       def column: -> :version
       def table: -> :data_migrations
-      def connect_database: -> untyped
+      def connect_database: () { (untyped db) -> void } -> untyped
       def ensure_table_exists: (untyped db) -> untyped
       def fetch_migration_files: -> Array[String]
       def load_migration_file: (String file) -> untyped

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sequel-data-migrate
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Hieu Nguyen
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-09-01 00:00:00.000000000 Z
+date: 2024-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-configurable