sequel-activerecord_connection 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 929f5047395464d1d3616aeab41742b6766ae14b96ca1f5b7ac47bb1991f3391
-  data.tar.gz: c931c23d71b73ce2bb35118e1d02ecc2df529f2c297b995c9c5ee46c5b0bfe85
+  metadata.gz: 6cbc8358a3097618cd7acc4e8cf46c013ef4d8b6aefde8e05de0277ca585c0b9
+  data.tar.gz: 2ba345ca95455c1acaabf7e2619b81b97b332d1c353bab2de50f700e9ba69148
 SHA512:
-  metadata.gz: 062f919b4268a57e392bad5dd7d4a988adc90a8df2d4076f5abfa9afe7c125534f9e7ad1ca16733d0539e622f2b988f95d4653d6b076cd356809d95daf1c24d2
-  data.tar.gz: 1f1efabd6b3ae74c6d35b3d0a23ad87a9d1c939e209afc2f24267840c6c72b2ff60fb1ca86010335b65a251c3c57fa81b300aa4cf38b9ad49df53b00f931d89f
+  metadata.gz: a9d3f729bfa2e5a82e78521856b2928887700a67129e47af6eb40d1bf4508b6deb7202928f7626ea3c4f6a424b23df8410756d2333295c1d56fee79b123dc7dd
+  data.tar.gz: 6184d4e1dd21bc550ac99285fd379215dcd13b4474aeff39928bdc68cc25ac34b235f68bed03260fae3fea34ef203422e2665bb12c822479e6ce4cc8d54d1f59

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.0.1 (2020-10-28)
+
+* Use Active Record connection lock in `Database#synchronize` (@janko)
+
 ## 1.0.0 (2020-10-25)
 
 * Clear AR statement cache on `ActiveRecord::PreparedStatementCacheExpired` when Sequel holds the transaction (@janko)

data/README.md

@@ -1,25 +1,23 @@
-# Sequel::ActiveRecordConnection
+# sequel-activerecord_connection
 
 This is an extension for [Sequel] that allows it to reuse an existing
-ActiveRecord connection for database interaction. It works on ActiveRecord 4.2
-or higher, and supports the built-in `postgresql`, `mysql2` and `sqlite3`
-adapters, as well as JDBC adapter for JRuby.
+ActiveRecord connection for database interaction.
 
 This can be useful if you're using a library that uses Sequel for database
 interaction (e.g. [Rodauth]), but you want to avoid creating a separate
 database connection. Or if you're transitioning from ActiveRecord to Sequel,
 and want the database connection to be shared.
 
-Note that this is a best-effort implementation, so some discrepancies are still
-possible. That being said, this implementation passes Rodauth's test suite
-(for all adapters), which has some fairly advanced Sequel usage.
+It works on ActiveRecord 4.2+ and fully supports PostgresSQL, MySQL and SQLite
+adapters, both the native ones and JDBC (JRuby). Other adapters might work too,
+but their integration hasn't been tested.
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
-```ruby
-gem "sequel-activerecord_connection", "~> 0.3"
+```rb
+gem "sequel-activerecord_connection", "~> 1.0"
 ```
 
 And then execute:

data/lib/sequel/extensions/activerecord_connection.rb

@@ -31,7 +31,9 @@ module Sequel
 
     # Avoid calling Sequel's connection pool, instead use Active Record's.
     def synchronize(*)
-      yield activerecord_connection.raw_connection
+      activerecord_lock do
+        yield activerecord_connection.raw_connection
+      end
     end
 
     # Log executed queries into Active Record logger as well.
@@ -111,6 +113,19 @@ module Sequel
       super
     end
 
+    # Active Record doesn't guarantee that a single connection can only be used
+    # by one thread at a time, so we need to use locking, which is what Active
+    # Record does internally as well.
+    def activerecord_lock
+      return yield if ActiveRecord.version < Gem::Version.new("5.1.0")
+
+      activerecord_connection.lock.synchronize do
+        ActiveSupport::Dependencies.interlock.permit_concurrent_loads do
+          yield
+        end
+      end
+    end
+
     def activerecord_connection
       activerecord_model.connection
     end

data/sequel-activerecord_connection.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "sequel-activerecord_connection"
-  spec.version       = "1.0.0"
+  spec.version       = "1.0.1"
   spec.authors       = ["Janko Marohnić"]
   spec.email         = ["janko.marohnic@gmail.com"]
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sequel-activerecord_connection
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Janko Marohnić
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-25 00:00:00.000000000 Z
+date: 2020-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sequel