sepparator 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c0db8dffa7a89eb9c7f4e572a49921059edd0342
-  data.tar.gz: ed95d128b87536a256141928a69be1948175f6c6
+  metadata.gz: 7ba71e463fa74383b9f14a35f2d96691917b62bd
+  data.tar.gz: 343953fd6024f90650bbac58c74c28bd8144a283
 SHA512:
-  metadata.gz: d7e56370c5f62fbc0ac04e86737c1792a45ead185380e764516e59cc03ea78dadea05dfedfa202864cc9340c05d00c09030bbb31967ae5aa3e5d8d49d65bf36d
-  data.tar.gz: f5cb224bb669339926a216f75221d2b6e95e37eb4cca80f4433c56ac01d05aac842f469c968dc877baa98589ceca2be28d4eed4b3358e81d837431580fecdeea
+  metadata.gz: 2986dc70483b662947a661f0b3fb9fa58980296be1696256ad792442851988d690683068951ba2562eb754df6ca80eddeb9ab2c4694e20f9a4ae08fa5bee26df
+  data.tar.gz: f5de91cdee6aa37ddd8969e0b7146787c3ad4416b870d3b63e2e1078a7ba5af85e10d86da7c911ecf7186bf5c3e6feb3f54986606f016c4442a90a1ca2d6f4c3

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    sepparator (0.0.4)
+    sepparator (0.0.5)
       simple_xlsx_writer
       thor
 
@@ -13,7 +13,7 @@ GEM
     fast_xs (0.8.0)
     ffi (1.9.0)
     formatador (0.2.4)
-    guard (1.8.1)
+    guard (1.8.2)
       formatador (>= 0.2.4)
       listen (>= 1.0.0)
       lumberjack (>= 1.0.2)
@@ -27,7 +27,7 @@ GEM
       rb-inotify (>= 0.9)
       rb-kqueue (>= 0.2)
     lumberjack (1.0.4)
-    method_source (0.8.1)
+    method_source (0.8.2)
     pry (0.9.12.2)
       coderay (~> 1.0.5)
       method_source (~> 0.8)
@@ -38,19 +38,19 @@ GEM
       ffi (>= 0.5.0)
     rb-kqueue (0.2.0)
       ffi (>= 0.5.0)
-    rspec (2.13.0)
-      rspec-core (~> 2.13.0)
-      rspec-expectations (~> 2.13.0)
-      rspec-mocks (~> 2.13.0)
-    rspec-core (2.13.1)
-    rspec-expectations (2.13.0)
+    rspec (2.14.1)
+      rspec-core (~> 2.14.0)
+      rspec-expectations (~> 2.14.0)
+      rspec-mocks (~> 2.14.0)
+    rspec-core (2.14.4)
+    rspec-expectations (2.14.0)
       diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.13.1)
+    rspec-mocks (2.14.2)
     rubyzip (0.9.9)
     simple_xlsx_writer (0.5.3)
       fast_xs (>= 0.7.3)
       rubyzip (>= 0.9.4)
-    slop (3.4.5)
+    slop (3.4.6)
     thor (0.18.1)
 
 PLATFORMS

data/lib/sepparator/spreadsheet_converter.rb

@@ -12,24 +12,27 @@ module Sepparator
     end
 
     def convert(csv_path, xls_path, sheet_name: 'from CSV')
-      raise ArgumentError, "destination file exists: #{xls_path}" if File.exists?(xls_path)
       raise ArgumentError, "file not found: #{csv_path}" unless File.exists?(csv_path)
-      SimpleXlsx::Serializer.new(xls_path) do |doc|
-        doc.add_sheet(sheet_name || 'from CSV') do |sheet|
-          CSV.foreach(csv_path, col_sep: col_sep, converters: [:numeric, :date_time, :date]) do |csv_row|
-            sheet.add_row(csv_row)
-          end
+      create_xlsx(xls_path, sheet_name) do |sheet|
+        CSV.foreach(csv_path, col_sep: col_sep, converters: [:numeric, :date_time, :date]) do |csv_row|
+          sheet.add_row(csv_row)
         end
       end
     end
 
     def convert_from_string(csv_string, xls_path, sheet_name: 'from CSV')
-      raise ArgumentError, "destination file exists: #{xls_path}" if File.exists?(xls_path)
+      create_xlsx(xls_path, sheet_name) do |sheet|
+        CSV.parse(csv_string, col_sep: col_sep, converters: [:numeric, :date_time, :date]) do |csv_row|
+          sheet.add_row(csv_row)
+        end
+      end
+    end
+
+    private
+    def create_xlsx(xls_path, sheet_name)
       SimpleXlsx::Serializer.new(xls_path) do |doc|
         doc.add_sheet(sheet_name || 'from CSV') do |sheet|
-          CSV.parse(csv_string, col_sep: col_sep, converters: [:numeric, :date_time, :date]) do |csv_row|
-            sheet.add_row(csv_row)
-          end
+          yield sheet
         end
       end
     end

data/sepparator.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "sepparator"
-  spec.version       = '0.0.4'
+  spec.version       = '0.0.5'
   spec.authors       = ["Andreas Brandl"]
   spec.email         = ["github@andreas-brandl.de"]
   spec.description   = %q{tool for working with CSV files, it supports conversion to Excel files and import to databases.}

data/spec/sepparator/spreadsheet_converter_spec.rb

@@ -22,12 +22,8 @@ describe Sepparator::SpreadsheetConverter do
       subject
       expect(File.exists?(xls_path)).to be_true
     end
-    it 'raises when the destination file already exists' do
-      expect{described_class.new.convert('/some/non/existing/file.csv', Tempfile.new('blafoo').path)}.to raise_error(ArgumentError, /destination file exists/)
-    end
   end
   context '#convert' do
-    #let(:xls_path) { Tempfile.new('convert-to-xlsx')}
     let(:xls_path) { '/tmp/example.xlsx' }
     let(:csv_path) { File.join(__dir__, 'example.csv')}
     subject { described_class.new.convert(csv_path, xls_path)}
@@ -46,9 +42,6 @@ describe Sepparator::SpreadsheetConverter do
       expect{described_class.new.convert('/some/non/existing/file.csv', xls_path)}.to raise_error(ArgumentError, /file not found/)
     end
 
-    it 'raises when the destination file already exists' do
-      expect{described_class.new.convert('/some/non/existing/file.csv', Tempfile.new('blafoo').path)}.to raise_error(ArgumentError, /destination file exists/)
-    end
   end
 
 end

data/spec/sepparator_spec.rb

@@ -8,7 +8,7 @@ describe Sepparator do
       csv_path = 'foo/bar.csv'
       xls_path = 'bla/fu.xls'
       sheet_name = 'my sheet'
-      converter = stub
+      converter = double
       Sepparator::SpreadsheetConverter.should_receive(:new).with(col_sep: col_sep).and_return(converter)
       converter.should_receive(:convert).with(csv_path, xls_path, sheet_name: sheet_name)
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sepparator
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Andreas Brandl