sepafm 1.1.8 → 1.1.9

data/test/custom_assertions.rb

@@ -1,41 +1,43 @@
 require 'minitest/assertions'
 
-module Minitest::Assertions
-  def assert_same_items(expected, actual)
-    assert same_items(expected, actual),
-           "Expected #{ expected.inspect } and #{ actual.inspect } to have the same items"
-  end
+module Minitest
+  module Assertions
+    def assert_same_items(expected, actual)
+      assert same_items(expected, actual),
+             "Expected #{expected.inspect} and #{actual.inspect} to have the same items"
+    end
 
-  def refute_same_items(expected, actual)
-    refute same_items(expected, actual),
-           "Expected #{ expected.inspect } and #{ actual.inspect } would not have the same items"
-  end
+    def refute_same_items(expected, actual)
+      refute same_items(expected, actual),
+             "Expected #{expected.inspect} and #{actual.inspect} would not have the same items"
+    end
 
-  def assert_valid_against_schema(schema, document)
-    errors = []
+    def assert_valid_against_schema(schema, document)
+      errors = []
 
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read(schema))
-      xsd.validate(document).each do |error|
-        errors << error
+      Dir.chdir(SCHEMA_PATH) do
+        xsd = Nokogiri::XML::Schema(IO.read(schema))
+        xsd.validate(document).each do |error|
+          errors << error
+        end
       end
-    end
 
-    assert errors.empty?, "The following schema validations failed:\n#{errors.join("\n")}"
-  end
+      assert errors.empty?, "The following schema validations failed:\n#{errors.join("\n")}"
+    end
 
-  def refute_valid_against_schema(schema, document)
-    Dir.chdir(SCHEMA_PATH) do
-      xsd = Nokogiri::XML::Schema(IO.read(schema))
+    def refute_valid_against_schema(schema, document)
+      Dir.chdir(SCHEMA_PATH) do
+        xsd = Nokogiri::XML::Schema(IO.read(schema))
 
-      refute xsd.valid?(document)
+        refute xsd.valid?(document)
+      end
     end
-  end
 
-  private
+    private
 
-    def same_items(expected, actual)
-      actual.is_a?(Enumerable) && expected.is_a?(Enumerable) &&
-        expected.count == actual.count && actual.all? { |e| expected.include?(e) }
-    end
+      def same_items(expected, actual)
+        actual.is_a?(Enumerable) && expected.is_a?(Enumerable) &&
+          expected.count == actual.count && actual.all? { |e| expected.include?(e) }
+      end
+  end
 end

data/test/sepa/banks/danske/danske_cert_response_test.rb

@@ -1,23 +1,28 @@
 require 'test_helper'
 
 class DanskeCertResponseTest < ActiveSupport::TestCase
-
   setup do
     options = {
-        response: File.read("#{DANSKE_TEST_RESPONSE_PATH}get_bank_cert.xml"),
-        command: :get_bank_certificate
+      response: File.read("#{DANSKE_TEST_RESPONSE_PATH}get_bank_cert.xml"),
+      command: :get_bank_certificate,
     }
     @get_bank_cert_response = Sepa::DanskeResponse.new options
 
     options = {
-        response: File.read("#{DANSKE_TEST_RESPONSE_PATH}create_cert.xml"),
-        command: :create_certificate
+      response: File.read("#{DANSKE_TEST_RESPONSE_PATH}create_cert.xml"),
+      command: :create_certificate,
     }
     @create_certificate_response = Sepa::DanskeResponse.new options
 
+    options = {
+      response: File.read("#{DANSKE_TEST_RESPONSE_PATH}create_cert_corrupted.xml"),
+      command: :create_certificate,
+    }
+    @create_certificate_corrupted_response = Sepa::DanskeResponse.new options
+
     options = {
       response: File.read("#{DANSKE_TEST_RESPONSE_PATH}get_bank_certificate_not_ok.xml"),
-      command: :get_bank_certificate
+      command: :get_bank_certificate,
     }
     @get_bank_certificate_not_ok_response = Sepa::DanskeResponse.new options
   end
@@ -75,9 +80,8 @@ class DanskeCertResponseTest < ActiveSupport::TestCase
   end
 
   test 'hashes shouldnt match when data is corrupted' do
-    assert_output /These digests failed to verify: {"#response"=>"2vCYl3h7ksRgk7IyV2axgpXxTWM="}/ do
-      @create_certificate_response.doc.at('xmlns|ReturnText', xmlns: DANSKE_PKI).content = 'kana'
-      refute @create_certificate_response.hashes_match?({ verbose: true })
+    assert_output(/These digests failed to verify: {"#response"=>"2vCYl3h7ksRgk7IyV2axgpXxTWM="}/) do
+      refute @create_certificate_corrupted_response.hashes_match?(verbose: true)
     end
   end
 
@@ -107,5 +111,4 @@ class DanskeCertResponseTest < ActiveSupport::TestCase
       x509_certificate certificate
     end
   end
-
 end

data/test/sepa/banks/danske/danske_generic_soap_builder_test.rb

@@ -1,19 +1,7 @@
 require 'test_helper'
 
 class DanskeGenericSoapBuilderTest < ActiveSupport::TestCase
-
   def setup
-    keys_path = File.expand_path('../keys', __FILE__)
-
-    signing_private_key_path = "#{keys_path}/signing_key.pem"
-    signing_private_key = File.read signing_private_key_path
-
-    signing_certificate_path = "#{keys_path}/own_signing_cert.pem"
-    signing_certificate = File.read signing_certificate_path
-
-    encryption_certificate_path = "#{keys_path}/own_enc_cert.pem"
-    encryption_certificate = File.read encryption_certificate_path
-
     @danske_generic_params = danske_generic_params
 
     # Convert keys in danske generic params, because this is usually done by the client
@@ -71,13 +59,13 @@ class DanskeGenericSoapBuilderTest < ActiveSupport::TestCase
     @danske_generic_params[:command] = :wrong_command
 
     assert_raises(ArgumentError) do
-      soap = Sepa::SoapBuilder.new(@danske_generic_params)
+      Sepa::SoapBuilder.new(@danske_generic_params)
     end
   end
 
   def test_sender_id_is_properly_set
     assert_equal @danske_generic_params[:customer_id],
-      @doc.at("//bxd:SenderId", 'bxd' => 'http://model.bxd.fi').content
+                 @doc.at("//bxd:SenderId", 'bxd' => 'http://model.bxd.fi').content
   end
 
   def test_request_id_is_properly_set
@@ -120,7 +108,7 @@ class DanskeGenericSoapBuilderTest < ActiveSupport::TestCase
     ).content
 
     actual_certificate = x509_certificate(
-      @danske_generic_params.fetch(:own_signing_certificate)
+      @danske_generic_params.fetch(:own_signing_certificate),
     ).to_s
 
     actual_certificate = actual_certificate.split('-----BEGIN CERTIFICATE-----')[1]
@@ -141,10 +129,7 @@ class DanskeGenericSoapBuilderTest < ActiveSupport::TestCase
       "//env:Body", 'env' => 'http://schemas.xmlsoap.org/soap/envelope/'
     )
 
-    body_node = body_node.canonicalize(
-      mode = Nokogiri::XML::XML_C14N_EXCLUSIVE_1_0,
-      inclusive_namespaces = nil, with_comments = false
-    )
+    body_node = canonicalize_exclusively(body_node)
 
     actual_digest = encode(sha1.digest(body_node)).strip
 
@@ -173,7 +158,7 @@ class DanskeGenericSoapBuilderTest < ActiveSupport::TestCase
     timestamp = Time.strptime(timestamp_node.content, '%Y-%m-%dT%H:%M:%S%z')
 
     assert timestamp <= (Time.now + 300) &&
-      timestamp > ((Time.now + 300) - 60)
+           timestamp > ((Time.now + 300) - 60)
   end
 
   def test_header_timestamps_digest_is_calculated_correctly
@@ -188,10 +173,7 @@ class DanskeGenericSoapBuilderTest < ActiveSupport::TestCase
       "//wsu:Timestamp", 'wsu' => wsu
     )
 
-    timestamp_node = timestamp_node.canonicalize(
-      mode = Nokogiri::XML::XML_C14N_EXCLUSIVE_1_0, inclusive_namespaces = nil,
-      with_comments = false
-    )
+    timestamp_node = canonicalize_exclusively(timestamp_node)
 
     actual_digest = encode(sha1.digest(timestamp_node)).strip
 
@@ -205,18 +187,15 @@ class DanskeGenericSoapBuilderTest < ActiveSupport::TestCase
 
     added_signature = @doc.at(
       "//dsig:SignatureValue",
-      'dsig' => 'http://www.w3.org/2000/09/xmldsig#'
+      'dsig' => 'http://www.w3.org/2000/09/xmldsig#',
     ).content
 
     signed_info_node = @doc.at("//dsig:SignedInfo", 'dsig' => 'http://www.w3.org/2000/09/xmldsig#')
 
-    signed_info_node = signed_info_node.canonicalize(
-      mode = Nokogiri::XML::XML_C14N_EXCLUSIVE_1_0, inclusive_namespaces = nil,
-      with_comments = false
-    )
+    signed_info_node = canonicalize_exclusively(signed_info_node)
 
     actual_signature = encode(
-      private_key.sign(sha1, signed_info_node)
+      private_key.sign(sha1, signed_info_node),
     ).gsub(/\s+/, "")
 
     assert_equal actual_signature, added_signature
@@ -251,5 +230,4 @@ class DanskeGenericSoapBuilderTest < ActiveSupport::TestCase
     assert_nil     application_request.at('ApplicationRequest')
     assert_not_nil application_request.at('xenc|EncryptedData')
   end
-
 end

data/test/sepa/banks/danske/danske_get_bank_cert_test.rb

@@ -1,14 +1,13 @@
 require 'test_helper'
 
 class DanskeGetBankCertTest < ActiveSupport::TestCase
-
   def setup
     @get_bank_cert_params = {
       bank: :danske,
       command: :get_bank_certificate,
       bank_root_cert_serial: '1111110002',
       customer_id: '360817',
-      request_id: SecureRandom.hex(5)
+      request_id: SecureRandom.hex(5),
     }
 
     @doc = Sepa::SoapBuilder.new(@get_bank_cert_params)
@@ -33,12 +32,12 @@ class DanskeGetBankCertTest < ActiveSupport::TestCase
 
   def test_sender_id_is_properly_set
     assert_equal @get_bank_cert_params[:customer_id],
-      @doc.at('SenderId', 'xmlns' => @pkif).content
+                 @doc.at('SenderId', 'xmlns' => @pkif).content
   end
 
   def test_customer_id_is_properly_set
     assert_equal @get_bank_cert_params[:customer_id],
-      @doc.at('CustomerId', 'xmlns' => @pkif).content
+                 @doc.at('CustomerId', 'xmlns' => @pkif).content
   end
 
   def test_header_request_id_is_properly_set
@@ -62,7 +61,7 @@ class DanskeGetBankCertTest < ActiveSupport::TestCase
 
   def test_bank_root_cert_serial_is_correctly_set
     assert_equal @get_bank_cert_params[:bank_root_cert_serial],
-      @doc.at('BankRootCertificateSerialNo', 'xmlns' => @elem).content
+                 @doc.at('BankRootCertificateSerialNo', 'xmlns' => @elem).content
   end
 
   def test_request_timestamp_is_set_correctly

data/test/sepa/banks/danske/danske_response_test.rb

@@ -3,7 +3,6 @@ require 'test_helper'
 # Tests Danske Bank specific response stuff
 class DanskeResponseTest < ActiveSupport::TestCase
   setup do
-
     # The private key of the certificate used to encrypt
     # the response which can be used to decrypt it
     encryption_private_key = '-----BEGIN RSA PRIVATE KEY-----
@@ -37,7 +36,7 @@ l+Ul4l4+FfAysq3a7b3xoQ59kN1CrEWqDo2KqndxGv6wQft3n/dxnQ==
     options = {
       response: File.read("#{DANSKE_TEST_RESPONSE_PATH}/download_file_list.xml"),
       command: :download_file_list,
-      encryption_private_key: rsa_key(encryption_private_key)
+      encryption_private_key: rsa_key(encryption_private_key),
     }
     @download_file_list_response = Sepa::DanskeResponse.new options
   end
@@ -87,7 +86,7 @@ ufGDBuk6Qe7BSx+/iYvjK1o/IP42RSwj7Ar/IaQuzzfxsflqrGA=
     options = {
       response: File.read("#{DANSKE_TEST_RESPONSE_PATH}/download_file_list.xml"),
       command: :download_file_list,
-      encryption_private_key: rsa_key(wrong_encryption_private_key)
+      encryption_private_key: rsa_key(wrong_encryption_private_key),
     }
     response = Sepa::DanskeResponse.new options
 

data/test/sepa/banks/danske/responses/create_cert_corrupted.xml

@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:pkif="http://danskebank.dk/PKI/PKIFactoryService" xmlns:elem="http://danskebank.dk/PKI/PKIFactoryService/elements" xmlns:xd="http://www.w3.org/2000/09/xmldsig#"><soapenv:Header/><soapenv:Body><CreateCertificateOut xmlns="http://danskebank.dk/PKI/PKIFactoryService"><pkif:ResponseHeader xmlns=""><pkif:SenderId>360817</pkif:SenderId><pkif:CustomerId>360817</pkif:CustomerId><pkif:RequestId>fad29587b6</pkif:RequestId><pkif:Timestamp>2014-08-06T11:00:03Z</pkif:Timestamp><pkif:InterfaceVersion>1</pkif:InterfaceVersion><pkif:Environment>customertest</pkif:Environment></pkif:ResponseHeader><tns:CreateCertificateResponse xml:id="response" xmlns:tns="http://danskebank.dk/PKI/PKIFactoryService/elements" xmlns=""><tns:ReturnCode>00</tns:ReturnCode><tns:ReturnText>OK</tns:ReturnText><tns:EncryptionCert>MIIDnzCCAoegAwIBAgIHHoy+tGx4NjANBgkqhkiG9w0BAQsFADCBwjEQMA4GA1UEAxMHREJHQ0FEQjELMAkGA1UEBhMCREsxEzARBgNVBAcTCkNvcGVuaGFnZW4xEDAOBgNVBAgTB0Rlbm1hcmsxGjAYBgNVBAoTEURhbnNrZSBCYW5rIEdyb3VwMRgwFgYDVQQLEw9EYW5za2UgQmFuayBBL1MxGDAWBgNVBAUTDzYxMTI2MjI4MjIzMDEwMTEJMAcGA1UEBBMAMQkwBwYDVQQqEwAxCTAHBgNVBAwTADEJMAcGA1UEERMAMB4XDTEwMDUyODExMTgzOVoXDTEyMDUyNzExMTgzOVowgaYxIDAeBgNVBAMTF0JFTkdUU1NPTiBPRyBGUi4gSkVOU0VOMQswCQYDVQQGEwJESzEcMBoGA1UEChMTREJUUyBERU1PIDEuICgzNEFLKTEeMBwGA1UECxMVQ09SUE9SQVRFIERFVkVMT1BNRU5UMTcwNQYDVQQFEy5TRS1LRVJIVi9EQUJBOjAwOTIxMDA4NDEtQUdSOjA2MTA0OC1VU1I6MDYxMTMzMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQCvWdhjVCuWXWu4H8WqUJGuvme+6l0g37fAXur3Xm28RChzvhue7pvwhtsZEyHN3Oa9DhLMV9UQC4wy5Md7Js+rm2HtgOtM2LMorE4GeoTYpi5f1fbYDUqHj2ygkkWDqQ9v0xSCJkGIyW+1vsrcId+DDlZqBacuXwtv5xy8plmX7wIDAQABozgwNjAJBgNVHQ4EAgQAMBkGA1UdIwQSMBCADsLGxMP29vnBwsTCxsTDMA4GA1UdDwEB/wQEAwIEMDANBgkqhkiG9w0BAQsFAAOCAQEAkITeNDN6Mxkb8AXF9SjZ1xfWD+yZcyb5wqQmpvwlM1gfovvV5mW/r2Wgn8uyhwwZd8dDJClNRslQeQrV8FbmCF8uh0dr1z2pt/t3u6lZ5YH1MWmLKGpJ8gGnWkRwEtkeZCuaD+Nji6YCGqCPytmKae+CFvz46XrvQ+VxfoqD8IlSoT2Himw6kfbE7H5oyJtuBSjozz+zz9GE09HQzCn3j1AX1jF0U0qFOXOR185NnDHtQPBytUOOBHBNog1+bVfby7E1nmXum38pMVnv5ReSvnhKhmusmxkHaKCGwgYCoKMvsXntHStvmH/t4tGdNyLvmC/88GYfoBXtNrsuZV3Ew==</tns:EncryptionCert><tns:SigningCert>MIIDnzCCAoegAwIBAgIHHoy+tGx4NTANBgkqhkiG9w0BAQsFADCBwjEQMA4GA1UEAxMHREJHQ0FEQjELMAkGA1UEBhMCREsxEzARBgNVBAcTCkNvcGVuaGFnZW4xEDAOBgNVBAgTB0Rlbm1hcmsxGjAYBgNVBAoTEURhbnNrZSBCYW5rIEdyb3VwMRgwFgYDVQQLEw9EYW5za2UgQmFuayBBL1MxGDAWBgNVBAUTDzYxMTI2MjI4MjIzMDEwMTEJMAcGA1UEBBMAMQkwBwYDVQQqEwAxCTAHBgNVBAwTADEJMAcGA1UEERMAMB4XDTEwMDUyODExMTgzOVoXDTEyMDUyNzExMTgzOVowgaYxIDAeBgNVBAMTF0JFTkdUU1NPTiBPRyBGUi4gSkVOU0VOMQswCQYDVQQGEwJESzEcMBoGA1UEChMTREJUUyBERU1PIDEuICgzNEFLKTEeMBwGA1UECxMVQ09SUE9SQVRFIERFVkVMT1BNRU5UMTcwNQYDVQQFEy5TRS1LRVJIVi9EQUJBOjAwOTIxMDA4NDEtQUdSOjA2MTA0OC1VU1I6MDYxMTMzMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQCfh+ajEvsFS1kByPsjReO+EmyFglGDiCBh7voya2aSbvGMQm/aAYugTliAhoklq4adwUwqjf86gon3ZdUMDBmDpJiPlxeexBHesOjr32hxzO8u67tS5o1xfDex3ga192g+94pAJsqmn3Fc8LJ0Wn2zJPtYCTYvbrx6551QLiD3fwIDAQABozgwNjAJBgNVHQ4EAgQAMBkGA1UdIwQSMBCADsLGxMP29vnBwsTCxsTDMA4GA1UdDwEB/wQEAwIGwDANBgkqhkiG9w0BAQsFAAOCAQEASgxJaAoWP08MKVnuvNxG7EkmogFUfKCX7fWrHYxDzEs5uhnRQ6IR4GitTHEM/BE5KNGu6MuHuKMhp4HuMBg5YzaFtk5yFk+K6BjLEEFwz/NBFLyrtPmrezxjmxMYx4PRTqeyEthOIkZ1KFQvzxB1Vg2Kt5fqdvxKVODAFstJB2nE3uICnrOQmHlo/R/1rp0J/VQnOsWdgKmIFhFlFdFpWhI7m1ry7cuilHPdCHq+M83jGfTYVXulwbxDYv0LPHZGzCxoAnxZQM4r2HqwXTCZiRT/eP+fEv7A571aHb9GhJhQQQ0lStd1vhOJu1LlO3fe68SSKSye5CozKwvvlEwbag==</tns:SigningCert><tns:CACert>MIIEFzCCAv+gAwIBAgIFAc+WvjUwDQYJKoZIhvcNAQELBQAwgZgxEDAOBgNVBAMTB0RCR1JPT1QxCzAJBgNVBAYTAkRLMRMwEQYDVQQHEwpDb3BlbmhhZ2VuMRAwDgYDVQQIEwdEZW5tYXJrMRowGAYDVQQKExFEYW5za2UgQmFuayBHcm91cDEaMBgGA1UECxMRRGFuc2tlIEJhbmsgR3JvdXAxGDAWBgNVBAUTDzYxMTI2MjI4MTEzMDAwMzAeFw0xMDEwMTEwMDAwMDBaFw0yMDEwMTEwMDAwMDBaMIGaMRAwDgYDVQQDEwdEQkdTV0RLMQswCQYDVQQGEwJESzETMBEGA1UEBxMKQ29wZW5oYWdlbjEQMA4GA1UECBMHRGVubWFyazEaMBgGA1UEChMRRGFuc2tlIEJhbmsgR3JvdXAxHDAaBgNVBAsTE0RhbnNrZSBCYW5rIERlbm1hcmsxGDAWBgNVBAUTDzYxMTI2MjI4NzczMDEwMTCCASAwDQYJKoZIhvcNAQEBBQADggENADCCAQgCggEBAOC0DrY9Q4HzHQ/BWr/RWB1GOq+90BiGN85uhWAeGGMI2od/ahn/R7zl8+MNcMLAuVHB8LvzRrC3lxZqjNvRKv8fYsMgwdmdYtBwiqHINpXTLjQxtLEWqEu5fiMZAi1oFE08YAkCDLUGopbkY+d2KULqxFK2blwHi3m0jOwuZGiw4ELeChGcELsOpCT/oJU5mR3dFHbRs3HBgWmuFwJKvwHNZeNAmrCwEUWqw1x4MjQRHRGl10TfTNqPrd7zyTfyR0+GPy1INxHwWZroBUc9j54ONX9pV6x835WedHdo80UxImjCiIruClzsMAXYtvsC3d9xgk9oLNFIVPRe2fTs07ECAQOjZjBkMB8GA1UdIwQYMBaAFLU6ie9kUC8x5CDLauuTRJBL35qYMB0GA1UdDgQWBBQO5nD7QkqlQCrxigdJncTYo20tIzAOBgNVHQ8BAf8EBAMCAQYwEgYDVR0TAQH/BAgwBgEB/wIBADANBgkqhkiG9w0BAQsFAAOCAQEAQPCp0H3g88CZZurq0kS76ozBVRiLZ3V8S0+IYi0dmMCfTpW/qnEzMGn+NlHOvgkm5C2VaHCdbEzZPsvv4cx2YrqpsFf8x+Ts6W2r3VVjOdve5u0Oj1CK/ONwaqUl5p4SxRCfnv6sSh6TwxhJF/zESiHXLdyWdJf+NkXsATE6QB4ZjgaGw1NcvhnDUvbbfUZ1zOTIf7+wUpfCNCJi0T1sFvJ88nYkVoQmVWQFS7Kwj+kwQ1ILfnp/1xbycrt1XNxZ8SkRDAWOJARY0fS/C0o7/1t/SB2ePrY/g0U8ZWi0B6odT5isGNpLOKzhD5YGjbKGesC9GEnhmhLoawXU7b4Wcw==</tns:CACert><tns:RequestId/><Signature xmlns="http://www.w3.org/2000/09/xmldsig#">
+<SignedInfo>
+  <CanonicalizationMethod Algorithm="http://www.w3.org/2001/10/xml-exc-c14n#"/>
+  <SignatureMethod Algorithm="http://www.w3.org/2000/09/xmldsig#rsa-sha1"/>
+  <Reference URI="#response">
+    <Transforms>
+      <Transform Algorithm="http://www.w3.org/2000/09/xmldsig#enveloped-signature"/>
+      <Transform Algorithm="http://www.w3.org/2001/10/xml-exc-c14n#"/>
+    </Transforms>
+    <DigestMethod Algorithm="http://www.w3.org/2000/09/xmldsig#sha1"/>
+    <DigestValue>2vCYl3h7ksRgk7IyV2axgpXxTWM=</DigestValue>
+  </Reference>
+</SignedInfo>
+    <SignatureValue>Vxs+AC28A9SGKjbuXKaWDZ3nxd1PW/JT5CJth7hGpv6+G/M/uiIKvHipdM5VilLdgPg8ocICJaKTPXg+pMzT2UkqgAQHBCh4JGBkIz0TR5tTppCs5pPO+rd/z6fGQU7gELLddh21pa58QtgAswgJtiIOupFG+wS5ocZTH//vryP/Rxh4VivMNg/jnvse2nETnchk+WCDl5iB0xbsuVRyAvFlw0SL1VWSqmLsDInoo8rQAFoc5A51mqP4ODaqSiK4shml7pOxj/JmRNrDQYOFuVoVIt/M/RTJWzc8nzXnnHc3ssSBKCsXv/x/mAmLBvBDpBOYQxLvu8zdFkLGZTGp+Q==</SignatureValue><KeyInfo><X509Data><X509Certificate>MIIEADCCAuigAwIBAgIFAMa3bfQwDQYJKoZIhvcNAQELBQAwgZgxEDAOBgNVBAMTB0RCR1JPT1QxCzAJBgNVBAYTAkRLMRMwEQYDVQQHEwpDb3BlbmhhZ2VuMRAwDgYDVQQIEwdEZW5tYXJrMRowGAYDVQQKExFEYW5za2UgQmFuayBHcm91cDEaMBgGA1UECxMRRGFuc2tlIEJhbmsgR3JvdXAxGDAWBgNVBAUTDzYxMTI2MjI4MTExMDAwMjAeFw0xNDA3MDcwMDAwMDBaFw0xNjA2MjYwMDAwMDBaMIGXMQ8wDQYDVQQDEwZEUFNJR04xCzAJBgNVBAYTAkRLMRMwEQYDVQQHEwpDb3BlbmhhZ2VuMRAwDgYDVQQIEwdEZW5tYXJrMRowGAYDVQQKExFEYW5za2UgQmFuayBHcm91cDEaMBgGA1UECxMRRGFuc2tlIEJhbmsgR3JvdXAxGDAWBgNVBAUTDzYxMTI2MjI4MzkxMDAwNDCCASAwDQYJKoZIhvcNAQEBBQADggENADCCAQgCggEBAMTopJ9GZXRkKm4Rq9M92EawXIfSI7VL0sykOzLfBzrgYMpqJ7rFxJe7nzECw22TeQ/3m4Gjnhe8XVaKSUDbfYfWzWD44iiZfecMaDZYIyR3g7GMwQowfwTqHhSEjFgfzH3QuGH2KGmqycvyuNGsbWjzvDAov8Yf7F88A4aOkseISO3Vmt2ElKm+gs09z7pwak6OxegDu5ZySS39kpTvq1DK3w2vXkEQGJUYOnDG/723v/hK3GjxclViu1OGSga7UJApjm3ky4s9EWoumf/vLBAnqRp6biOKnkGmOJEJlT00VWjaRoDarKOjgC7b/05Xp0ynDSOwqvTI92BdAQwfgEsCAQOjUjBQMB8GA1UdIwQYMBaAFIT65b/ekUlm38WKUsOzt7MgHMdtMB0GA1UdDgQWBBSh3exlGZ8eC4EiAVvbxenmc9faUzAOBgNVHQ8BAf8EBAMCBsAwDQYJKoZIhvcNAQELBQADggEBACjZJx8+UEcAYXJzstd+6E2wBNmmSvUTiuG7+Vws4+l4eqLLrHkhi66FOEwPdnf5/t8k7h5ry61aEf+HdUcQuYRrf7hJPkFjxaMcMGss4uURjVt/R/GhWMgu6cYgUIq0NHIMqdYH4dM/19qv7E+je2D3BuJOE3ucqe4Ywd+W2WP8HGlA3PkpMV78SPA9N/Usg3VX2KVbdS3idTpSMpxQftjWXmJtef0KawvYmYOw7i+eazHmv5mgxhgCvJSCPHN6oGS7v5AVVz9RCjSWEKIXZE0wRSLuTFYzt7/7CgRsdTVwpkFzn+ZJUAjYBPhZQ3Xn3p03DyCFsvtLxwE17UpUFUU=</X509Certificate><X509IssuerSerial><X509IssuerName>serialNumber=611262281110002, OU=Danske Bank Group, O=Danske Bank Group, ST=Denmark, L=Copenhagen, C=DK, CN=DBGROOT</X509IssuerName><X509SerialNumber>3333910004</X509SerialNumber></X509IssuerSerial></X509Data></KeyInfo></Signature></tns:CreateCertificateResponse></CreateCertificateOut></soapenv:Body></soapenv:Envelope>

data/test/sepa/banks/nordea/nordea_application_request_test.rb

@@ -178,7 +178,7 @@ class NordeaApplicationRequestTest < ActiveSupport::TestCase
     assert_raises(ArgumentError) do
       @nordea_generic_params[:command] = :wrong_kind_of_command
       ar = Sepa::ApplicationRequest.new(@nordea_generic_params)
-      doc = ar.get_as_base64
+      ar.get_as_base64
     end
   end
 
@@ -201,10 +201,9 @@ class NordeaApplicationRequestTest < ActiveSupport::TestCase
   end
 
   def test_signature_is_constructed_correctly
-    #private_key = @params.fetch(:private_key)
-
     signed_info_node = @doc_file.at_css(
-    "dsig|SignedInfo", 'dsig' => 'http://www.w3.org/2000/09/xmldsig#')
+      "dsig|SignedInfo", 'dsig' => 'http://www.w3.org/2000/09/xmldsig#'
+    )
 
     # The value of the signature node in the constructed ar
     calculated_signature = @doc_file.at_css(
@@ -216,8 +215,7 @@ class NordeaApplicationRequestTest < ActiveSupport::TestCase
     private_key = rsa_key(File.read("#{keys_path}/nordea.key"))
 
     sha1 = OpenSSL::Digest::SHA1.new
-    actual_signature = encode(private_key.sign(
-    sha1, signed_info_node.canonicalize))
+    actual_signature = encode(private_key.sign(sha1, signed_info_node.canonicalize))
 
     # And then of course assert the two are equal
     assert_equal calculated_signature, actual_signature

data/test/sepa/banks/nordea/nordea_application_response_test.rb

@@ -8,28 +8,28 @@ class NordeaApplicationResponseTest < ActiveSupport::TestCase
   def setup
     options = {
       response: File.read("#{NORDEA_TEST_RESPONSE_PATH}/dfl.xml"),
-      command: :download_file_list
+      command: :download_file_list,
     }
     @dfl = Sepa::NordeaResponse.new(options).application_response
     @dfl_doc = xml_doc @dfl
 
     options = {
       response: File.read("#{NORDEA_TEST_RESPONSE_PATH}/uf.xml"),
-      command: :upload_file
+      command: :upload_file,
     }
     @uf = Sepa::NordeaResponse.new(options).application_response
     @uf_doc = xml_doc @dfl
 
     options = {
       response: File.read("#{NORDEA_TEST_RESPONSE_PATH}/df_tito.xml"),
-      command: :download_file
+      command: :download_file,
     }
     @df_tito = Sepa::NordeaResponse.new(options).application_response
     @df_tito_doc = xml_doc @df_tito
 
     options = {
       response: File.read("#{NORDEA_TEST_RESPONSE_PATH}/gui.xml"),
-      command: :get_user_info
+      command: :get_user_info,
     }
     @gui = Sepa::NordeaResponse.new(options).application_response
     @gui_doc = xml_doc @gui
@@ -90,7 +90,7 @@ class NordeaApplicationResponseTest < ActiveSupport::TestCase
   def test_invalid_df_hash_check_should_not_verify
     digest_value_node = @df_tito_doc.at_css(
       'xmlns|DigestValue',
-      'xmlns' => 'http://www.w3.org/2000/09/xmldsig#'
+      'xmlns' => 'http://www.w3.org/2000/09/xmldsig#',
     )
 
     digest_value_node.content = digest_value_node.content[4..-1]
@@ -101,7 +101,7 @@ class NordeaApplicationResponseTest < ActiveSupport::TestCase
   def test_invalid_gui_hash_check_should_not_verify
     digest_value_node = @gui_doc.at_css(
       'xmlns|DigestValue',
-      'xmlns' => 'http://www.w3.org/2000/09/xmldsig#'
+      'xmlns' => 'http://www.w3.org/2000/09/xmldsig#',
     )
 
     digest_value_node.content = '1234' + digest_value_node.content
@@ -128,7 +128,7 @@ class NordeaApplicationResponseTest < ActiveSupport::TestCase
   def test_corrupted_signature_in_dfl_should_fail_signature_verification
     signature_node = @dfl_doc.at_css(
       'xmlns|SignatureValue',
-      'xmlns' => 'http://www.w3.org/2000/09/xmldsig#'
+      'xmlns' => 'http://www.w3.org/2000/09/xmldsig#',
     )
 
     signature_node.content = signature_node.content[4..-1]
@@ -139,7 +139,7 @@ class NordeaApplicationResponseTest < ActiveSupport::TestCase
   def test_corrupted_signature_in_uf_should_fail_signature_verification
     signature_node = @uf_doc.at_css(
       'xmlns|SignatureValue',
-      'xmlns' => 'http://www.w3.org/2000/09/xmldsig#'
+      'xmlns' => 'http://www.w3.org/2000/09/xmldsig#',
     )
 
     signature_node.content = signature_node.content[0..-5]
@@ -150,7 +150,7 @@ class NordeaApplicationResponseTest < ActiveSupport::TestCase
   def test_corrupted_signature_in_df_should_fail_signature_verification
     signature_node = @df_tito_doc.at_css(
       'xmlns|SignatureValue',
-      'xmlns' => 'http://www.w3.org/2000/09/xmldsig#'
+      'xmlns' => 'http://www.w3.org/2000/09/xmldsig#',
     )
 
     signature_node.content = 'a' + signature_node.content[1..-1]
@@ -161,7 +161,7 @@ class NordeaApplicationResponseTest < ActiveSupport::TestCase
   def test_corrupted_signature_in_gui_should_fail_signature_verification
     signature_node = @gui_doc.at_css(
       'xmlns|SignatureValue',
-      'xmlns' => 'http://www.w3.org/2000/09/xmldsig#'
+      'xmlns' => 'http://www.w3.org/2000/09/xmldsig#',
     )
 
     signature_node.content = 'zombi' + signature_node.content[1..-1]
@@ -172,7 +172,7 @@ class NordeaApplicationResponseTest < ActiveSupport::TestCase
   def test_should_raise_error_if_certificate_corrupted_in_dfl
     cert_node = @dfl_doc.at_css(
       'xmlns|X509Certificate',
-      'xmlns' => 'http://www.w3.org/2000/09/xmldsig#'
+      'xmlns' => 'http://www.w3.org/2000/09/xmldsig#',
     )
 
     cert_node.content = cert_node.content[0..-5]
@@ -185,7 +185,7 @@ class NordeaApplicationResponseTest < ActiveSupport::TestCase
   def test_should_raise_error_if_certificate_corrupted_in_uf
     cert_node = @uf_doc.at_css(
       'xmlns|X509Certificate',
-      'xmlns' => 'http://www.w3.org/2000/09/xmldsig#'
+      'xmlns' => 'http://www.w3.org/2000/09/xmldsig#',
     )
 
     cert_node.content = cert_node.content[4..-1]
@@ -198,7 +198,7 @@ class NordeaApplicationResponseTest < ActiveSupport::TestCase
   def test_should_raise_error_if_certificate_corrupted_in_df
     cert_node = @df_tito_doc.at_css(
       'xmlns|X509Certificate',
-      'xmlns' => 'http://www.w3.org/2000/09/xmldsig#'
+      'xmlns' => 'http://www.w3.org/2000/09/xmldsig#',
     )
 
     cert_node.content = "n5iw#{cert_node.content}"
@@ -211,7 +211,7 @@ class NordeaApplicationResponseTest < ActiveSupport::TestCase
   def test_should_raise_error_if_certificate_corrupted_in_gui
     cert_node = @gui_doc.at_css(
       'xmlns|X509Certificate',
-      'xmlns' => 'http://www.w3.org/2000/09/xmldsig#'
+      'xmlns' => 'http://www.w3.org/2000/09/xmldsig#',
     )
 
     cert_node.content = encode 'voivoi'
@@ -235,5 +235,4 @@ class NordeaApplicationResponseTest < ActiveSupport::TestCase
   test 'to_s works' do
     assert_equal @uf, @uf_ar.to_s
   end
-
 end

data/test/sepa/banks/nordea/nordea_cert_request_soap_builder_test.rb

@@ -1,7 +1,6 @@
 require 'test_helper'
 
 class NordeaCertRequestSoapBuilderTest < ActiveSupport::TestCase
-
   def setup
     @nordea_get_certificate_params = nordea_get_certificate_params
     @certrequest = Sepa::SoapBuilder.new(@nordea_get_certificate_params)
@@ -30,7 +29,7 @@ class NordeaCertRequestSoapBuilderTest < ActiveSupport::TestCase
   def test_should_raise_error_if_command_not_correct
     @nordea_get_certificate_params[:command] = :wrong_command
     assert_raises(ArgumentError) do
-      soap = Sepa::SoapBuilder.new(@nordea_get_certificate_params).to_xml
+      Sepa::SoapBuilder.new(@nordea_get_certificate_params).to_xml
     end
   end
 
@@ -58,5 +57,4 @@ class NordeaCertRequestSoapBuilderTest < ActiveSupport::TestCase
   def test_should_validate_against_schema
     assert_valid_against_schema 'soap.xsd', @xml
   end
-
 end

data/test/sepa/banks/nordea/nordea_generic_soap_builder_test.rb

@@ -1,7 +1,6 @@
 require 'test_helper'
 
 class NordeaGenericSoapBuilderTest < ActiveSupport::TestCase
-
   def setup
     @nordea_generic_params = nordea_generic_params
 
@@ -62,13 +61,13 @@ class NordeaGenericSoapBuilderTest < ActiveSupport::TestCase
     @nordea_generic_params[:command] = :wrong_command
 
     assert_raises(ArgumentError) do
-      soap = Sepa::SoapBuilder.new(@nordea_generic_params)
+      Sepa::SoapBuilder.new(@nordea_generic_params)
     end
   end
 
   def test_sender_id_is_properly_set
     assert_equal @nordea_generic_params[:customer_id],
-      @doc.xpath("//bxd:SenderId", 'bxd' => 'http://model.bxd.fi').first.content
+                 @doc.xpath("//bxd:SenderId", 'bxd' => 'http://model.bxd.fi').first.content
   end
 
   # Just testing that the content of the node is an actual hex number and that
@@ -156,10 +155,7 @@ class NordeaGenericSoapBuilderTest < ActiveSupport::TestCase
       "//env:Body", 'env' => 'http://schemas.xmlsoap.org/soap/envelope/'
     ).first
 
-    body_node = body_node.canonicalize(
-      mode = Nokogiri::XML::XML_C14N_EXCLUSIVE_1_0, inclusive_namespaces = nil,
-      with_comments = false
-    )
+    body_node = canonicalize_exclusively(body_node)
 
     actual_digest = encode(sha1.digest(body_node)).strip
 
@@ -202,10 +198,7 @@ class NordeaGenericSoapBuilderTest < ActiveSupport::TestCase
       "//wsu:Timestamp", 'wsu' => wsu
     ).first
 
-    timestamp_node = timestamp_node.canonicalize(
-      mode = Nokogiri::XML::XML_C14N_EXCLUSIVE_1_0, inclusive_namespaces = nil,
-      with_comments = false
-    )
+    timestamp_node = canonicalize_exclusively(timestamp_node)
 
     actual_digest = encode(sha1.digest(timestamp_node)).strip
 
@@ -224,13 +217,10 @@ class NordeaGenericSoapBuilderTest < ActiveSupport::TestCase
       "//dsig:SignedInfo", 'dsig' => 'http://www.w3.org/2000/09/xmldsig#'
     ).first
 
-    signed_info_node = signed_info_node.canonicalize(
-      mode = Nokogiri::XML::XML_C14N_EXCLUSIVE_1_0, inclusive_namespaces = nil,
-      with_comments = false
-    )
+    signed_info_node = canonicalize_exclusively(signed_info_node)
 
     actual_signature = encode(
-      signing_private_key.sign(sha1, signed_info_node)
+      signing_private_key.sign(sha1, signed_info_node),
     ).gsub(/\s+/, "")
 
     assert_equal actual_signature, added_signature

data/test/sepa/banks/nordea/nordea_response_test.rb

@@ -6,67 +6,67 @@ class NordeaResponseTest < ActiveSupport::TestCase
   setup do
     options = {
       response: File.read("#{NORDEA_TEST_RESPONSE_PATH}/dfl.xml"),
-      command: :download_file_list
+      command: :download_file_list,
     }
     @dfl = Sepa::NordeaResponse.new options
 
     options = {
       response: File.read("#{NORDEA_TEST_RESPONSE_PATH}/uf.xml"),
-      command: :upload_file
+      command: :upload_file,
     }
     @uf = Sepa::NordeaResponse.new options
 
     options = {
       response: File.read("#{NORDEA_TEST_RESPONSE_PATH}/df_tito.xml"),
-      command: :download_file
+      command: :download_file,
     }
     @df_tito = Sepa::NordeaResponse.new options
 
     options = {
       response: File.read("#{NORDEA_TEST_RESPONSE_PATH}/df_ktl.xml"),
-      command: :download_file
+      command: :download_file,
     }
     @df_ktl = Sepa::NordeaResponse.new options
 
     options = {
       response: File.read("#{NORDEA_TEST_RESPONSE_PATH}/gui.xml"),
-      command: :get_user_info
+      command: :get_user_info,
     }
     @gui = Sepa::NordeaResponse.new options
 
     options = {
       response: File.read("#{NORDEA_TEST_RESPONSE_PATH}/gc.xml"),
-      command: :get_certificate
+      command: :get_certificate,
     }
     @gc = Sepa::NordeaResponse.new options
 
     options = {
       response: File.read("#{NORDEA_TEST_RESPONSE_PATH}/rc.xml"),
-      command: :renew_certificate
+      command: :renew_certificate,
     }
     @rc = Sepa::NordeaResponse.new options
 
     options = {
       response: File.read("#{NORDEA_TEST_RESPONSE_PATH}/not_ok_response_code.xml"),
-      command: :download_file_list
+      command: :download_file_list,
     }
     @not_ok_response_code_response = Sepa::NordeaResponse.new options
 
     options = {
       response: File.read("#{NORDEA_TEST_RESPONSE_PATH}/download_file_list_no_content.xml"),
-      command: :download_file_list
+      command: :download_file_list,
     }
     @response_with_code_24 = Sepa::NordeaResponse.new options
 
     options = {
       response: File.read("#{NORDEA_TEST_RESPONSE_PATH}/invalid/timestamp_altered.xml"),
-      command: :download_file_list
+      command: :download_file_list,
     }
     @timestamp_altered = Sepa::NordeaResponse.new options
 
     options = {
       response: File.read("#{NORDEA_TEST_RESPONSE_PATH}/invalid/body_altered.xml"),
-      command: :upload_file
+      command: :upload_file,
     }
     @body_altered = Sepa::NordeaResponse.new options
   end

data/test/sepa/banks/op/op_cert_application_request_test.rb

@@ -59,7 +59,7 @@ class OpCertApplicationRequestTest < ActiveSupport::TestCase
   end
 
   test "hmac is not set" do
-    refute @xml.at_css("HMAC"), "HMAC should not be set, but is #{@xml.at_css("HMAC")}"
+    refute @xml.at_css("HMAC"), "HMAC should not be set, but is #{@xml.at_css('HMAC')}"
   end
 
   test "validates against schema" do