sepa_king 0.10.0 → 0.10.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 26e9894eb7ccc0a61f5f5eaba7f787c9c0e19095
-  data.tar.gz: effbc319d83f8b8967ef06f3055ea1af5a686de5
+  metadata.gz: 06ba65debe0037b33312ef3e37e26ee1961f455e
+  data.tar.gz: 2a18cefa0543ff2e0f4d3ca80fe85188e97615a2
 SHA512:
-  metadata.gz: 7d228d0db0b1fdba496ddf820a9ce9ecb0ee3c9e7b685705353eb9e2022975c103577324e37b8091709cd581d317c01b3d452cebafc0e559a2b8736d024ccf9c
-  data.tar.gz: a4f437e100aecbe85d63ab94075176cbd348756a1640ed09566aaf855008dfdf2cc4ff0e7eec5caa3ebcd3147bf01a1289ac590dca439b72d16fc89c26be1aca
+  metadata.gz: dad5f9e7304d1cba1cc7e241cfd3a5a394d7ca5214a0e64194dd774fb72b10d749d44bba655152e7e92339a3496bd6b51da26da529b6012e5517165d2800cae0
+  data.tar.gz: aea41790a245876bf8659a85118034c80f5ed09f7e9d9d7080af65a0de96679f58648e2945ed309abc0d0437aa5e4545ba711e061b697f3b5c3ab4420664ea75

data/.travis.yml

@@ -1,9 +1,9 @@
 rvm:
   - 2.0.0
   - 2.1.10
-  - 2.2.7
-  - 2.3.4
-  - 2.4.1
+  - 2.2.8
+  - 2.3.5
+  - 2.4.2
 gemfile:
   - gemfiles/Gemfile-activemodel-3.0.x
   - gemfiles/Gemfile-activemodel-3.1.x
@@ -23,8 +23,8 @@ matrix:
       gemfile: gemfiles/Gemfile-activemodel-5.0.x
     - rvm: 2.1.10
       gemfile: gemfiles/Gemfile-activemodel-5.0.x
-    - rvm: 2.4.1
+    - rvm: 2.4.2
       gemfile: gemfiles/Gemfile-activemodel-4.1.x
-    - rvm: 2.4.1
+    - rvm: 2.4.2
       gemfile: gemfiles/Gemfile-activemodel-4.2.x
 sudo: false

data/lib/sepa_king/transaction/credit_transfer_transaction.rb

@@ -15,7 +15,7 @@ module SEPA
     def schema_compatible?(schema_name)
       case schema_name
       when PAIN_001_001_03
-        self.bic.present? && self.service_level == 'SEPA'
+        self.service_level == 'SEPA'
       when PAIN_001_002_03
         self.bic.present? && self.service_level == 'SEPA' && self.currency == 'EUR'
       when PAIN_001_003_03

data/lib/sepa_king/version.rb

@@ -1,3 +1,3 @@
 module SEPA
-  VERSION = '0.10.0'
+  VERSION = '0.10.1'
 end

data/spec/credit_transfer_spec.rb

@@ -62,6 +62,12 @@ describe SEPA::CreditTransfer do
           expect(subject.to_xml).to validate_against('pain.001.003.03.xsd')
         end
 
+        it 'should fail for pain.001.001.03' do
+          expect {
+            subject.to_xml(SEPA::PAIN_001_001_03)
+          }.to raise_error(RuntimeError)
+        end
+
         it 'should fail for pain.001.002.03' do
           expect {
             subject.to_xml(SEPA::PAIN_001_002_03)
@@ -327,6 +333,32 @@ describe SEPA::CreditTransfer do
           }.to raise_error(RuntimeError)
         end
       end
+
+      context 'with a transaction without a bic' do
+        subject do
+          sct = credit_transfer
+
+          sct.add_transaction name:                   'Telekomiker AG',
+                              iban:                   'DE37112589611964645802',
+                              amount:                 102.50
+
+          sct
+        end
+
+        it 'should validate against pain.001.001.03' do
+          expect(subject.to_xml('pain.001.001.03')).to validate_against('pain.001.001.03.xsd')
+        end
+
+        it 'should fail for pain.001.002.03' do
+          expect {
+            subject.to_xml(SEPA::PAIN_001_002_03)
+          }.to raise_error(RuntimeError)
+        end
+
+        it 'should validate against pain.001.003.03' do
+          expect(subject.to_xml(SEPA::PAIN_001_003_03)).to validate_against('pain.001.003.03.xsd')
+        end
+      end
     end
   end
 end

data/spec/credit_transfer_transaction_spec.rb

@@ -41,6 +41,7 @@ describe SEPA::CreditTransferTransaction do
     context 'for pain.001.001.03' do
       it 'should succeed for valid attributes' do
         expect(SEPA::CreditTransferTransaction.new(:bic => 'SPUEDE2UXXX', :currency => 'CHF')).to be_schema_compatible('pain.001.001.03')
+        expect(SEPA::CreditTransferTransaction.new(:bic => nil)).to be_schema_compatible('pain.001.003.03')
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sepa_king
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.10.1
 platform: ruby
 authors:
 - Georg Leciejewski
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-17 00:00:00.000000000 Z
+date: 2017-09-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -223,7 +223,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Ruby gem for creating SEPA XML files