sentry-raven 2.7.3 → 2.7.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 400e642f148227a40dcf81d00af5513e2787b35c
-  data.tar.gz: a4c90987e4d11f40234ada594208b109dccf4681
+  metadata.gz: 39f754caa8c8dc1d3adf0a5ef6fc1691817c4902
+  data.tar.gz: 1367510ab3abaed41237210d7810626d7bf87fb5
 SHA512:
-  metadata.gz: 71ed2517a4a5a34397125108bbbac441a2b9aa2610684f70a2578e64a56775755373eef4369194605747a1498da3936e27fbbb4e3e78961edd102fec970bdbcb
-  data.tar.gz: 3c33543e522a1f06f00967175c104fe515c71b60ce62994647e1d65c4d6fefcca56cabeb940450d08ca41c3384d48d0260fab1db378c260b438eae52b43258dd
+  metadata.gz: 2deb6a18853cd32279e3a4c02a202cf661cb45062700d1efff75284ae7f31955426f774f91d461b9e4e74f13847fb092bf09957abab57cb79a2817e4949be3a3
+  data.tar.gz: 9cc99e456d2485bcd80e92f3d7b4c9f40429d96872d904dcec006804ee4e31b20325366ba263f14872b8b96b4a8e9aaa1f7c1fc53485b96e0a952c9955d28e3e

data/.rubocop.yml

@@ -7,11 +7,11 @@ AllCops:
      - 'vendor/**/*'
 
 Metrics/ClassLength:
-  Max: 268
+  Max: 269
   CountComments: false
 
 Metrics/AbcSize:
-  Max: 30
+  Max: 40
 
 Metrics/CyclomaticComplexity:
   Max: 12

data/.travis.yml

@@ -37,9 +37,9 @@ matrix:
       env: RAILS_VERSION=4
     - rvm: jruby-1.7.27
       env: JRUBY_OPTS="--dev" RAILS_VERSION=4
-    - rvm: jruby-9.1.15.0
+    - rvm: jruby-9.1.17.0
       env: JRUBY_OPTS="--dev -J-Djruby.launch.inproc=true -J-Xmx1024M" RAILS_VERSION=4
-    - rvm: jruby-9.1.15.0
+    - rvm: jruby-9.1.17.0
       env: JRUBY_OPTS="--dev -J-Djruby.launch.inproc=true -J-Xmx1024M" RAILS_VERSION=5
     - rvm: ruby-head
       env: RAILS_VERSION=0

data/Rakefile

@@ -14,6 +14,7 @@ begin
   require 'rubocop/rake_task'
   RuboCop::RakeTask.new(:rubocop) do |task|
     task.patterns = ['lib/**/*.rb','spec/**/*.rb',]
+    task.options << '--display-cop-names'
   end
 
   RSpec::Core::RakeTask.new(:spec) do |spec|

data/changelog.md

@@ -1,3 +1,10 @@
+2.7.4
+-----
+
+* BUGFIX: Correctly handle public only DSNs [@mitsuhiko, #847]
+* BUGFIX: context attributes with nil raised error [@joker-777, 824]
+* BUGFIX: Suppress warning about enabling dyno metadata in Heroku CI [@meganemura, #833]
+
 2.7.3
 -----
 

data/docs/config.rst

@@ -197,7 +197,7 @@ Optional settings
 
 .. describe:: should_capture
 
-    By providing a proc or lambda, you can control what events are captured. Events are passed to the Proc or lambda you provide - returning false will stop the event from sending to Sentry:
+    By providing a proc or lambda, you can control what events are captured. A String (if you've captured a message) or the Exception (if you've captured an exception) will be passed to the Proc or lambda you provide - returning false will stop the event from sending to Sentry:
 
     .. code-block:: ruby
 

data/lib/raven/client.rb

@@ -81,9 +81,9 @@ module Raven
         'sentry_version' => PROTOCOL_VERSION,
         'sentry_client' => USER_AGENT,
         'sentry_timestamp' => now,
-        'sentry_key' => configuration.public_key,
-        'sentry_secret' => configuration.secret_key
+        'sentry_key' => configuration.public_key
       }
+      fields['sentry_secret'] = configuration.secret_key unless configuration.secret_key.nil?
       'Sentry ' + fields.map { |key, value| "#{key}=#{value}" }.join(', ')
     end
 

data/lib/raven/configuration.rb

@@ -116,6 +116,8 @@ module Raven
 
     # Secret key for authentication with the Sentry server
     # If you provide a DSN, this will be set automatically.
+    #
+    # This is deprecated and not necessary for newer Sentry installations any more.
     attr_accessor :secret_key
 
     # Include module versions in reports - boolean.
@@ -223,7 +225,7 @@ module Raven
         # DSN-style string
         self.project_id = uri_path.pop
         self.public_key = uri.user
-        self.secret_key = uri.password
+        self.secret_key = !(uri.password.nil? || uri.password.empty?) ? uri.password : nil
       end
 
       self.scheme = uri.scheme
@@ -349,6 +351,7 @@ module Raven
 
     def detect_release_from_heroku
       return unless running_on_heroku?
+      return if ENV['CI']
       logger.warn(heroku_dyno_metadata_message) && return unless ENV['HEROKU_SLUG_COMMIT']
 
       ENV['HEROKU_SLUG_COMMIT']
@@ -391,9 +394,9 @@ module Raven
     end
 
     def valid?
-      return true if %w(server host path public_key secret_key project_id).all? { |k| public_send(k) }
+      return true if %w(server host path public_key project_id).all? { |k| public_send(k) }
       if server
-        %w(server host path public_key secret_key project_id).map do |key|
+        %w(server host path public_key project_id).map do |key|
           @errors << "No #{key} specified" unless public_send(key)
         end
       else

data/lib/raven/event.rb

@@ -39,7 +39,7 @@ module Raven
 
       # Allow attributes to be set on the event at initialization
       yield self if block_given?
-      init.each_pair { |key, val| public_send("#{key}=", val) }
+      init.each_pair { |key, val| public_send("#{key}=", val) unless val.nil? }
 
       set_core_attributes_from_configuration
       set_core_attributes_from_context

data/lib/raven/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module Raven
   # Freezing this constant breaks in 1.9.x
-  VERSION = "2.7.3" # rubocop:disable Style/MutableConstant
+  VERSION = "2.7.4" # rubocop:disable Style/MutableConstant
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sentry-raven
 version: !ruby/object:Gem::Version
-  version: 2.7.3
+  version: 2.7.4
 platform: ruby
 authors:
 - Sentry Team
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-04-26 00:00:00.000000000 Z
+date: 2018-06-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -136,7 +136,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: A gem that provides a client interface for the Sentry error logger