sentry-raven 2.3.0 → 2.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1d47eee39c7781d07673b21c829027ae9ff2a4e3
-  data.tar.gz: 14406d91d68320529521e749b2392ead1e59a95c
+  metadata.gz: fe631150dba3e7d468ec1b82dce90c833efe4e09
+  data.tar.gz: 6b362a1faf2b2b17bb4635cbeca461402459428b
 SHA512:
-  metadata.gz: aeb178b4827443e9dcfe3bd2299e772d9b0f69c42a8e6a281574dec4152d6f976ebd12b8d2aed490073111ad21624e6443f8bf6829d74dc6e2701eaed6b245f2
-  data.tar.gz: 4cd7b703b9cc39c8e838429daef8a24bb70de46d4397bcb9a93c9c1731b51acd600096e1f9db5a83de4e3a7fe498fa69e48fdb92c75f39b14f1ec01f465a5f07
+  metadata.gz: 82ca336c688dd243a368bb59cca6afb73e5de96828f2dfca286efded734946997cea6f6dcd862d41184d5cfe251f5927d4b7a25fd7fc705841b40662dd131680
+  data.tar.gz: 1e49e8fc891a662fc6043690d5711419f5703a44f2a40c8a5acff9f1696368d52160345f9e575f8e7b965b8d803abd3b5896266702e57256305279dbd2a2bb28

data/lib/raven/backtrace.rb

@@ -5,8 +5,12 @@ module Raven
   class Backtrace
     # Handles backtrace parsing line by line
     class Line
-      # regexp (optionnally allowing leading X: for windows support)
-      RUBY_INPUT_FORMAT = /^((?:[a-zA-Z]:)?[^:]+|<.*>):(\d+)(?::in `([^']+)')?$/
+      # regexp (optional leading X: on windows, or JRuby9000 class-prefix)
+      RUBY_INPUT_FORMAT = /
+        ^ \s* (?: [a-zA-Z]: | uri:classloader: )? ([^:]+ | <.*>):
+        (\d+)
+        (?: :in \s `([^']+)')?$
+      /x
 
       # org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:170)
       JAVA_INPUT_FORMAT = /^(.+)\.([^\.]+)\(([^\:]+)\:(\d+)\)$/
@@ -30,6 +34,7 @@ module Raven
         ruby_match = unparsed_line.match(RUBY_INPUT_FORMAT)
         if ruby_match
           _, file, number, method = ruby_match.to_a
+          file.sub!(/\.class$/, ".rb")
           module_name = nil
         else
           java_match = unparsed_line.match(JAVA_INPUT_FORMAT)

data/lib/raven/client.rb

@@ -97,8 +97,7 @@ module Raven
     def failed_send(e, event)
       @state.failure
       if e # exception was raised
-        configuration.logger.error "Unable to record event with remote Sentry server (#{e.class} - #{e.message})"
-        e.backtrace[0..10].each { |line| configuration.logger.error(line) }
+        configuration.logger.error "Unable to record event with remote Sentry server (#{e.class} - #{e.message}):\n#{e.backtrace[0..10].join("\n")}"
       else
         configuration.logger.error "Not sending event due to previous failure(s)."
       end

data/lib/raven/integrations/delayed_job.rb

@@ -24,10 +24,10 @@ module Delayed
               }
             }
             # last_error can be nil
-            extra[:last_error] = job.last_error[0...100] if job.last_error
+            extra[:last_error] = job.last_error[0...1000] if job.last_error
             # handlers are YAML objects in strings, we definitely can't
             # report all of that or the event will get truncated randomly
-            extra[:handler] = job.handler[0...100] if job.handler
+            extra[:handler] = job.handler[0...1000] if job.handler
 
             if job.respond_to?('payload_object') && job.payload_object.respond_to?('job_data')
               extra[:active_job] = job.payload_object.job_data

data/lib/raven/integrations/rack.rb

@@ -101,7 +101,7 @@ module Raven
         # env['SERVER_PROTOCOL']. But we don't want to ignore a valid header
         # if the request has legitimately sent a Version header themselves.
         # See: https://github.com/rack/rack/blob/028438f/lib/rack/handler/cgi.rb#L29
-        next if key == 'HTTP_VERSION' && value == ENV['SERVER_PROTOCOL']
+        next if key == 'HTTP_VERSION' && value == env_hash['SERVER_PROTOCOL']
 
         next unless key.start_with?('HTTP_') || %w(CONTENT_TYPE CONTENT_LENGTH).include?(key)
         # Rack stores headers as HTTP_WHAT_EVER, we need What-Ever

data/lib/raven/integrations/rake.rb

@@ -6,7 +6,7 @@ module Rake
   class Application
     alias orig_display_error_messsage display_error_message
     def display_error_message(ex)
-      Raven.capture_exception ex, :logger => 'rake', :tags => { 'rake_task' => @name }
+      Raven.capture_exception ex, :logger => 'rake', :tags => { 'rake_task' => top_level_tasks.join(' ') }
       orig_display_error_messsage(ex)
     end
   end

data/lib/raven/interfaces/message.rb

@@ -10,7 +10,7 @@ module Raven
     end
 
     def unformatted_message
-      params.nil? ? message : message % params
+      Array(params).empty? ? message : message % params
     end
 
     def self.sentry_alias

data/lib/raven/processor/cookies.rb

@@ -1,16 +1,26 @@
 module Raven
   class Processor::Cookies < Processor
     def process(data)
-      if data[:request]
-        # Remove possibly sensitive cookies
-        data[:request][:cookies] = STRING_MASK if data[:request][:cookies]
-
-        if data[:request][:headers] && data[:request][:headers]["Cookie"]
-          data[:request][:headers]["Cookie"] = STRING_MASK
-        end
-      end
+      process_if_symbol_keys(data) if data[:request]
+      process_if_string_keys(data) if data["request"]
 
       data
     end
+
+    private
+
+    def process_if_symbol_keys(data)
+      data[:request][:cookies] = STRING_MASK if data[:request][:cookies]
+
+      return unless data[:request][:headers] && data[:request][:headers]["Cookie"]
+      data[:request][:headers]["Cookie"] = STRING_MASK
+    end
+
+    def process_if_string_keys(data)
+      data["request"]["cookies"] = STRING_MASK if data["request"]["cookies"]
+
+      return unless data["request"]["headers"] && data["request"]["headers"]["Cookie"]
+      data["request"]["headers"]["Cookie"] = STRING_MASK
+    end
   end
 end

data/lib/raven/processor/http_headers.rb

@@ -10,17 +10,30 @@ module Raven
     end
 
     def process(data)
-      if data[:request] && data[:request][:headers]
-        data[:request][:headers].keys.select { |k| fields_re.match(k.to_s) }.each do |k|
-          data[:request][:headers][k] = STRING_MASK
-        end
-      end
+      process_if_symbol_keys(data) if data[:request]
+      process_if_string_keys(data) if data["request"]
 
       data
     end
 
     private
 
+    def process_if_symbol_keys(data)
+      return unless data[:request][:headers]
+
+      data[:request][:headers].keys.select { |k| fields_re.match(k.to_s) }.each do |k|
+        data[:request][:headers][k] = STRING_MASK
+      end
+    end
+
+    def process_if_string_keys(data)
+      return unless data["request"]["headers"]
+
+      data["request"]["headers"].keys.select { |k| fields_re.match(k) }.each do |k|
+        data["request"]["headers"][k] = STRING_MASK
+      end
+    end
+
     def matches_regexes?(k)
       fields_re.match(k.to_s)
     end

data/lib/raven/processor/post_data.rb

@@ -1,11 +1,22 @@
 module Raven
   class Processor::PostData < Processor
     def process(data)
-      if data[:request] && data[:request][:method] == "POST"
-        data[:request][:data] = STRING_MASK # Remove possibly sensitive POST data
-      end
+      process_if_symbol_keys(data) if data[:request]
+      process_if_string_keys(data) if data["request"]
 
       data
     end
+
+    private
+
+    def process_if_symbol_keys(data)
+      return unless data[:request][:method] == "POST"
+      data[:request][:data] = STRING_MASK
+    end
+
+    def process_if_string_keys(data)
+      return unless data["request"]["method"] == "POST"
+      data["request"]["data"] = STRING_MASK
+    end
   end
 end

data/lib/raven/processor/removestacktrace.rb

@@ -1,13 +1,24 @@
 module Raven
   class Processor::RemoveStacktrace < Processor
-    def process(value)
-      if value[:exception]
-        value[:exception][:values].map do |single_exception|
-          single_exception.delete(:stacktrace) if single_exception[:stacktrace]
-        end
+    def process(data)
+      process_if_symbol_keys(data) if data[:exception]
+      process_if_string_keys(data) if data["exception"]
+
+      data
+    end
+
+    private
+
+    def process_if_symbol_keys(data)
+      data[:exception][:values].map do |single_exception|
+        single_exception.delete(:stacktrace) if single_exception[:stacktrace]
       end
+    end
 
-      value
+    def process_if_string_keys(data)
+      data["exception"]["values"].map do |single_exception|
+        single_exception.delete("stacktrace") if single_exception["stacktrace"]
+      end
     end
   end
 end

data/lib/raven/transports/http.rb

@@ -29,7 +29,9 @@ module Raven
         end
       rescue Faraday::ClientError => ex
         error_info = ex.message
-        error_info += " Error in headers is: #{ex.response[:headers]['x-sentry-error']}" if ex.response[:headers]['x-sentry-error']
+        if ex.response && ex.response[:headers]['x-sentry-error']
+          error_info += " Error in headers is: #{ex.response[:headers]['x-sentry-error']}"
+        end
         raise Raven::Error, error_info
       end
 

data/lib/raven/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module Raven
   # Freezing this constant breaks in 1.9.x
-  VERSION = "2.3.0" # rubocop:disable Style/MutableConstant
+  VERSION = "2.3.1" # rubocop:disable Style/MutableConstant
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sentry-raven
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.3.1
 platform: ruby
 authors:
 - Sentry Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-04 00:00:00.000000000 Z
+date: 2017-02-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday