sensu-plugins-raid-checks 2.0.2 → 2.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5dca29a536c69abffcf2b8d2c4d916bfdaed79d75bc9b2f9c65a4826cbbb6394
-  data.tar.gz: 06640d9238016c8d91acae04ec10d852c43715aa808a6f303a00bc23e040985c
+  metadata.gz: ceab50cad9486cfca8dec249de788cfc0da6a02e5d4011caf1b252264410c420
+  data.tar.gz: ecd2efa942a99f8999fdd4a8c8ef2351205eb75f95073bde27d4fa50b4327fc0
 SHA512:
-  metadata.gz: 9609e3852a5d1f2ac1c7c577ef03d568d5b3e514f6baf8a7b15b112ba83b898f33c4f955e482c0cbfabb28314564ef5dd3cd9db8702ca54f13828414a7a2319e
-  data.tar.gz: f6d59989bebed47dcd492045c01817fcfc31e92b95ce8797249800fb204c7feb3857390be6dd8eba0aca36b4deadc997b73f41dd18127a3b3a93155a59e83429
+  metadata.gz: 5cb3f077d5fcc1780435d7a9cc07b5e32a4adca07b4b0b7568b3aa3a89d153754e4063c2067c9ac5683ef2406aa6eab4dd35a54a01e46873c3ae6f7f072a7778
+  data.tar.gz: e31065cab845fcbb406d21ba6c88f7cae17b2d7c2210f9c8f79a244de85f7cc3e71ca6402114550ac5dff2f09d0693fe79f9881014fd81fa9baf24006c67f944

data/CHANGELOG.md

@@ -6,6 +6,10 @@ Which is based on [Keep A Changelog](http://keepachangelog.com/)
 
 ## [Unreleased]
 
+## [2.0.3] - 2019-02-17
+### Fixed
+- `check-megaraid-sas-status.rb`: Fixed logic error in which it was assumed that all virtual drives were in sequential order. Also fixed pattern matching when parsing individual drive status. (@SeanSith)
+
 ## [2.0.2] - 2018-04-18
 ### Fixed
 - fixed software raid check (@corro)
@@ -66,7 +70,8 @@ Which is based on [Keep A Changelog](http://keepachangelog.com/)
 ### Added
 - initial release
 
-[Unreleased]: https://github.com/sensu-plugins/sensu-plugins-raid-checks/compare/2.0.2...HEAD
+[Unreleased]: https://github.com/sensu-plugins/sensu-plugins-raid-checks/compare/2.0.3...HEAD
+[2.0.3]: https://github.com/sensu-plugins/sensu-plugins-raid-checks/compare/2.0.2...2.0.3
 [2.0.2]: https://github.com/sensu-plugins/sensu-plugins-raid-checks/compare/2.0.1...2.0.2
 [2.0.1]: https://github.com/sensu-plugins/sensu-plugins-raid-checks/compare/2.0.0...2.0.1
 [2.0.0]: https://github.com/sensu-plugins/sensu-plugins-raid-checks/compare/1.0.0...2.0.0

data/bin/check-megaraid-sas-status.rb

@@ -53,12 +53,21 @@ class CheckMegaRAID < Sensu::Plugin::Check::CLI
   def run
     have_error = false
     error = ''
-    # get number of virtual drives
-    `#{config[:megaraidcmd]} -LDGetNum -a#{config[:controller]} `
-    (0..$CHILD_STATUS.exitstatus - 1).each do |i|
+    # get list of virtual drives
+    stdout = `#{config[:megaraidcmd]} -LDInfo -LALL -a#{config[:controller]} `.split("\n")
+    virtual_drives = []
+    stdout.each do |line|
+      if line =~ /^Virtual Drive:/
+        virtual_drives << line.gsub(/^Virtual Drive: (\d+) .*$/, '\1')
+      end
+    end
+    virtual_drives.each do |i|
       # and check them in turn
       stdout = `#{config[:megaraidcmd]} -LDInfo -L#{i} -a#{config[:controller]} `
-      unless Regexp.new('State\s*:\s*Optimal').match?(stdout)
+      # TODO: once we drop ruby 2.3 support change this to `.match?(stdout)`
+      # this reduces memory consumption as we don't care about the output in this conditional just whether or not it matches.
+      # The `.match?()` function was introduced in 2.4
+      unless Regexp.new(/State\s+:\s+Optimal/).match(stdout)
         error = sprintf '%svirtual drive %d: %s ', error, i, stdout[/State\s*:\s*.*/].split(':')[1] # rubocop:disable Style/FormatString
         have_error = true
       end

data/lib/sensu-plugins-raid-checks/version.rb

@@ -4,7 +4,7 @@ module SensuPluginsRaidChecks
   module Version
     MAJOR = 2
     MINOR = 0
-    PATCH = 2
+    PATCH = 3
 
     VER_STRING = [MAJOR, MINOR, PATCH].compact.join('.')
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sensu-plugins-raid-checks
 version: !ruby/object:Gem::Version
-  version: 2.0.2
+  version: 2.0.3
 platform: ruby
 authors:
 - Sensu-Plugins and contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-19 00:00:00.000000000 Z
+date: 2019-02-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: english
@@ -58,28 +58,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: github-markup
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.3'
 - !ruby/object:Gem::Dependency
   name: redcarpet
   requirement: !ruby/object:Gem::Requirement
@@ -170,11 +170,11 @@ description: |-
                                 controller/array health
 email: "<sensu-users@googlegroups.com>"
 executables:
+- check-mpt2sas-status.rb
 - check-3ware-status.rb
+- check-smart-array-status.rb
 - check-megaraid-sas-status.rb
-- check-mpt2sas-status.rb
 - check-raid.rb
-- check-smart-array-status.rb
 extensions: []
 extra_rdoc_files: []
 files:
@@ -213,8 +213,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.2
 signing_key: 
 specification_version: 4
 summary: Sensu plugins for working with raid evices