sensu-plugins-microsoft-teams 1.3.1 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e4c10bea07f3b57632bc6b8e965c04e2fe5502708d1c6aeb452e454eb3de6949
-  data.tar.gz: 4f490e4151df076c14efc7d674adfb0888a2f642854b8cc5b689b4b370b4b9c5
+  metadata.gz: 541d1853503db9c80c64c029919579bae2348c99daf04c9a791a99117d9a8c80
+  data.tar.gz: 7f4e1ec3baa89aad3a4907b2548d00fdc81118adcd62ba5ee6fc1f2178022818
 SHA512:
-  metadata.gz: 713db5cb125523b0c04f4bb4473922d4090ea24ef5e5b01f8517904dadac7bf44c1f834588251a2dcd9cdb43244b8daaa1e24abd87cecd5567b86be3025310d2
-  data.tar.gz: 6960388550243468ddd162b613970fd7444d462e2ae80bf2638713c46d7c027dbd5a552ca0b63de58bf5347da80abdf3a1f22378d8f86b93edb5897194594bf5
+  metadata.gz: 01508752368d3d228bd6146f82122aded13e1a13eb6c107bb8d4d100c695d223c70f2c45eb591dc95fc49acda34bf01d4e999240d50bb82d04fab19d8407242c
+  data.tar.gz: 101347e9de53a19d93800a7a76172c1cb9f46dd2bae01e0dee6135fff71a4c2172fad7d1cb97de28967f2b4f33ae570ce3db5904f4dc77aaa782ae9f48b4efa2

data/CHANGELOG.md

@@ -5,6 +5,21 @@ This CHANGELOG follows the format located [here](https://github.com/sensu-plugin
 
 ## [Unreleased]
 
+## [2.0.0] - 2018-09-15
+### Security
+- updated `yard` dependency to `~> 0.9.11` per: https://nvd.nist.gov/vuln/detail/CVE-2017-17042 which closes attacks against a yard server loading arbitrary files (@majormoses)
+- updated rubocop dependency to `~> 0.51.0` per: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-8418. (@majormoses)
+
+### Breaking Changes
+- removed ruby versions `< 2.3` support (@majormoses)
+- bumped `sensu-plugin` to `~> 2.7` which removes in handler event filtering you can read about it  [here](https://github.com/sensu-plugins/sensu-plugin/blob/master/CHANGELOG.md#v145---2017-03-07)(@majormoses)
+
+### Fixed
+- fix `handler-microsoft-teams.rb`: rescue any non sensu specification compliant status code passed to the microsoft-teams handler as the color matching `unknown` (@majormoses)
+
+### Changed
+- appeased the cops (@majormoses)
+
 ## [1.3.1] - 2018-09-12
 ### Fixed
 - Add erubis gem as a startup dependency (@asachs01)
@@ -70,7 +85,8 @@ This CHANGELOG follows the format located [here](https://github.com/sensu-plugin
 - updated references of `skel` to `microsoft-teams` (@tuxpower)
 
 
-[Unreleased]: https://github.com/sensu-plugins/sensu-plugins-microsoft-teams/compare/1.3.1...HEAD
+[Unreleased]: https://github.com/sensu-plugins/sensu-plugins-microsoft-teams/compare/2.0.0...HEAD
+[2.0.0]: https://github.com/sensu-plugins/sensu-plugins-microsoft-teams/compare/1.3.1...2.0.0
 [1.3.1]: https://github.com/sensu-plugins/sensu-plugins-microsoft-teams/compare/1.3.0...1.3.1
 [1.3.0]: https://github.com/sensu-plugins/sensu-plugins-microsoft-teams/compare/v1.2.2...1.3.0
 [1.2.2]: https://github.com/sensu-plugins/sensu-plugins-microsoft-teams/compare/v1.2.1...v1.2.2

data/bin/handler-microsoft-teams.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 # Copyright 2017 Jose Gaspar and contributors.
 #
@@ -199,7 +200,21 @@ class MicrosoftTeams < Sensu::Handler
       2 => '#FF0000',
       3 => '#6600CC'
     }
-    color.fetch(check_status.to_i)
+    # a script can return any error code it feels like we should not assume
+    # that it will always be 0,1,2,3 even if that is the sensu (nagions)
+    # specification. A couple common examples:
+    # 1. A sensu server schedules a check on the instance but the command
+    # executed does not exist in your `$PATH`. Shells will return a `127` status
+    # code.
+    # 2. Similarly a `126` is a permission denied or the command is not
+    # executable.
+    # Rather than adding every possible value we should just treat any non spec
+    # designated status code as `unknown`s.
+    begin
+      color.fetch(check_status.to_i)
+    rescue KeyError
+      color.fetch(3)
+    end
   end
 
   def check_status
@@ -213,6 +228,11 @@ class MicrosoftTeams < Sensu::Handler
       2 => :CRITICAL,
       3 => :UNKNOWN
     }
-    status[check_status.to_i]
+    begin
+      status[check_status.to_i]
+    # handle any non standard check status as `unknown`
+    rescue KeyError
+      status.fetch(3)
+    end
   end
 end

data/lib/sensu-plugins-microsoft-teams.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'sensu-plugins-microsoft-teams/version'

data/lib/sensu-plugins-microsoft-teams/version.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module SensuPluginsMicrosoftTeams
   module Version
-    MAJOR = 1
-    MINOR = 3
-    PATCH = 1
+    MAJOR = 2
+    MINOR = 0
+    PATCH = 0
 
     VER_STRING = [MAJOR, MINOR, PATCH].compact.join('.')
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sensu-plugins-microsoft-teams
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 2.0.0
 platform: ruby
 authors:
 - Sensu-Plugins and contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-13 00:00:00.000000000 Z
+date: 2018-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: erubis
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '2.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '2.7'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -142,14 +142,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.9.11
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.9.11
 description: Sensu plugins for interfacing with Microsoft Teams
 email: "<sensu-users@googlegroups.com>"
 executables:
@@ -181,7 +181,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.0.0
+      version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="